- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: packaging: build: fix 2nd time installation
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: build: fix 2nd time installation ...................................................................... packaging: build: fix 2nd time installation remove files symlink before creating new. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=997418 Change-Id: I5c78b4de6fc50d5445f6aff854cb01df8bddc41d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c78b4de6fc50d5445f6aff854cb01df8bddc41d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: introduce generic file serving
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: introduce generic file serving ...................................................................... packaging: introduce generic file serving current implementation adds a reference for each file within root web.xml, this is inflexible to manage and add new files as needed. new implementation defines maps /ovirt-engine-files URI into /usr/share/ovirt-engine/files, every file within that directory will be exposed to application. packaging can add misc files or symlinks to expose files based on specific location or capabilities. moved: 1. spice 2. spice-html5 3. novnc usbfilter.txt moved out of spice directory as it is application provided and not spice artifact. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=997418 Change-Id: I1cd8b39ff2647bc006e09d50c9fc7088fcef7434 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/root/src/main/webapp/ovirt-engine-novnc-main.html M backend/manager/modules/root/src/main/webapp/ovirt-engine-spicehtml5-main.html M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M ovirt-engine.spec.in M packaging/conf/ovirt-engine-proxy.conf.v2.in M packaging/services/ovirt-engine/ovirt-engine.conf.in 9 files changed, 41 insertions(+), 144 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cd8b39ff2647bc006e09d50c9fc7088fcef7434 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: add manual reference
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: add manual reference ...................................................................... packaging: add manual reference empty manual to allow application to handle using single execution path. as this is not really a manual, move out of /usr/share/doc/ Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002353 Change-Id: I00c6a0a554bf684c38f7db21fcbf31621996a0bd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in A packaging/manual/DocumentationPath.csv A packaging/manual/UserPortalDocumentationPath.csv M packaging/services/ovirt-engine/ovirt-engine.conf.in 5 files changed, 3 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00c6a0a554bf684c38f7db21fcbf31621996a0bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix a possible null dereference in CpuLevelFilterPolic...
by oourfali＠redhat.com 02 Oct '13

02 Oct '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix a possible null dereference in CpuLevelFilterPolicyUnit ...................................................................... core: fix a possible null dereference in CpuLevelFilterPolicyUnit Change-Id: I01e9196fd4d48dffe5ee136c0137f16a0cd77094 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01e9196fd4d48dffe5ee136c0137f16a0cd77094 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: Use FQDN from guest agent for RDP
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: Use FQDN from guest agent for RDP ...................................................................... Use FQDN from guest agent for RDP This commit adds the support for retrieving the guestFQDN value from VDSM and stores it in the VmDynamic database. We're not storing FQDN which are localhost or localhost.localdomain Additionally a new vdc_option "RdpUseFqdnIfAvailable" has been introduced, to give the administrators the option to disable this feature. If RdpUseFqdnIfAvailable is true (default) RDP will use the reported FQDN if it is not null or an empty string. The value can now be read on the Frontend from the RdpConsoleModel and it will check whether or not the vdc_option RdpUseFqdnIfAvailable was set. The FQDN value is now also part of the GuestInfo data in the REST API. Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526 Bug-Url: https://bugzilla.redhat.com/1014546 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M packaging/dbscripts/create_dwh_views.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_03_0920_add_fqdn_to_vm_dynamic.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vms_sp.sql 27 files changed, 158 insertions(+), 14 deletions(-) Approvals: Vinzenz Feenstra: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[otopi-1.1]: core: Suppress dump of certain env keys
by Alon Bar-Lev 02 Oct '13

02 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: Suppress dump of certain env keys ...................................................................... core: Suppress dump of certain env keys Fix a bug in the code that was already meant to do that. Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ChangeLog M src/otopi/context.py 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.1 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: fix typo
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: fix typo ...................................................................... engine: fix typo Wair for launch -> Wait for launch Change-Id: I99c62ee25ff60328b1a6510a39374a50694ae610 Bug-Url: https://bugzilla.redhat.com/1013998 Bug-Url: https://bugzilla.redhat.com/1005689 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c62ee25ff60328b1a6510a39374a50694ae610 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: doc: core: Suppress dump of certain env keys
by Alon Bar-Lev 02 Oct '13

02 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: core: Suppress dump of certain env keys ...................................................................... doc: core: Suppress dump of certain env keys Change-Id: Ia8a6d934461f8010b67a886a3d49f841b27d93af Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8a6d934461f8010b67a886a3d49f841b27d93af Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: Suppress dump of certain env keys
by Alon Bar-Lev 02 Oct '13

02 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: Suppress dump of certain env keys ...................................................................... core: Suppress dump of certain env keys Fix a bug in the code that was already meant to do that. Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/context.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/19776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: VmMapper test - Move mock to class level
by oliel＠redhat.com 02 Oct '13

02 Oct '13

Ori Liel has submitted this change and it was merged. Change subject: restapi: VmMapper test - Move mock to class level ...................................................................... restapi: VmMapper test - Move mock to class level When mapping OsType, the code references a service which is currently mocked. But it's not mocked everywhere it should be, and the result is a strange behavior: when all the test method in VmMapperTest are run sequentially, one after the other - they pass. But if only 'testRoundTrip()' is run - it fails. The current change takes the necessary mocking up to the class level. The mocking is static and should only happen once - that's why the class level is the right place. And this way all test methods benefit from the mocking. Change-Id: Iaa9794a268551461263ff0aecb12a12cda279bd1 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa9794a268551461263ff0aecb12a12cda279bd1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0