- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: hide DC in Clusters tab in gluster-only mode
by kmayilsa＠redhat.com 18 Jun '13

18 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide DC in Clusters tab in gluster-only mode ...................................................................... webadmin: hide DC in Clusters tab in gluster-only mode 'Data Center' column of 'Clusters' main tab will be hidden if application is running in GlusterOnly mode . Change-Id: I5a771714304727fb133b3dd4dbe5311de4f6a283 Bug-Url: https://bugzilla.redhat.com/955464 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a771714304727fb133b3dd4dbe5311de4f6a283 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Correct event log message for sync job
by kmayilsa＠redhat.com 18 Jun '13

18 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Correct event log message for sync job ...................................................................... gluster: Correct event log message for sync job Corrected the event log message to show volume option value as well during setting of options from CLI. Change-Id: I1f431f9c748dfde9516514a15b209b99b7740ee6 Bug-Url: https://bugzilla.redhat.com/956000 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f431f9c748dfde9516514a15b209b99b7740ee6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Save VDSM information about HBA devices
by lhornyak＠redhat.com 17 Jun '13

17 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Save VDSM information about HBA devices ...................................................................... engine: Save VDSM information about HBA devices This patch adds the necessary infrastructure for getting and saving the list of HBA (iSCSI, FC) devices in the engine. Change-Id: I8512f30c795690edc46838c0eb422013871b35f9 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_03_0210_add_hbas_col.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 10 files changed, 72 insertions(+), 16 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8512f30c795690edc46838c0eb422013871b35f9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: handle a yum error when no groups
by juan.hernandez＠redhat.com 17 Jun '13

17 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup: handle a yum error when no groups ...................................................................... packaging: setup: handle a yum error when no groups apparently, when querying yum for group, if no groups at all it raises an exception instead of return empty set. this is unexpected behavior of an api. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=973383 Change-Id: Ifb1f196006662d6571c7ca80554e0a9a17aaec2a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/miniyum.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb1f196006662d6571c7ca80554e0a9a17aaec2a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Suspicious reference comparison of Boolean values
by shavivi＠redhat.com 17 Jun '13

17 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Suspicious reference comparison of Boolean values ...................................................................... findbugs: Suspicious reference comparison of Boolean values commit dcc771b2ad21bea0caecaef79cf26daaa8ecc229 fix reference comparison of Boolean values. I GWT debugging we are getting NPE because the new comparison of consoleAddressPartiallyOverridden null value to false, hence not setting it to false. This patch add default value to false and change the isConsoleAddressPartiallyOverridden() to return false instead of null Change-Id: I81405b5484dcfcaa4e7f90279e076cad5f085581 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81405b5484dcfcaa4e7f90279e076cad5f085581 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : during deleting disk an error in log “Could not fi...
by mpastern＠redhat.com 17 Jun '13

17 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : during deleting disk an error in log “Could not find sub-resource in the collection resource" ...................................................................... restapi : during deleting disk an error in log “Could not find sub-resource in the collection resource" During deleting disk there is an error logged into engine.log “Could not find sub-resource in the collection resource" The operation succeeds but there is an error message in log Change-Id: I1be9c02b2aadd7e59371e1cca1ed531964039e7a Bug-Url: https://bugzilla.redhat.com/973751 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1be9c02b2aadd7e59371e1cca1ed531964039e7a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: increase blank template memory size
by lhornyak＠redhat.com 17 Jun '13

17 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: increase blank template memory size ...................................................................... engine: increase blank template memory size Installation of any linux box today requires 1 GB of RAM, setting the memory of the default template could improve user experience by bumping into less problem when doing this. Change-Id: If74889c0165a66fb76fc5081fefdb66cd4df9e83 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/insert_data.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If74889c0165a66fb76fc5081fefdb66cd4df9e83 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove memory snapshot when its not needed
by ofrenkel＠redhat.com 17 Jun '13

17 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove memory snapshot when its not needed ...................................................................... core: remove memory snapshot when its not needed This patch adds the removal of memory snapshot volumes in case it's not needed anymore: 1. when removing VM that has snapshots with memory 2. when snapshots with memory are removed because we revert (commit) to previous snapshot 3. on run VM when the VM reach to a point where the disks might not be synchronous with the memory state that was restored anymore (and the active snapshot is the only one that points to its memory) This patch also treat the restoration of snapshot's memory when running a VM that is previewing/being committed to a snapshot with memory in stateless mode. Change-Id: Ic087580475cd4fcfac969ddf0f69929fa247f86d Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/dbscripts/snapshots_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/StatelessSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java 17 files changed, 263 insertions(+), 126 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic087580475cd4fcfac969ddf0f69929fa247f86d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine:Fixed FK violation on update of gluster event names
by emesika＠redhat.com 17 Jun '13

17 Jun '13

Eli Mesika has submitted this change and it was merged. Change subject: engine:Fixed FK violation on update of gluster event names ...................................................................... engine:Fixed FK violation on update of gluster event names A FK violation occurs during upgrade due to event_up name being present in event_subscriber Change-Id: If8d811be0e8eb52d3ebf2d1bfb4e391398b65abe Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_02_0060_change_host_to_server_event_map.sql 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8d811be0e8eb52d3ebf2d1bfb4e391398b65abe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: host gluster-swift sub tab
by kmayilsa＠redhat.com 17 Jun '13

17 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: host gluster-swift sub tab ...................................................................... webadmin: host gluster-swift sub tab Adding a new sub-tab "Gluster Swift" under Hosts. This will list all the Gluster Swift related services and their statuses. Start, Stop and Restart action are added to the sub-tab. Change-Id: Iacffe5b49e6dcde743fa81d5a3f694de5d8f1421 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterSwiftListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostEventPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGlusterSwiftPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostHardwarePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostPermissionPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGlusterSwiftView.java 14 files changed, 381 insertions(+), 5 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacffe5b49e6dcde743fa81d5a3f694de5d8f1421 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0