- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: fix gluster hook conten-type detection
by kmayilsa＠redhat.com 16 Jun '13

16 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: fix gluster hook conten-type detection ...................................................................... engine: fix gluster hook conten-type detection The hook will be considered as human readable('TEXT') if mime-type has 'text' in type part. And the sub-type part will be ignored. Modified the GlusterHookContentQuery to check server hook's content type if serverId is provided. Change-Id: I191d8f233c965c6b34a652fa07b2c60ef5ee6194 Bug-Url: https://bugzilla.redhat.com/973091 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterHookContentQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookContentType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java 3 files changed, 31 insertions(+), 15 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I191d8f233c965c6b34a652fa07b2c60ef5ee6194 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: gluster hooks - sync with servers action
by kmayilsa＠redhat.com 16 Jun '13

16 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: gluster hooks - sync with servers action ...................................................................... webadmin: gluster hooks - sync with servers action Added a new action "Sync" to gluster hooks sub-tab. This will invoke the GlusterHooksSyncJob internally to sync the hooks across the servers of the cluster. Change-Id: I3e825620ec15e41a2093b0f84b53a926974d66cb Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java 3 files changed, 29 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e825620ec15e41a2093b0f84b53a926974d66cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: renamed RefreshGlusterHook action
by kmayilsa＠redhat.com 16 Jun '13

16 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: renamed RefreshGlusterHook action ...................................................................... gluster: renamed RefreshGlusterHook action changed from "RefreshGlusterHook" to "RefreshGlusterHooks" to be inline with the bll command. Change-Id: I1a53c1d242dd18f83810f940aad3d7239a53b78f Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a53c1d242dd18f83810f940aad3d7239a53b78f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix disk allocation on new VM/Template
by tnisan＠redhat.com 16 Jun '13

16 Jun '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix disk allocation on new VM/Template ...................................................................... webadmin: Fix disk allocation on new VM/Template When creating a new template from VM or a new VM/pool from template the disk allocation table selected the first storage domain as the default storage domain for the operation and that caused all the disks in the template/VM to be created on this storage domain regardless to the storage domain the original disks reside on Change-Id: I0a2f71c4f18ccb52362272edf56853e2fde9643f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 16 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a2f71c4f18ccb52362272edf56853e2fde9643f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: packager: yum: refresh yum instance at every transaction
by Alon Bar-Lev 16 Jun '13

16 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packager: yum: refresh yum instance at every transaction ...................................................................... packager: yum: refresh yum instance at every transaction yum has long history, especially at the suck where it holds the include/exclude data. as we need to handle runtime change in versionlock, we need to force yum to read the information again. I would have expected this information will be re-read at every new transaction... but apparently not. Change-Id: I35a39253aab15b2be27e73be6ac89fe14c9d3f2a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/yumpackager.py 1 file changed, 33 insertions(+), 16 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35a39253aab15b2be27e73be6ac89fe14c9d3f2a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: add explicit destructor to miniyum
by Alon Bar-Lev 16 Jun '13

16 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: add explicit destructor to miniyum ...................................................................... packagers: yum: add explicit destructor to miniyum Change-Id: Ib75f01b8dd26a9f4d0b8748b45322d5619f34ac3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib75f01b8dd26a9f4d0b8748b45322d5619f34ac3 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: drop the local helper
by Alon Bar-Lev 16 Jun '13

16 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: drop the local helper ...................................................................... packagers: yum: drop the local helper Change-Id: I65e3340bc805811e5e2a41af23bd53386ba340ae Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M po/POTFILES.in M src/plugins/otopi/packagers/Makefile.am D src/plugins/otopi/packagers/miniyumlocal.py M src/plugins/otopi/packagers/yumpackager.py 4 files changed, 65 insertions(+), 103 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65e3340bc805811e5e2a41af23bd53386ba340ae Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup CreateVmVDSCommand
by ofrenkel＠redhat.com 16 Jun '13

16 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup CreateVmVDSCommand ...................................................................... core: cleanup CreateVmVDSCommand - Refactor CreateVmVDSCommand#ExecuteVdsIdCommand method to be with less nested levels and to have more readable structure - Reduce duplicate code at CreateVmVDSCommand#ExecuteVdsIdCommand by extracting the variability to external method: initCreateVDSCommand - Rename private methods names in this class to start with lowercase Change-Id: I8159dbfd351ea460d01c56553cfe3219d960c8b7 Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 1 file changed, 55 insertions(+), 63 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8159dbfd351ea460d01c56553cfe3219d960c8b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: restore memory from snapshot on run vm
by ofrenkel＠redhat.com 16 Jun '13

16 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: restore memory from snapshot on run vm ...................................................................... core: restore memory from snapshot on run vm If we're going to run a VM which is not suspended and its active snapshot contains memory, we set the memory volume that the active snapshot points to as the initial memory state of the VM. Change-Id: Iee1e4149db44d690726f00d366562df07eb5cacd Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVmVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 4 files changed, 50 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee1e4149db44d690726f00d366562df07eb5cacd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: memory state handling on preview/commit/undo
by ofrenkel＠redhat.com 16 Jun '13

16 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: memory state handling on preview/commit/undo ...................................................................... core: memory state handling on preview/commit/undo On preview snapshot, add the memory from the previewed snapshot to the active snapshot that is created, if the 'restoreMemory' flag is set in the parameters. On commit/undo, add the memory from the restored snapshot to the active snapshot that is created. Change-Id: I42c1b7dd4fcdf12fba1943792a1442984796cf45 Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java 4 files changed, 124 insertions(+), 26 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c1b7dd4fcdf12fba1943792a1442984796cf45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0