- Engine-commits - oVirt List Archives

Change in ovirt-iso-uploader[master]: build: prepare for ovirt-iso-uploader-3.2.0 release
by kroberts＠redhat.com 05 Feb '13

05 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: prepare for ovirt-iso-uploader-3.2.0 release ...................................................................... build: prepare for ovirt-iso-uploader-3.2.0 release Change-Id: Ica283e5276591b6852fe6b0a886ec5db7c0cab10 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica283e5276591b6852fe6b0a886ec5db7c0cab10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: uicommonweb: timezone reset when os type change in VM popup
by tjelinek＠redhat.com 05 Feb '13

05 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: uicommonweb: timezone reset when os type change in VM popup ...................................................................... uicommonweb: timezone reset when os type change in VM popup It is done by caching the timezone value string for windows timezone and general timezone Change-Id: I322df5bae018c4d8d1a0647057634daf05c01ec7 Signed-off-by: plysan <plysab(a)gmail.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I322df5bae018c4d8d1a0647057634daf05c01ec7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ly pan <plysab(a)gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed DoubleCompat class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed DoubleCompat class ...................................................................... core: Removed DoubleCompat class Change-Id: Ia5f3cb48bf49064de543c9478bbb2b445055bbb0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DoubleCompat.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml 4 files changed, 28 insertions(+), 37 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5f3cb48bf49064de543c9478bbb2b445055bbb0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed NumberStyles class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed NumberStyles class ...................................................................... core: Removed NumberStyles class Removed the class NumberStyles from the compat module, also removed the methods using it, all of which did not have any references Change-Id: I0abe40050c1bafb0e25c11a917b5e722fea0d7e0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/LongCompat.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NumberStyles.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml 4 files changed, 0 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0abe40050c1bafb0e25c11a917b5e722fea0d7e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed the LongCompat class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed the LongCompat class ...................................................................... core: Removed the LongCompat class Removed the LongCompat class and replaced all calls in Long.parse with catching NumberFormatException, there are error handling anyway in each of the references so it added no boilerplate code Change-Id: If2b672f3406ce7b3316a5ff1b50379d92eedb062 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/LongCompat.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtilsSeedingRule.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml 5 files changed, 12 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2b672f3406ce7b3316a5ff1b50379d92eedb062 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Report error only for non-pluggable devices
by mkolesni＠redhat.com 05 Feb '13

05 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Report error only for non-pluggable devices ...................................................................... engine: Report error only for non-pluggable devices Error should be reported (as it states in the error itself) only for non pluggable devices, otherwise if the device is pluggable it's cool that it is unplugged in DB and VDSM. Change-Id: Id68197668fc2432bb7c26e6940fe8bf92bd3e674 Bug-Url: https://bugzilla.redhat.com/872165 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id68197668fc2432bb7c26e6940fe8bf92bd3e674 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Code cleanup for device refresh treatment
by mkolesni＠redhat.com 05 Feb '13

05 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Code cleanup for device refresh treatment ...................................................................... engine: Code cleanup for device refresh treatment Performed some clean ups in VdsUpdateRunTimeInfo code which treats devices refreshment, to make code easier to read and understand: 1. Don't use toString() on objects sent to log.xxxFormat() method since this is what happens anyway. 2. Moved lines of code closer to where they're really needed. 3. Used Set instead of HashSet in reference declaration. 4. Inlined some variables that were used only in one place. 5. Used Entities.businessEntitiesById() method instead of manual map building. 6. Used StringUtils.defaultString(xxx) instead of variations of StringUtils.defaultIfEmpty(xxx, ""). 7. Changed code to "fail early" instead of nesting (5 levels of nesting is excessive). 8. Reordered conditions so that positive case is first. 9. General formatting (removed unecessary line breaks, added some where needed). Change-Id: I978b46912f095d636ea0c4f1c58d3bb14083d855 Bug-Url: https://bugzilla.redhat.com/872165 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 38 insertions(+), 39 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I978b46912f095d636ea0c4f1c58d3bb14083d855 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Store boot order after plug/unplug vNIC
by mkolesni＠redhat.com 05 Feb '13

05 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Store boot order after plug/unplug vNIC ...................................................................... engine: Store boot order after plug/unplug vNIC Store the updated boot order in DB after the plugging/unplugging is performed. Change-Id: I1fa77fbf727f4df96d5bfa3a2aaa4fc1c9188295 Bug-Url: https://bugzilla.redhat.com/907155 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fa77fbf727f4df96d5bfa3a2aaa4fc1c9188295 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Use standard audit log fields mechanism
by mkolesni＠redhat.com 05 Feb '13

05 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Use standard audit log fields mechanism ...................................................................... engine: Use standard audit log fields mechanism No need to set fields using the method, we can use the standard annotations mechanism. Change-Id: I96acc0f97a5304838db51b91d7bc7c64678d0181 Bug-Url: https://bugzilla.redhat.com/907155 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96acc0f97a5304838db51b91d7bc7c64678d0181 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Simplify canDoAction
by mkolesni＠redhat.com 05 Feb '13

05 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Simplify canDoAction ...................................................................... engine: Simplify canDoAction Simplify canDoAction to fast-fail so that the code becomes easier to read (less nested conditionals). Change-Id: I7fa092ce8f568b11ae14ac1c943107a10cffa068 Bug-Url: https://bugzilla.redhat.com/907155 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 17 insertions(+), 21 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fa092ce8f568b11ae14ac1c943107a10cffa068 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0