- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: improve error message of export template
by tnisan＠redhat.com 04 Feb '13

04 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: improve error message of export template ...................................................................... core: improve error message of export template Improving the error message displayed in case of export template failure - when one or more storage domains on which the template's disks are located, are not available. The fix does 2 things: 1. Fixes "Cannot export VM" to "Cannot export Template". 2. Rewrites second part of the message "Provided destination storage domains doesn't match for provided disks." to a more clear and related to scenario text. related to bug https://bugzilla.redhat.com/884780 Change-Id: Ib5b0bf022e6b8ee5502e30912d32a80fdd251d90 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/11716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5b0bf022e6b8ee5502e30912d32a80fdd251d90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Show warning for non-exportable disks
by derez＠redhat.com 04 Feb '13

04 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal, webadmin: Show warning for non-exportable disks ...................................................................... userportal, webadmin: Show warning for non-exportable disks Display warning in Create VM template, Export VM, Create VM snapshot dialogs, if non-exportable disks are detected (e.g. shared disk, direct lun , ...), that these disks will not be part of the export. For the detection, the Disk.isAllowSnapshot() is used. Change-Id: I6a183931e36ccd4668225ad206edc4a5e58795e3 Bug-Url: https://bugzilla.redhat.com/855625 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExportVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmExportPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmExportPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 16 files changed, 180 insertions(+), 38 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a183931e36ccd4668225ad206edc4a5e58795e3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixed a spelling mistake in AuditLogAgingThreashold ...
by asaf＠redhat.com 04 Feb '13

04 Feb '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold config var ...................................................................... engine: Fixed a spelling mistake in AuditLogAgingThreashold config var Fixed a spelling mistake in 'AuditLogAgingThreashold' config variable, Changed to 'AuditLogAgingThreshold'. This patch also contains a generic new SQL function (fn_db_rename_config_key) which renames a conf key while preserving the current conf value. Change-Id: I14becc0f57404a86ca18917e4b6e2d00054a44b1 Bug-Url: https://bugzilla.redhat.com/743032 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 5 files changed, 28 insertions(+), 6 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14becc0f57404a86ca18917e4b6e2d00054a44b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use storage validator when adding template.
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator when adding template. ...................................................................... core: Use storage validator when adding template. Use storage validator instead regular check when validating space requirements in the CDA phase. Change-Id: If36ba750308adb2751a02738f66816fb097fe93e Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If36ba750308adb2751a02738f66816fb097fe93e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add storage space validator
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add storage space validator ...................................................................... core: Add storage space validator Use the storage validator to validate if there is enough space in the storage compared to the threshold. The validator should replace the use of StorageDomainSpaceChecker. Change-Id: I097965d6362bd54d12860d5409f5c14d569a8968 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java 2 files changed, 77 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I097965d6362bd54d12860d5409f5c14d569a8968 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use storage validator when adding a new VM.
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator when adding a new VM. ...................................................................... core: Use storage validator when adding a new VM. Use storage validator instead regular check when adding a new VM. Change-Id: I6ee28506dec042fe60e9691d41458ad54a83b2f0 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 2 files changed, 14 insertions(+), 15 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ee28506dec042fe60e9691d41458ad54a83b2f0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use storage validator when validating move or copy.
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator when validating move or copy. ...................................................................... core: Use storage validator when validating move or copy. Use storage validator instead regular check when validating space requirements in the CDA phase. Change-Id: I01980de86ed445d397f12ff9c471974d1cb5c44d Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 20 insertions(+), 12 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01980de86ed445d397f12ff9c471974d1cb5c44d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use storage validator when validating add disk.
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator when validating add disk. ...................................................................... core: Use storage validator when validating add disk. Use storage validator instead regular check when validating space requirements in the CDA phase. Change-Id: I8bb5101600aa22271529fb72fb33b2031ee81f83 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 2 files changed, 7 insertions(+), 28 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bb5101600aa22271529fb72fb33b2031ee81f83 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use storage validator for images handler.
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator for images handler. ...................................................................... core: Use storage validator for images handler. Use storage validator instead regular check when validating space requirements in images handler functionality. Change-Id: I212da7c8d1042e54eafaa2e2367081dd1315e003 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 36 insertions(+), 6 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I212da7c8d1042e54eafaa2e2367081dd1315e003 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use storage validator on Live Migrate disk.
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator on Live Migrate disk. ...................................................................... core: Use storage validator on Live Migrate disk. Use storage validator instead regular check when validating space requirements in the CDA phase. Change-Id: I116f12c0d4c05bd03f0f42009b4727fbd6b71420 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I116f12c0d4c05bd03f0f42009b4727fbd6b71420 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0