- Engine-commits - oVirt List Archives

Change in ovirt-host-deploy[master]: api: do not expose internal constants
by Alon Bar-Lev 16 Dec '12

16 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: api: do not expose internal constants ...................................................................... api: do not expose internal constants Change-Id: I4bab09d938936edc5cc07f69648d3b0a1c7209b9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-deploy/core/misc.py M src/plugins/ovirt-host-deploy/node/persist.py M src/plugins/ovirt-host-deploy/vdsm/bridge.py M src/plugins/ovirt-host-deploy/vdsm/config.py M src/plugins/ovirt-host-deploy/vdsm/packages.py M src/plugins/ovirt-host-deploy/vdsm/pki.py M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py M src/plugins/ovirt-host-deploy/vdsmhooks/hooks.py 9 files changed, 52 insertions(+), 42 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bab09d938936edc5cc07f69648d3b0a1c7209b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: node: persist: minor cleanup
by Alon Bar-Lev 16 Dec '12

16 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: node: persist: minor cleanup ...................................................................... node: persist: minor cleanup Change-Id: Ic89be93394823c5d41b49de9a3500360b1a74e72 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/node/persist.py 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic89be93394823c5d41b49de9a3500360b1a74e72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: pki: install libvirt client duplicate certificates
by Alon Bar-Lev 16 Dec '12

16 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: pki: install libvirt client duplicate certificates ...................................................................... vdsm: pki: install libvirt client duplicate certificates libvirtd does allow us to configure the location of pki artifacts, and vdsm configure it properly to access its certificates. However, vdsm does not configure the libvirt client, thus libvirt accesses the default location. Change-Id: If03db2d3ec26d21b74e2c8363f927ed5865667d5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-deploy/vdsm/pki.py 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If03db2d3ec26d21b74e2c8363f927ed5865667d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: api: do not expose internal constants
by Alon Bar-Lev 16 Dec '12

16 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: api: do not expose internal constants ...................................................................... api: do not expose internal constants Change-Id: I7ba5d684b5a51b2d609f21359974bd1bd899ca49 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/constants.py M src/otopi/dialog.py M src/otopi/main.py M src/plugins/otopi/core/config.py M src/plugins/otopi/core/log.py M src/plugins/otopi/packagers/yumpackager.py M src/plugins/otopi/system/command.py 7 files changed, 29 insertions(+), 21 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ba5d684b5a51b2d609f21359974bd1bd899ca49 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DataProvider.java cleanup (6/6)
by gchaplik＠redhat.com 16 Dec '12

16 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: DataProvider.java cleanup (6/6) ...................................................................... webadmin: DataProvider.java cleanup (6/6) DataProvider is a class which is mostly obsolete, as it contains synchronous calls to the engine, which are not relevant anymore under the GWT platform/infrastructure. The goal is to eliminate this class all-together. In this patch: 1) Removing sync getUsers and not replacing it; The original flow was to get all users, and filter out users that are already included. This filtering needs further thinking, beacuse the admins may be confused by it (e.g. empty list) 2) Deleting DataProvider.java since it's now empty Change-Id: I31f6af5b3af32a55a623ce701c2a6c384bef6ddc Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/881747 --- D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java 2 files changed, 0 insertions(+), 37 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31f6af5b3af32a55a623ce701c2a6c384bef6ddc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DataProvider.java cleanup (5/6)
by gchaplik＠redhat.com 16 Dec '12

16 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: DataProvider.java cleanup (5/6) ...................................................................... webadmin: DataProvider.java cleanup (5/6) DataProvider is a class which is mostly obsolete, as it contains synchronous calls to the engine, which are not relevant anymore under the GWT platform/infrastructure. The goal is to eliminate this class all-together. In this patch: Removing sync call for IsVmNameUnique, and replacing it with an async call in AsyncDataProvider Change-Id: If11911f94e02a5c115a4c4407b918580704bd9eb Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/881747 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 32 insertions(+), 30 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If11911f94e02a5c115a4c4407b918580704bd9eb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DataProvider.java cleanup (4/6)
by gchaplik＠redhat.com 16 Dec '12

16 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: DataProvider.java cleanup (4/6) ...................................................................... webadmin: DataProvider.java cleanup (4/6) DataProvider is a class which is mostly obsolete, as it contains synchronous calls to the engine, which are not relevant anymore under the GWT platform/infrastructure. The goal is to eliminate this class all-together. In this patch: removing sync getTemplateById and getClusterById, which were used by Edit Pool; PoolListModel.Edit used these methods while filling out the dialog incase the pool is empty. We cannot edit empty pool, hence removed the code dealing with it. Change-Id: Ie7dbd26e10a5d0680a74c5a8dc1ee5cc9461c309 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/881747 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 2 files changed, 1 insertion(+), 195 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7dbd26e10a5d0680a74c5a8dc1ee5cc9461c309 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DataProvider.java cleanup (3/6)
by gchaplik＠redhat.com 16 Dec '12

16 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: DataProvider.java cleanup (3/6) ...................................................................... webadmin: DataProvider.java cleanup (3/6) DataProvider is a class which is mostly obsolete, as it contains synchronous calls to the engine, which are not relevant anymore under the GWT platform/infrastructure. The goal is to eliminate this class all-together. In this patch: Removing IsLicenseHasDesktops, and reference, since it always returns true. Change-Id: I25ce87c5107a483dfbe2ad2d3625a9dfaadf3064 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/881747 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 2 files changed, 2 insertions(+), 15 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25ce87c5107a483dfbe2ad2d3625a9dfaadf3064 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DataProvider.java cleanup (2/6)
by gchaplik＠redhat.com 16 Dec '12

16 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: DataProvider.java cleanup (2/6) ...................................................................... webadmin: DataProvider.java cleanup (2/6) DataProvider is a class which is mostly obsolete, as it contains synchronous calls to the engine, which are not relevant anymore under the GWT platform/infrastructure. The goal is to eliminate this class all-together. In this patch: 1) Removing methods that used old cache mechanism for config values, and replacing them with the new mechanism in AsyncDataProvider (only 2 methods) 2) Removing DataProvider config values mechanism Change-Id: I8eb69268ef416c1738d92129e8c10f3197967a53 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/881747 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java 7 files changed, 45 insertions(+), 119 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8eb69268ef416c1738d92129e8c10f3197967a53 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DataProvider.java cleanup (1/6)
by gchaplik＠redhat.com 16 Dec '12

16 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: DataProvider.java cleanup (1/6) ...................................................................... webadmin: DataProvider.java cleanup (1/6) DataProvider is a class which is mostly obsolete, as it contains synchronous calls to the engine, which are not relevant anymore under the GWT platform/infrastructure. The goal is to eliminate this class all-together. In this patch: Harmless clean-ups: 1) Removing unused methods in DataProvider.java 2) Moving used non-async methods to AsyncDataProvider.java Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: Ifb3a1ee7dbca478501d138f8aa1fd4dd5aec26dd Bug-Url: https://bugzilla.redhat.com/881747 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/ObjectNameRenderer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplicationModeHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameLengthValidation.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/GroupNameRenderer.java 33 files changed, 451 insertions(+), 2,643 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb3a1ee7dbca478501d138f8aa1fd4dd5aec26dd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0