- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: set jsessionid cookie only if "prefer: persistent-...
by mpastern＠redhat.com 16 Dec '12

16 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: set jsessionid cookie only if "prefer: persistent-auth" header is set ...................................................................... restapi: set jsessionid cookie only if "prefer: persistent-auth" header is set https://bugzilla.redhat.com/show_bug.cgi?id=876641 Change-Id: Id2ee609fb6a80eda82ab73c2ea2351d6b2f5129f Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2ee609fb6a80eda82ab73c2ea2351d6b2f5129f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: RunAction failureEventHandler - multiple messages
by derez＠redhat.com 16 Dec '12

16 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: frontend: RunAction failureEventHandler - multiple messages ...................................................................... frontend: RunAction failureEventHandler - multiple messages Adding RunAction failureEventHandler for multiple error messages. * When a RunAction fails and returns multiple canDoActionMessages, raise a frontendFailureEvent with multiple messages. * FrontendFailureEventListener.java already supports displaying a popup with multiple error messages. * Converted variables map's value to a list of strings to support multiple values for the same variable. Change-Id: I8c7011e9cab02d6e3320ab750b9ba57bf1a3b091 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 2 files changed, 30 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c7011e9cab02d6e3320ab750b9ba57bf1a3b091 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove SQL Server specific code
by emesika＠redhat.com 15 Dec '12

15 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Remove SQL Server specific code ...................................................................... core: Remove SQL Server specific code This code is no longer needed. Change-Id: Ibdb0eb97dfe5554f2606e16b85705fbf51e571bb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SqlServerDbEngineDialect.java D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SQLServerDataTypeFactory.java 4 files changed, 2 insertions(+), 61 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdb0eb97dfe5554f2606e16b85705fbf51e571bb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: fix LDAPConnectTimeout in properties
by emesika＠redhat.com 15 Dec '12

15 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: fix LDAPConnectTimeout in properties ...................................................................... common: config: fix LDAPConnectTimeout in properties Change-Id: I528b0b631cababf77bfc5830036d8f0785ce4529 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I528b0b631cababf77bfc5830036d8f0785ce4529 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Rename async_tasks to AsyncTasks
by lhornyak＠redhat.com 14 Dec '12

14 Dec '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Rename async_tasks to AsyncTasks ...................................................................... core: Rename async_tasks to AsyncTasks Change-Id: I66fefcb9f7996d59253e0feb603570e6d8fa389e Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 11 files changed, 56 insertions(+), 56 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Sharad Mishra: Verified -- To view, visit http://gerrit.ovirt.org/10046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66fefcb9f7996d59253e0feb603570e6d8fa389e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: pki: install spice duplicate certificates
by Alon Bar-Lev 13 Dec '12

13 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: pki: install spice duplicate certificates ...................................................................... vdsm: pki: install spice duplicate certificates Change-Id: I1fbe29b53cded96aff786a8ec81db992e028b6a9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-deploy/vdsm/pki.py 2 files changed, 68 insertions(+), 44 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fbe29b53cded96aff786a8ec81db992e028b6a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: pki: enroll pending certificate in separate file
by Alon Bar-Lev 13 Dec '12

13 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: pki: enroll pending certificate in separate file ...................................................................... vdsm: pki: enroll pending certificate in separate file This will enable existing key to be used until we have the certificate available. Change-Id: I8d3c7850900870e43bf102bd9365b171083cfe56 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-deploy/vdsm/pki.py 2 files changed, 54 insertions(+), 20 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d3c7850900870e43bf102bd9365b171083cfe56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix layout of multiple lines conf msgs
by tjelinek＠redhat.com 13 Dec '12

13 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: fix layout of multiple lines conf msgs ...................................................................... webadmin: fix layout of multiple lines conf msgs Fix the layout of messages in some confirmations dialogs that should be splitted over multiple lines (such as in the "import vm" confirmation dialog). The problem was that the widget which is used to contain those messages is Label, thus the '\n' characters in the message are ignored, and the message is presented in a single long line. This patch solves the problem by replacing the '\n' characters in the message with "<br>" tags and setting the message as HTML Change-Id: I1576b7576cf93ba9e525f20261d423fd4c0721b0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractConfirmationPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/DefaultConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StorageForceCreatePopupView.ui.xml 5 files changed, 14 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1576b7576cf93ba9e525f20261d423fd4c0721b0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Print network description on Remove dialog
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Print network description on Remove dialog ...................................................................... webadmin: Print network description on Remove dialog The patch modifies the 'null' value printed for each network within the list of removed networks with the network name and its description (if description was defined for the network). Change-Id: Ic7842e5267b084470fc75e8f12bc4666b2f75605 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7842e5267b084470fc75e8f12bc4666b2f75605 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine, webadmin: Remove getNetwork from NetworkView
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine,webadmin: Remove getNetwork from NetworkView ...................................................................... engine,webadmin: Remove getNetwork from NetworkView Since NetworkView extends Network, there is no need for the getNetwork() method used to return the Network element once held by NetworkView. Change-Id: I27d52f966fb0af0ad53afe0d053d5a01f659ab42 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkView.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkViewDaoTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java 12 files changed, 39 insertions(+), 54 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27d52f966fb0af0ad53afe0d053d5a01f659ab42 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0