- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Add search capabilities to Network
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Add search capabilities to Network ...................................................................... restapi: Add search capabilities to Network The patch adds the search capabilities to networks under uri: api/networks?search={query} Change-Id: I68d1a04437255d534dabf89e1ce02fbd97ea556c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/QueryHelperTest.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResourceTest.java 10 files changed, 80 insertions(+), 43 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68d1a04437255d534dabf89e1ce02fbd97ea556c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Organize imports
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Organize imports ...................................................................... restapi: Organize imports The patch organizes the import declarations of several classes which will be modified by the following patch, as part of adding search capabilities for Network entities. Change-Id: I0529200ea4b00d2ac2a49260bf4143fbd1bf1e75 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/QueryHelperTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResourceTest.java 5 files changed, 56 insertions(+), 61 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0529200ea4b00d2ac2a49260bf4143fbd1bf1e75 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Modify NetworkView to inherit Network
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Modify NetworkView to inherit Network ...................................................................... core: Modify NetworkView to inherit Network The patch modifies the relations between NetworkView and Network from composition to inheritance. In addition, the relations between the DB mappers are also changed to reflect the new relation. Change-Id: I534e214175fb534f4209baf773878b65f754f2ca Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkView.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkViewDaoDbFacadeImpl.java 3 files changed, 24 insertions(+), 32 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I534e214175fb534f4209baf773878b65f754f2ca Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Adding utility functions
by juan.hernandez＠redhat.com 13 Dec '12

13 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Adding utility functions ...................................................................... packaging: Adding utility functions * Added a renameParam function that allows renaming a param in a TextConfig file. * Implemented a delParams function that will comment out a list of params provided, if they are defined. Change-Id: I5740ab71597781f3995087ad29c85cde8c1e555a Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 35 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5740ab71597781f3995087ad29c85cde8c1e555a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Fix comment in /etc/sysconfig/ovirt-engine
by juan.hernandez＠redhat.com 13 Dec '12

13 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Fix comment in /etc/sysconfig/ovirt-engine ...................................................................... packaging: Fix comment in /etc/sysconfig/ovirt-engine The /etc/sysconfig/ovirt-engine file contains a comment indicating the location of the defaults file, but it is wrong. Change-Id: Ie5d3e787645431b64a5bf6813f7b960c9240aeff Bug-Url: https://bugzilla.redhat.com/886433 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.sysconfig 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d3e787645431b64a5bf6813f7b960c9240aeff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: API: Cannot remove the payload via REST
by shavivi＠redhat.com 13 Dec '12

13 Dec '12

Shahar Havivi has submitted this change and it was merged. Change subject: API: Cannot remove the payload via REST ...................................................................... API: Cannot remove the payload via REST Change-Id: I01cf3b6cf0bae68ec0797c0585ee55b19e54463d Bug-Url: https://bugzilla.redhat.com/882649 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 6 files changed, 116 insertions(+), 34 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01cf3b6cf0bae68ec0797c0585ee55b19e54463d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused ldap class.
by yzaslavs＠redhat.com 13 Dec '12

13 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: remove unused ldap class. ...................................................................... core: remove unused ldap class. org/ovirt/engine/core/common/businessentities/ad_vm_pool_group_map.java is unused. Change-Id: I9881423db29fc9933b31016fc6452a4e0b878156 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ad_vm_pool_group_map.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Sharad Mishra: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9881423db29fc9933b31016fc6452a4e0b878156 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Newly added domain is always before the old one
by yzaslavs＠redhat.com 12 Dec '12

12 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Newly added domain is always before the old one ...................................................................... core: Newly added domain is always before the old one When a domain is added using engine-manage-domains the list of domains in the frontend login screen and engine-manage-domains -action=list shows the newly added domain first. A natural ordering of domain names has been implemented in the backend and in ManageDomains code. Change-Id: I90b32678f8184ac39570e15aa840a8563bb350cf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=731763 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/DomainsConfigurationEntry.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b32678f8184ac39570e15aa840a8563bb350cf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: search disks does not complete bootable and shareabl...
by amureini＠redhat.com 12 Dec '12

12 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: engine: search disks does not complete bootable and shareable ...................................................................... engine: search disks does not complete bootable and shareable Search engine does not complete values for boolean fields like Disks : bootable = and Disks : shareable = Change-Id: Ia0a3a9c1fa6186c426d764afd11875e80478912b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=859762 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0a3a9c1fa6186c426d764afd11875e80478912b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm test cleanup: remove spring
by amureini＠redhat.com 12 Dec '12

12 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm test cleanup: remove spring ...................................................................... core: ImportVm test cleanup: remove spring Remove wrongfully used spring validation assertions and replaced with standard JUnit 4 calls. Change-Id: I67e7593ea28751cd6c4c50a54ec0bdf46174107f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e7593ea28751cd6c4c50a54ec0bdf46174107f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0