If Jenkins is bored, it could be cool if it could perform 'git bisect' on such failures.
Y.
Eyal Edri <eedri(a)redhat.com> wrote:
FYI,
one of these commits inserted 3 new HIGH Priority bugs:
core : Fixing import of vm with snapshots (detail / gitweb)
restapi: rename case-sensitive matrix param (detail / gitweb)
restapi: Add JSON support (detail / gitweb)
pleae check here for more details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/278/
Eyal Edri
oVirt Infrastructure
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
Hi,
I am reviewing Allon's patches (e.g. http://gerrit.ovirt.org/#patch,sidebyside,2188,11,backend/manager/modules/d… ) and this is the first time I have met @SuppressWarnings("synthetic-access") annotations in the ovirt code. It is right, eclipse warns about the performance problem synthetic access (if turned on, by default it is turned off). This mostly happens in DAO's because rowmappers are private inner classes. What if, instead of adding an annotation to ignore this
- we could make the rowmapper classes package protected?
- or since most of these classes are stateless and thread safe, we can add a public final static rowmapper instance and instead of instantiating the rowmapper over and over again, use that single instance.
Please share your thoughts.
Thank you,
Laszlo
