Hi all,
There is a new networking test failure in the ci:
16:18:11 ======================================================================
16:18:11 ERROR: test_dump_bonding_name2numeric
(toolBondingTests.TestToolBonding)
16:18:11 ----------------------------------------------------------------------
16:18:11 Traceback (most recent call last):
16:18:11 File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
line 97, in wrapper
16:18:11 return f(*args, **kwargs)
16:18:11 File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/modprobe.py",
line 58, in wrapper
16:18:11 return f(*args, **kwargs)
16:18:11 File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/toolBondingTests.py",
line 37, in test_dump_bonding_name2numeric
16:18:11 opt_map = _get_bonding_options_name2numeric()
16:18:11 File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/lib/vdsm/tool/dump_bonding_opts.py",
line 94, in _get_bonding_options_name2numeric
16:18:11 opts[mode] = bond_opts_name2numeric_filtered(bond_name)
16:18:11 File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/lib/vdsm/netinfo/bonding.py",
line 203, in bond_opts_name2numeric_filtered
16:18:11 in _bond_opts_name2numeric(bond).iteritems()
16:18:11 File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/lib/vdsm/netinfo/bonding.py",
line 238, in _bond_opts_name2numeric
16:18:11 _bond_opts_name2numeric_scan(path)
16:18:11 File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/lib/vdsm/netinfo/bonding.py",
line 247, in _bond_opts_name2numeric_scan
16:18:11 numeric_val)
16:18:11 File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/lib/vdsm/netinfo/bonding.py",
line 259, in _bond_opts_name2numeric_getval
16:18:11 opt_write_file.flush()
16:18:11 IOError: [Errno 16] Device or resource busy:
'opt[/sys/class/net/Z7PxqN9gLALvKkE/bonding/lacp_rate],
numeric_val[1]'
See http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1831/conso…
Can someone from networking check this?
Thanks,
Nir
All stable branch maintainers, please make sure to merge all relevant open
bugs until Tuesday morning 11:00 AM TLV time (10:00 CET).
https://bugzilla.redhat.com/buglist.cgi?quicksearch=target_milestone%3A3.6.…
Every package build (i.e oVirt product) - please make sure every bug in
MODIFIED has the right Target Release and Target Milestone.
A Target release should state the version of the package you're building
and should include the same version you used for the tag you just used for
this build. (e.g. for ovirt-engine, tag will be: ovirt-engine-3.6.2, and
target release must be: 3.6.2)
On Tue, Dec 29, 2015 at 7:04 PM, Yaniv Kaul <ykaul(a)redhat.com> wrote:
> On Tue, Dec 29, 2015 at 6:29 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
>>
>> Hi all,
>>
>> Recently we added a new test, breaking make check when run on a
>> development
>> machine as non-privileged user.
>> https://gerrit.ovirt.org/50984
>>
>> This test pass on the CI environment, because the tests are running as
>> root.
>
>
> Should we do something different in CI?
We should, but I want to discuss this in the devel mailing list.
Nir
> Y.
>
>>
>>
>> Please verify that "make check" is successful on your development
>> environment.
>> otherwise, you may break the tests for others using this practice.
>>
>>
>> Best practice for running the tests:
>>
>> 1. Run the tests for the module you change:
>>
>> $ ./run_tests_local.sh rwlock_test.py
>> nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
>> rwlock_test.RWLockStressTests
>> test_fairness(1, 2) SKIP:
>> Stress tests are disabled
>> test_fairness(2, 8) SKIP:
>> Stress tests are disabled
>> test_fairness(3, 32) SKIP:
>> Stress tests are disabled
>> test_fairness(4, 128) SKIP:
>> Stress tests are disabled
>> rwlock_test.RWLockTests
>> test_concurrent_readers OK
>> test_demotion_no_waiters OK
>> test_demotion_with_blocked_reader SKIP:
>> Slow tests are disabled
>> test_demotion_with_blocked_writer SKIP:
>> Slow tests are disabled
>> test_exclusive_context_blocks_reader SKIP:
>> Slow tests are disabled
>> test_exclusive_context_blocks_writer SKIP:
>> Slow tests are disabled
>> test_fifo SKIP:
>> Slow tests are disabled
>> test_promotion_forbidden OK
>> test_recursive_read_lock OK
>> test_recursive_write_lock OK
>> test_release_other_thread_read_lock OK
>> test_release_other_thread_write_lock OK
>> test_shared_context_allows_reader OK
>> test_shared_context_blocks_writer SKIP:
>> Slow tests are disabled
>> test_wakeup_all_blocked_readers SKIP:
>> Slow tests are disabled
>> test_wakeup_blocked_reader SKIP:
>> Slow tests are disabled
>> test_wakeup_blocked_writer SKIP:
>> Slow tests are disabled
>>
>> ----------------------------------------------------------------------
>> Ran 21 tests in 0.005s
>>
>> This should be very fast and should run after every change.
>>
>> 2. Check that slow and stress tests pass
>>
>> Some modules have @slowtest and @stresstest, which are skipped by default.
>> When modifying such modules, enable also these tests:
>>
>> $ ./run_tests_local.sh rwlock_test.py --enable-slow-tests
>> --enable-stress-tests
>> nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
>> rwlock_test.RWLockStressTests
>> test_fairness(1, 2) OK
>> test_fairness(2, 8) OK
>> test_fairness(3, 32) OK
>> test_fairness(4, 128) OK
>> rwlock_test.RWLockTests
>> test_concurrent_readers OK
>> test_demotion_no_waiters OK
>> test_demotion_with_blocked_reader SKIP:
>> Known issue in current code
>> test_demotion_with_blocked_writer OK
>> test_exclusive_context_blocks_reader OK
>> test_exclusive_context_blocks_writer OK
>> test_fifo OK
>> test_promotion_forbidden OK
>> test_recursive_read_lock OK
>> test_recursive_write_lock OK
>> test_release_other_thread_read_lock OK
>> test_release_other_thread_write_lock OK
>> test_shared_context_allows_reader OK
>> test_shared_context_blocks_writer OK
>> test_wakeup_all_blocked_readers OK
>> test_wakeup_blocked_reader OK
>> test_wakeup_blocked_writer OK
>>
>> ----------------------------------------------------------------------
>> Ran 21 tests in 14.054s
>>
>> This may take more time.
>>
>> 3. When the module tests pass, run "make check"
>>
>> make check
>>
>> This takes about 90 seconds.
>>
>> To run all tests, including slow and stress tests, use:
>>
>> make check-all
>>
>> This may take couple of minutes, so it is not recommended.
>>
>> Thanks,
>> Nir
>> _______________________________________________
>> Devel mailing list
>> Devel(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>
>
