January 2017 - Devel - oVirt List Archives

About ovirtsdk.api module
by 张余歌 07 Jan '17

07 Jan '17

--_000_DM5PR11MB1930AD045547627FBE19645790630DM5PR11MB1930namp_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGVsbG8saSB3YW50IHRvIGNyZWF0IGEgZGV2ZWxvcGVyIGVudmlyb25tZW50ICxhZnRlciBpIHRy eSB0byBEbyBUaGlzIDoNCmZyb20gb3ZpcnRzZGsuYXBpIGltcG9ydCBBUEkNCkkgYWx3YXlzIGdl dCBUaGlzIGVycm9yOg0Kbm8gbW9kdWxlIG5hbWVkIG92aXJ0c2RrLmFwaQ0KDQpCeSB0aGUgd2F5 LGkgdGhpbmsgIGkgSGFkIGluc3RhbGxlZCBzb21lIG5lY2Vzc2FyeSBwYWNrYWdlIGFscmVhZHkg LGkgRG9uJ3Qga25vdyBob3cgd28gZGVhbCAuLkNhbiB1IGhlbHAgLFRoYW5rcw0KDQpHZXQgT3V0 bG9vayBmb3IgQW5kcm9pZDxodHRwczovL2FrYS5tcy9naGVpMzY+DQo= --_000_DM5PR11MB1930AD045547627FBE19645790630DM5PR11MB1930namp_ Content-Type: text/html; charset="utf-8" Content-ID: <AA5E767A59E6184CB75EC0AACFE987B2(a)sct-15-1-789-14-msonline-outlook-2bec4.templateTenant> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPHAgZGlyPSJhdXRv IiBzdHlsZT0iIHRleHQtYWxpZ246IGxlZnQ7IG1hcmdpbi10b3A6IDI1cHg7IG1hcmdpbi1ib3R0 b206IDI1cHg7IGZvbnQtZmFtaWx5OiBzYW5zLXNlcmlmOyBmb250LXNpemU6IDExcHQ7IGNvbG9y OiBibGFjazsgYmFja2dyb3VuZC1jb2xvcjogd2hpdGUgIj4NCkhlbGxvLGkgd2FudCB0byBjcmVh dCBhIGRldmVsb3BlciBlbnZpcm9ubWVudCAsYWZ0ZXIgaSB0cnkgdG8gRG8gVGhpcyA6PGJyPg0K ZnJvbSBvdmlydHNkay5hcGkgaW1wb3J0IEFQSSA8YnI+DQpJIGFsd2F5cyBnZXQgVGhpcyBlcnJv cjo8YnI+DQpubyBtb2R1bGUgbmFtZWQgb3ZpcnRzZGsuYXBpPC9wPg0KPHAgZGlyPSJhdXRvIiBz dHlsZT0iIHRleHQtYWxpZ246IGxlZnQ7IG1hcmdpbi10b3A6IDI1cHg7IG1hcmdpbi1ib3R0b206 IDI1cHg7IGZvbnQtZmFtaWx5OiBzYW5zLXNlcmlmOyBmb250LXNpemU6IDExcHQ7IGNvbG9yOiBi bGFjazsgYmFja2dyb3VuZC1jb2xvcjogd2hpdGUgIj4NCkJ5IHRoZSB3YXksaSB0aGluayZuYnNw OyBpIEhhZCBpbnN0YWxsZWQgc29tZSBuZWNlc3NhcnkgcGFja2FnZSBhbHJlYWR5ICxpIERvbid0 IGtub3cgaG93IHdvIGRlYWwgLi5DYW4gdSBoZWxwICxUaGFua3MNCjwvcD4NCjxwIGRpcj0iYXV0 byIgc3R5bGU9IiB0ZXh0LWFsaWduOiBsZWZ0OyBtYXJnaW4tdG9wOiAyNXB4OyBtYXJnaW4tYm90 dG9tOiAyNXB4OyBmb250LWZhbWlseTogc2Fucy1zZXJpZjsgZm9udC1zaXplOiAxMXB0OyBjb2xv cjogYmxhY2s7IGJhY2tncm91bmQtY29sb3I6IHdoaXRlICI+DQpHZXQgPGEgaHJlZj0iaHR0cHM6 Ly9ha2EubXMvZ2hlaTM2Ij5PdXRsb29rIGZvciBBbmRyb2lkPC9hPjxicj4NCjwvcD4NCjwvYm9k eT4NCjwvaHRtbD4NCg== --_000_DM5PR11MB1930AD045547627FBE19645790630DM5PR11MB1930namp_--

2 1

[VDSM] Re: [ovirt-users] The feature everyone was asking for is finally here...
by Dan Kenigsberg 05 Jan '17

05 Jan '17

As mentioned in yesterday's Vdsm call: this job is most useful and recommended to be run for every system-level modification of Vdsm. On Wed, Jan 4, 2017 at 5:31 PM, Eyal Edri <eedri(a)redhat.com> wrote: > FYI, > > After many requests from multiple developers and testers, the oVirt CI added > a new simple job that lets you run the full fledged end-to-end oVirt system > tests with a click of a button. > You can read all the details and how-to in the new oVirt blog [1]. > > We wanted to allow running oVirt system tests on EVERY open patch from ANY > oVirt project, without relaying on complex building code inside the job. > Luckily we just added the 'build-on-demand' so together with it you can > build any rpms you'd like and use them to run the manual job. > > So the 2 steps you'll need to do are: > > Write 'ci please build' inside a comment on an open oVirt patch ( make sure > the feature is enabled for that project first, its already available for > ovirt-engine,vdsm,dashboard and vdsm-jsonrpc-java) > Run the manual OST job for the version you'd like to test with the URLs you > got from #1 > > You'll get and email once the job is done and you can browse the results and > check for logs from engine and the hosts. > > Please feel free to ask questions on infra(a)ovirt.org as usual. > > > [1] https://www.ovirt.org/blog/2017/01/ovirt-system-tests-to-the-rescue/ > > -- > Eyal Edri > Associate Manager > RHV DevOps > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ) > > _______________________________________________ > Users mailing list > Users(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/users >

1 0

Re: [ovirt-devel] Heads-up: moving Libvirt xml creation to the engine
by Yevgeny Zaspitsky 04 Jan '17

04 Jan '17

I agree with Piotr&Edward: - having engine uses libvirt xml would impose coupling between engine and libvirt (a cross-layers dependency), which currently does not exist. - moreover, engine would be coupled to all versions of libvirt api that it manages - currently each VDSM version knows how to interact with libvirt it uses (de-centralized approach) - currently we do not have a mechanism that ensures libvirt version based on cluster level (IMHO). Ensuring that would imply requesting a very specific version of libvirt by VDSM. - cluster version means a minimum level of compatibility, but what if cluster of version (x.y) contains a host of a newer version (x+1.y+2). What would be able to tell about libvirt it uses? Regards, Yevgeny On Fri, Dec 9, 2016 at 12:58 PM, Martin Sivak <msivak(a)redhat.com> wrote: > > I like transport abstractions (DTOs) and here we make the libvirt xml > > (its structure) part of our communication interface. > > I agree, but only partially. We can have a DTO for this, but we need a > library to convert from/to it. Hosted engine has to duplicate the > current Java code as it has to convert the OVF to the format vdsm is > expecting. And that is very error prone. Getting the domain XML from > the engine and using it directly would solve a lot of bugs we have. Or > alternatively the ability to send the OVF to vdsm without > preprocessing. > > On the other hand, the logic we have in vdsm is not that complicated > and we could move it to the engine, because we have (almost) all the > information there as well. The (complicated) logic needed to use vdsm > verbs is part of engine anyway and I am constantly under pressure to > not use (for example from virt) the verbs directly. It does not make > sense to maintain the current separation in the situation where there > is tight coupling anyway. > > This whole discussion will boil to a simple point eventually: What is > the role of vdsm and how dumb is it supposed to be in the future (it > is pretty dumb currently.. just a conversion proxy + monitoring, at > least in areas I am concerned about). I would like slightly smarter > vdsm with engine acting only as the high level boss, without the > micromanaging of storage verbs for example. > > TLDR; I would like to get data from storage (currently OVF) and pass > them to vdsm without any preprocessing. Separation is not a bad idea, > but we currently have three different formats with no clear rules for > conversion. I would also like to have slightly more high level API in > vdsm ("prepareImage" should make sure domain monitor is up, domain is > mounted and so on.. I do not want to micromanage that). > > Martin > > > On Fri, Dec 9, 2016 at 11:39 AM, Piotr Kliczewski > <piotr.kliczewski(a)gmail.com> wrote: > > I like transport abstractions (DTOs) and here we make the libvirt xml > > (its structure) part of our communication interface. > > We were never good at evolving our api. Here is [1] recent example of it. > > > > I am not against this change but I would like us to think about > > potential changes to this xml. With this approach when change > > happens we would need to change the engine and vdsm code and make sure > > that supported engine/vdsm matrix still work. > > > > Will it be possible to have different libvirt versions (different xml > > structure) between version clusters? If so, how are we going to > > handle different xml structure per cluster? > > > > Thanks, > > Piotr > > > > [1] https://gerrit.ovirt.org/#/c/67596 > > > > > > On Thu, Dec 8, 2016 at 11:30 PM, Edward Haas <ehaas(a)redhat.com> wrote: > >> > >> > >> On Wed, Nov 23, 2016 at 2:59 PM, Arik Hadas <ahadas(a)redhat.com> wrote: > >>> > >>> Hi All, > >>> > >>> We are working on something that is expected to have a big impact, > hence > >>> this heads-up. > >>> First, we want you to be aware of this change and provide your > feedback to > >>> make it as good as possible. > >>> Second, until the proposed mechanism is fully merged there will be a > chase > >>> to cover all features unless new features are also implemented with > the new > >>> mechanism. So please, if you are working on something that adds/changes > >>> something in the Libvirt's domain xml, do it with this new mechanism > as well > >>> (first version would be merged soon). > >>> > >>> * Goal > >>> Creating Libvirt XML in the engine rather than in VDSM. > >>> ** Today's flow > >>> Engine: VM business entity -> VM properties map > >>> VDSM: VM properties map -> Libvirt XML > >>> ** Desired flow > >>> Engine: VM business entity -> Libvirt XML > >>> > >>> * Potential Benefits > >>> 1. Reduce the number of conversions from 2 to 1, reducing chances for > >>> mistakes in the process. > >>> 2. Reduce the amount of code in VDSM. > >>> 3. Make VM related changes easier - today many of these changes need > to be > >>> reviewed in 2 projects, this will eliminate the one that tends to take > >>> longer. > >>> 4. Prevent shortcuts in the form of VDSM-only changes that should be > >>> better reflected in the engine. > >>> 5. Not to re-generate the XML on each rerun attempt of VM > run/migration. > >>> 6. Future - not to re-generate the XML on each attempt to auto-start > HA VM > >>> when using vm-leases (need to make sure we're using the up-to-date VM > >>> configuration though). > >>> 7. We already found improvements and cleanups that could be made while > >>> touching this area (e.g., remove the boot order from devices in the > >>> database). > >>> > >>> * Challenges > >>> 1. Not to move host-specific information to the engine. For example, > path > >>> to storage domain or sockets of channels. > >>> The solution is to use place-holders that will be replaced by VDSM. > >>> 2. Backward compatibility. > >>> 3. The more challenging part is the other direction - that will be the > >>> next phase. > >>> > >>> * Status > >>> As a first step, we began with producing the Libvirt XML in the engine > by > >>> converting the VM properties map to XML in the engine [1] > >>> And using the XML that is received as an input in VDSM [2] > >>> > >>> > >>> [1] https://gerrit.ovirt.org/#/c/64473/ > >>> [2] https://gerrit.ovirt.org/#/c/65182/ > >>> > >>> Regards, > >>> Arik > >> > >> > >> This is an interesting path to take, but centralizing the logic to a > single > >> component often limits and does not allow scaling. > >> A large amount of solutions these days attempt to distribute work, > reducing > >> central work to a minimum, but this approach suggests the opposite. > >> > >> In the networking area, from my limited experience, changes are pushed > >> faster to VDSM compared to Engine. > >> In many cases it is just logically simpler: Engine needs to handle and > be > >> concern about all the system as a whole, while VDSM just takes care of > the > >> host. > >> Therefore, in my mind, the goal is to distribute as much as possible to > the > >> edges, keeping in the centre the minimum required to connect then all > >> together. > >> > >> This approach will remove a conversion and with it an abstraction > layer. I > >> find abstraction useful, decoupling components and increasing > modularity. > >> As an example from the OvS integration work, changing the underlying > >> networking implementation should not concern the upper business logic > >> components, > >> it should be well hidden in the hypervisor, exposing only capabilities > and > >> nothing more that hints about the what and how. > >> > >> Thanks, > >> Edy. > >> > >> > >> > >> _______________________________________________ > >> Devel mailing list > >> Devel(a)ovirt.org > >> http://lists.phx.ovirt.org/mailman/listinfo/devel > > _______________________________________________ > > Devel mailing list > > Devel(a)ovirt.org > > http://lists.phx.ovirt.org/mailman/listinfo/devel > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.phx.ovirt.org/mailman/listinfo/devel >

2 1

Re: [ovirt-devel] how does findbugs work?
by Michal Skrivanek 04 Jan '17

04 Jan '17

--Apple-Mail=_276E41C4-C160-4736-B90A-3000D1AC388B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 21 Dec 2016, at 12:23, Eyal Edri <eedri(a)redhat.com> wrote: >=20 > You can see from the output the maven plugin is running [1], > Have you checked the filters that are ignoring 'false positives'? = maybe those needs to be updated? >=20 > The are in the 'exclude-filters.xml' files under each project and = maintained by the ovirt-engine maintainers. AFAICT no, it=E2=80=99s not excluded, but checking whole ovirt-engine on = coverity site I can=E2=80=99t seem to find the whole file. I dunno, = I=E2=80=99m not much of an expert, but I do not see any exclude anywhere = and there are bunch of other files in the same dir=E2=80=A6 anyone any idea? >=20 >=20 >=20 > [1] 08:13:21 [FINDBUGS] Collecting findbugs analysis files... > 08:13:23 [FINDBUGS] Finding all files that match the pattern = **/findbugsXml.xml > 08:13:23 [FINDBUGS] Parsing 34 files in = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/extensions-tool/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/aaa/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/auth-plugin/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/bll/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/branding/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/builtin-extensions/target/findbugsXml.xml with = 0 unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/common/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/compat/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/dal/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/docs/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/enginesso/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/extensions-api-root/extensions-api/target/findbug= sXml.xml with 0 unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/extensions-manager/target/findbugsXml.xml with = 0 unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/logger/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/restapi/interface/common/jaxrs/target/findbugsXml= .xml with 0 unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/restapi/interface/definition/target/findbugsXml.x= ml with 0 unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/restapi/jaxrs/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/restapi/types/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/scheduler/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/searchbackend/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/services/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/utils/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/uutils/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/vdsbroker/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/welcome/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/tools/target/findbugsXml.xml with 0 unique warnings and = 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /build-tools-root/ovirt-checkstyle-extension/target/findbugsXml.xml with = 0 unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/frontend/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/gwt-common/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/gwt-extension/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/uicommonweb/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/uicompat/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/userportal-gwtp/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/webadmin/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates. > 08:13:23 [FINDBUGS] Computing warning deltas based on reference build = #11731 > 08:13:23 [FINDBUGS] Ignore new warnings since this is the first valid = build > 08:13:23 [FINDBUGS] Plug-in Result: Success - no threshold has been = exceeded >=20 > On Wed, Dec 21, 2016 at 12:42 PM, Michal Skrivanek = <michal.skrivanek(a)redhat.com <mailto:michal.skrivanek@redhat.com>> = wrote: > Hi, > I was trying to see why the recent NPE[1] was not found by findbugs. = Typically identifying potential NPE is the most easy thing=E2=80=A6but = it was not reported. > So I triggered the build again on the wrong patch [2] and it doesn=E2=80= =99t show anything useful[3] > Does it work at all? > There seem to be no artifacts to review that >=20 > Thanks, > michal >=20 > [1] https://gerrit.ovirt.org/#/c/68731 = <https://gerrit.ovirt.org/#/c/68731> > [2] https://gerrit.ovirt.org/#/c/68400/5 = <https://gerrit.ovirt.org/#/c/68400/5> > [3] = http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_created/11732/ = <http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_created/11732/= > > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org <mailto:Infra@ovirt.org> > http://lists.ovirt.org/mailman/listinfo/infra = <http://lists.ovirt.org/mailman/listinfo/infra> >=20 >=20 >=20 >=20 >=20 > --=20 > Eyal Edri > Associate Manager > RHV DevOps > EMEA ENG Virtualization R&D > Red Hat Israel >=20 > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ) --Apple-Mail=_276E41C4-C160-4736-B90A-3000D1AC388B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" = class=3D""><br class=3D""><div><blockquote type=3D"cite" class=3D""><div = class=3D"">On 21 Dec 2016, at 12:23, Eyal Edri <<a = href=3D"mailto:eedri@redhat.com" class=3D"">eedri(a)redhat.com</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = dir=3D"ltr" class=3D"">You can see from the output the maven plugin is = running [1],<div class=3D"">Have you checked the filters that are = ignoring 'false positives'? maybe those needs to be updated?</div><div = class=3D""><br class=3D""></div><div class=3D"">The are in the = 'exclude-filters.xml' files under each project and maintained by the = ovirt-engine maintainers.<br = class=3D""></div></div></div></blockquote><div><br = class=3D""></div><div><br class=3D""></div>AFAICT no, it=E2=80=99s not = excluded, but checking whole ovirt-engine on coverity site I can=E2=80=99t= seem to find the whole file. I dunno, I=E2=80=99m not much of an = expert, but I do not see any exclude anywhere and there are bunch of = other files in the same dir=E2=80=A6</div><div>anyone any = idea?</div><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D""><div dir=3D"ltr" class=3D""><div class=3D""><div class=3D""><br= class=3D""></div><div class=3D""><br class=3D""></div><div class=3D""><br= class=3D""></div><div class=3D"">[1] 08:13:21 [FINDBUGS] Collecting = findbugs analysis files...</div><div class=3D"">08:13:23 [FINDBUGS] = Finding all files that match the pattern **/findbugsXml.xml</div><div = class=3D"">08:13:23 [FINDBUGS] Parsing 34 files in = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created</div><div = class=3D"">08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/extensions-tool/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/aaa/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/auth-plugin/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/bll/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/branding/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/builtin-extensions/target/findbugsXml.xml with = 0 unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/common/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/compat/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/dal/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/docs/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/enginesso/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/extensions-api-root/extensions-api/target/findbug= sXml.xml with 0 unique warnings and 0 duplicates.</div><div = class=3D"">08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/extensions-manager/target/findbugsXml.xml with = 0 unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/logger/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/restapi/interface/common/jaxrs/target/findbugsXml= .xml with 0 unique warnings and 0 duplicates.</div><div = class=3D"">08:13:23 [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/restapi/interface/definition/target/findbugsXml.x= ml with 0 unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/restapi/jaxrs/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/restapi/types/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/scheduler/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/searchbackend/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/services/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/utils/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/uutils/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/vdsbroker/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/modules/welcome/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /backend/manager/tools/target/findbugsXml.xml with 0 unique warnings and = 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] Successfully = parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /build-tools-root/ovirt-checkstyle-extension/target/findbugsXml.xml with = 0 unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/frontend/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/gwt-common/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/gwt-extension/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/uicommonweb/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/uicompat/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/userportal-gwtp/target/findbugsXml.xml with 0 = unique warnings and 0 duplicates.</div><div class=3D"">08:13:23 = [FINDBUGS] Successfully parsed file = /home/jenkins/workspace/ovirt-engine_master_find-bugs_created/ovirt-engine= /frontend/webadmin/modules/webadmin/target/findbugsXml.xml with 0 unique = warnings and 0 duplicates.</div><div class=3D"">08:13:23 [FINDBUGS] = Computing warning deltas based on reference build #11731</div><div = class=3D"">08:13:23 [FINDBUGS] Ignore new warnings since this is the = first valid build</div><div class=3D"">08:13:23 [FINDBUGS] Plug-in = Result: Success - no threshold has been exceeded</div></div></div><div = class=3D"gmail_extra"><br class=3D""><div class=3D"gmail_quote">On Wed, = Dec 21, 2016 at 12:42 PM, Michal Skrivanek <span dir=3D"ltr" = class=3D""><<a href=3D"mailto:michal.skrivanek@redhat.com" = target=3D"_blank" class=3D"">michal.skrivanek(a)redhat.com</a>></span> = wrote:<br class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0 = 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br class=3D""> I was trying to see why the recent NPE[1] was not found by findbugs. = Typically identifying potential NPE is the most easy thing=E2=80=A6but = it was not reported.<br class=3D""> So I triggered the build again on the wrong patch [2] and it doesn=E2=80=99= t show anything useful[3]<br class=3D""> Does it work at all?<br class=3D""> There seem to be no artifacts to review that<br class=3D""> <br class=3D""> Thanks,<br class=3D""> michal<br class=3D""> <br class=3D""> [1] <a href=3D"https://gerrit.ovirt.org/#/c/68731" rel=3D"noreferrer" = target=3D"_blank" class=3D"">https://gerrit.ovirt.org/#/c/<wbr = class=3D"">68731</a><br class=3D""> [2] <a href=3D"https://gerrit.ovirt.org/#/c/68400/5" rel=3D"noreferrer" = target=3D"_blank" class=3D"">https://gerrit.ovirt.org/#/c/<wbr = class=3D"">68400/5</a><br class=3D""> [3] <a = href=3D"http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_created= /11732/" rel=3D"noreferrer" target=3D"_blank" = class=3D"">http://jenkins.ovirt.org/job/<wbr = class=3D"">ovirt-engine_master_find-bugs_<wbr = class=3D"">created/11732/</a><br class=3D""> ______________________________<wbr class=3D"">_________________<br = class=3D""> Infra mailing list<br class=3D""> <a href=3D"mailto:Infra@ovirt.org" class=3D"">Infra(a)ovirt.org</a><br = class=3D""> <a href=3D"http://lists.ovirt.org/mailman/listinfo/infra" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">http://lists.ovirt.org/<wbr = class=3D"">mailman/listinfo/infra</a><br class=3D""> <br class=3D""> <br class=3D""> </blockquote></div><br class=3D""><br clear=3D"all" class=3D""><div = class=3D""><br class=3D""></div>-- <br class=3D""><div = class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div = dir=3D"ltr" class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D""><div dir=3D"ltr" class=3D""><div class=3D"">Eyal Edri<br = class=3D"">Associate Manager</div><div class=3D"">RHV DevOps<br = class=3D"">EMEA ENG Virtualization R&D<br class=3D"">Red Hat = Israel<br class=3D""><br class=3D"">phone: +972-9-7692018<br = class=3D"">irc: eedri (on #tlv #rhev-dev = #rhev-integ)</div></div></div></div></div></div></div> </div> </div></blockquote></div><br class=3D""></body></html>= --Apple-Mail=_276E41C4-C160-4736-B90A-3000D1AC388B--

2 1

Can't find relative path for class "org.ovirt.engine.api.resource.VmDisksResource", will return null
by Pavel Zhukov 04 Jan '17

04 Jan '17

Hello, In ovirt-system-tests results I can see engine log is flooded with messages like: 147: 40147:2017-01-03 21:45:13,837-05 ERROR [org.ovirt.engine.api.restapi.util.LinkHelper] (default task-22) [] Can't find relative path for class "org.ovirt.engine.api.resource.VmDisksResource", will return null There're 123 messages like (logging time is 15 mins). Is it expected to have too many ERROR messages? [1] http://jenkins.ovirt.org/job/ovirt_4.1_system-tests/28/artifact/exported-ar… -- Pavel Zhukov Software Engineer RHEV Devops IRC: landgraf

2 2

Strange failure in 4.1 - in running VM (qemu issue?)
by Yaniv Kaul 04 Jan '17

04 Jan '17

I'm running ovirt-system-test with 4.1 and running into a new issue -VM run fails with: 2017-01-03 05:53:25,956-05 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ForkJoinPool-1-worker-13) [] Correlation ID: null, Call Stack: null, Custom Event ID: -1, Message: VM vm0 is down with error. Exit message: internal error: qemu unexpectedly closed the monitor: 2017-01-03T10:53:23.993768Z qemu-kvm: warning: CPU(s) not present in any NUMA nodes: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2017-01-03T10:53:23.994225Z qemu-kvm: warning: All CPU(s) up to maxcpus should be described in NUMA config warning: host doesn't support requested feature: CPUID.07H:EBX.invpcid [bit 10] 2017-01-03T10:53:24.042859Z qemu-kvm: -device usb-ccid,id=ccid0,bus=usb.0,port=1: Warning: speed mismatch trying to attach usb device "QEMU USB CCID" (full speed) to bus "usb.0", port "1" (high speed). Has anyone seeing something like that? possibly a regression in qemu? TIA, Y.

3 3

[VDSM] Notification in vdsm client
by Piotr Kliczewski 02 Jan '17

02 Jan '17

All, Some time ago during discussion we noticed that we are missing ability to send/receive events from vdsm client [1]. Initially we thought that having [2] would be enough to support notification between engine and vdsm. Now we know we need it for [1]. I would like to collect potential use cases from mom, hosted engine and others so we could design the api to enable them. As part of the work I would like to see whether there is a need to have global event topic or have name convention and use more granular queues. Do we have any use cases to subscribe to additional topic(s) during life time of a client or subscription during instantiation is good enough. Thanks, Piotr [1] https://github.com/oVirt/vdsm/blob/master/lib/vdsmclient/client.py [2] https://github.com/oVirt/vdsm/blob/master/vdsm/clientIF.py#L149

3 2

hotplug_disk test failed
by Gil Shinar 02 Jan '17

02 Jan '17

Hi, The above test failed. Here are the VDSM and engine logs: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_4.1/88/artifact/e… For the exact same patch, this test has failed for fc24 but succeeded for el7. Thanks Gil

2 2

engine: the link to host-deploy log is wrong
by Yaniv Bronheim 02 Jan '17

02 Jan '17

Hi, I'm not sure if I'm right or wrong so before filing a bug let me know if I don't miss anything - I think the audit log on fail deploy that says the path for the deploy log is wrong. few times I already faced that it points to somewhere under /tmp/ovirt-host-deploy... but the log is actually under /var/log/ovirt-engine/host-deploy/... -- *Yaniv Bronhaim.*

3 4