April 2017 - Devel - oVirt List Archives

Re: [ovirt-devel] [rhev-devel] Fwd: [ACTION REQUIRED] update ovirt-js-dependencies
by Jakub Niedermertl 25 Apr '17

25 Apr '17

Hi Greg, I can't find package ovirt-js-dependencies-0.0.4 for fedora 24. Is there any? Thanks Jakub On Sun, Apr 23, 2017 at 6:24 PM, Greg Sheremeta <gshereme(a)redhat.com> wrote: > > ---------- Forwarded message ---------- > From: Greg Sheremeta <gshereme(a)redhat.com> > Date: Sun, Apr 23, 2017 at 12:23 PM > Subject: [ACTION REQUIRED] update ovirt-js-dependencies > To: devel <devel(a)ovirt.org> > > > Hi, > > We added [1][2] a JavaScript library [3] to webadmin and userportal to > re-enable draggable dialogs. > > Please: > > sudo dnf update ovirt-js-dependencies > > If that doesn't work for you for some reason, 1. let me know, 2. if you need > it immediately, > sudo dnf install > http://plain.resources.ovirt.org/repos/ovirt/tested/master/rpm/fc25/noarch/… > > Best wishes, > Greg > > [1] https://gerrit.ovirt.org/#/c/74616/ > [2] https://gerrit.ovirt.org/#/c/74615/ > [3] https://jqueryui.com/draggable/ > > -- > Greg Sheremeta, MBA > Sr. Software Engineer > Red Hat, Inc. > gshereme(a)redhat.com > > > > -- > Greg Sheremeta, MBA > Sr. Software Engineer > Red Hat, Inc. > gshereme(a)redhat.com

2 2

[VDSM] Using pylint to improve your code
by Nir Soffer 25 Apr '17

25 Apr '17

Hi all, Dan merge today a patch adding pylint-diff make target. With this target, you can check new code quickly: $ time make pylint ... real 1m31.133s user 1m29.934s sys 0m0.849s $ time make pylint-diff ... real 0m12.364s user 0m11.879s sys 0m0.262s Here is example patch adding stupid code to vdsm: diff --git a/lib/vdsm/common/osutils.py b/lib/vdsm/common/osutils.py index 0b3576a..6d37b7a 100644 --- a/lib/vdsm/common/osutils.py +++ b/lib/vdsm/common/osutils.py @@ -55,5 +55,5 @@ def uninterruptible(func, *args, **kwargs): try: return func(*args, **kwargs) except EnvironmentError as e: - if e.errno != errno.EINTR: + if e.errrno != errno.EINTR: We had real errors like this in vdsm, some of them were made by the author of this message :-) Once committed, running pylint-diff will show: $ make pylint-diff [stripped uninteresting output] ************* Module vdsm.common.osutils E: 58,15: Instance of 'EnvironmentError' has no 'errrno' member (no-member) ERROR: InvocationError: '/home/nsoffer/.local/bin/pylint --errors-only lib/vdsm/common/osutils.py' __________________________________________________________________________________________ summary ___________________________________________________________________________________________ ERROR: pylint: commands failed Makefile:978: recipe for target 'pylint-diff' failed make: *** [pylint-diff] Error 1 This is not part of the build yet, since we still have lot of pylint errors in vdsm. Hopefully we will be pylint clean this week, and we can enable pylint during the build next week: https://gerrit.ovirt.org/75895 Please run pylint-diff before you submit patches. Nir

1 0

Re: [ovirt-devel] Which is the official oVirt docker repository, 'ovirt' or 'ovirtorg'?
by Barak Korren 25 Apr '17

25 Apr '17

On 18 April 2017 at 16:22, Juan Hernández <jhernand(a)redhat.com> wrote: > Hello, > > Both exist: > > https://hub.docker.com/u/ovirt > https://hub.docker.com/u/ovirtorg > > The first, 'ovirt', has some branding, but it is empty, no images. > > The second, 'ovirtorg', has no branding, but hosts some images. > > Which one should we use to publish our official images? I'd like to > start publishing the images that we are building for the engine? Who has > the credentials for that? Hi Juan, I see you've been referred to all the relevant tickets in Jira. Let me try and summarise where we stand currently. The TL;DR is that everything that has to do with container publishing it still TBD and we (The CI team) are waiting for input from developers before implementing any capabilities into the system. When it comes to Dockerhub repos, as described in OVIRT-758 [1], we have the credentials for two of them: 1. ovirt - Which I guess would be used for "official" releases 2. ovirtinfra - Which I guess would be used for storing intermediate builds during the testing processes I'm not sure who holds 'ovirtorg' and for what. When it comes to publishing As described in the comments on OVIRT-890 [2], there are basically two approaches we could take. 1. Let developers access the credentials for the repos from STD-CI scripts and do with then as they please. This will provide the greatest degree of freedom to developers but will make it hard to standardise on naming and versioning conventions. 2. Establish a method for STD-CI scripts to indicate the there are containers to be published and let the CI system take care of the rest like it does for RPMs. >From our standpoint, we'd like to be able to create a similar process to what we have for RPMs currently, where artifacts get moved between different repositories as they progress in the testing process. The main issue with that is that Docker does not seem support a well structured notion of versions and repositories like RPMs do. I think this could be implemented by using tags, but this would necessitate taking approach #2 above, and developers might prefer using tags for other things. A similar question is what official releases look like, I guess the 'latest' tag indicates some kind of a "release" for a container, but how does one maintain multiple official releases at the same time? Another related question is when do we release containers and who will do it, will it work in a similar process to how we release RPMs? Sine we do want to move things along and provide support, we've started work on OVIRT-894 [3] which would enable approach #1 above. Credentials are useful for many things, so I guess there will be no harm in implementing it even if we don't end up using it for containers. I hope this clarifies where we stand right now. [1]: https://ovirt-jira.atlassian.net/browse/OVIRT-758 [2]: https://ovirt-jira.atlassian.net/browse/OVIRT-890 [3]: https://ovirt-jira.atlassian.net/browse/OVIRT-894 -- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted

2 2

OST failure NoClassDefFoundError
by Roy Golan 25 Apr '17

25 Apr '17

I get this on basic suite from a built RPM[1]: Caused by: java.lang.NoClassDefFoundError: org/apache/commons/lang/StringUtils at org.ovirt.vdsm.jsonrpc.client.reactors.stomp.impl.Message.withCorrelationId(Message.java:75) [vdsm-jsonrpc-java-client.jar:] at org.ovirt.vdsm.jsonrpc.client.reactors.stomp.SSLStompClient.sendMessage(SSLStompClient.java:85) [vdsm-jsonrpc-java-client.jar:] at org.ovirt.vdsm.jsonrpc.client.JsonRpcClient.call(JsonRpcClient.java:83) [vdsm-jsonrpc-java-client.jar:] My patch under test certainly didn't touch this area [2] [1] http://jenkins.ovirt.org/job/ovirt-system-tests_manual/290/artifact/exporte… [2] https://gerrit.ovirt.org/#/c/75262/ Did anyone see that?

3 3

[ACTION SUGGESTED] can't start VMs on master? run engine-setup
by Greg Sheremeta 25 Apr '17

25 Apr '17

Hi, I noticed today that I couldn't start a VM on master. Turns out I needed to run engine-setup to pull in some database changes (I assume). For what it's worth, the stacktrace [1] didn't say anything about missing columns (as it usually will for things like this). It just said it couldn't create a new RunVm because of NPE. Best wishes, Greg [1] https://paste.fedoraproject.org/paste/TYNKZh1tR0f2XU3ifboHCF5M1UNdIGYhyRLiv… -- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme(a)redhat.com

2 1

GSoC Mentors Needed
by Brian Proffitt 24 Apr '17

24 Apr '17

All: We have been given five slots for projects in Google Summer of Code this year and thus far only one has a mentor. If anyone is interested in mentoring one of these projects, please contact me immediately. The deadline is 1200 EDT today. -- Configuring Backup storage for Ovirt This proposal is about configuring any Storage Domain as a new Backup Storage Domain.This will help to replace the use of Export storage domain which use dedicated storage domain for backup and disaster recovery. -- Implement oVirt integration tests using Lago Complete the ovirt-system-tests with the necessary tests -- oVirt log analyzer oVirt is a distributed system and all parts of the system have their own logs. In order to analyze/troubleshoot an issue, it is useful to correlate an action triggered on one subsystem and how it travelled over the other parts. This would be a greenfield project written in Python. Timeline of the work: Develop a method for recognizing the contents of log files of different formats - May, 30 - June, 15 Implement matching events in different log files with each other - June, 15 - July, 1 Develop and implement methods for automatic analysis of the logs and the events occurring in them, such as identifying errors, unusual events, VM properties, etc. - July, 1 - August, 1 Add an interactive user interface to the developed algorithms, testing and improving - August, 1 - August, 30 The initial version of steps 1-3 implementation was proposed under mentor (Milan Zamazal) control, the results are in repository https://github.com/aantsiferova/ovirt-log-analyzer -- BRIAN PROFFITT PRINCIPAL COMMUNITY ANALYST Red Hat Inc. <https://www.redhat.com/> bproffit(a)redhat.com T: 574.383.9BKP <http://redhatemailsignature-marketing.itos.redhat.com/> M: 574.780.5695 <http://redhatemailsignature-marketing.itos.redhat.com/> <https://red.ht/sig> T: @redhatopen <https://twitter.com/redhatopen> F: Red Hat Community <https://www.facebook.com/redhatopen>

2 2

Abusing injection and DB access
by Moti Asayag 24 Apr '17

24 Apr '17

Hi All, ATM, there are 78 occurrences of "Injector.injectMembers(new AuditLogableBase())" in ovirt-engine project, which their main purpose is to ease the resolve of the placeholders of the audit log message while logging an event. For instance AuditLogType.MAC_ADDRESS_IS_EXTERNAL is being used from ImportVmCommandBase.java in the following way: private AuditLogableBase createExternalMacsAuditLog(VM vm, Set<String> externalMacs) { AuditLogableBase logable = *Injector.injectMembers*(new AuditLogableBase()); logable.setVmId(vm.getId()); logable.setCustomCommaSeparatedValues("MACAddr", externalMacs); return logable; } The entry in the properties file is: MAC_ADDRESS_IS_EXTERNAL=VM ${*VmName*} has MAC address(es) ${MACAddr}, which is/are out of its MAC pool definitions. Therefore the only purpose of the injection is to allow the AuditLogDirector to resolve the ${*VmName*} which is already known at the time of creating the AuditLogableBase entry. The result is injecting the DAOs for the AuditLogableBase instance and using the VM dao to retrieve the VM entry from the DB. This is just a wastef of injection and DB access while both can be spared. This could have been easily replaced by one of the following: - auditLogableBase.setVmName(vm.getName()); - auditLogableBase.addCustomValue("VmName", vm.getName()); Please pick up any occurrence from your domain and send a patch to replace it where possible. Thanks in advance, Moti

4 7

abrt integration in vdsm 4.1
by Yaniv Bronheim 24 Apr '17

24 Apr '17

Hi, I posted the new integration [1] to 4.1 - https://gerrit.ovirt.org/#/q/topic:backport-abrt-intgr for review. Abrt is a service that runs in parallel to vdsm and collect binaries and python crashes under /var/run/tmp - to try that out you can crash a qemu process or vdsm with signal -6 and watch the report using "abrt-cli list" command, which its output will be reported by our sos plugin. Thanks, Yaniv Bronhaim. [1] https://bugzilla.redhat.com/show_bug.cgi?id=917062 -- Yaniv Bronhaim.

3 5

[Vdsm] silence existing pylint errors
by Dan Kenigsberg 24 Apr '17

24 Apr '17

As we all know, Python is dynamically typed, which requires good coverage by unit tests. As we all know, Vdsm unit tests' coverage is not good. We need all the help we can get in order to avoid typos leading to bugs. Nir's `make pylint-diff` would give some. In order to have it merged, I have posted https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:p… to silence existing pylint errors. I hope I did not silence any serious ones; please review this topic as soon as possible. Regards, Dan.

3 5

[ACTION REQUIRED] update ovirt-js-dependencies
by Greg Sheremeta 23 Apr '17

23 Apr '17

Hi, We added [1][2] a JavaScript library [3] to webadmin and userportal to re-enable draggable dialogs. Please: sudo dnf update ovirt-js-dependencies If that doesn't work for you for some reason, 1. let me know, 2. if you need it immediately, sudo dnf install http://plain.resources.ovirt.org/repos/ovirt/tested/master/rpm/fc25/noarch/… Best wishes, Greg [1] https://gerrit.ovirt.org/#/c/74616/ [2] https://gerrit.ovirt.org/#/c/74615/ [3] https://jqueryui.com/draggable/ -- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme(a)redhat.com

1 0