June 2017 - Devel - oVirt List Archives

OVN provider's firewalld services deployment during engine setup
by Leon Goldberg 19 Sep '17

19 Sep '17

Hey, We're trying to come up with a way to deploy OVN provider's firewalld services during engine setup. The naive solution of querying the user during customization and then installing during STAGE_PACKAGES fails as firewalld configuration happens prior to it. We thought of a couple of possible solutions we'd like your opinions on (ordered in perceived level of difficulty): 1) Ship/require the packages with ovirt-engine without requiring user input. This essentially couples engine with OVN and disregards a future where OVN doesn't run alongside Engine. 2) Install the packages immediately following user input during customization. A bit hacky and doesn't conceptually fit the stage of customization. 3) Move user input to STAGE_INTERNAL_PACKAGES. Feels more disruptive than #1 to the current otopi flow as STAGE_INTERNAL_PACKAGES is dedicated for packages that are required for otopi itself to operate. Not only this doesn't fit conceptually, it introduces user input to a stage that shouldn't have any. 4) Move firewalld configuration to happen after STAGE_PACKAGES. 5) Refactor to prepare the grounds for OVN/Engine separation. At this point this feels very ambiguous. We don't yet know how will containers be accessed (is ssh guaranteed?) in the future or generally how should a remote installation look like. Any input/questions are appreciated. Thanks, Leon

6 10

New design for the Gerrit UI
by Evgheni Dereveanchin 06 Sep '17

06 Sep '17

Hi everyone, The Infra team is working on customizing the look of Gerrit to make it fit better with other oVirt services. I want to share the result of this effort. Hopefully we can gather some feedback before applying the design to oVirt's instance of Gerrit. Please visit the Staging instance to check it out: https://gerrit-staging.phx.ovirt.org/ The new design is inspired by oVirt's main website. There is a known glitch that the "Loading Gerrit Code Review" message is overlapped by the logo when the UI is loading. If you spot any other issues or have ideas for improvement feel free to respond to this thread or share your feedback in the following JIRA ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-912 -- Regards, Evgheni Dereveanchin

17 28

Help get oVirt's add featured on Stack Overflow
by Allon Mureinik 27 Jul '17

27 Jul '17

Hi lists, Thanks to Eldan, we have a community ad for oVirt proposed on Stack Overflow [1]. Now, we need some upvotes (current threshold is 6) before SO starts serving it. Have a SO account? Want to help? Just drop by and upvote. Have a great weekend, Allon [1] https://meta.stackoverflow.com/a/351453/2422776

3 4

Vdsm dependency on GlusterFS 3.10
by Milan Zamazal 02 Jul '17

02 Jul '17

Vdsm master depends on GlusterFS 3.10 now but that doesn't seem to be available in common RHEL repos. So what's the recommended way to satisfy the dependency on RHEL hosts? Thanks, Milan

4 4

New Gerrit 2.13 UI updates
by Eyal Edri 02 Jul '17

02 Jul '17

FYI, Following last night Gerrit upgrade to 2.13.8 ( Thanks Evgheni! ), there are some nice updates worth mentioning: (I really like the new 'blame' option on the diff screen... :) User Interface - The UI can now be loaded in an iFrame by enabling gerrit.canLoadInIFrame <https://gerrit-documentation.storage.googleapis.com/Documentation/2.13/conf…> in the site configuration. <https://www.gerritcodereview.com/releases/2.13.md#Change-Screen>Change Screen - Issue 106 <https://bugs.chromium.org/p/gerrit/issues/detail?id=106>: Allow to select merge commit's parent for diff base in change screen. - Issue 3035 <https://bugs.chromium.org/p/gerrit/issues/detail?id=3035>: Allow to remove specific votes from a change, while leaving the reviewer on the change. - Issue 3487 <https://bugs.chromium.org/p/gerrit/issues/detail?id=3487>: Use ‘Ctrl-Alt-e’ instead of ‘e’ to open edit mode. <https://www.gerritcodereview.com/releases/2.13.md#Diff-Screens>Diff Screens - Add all syntax highlighting available in CodeMirror. - Improve search experience in diff screen. Ctrl-F, Ctrl-G and Shift-Ctrl-G now bind to the search dialog box provided by CodeMirror's search add-on. Enter and Shift-Enter navigate among the search results from the CodeMirror search, just like they do in a normal browser search. Esc now clears the search result. If the user sets Render to Slow in the diff preferences and the file is less than 4000 lines (huge), then Ctrl-F, Ctrl-G and Shift-Ctrl-G fall back to the browser search. - Issue 2968 <https://bugs.chromium.org/p/gerrit/issues/detail?id=2968>: Allow to go back to change list by keyboard shortcut from diff screens. - Blame annotations. By enabling change.allowBlame <https://gerrit-documentation.storage.googleapis.com/Documentation/2.13/conf…>, blame annotations can be shown in the side-by-side diff screen gutter. Clicking the annotation opens the relevant change. <https://www.gerritcodereview.com/releases/2.13.md#User-Preferences>User Preferences - Issue 989 <https://bugs.chromium.org/p/gerrit/issues/detail?id=989>: New option to control email notifications. Users can now choose between ‘Enabled’, ‘Disabled’ and ‘CC Me on Comments I Write’. - New option to control adding ‘Signed-off-by’ footer in commit message of new changes created online. - New option to control auto-indent width in inline editor. - Issue 890 <https://bugs.chromium.org/p/gerrit/issues/detail?id=890>: New diff option to control whether to skip unchanged files when navigating to the previous or the next file. <https://www.gerritcodereview.com/releases/2.13.md#New-Features-Changes> Full changelog: https://www.gerritcodereview.com/releases/2.13.md -- Eyal edri ASSOCIATE MANAGER RHV DevOps EMEA VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

2 1

moVirt 2.0 released!
by Filip Krepinsky 30 Jun '17

30 Jun '17

Hello everyone, moVirt 2.0 has just been released and should arrive to your devices soon! You can also get the apk from our GitHub [1]. The main feature of this release is managing multiple oVirt installations + many other cool features [2]. Thanks everybody who helped with testing and especially big thanks to Shira who gave us lots of valuable input. Have a nice day Filip [1]: https://github.com/oVirt/moVirt/releases/tag/v2.0 [2]: https://github.com/oVirt/moVirt/wiki/Changelog

1 0

Help understanding the conflict with libvirt-guests.service - gerrit patch 78693
by Petr Kotas 30 Jun '17

30 Jun '17

Hi, I am kindly asking for help with understanding the origin of conflict within the *libvirt-guests*.service and *vdsmd.service*. Explanation: I am working on a graceful VM shutdown as described by the feature in a Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1334982. One way (the simplest one as described in the Bugzilla) of achieving the required functionality is to utilize *"libvirt-guests.service"*, which does exactly what is required. The second option is to write a new service that does the shutdown and utilizes the *vdsm.* Since I am new, I do not know what is the best solution. Staying with the fist one I have discovered an old conflict between *"vdsmd.service" *and *"libvirt-guests.service"* explained in bug https://bugzilla.redhat.com/show_bug.cgi?id=720359. <https://bugzilla.redhat.com/show_bug.cgi?id=720359> I have tried to reproduce described scenario and found that it is no longer an issue. Therefore I have created a *proposal draft* patch to start a discussion, whether it is really needed or not. Further, the research in git history showed this conflict precedes the git history, effectively blocking me in understanding details. Does somebody know about this issue? I am grateful for any information that can point me in the right direction. Thank you in advance for any help. Kind regards, Petr Kotas

2 1

[ OST Failure Report ] [ oVirt master ] [ 18/06/17 ] [ 004_basic_sanity.hotunplug_disk ]
by Gil Shinar 30 Jun '17

30 Jun '17

Test failed: [ 004_basic_sanity.hotunplug_disk ] Link to suspected patches: https://gerrit.ovirt.org/#/c/78224/ Link to Job: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/7245/ Link to all logs: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/7245/artif… Error snippet from the log: 2017-06-18 06:09:13,048-04 WARN [org.ovirt.engine.core.bll.storage.disk.HotUnPlugDiskFromVmCommand] (default task-6) [67f39908-fe27-4450-8748-c5b3f0c602f7] Validation of action 'HotUnPlugDiskFromVm' failed for user admin@internal-authz. Reasons: VAR__ACTION__HOT_UNPLUG,VAR__TYPE__DISK,ACTION_TYPE_FAILED_DISK_IS_BEING_MIGRATED,$DiskName vm0_disk0 2017-06-18 06:09:13,055-04 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-6) [] Operation Failed: [Cannot hot unplug Virtual Disk. Disk vm0_disk0 is being moved or copied.]

3 2

ovirt-system-test failing on master
by Sandro Bonazzola 30 Jun '17

30 Jun '17

Hi, just an heads up ovirt-system-test is failing[1] on master for: [ ERROR ] Failed to execute stage 'Environment customization': [u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-keystone-model >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-client >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-glance-model >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-glance-client >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-resteasy-connector >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-cinder-client >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-quantum-model >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-keystone-client >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-quantum-client >= 3.1.2', u'ovirt-engine-4.2.0-0.0.master.20170630084548.gitbbd011e.el7.centos.noarch requires openstack-java-cinder-model >= 3.1.2'] after I merged https://gerrit.ovirt.org/#/c/78761/ Issue is that ovirt-system-test is using CentOS Virt SIG 4.0 repo instead of 4.2 repo as lookaside repo. Fixing patch is https://gerrit.ovirt.org/78248 ; I'm trying to get it merged since June 16th with no luck on Jenkins validation. If https://gerrit.ovirt.org/78248 won't be merged today please don't revert https://gerrit.ovirt.org/#/c/78761 but fix the root cause of eventual failures or we'll continue testing stuff having a test successful but wrong stuff tested. Thanks, [1] http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/1000/testRepo… -- SANDRO BONAZZOLA ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>

2 1

patch granularity, extracting patches
by Greg Sheremeta 30 Jun '17

30 Jun '17

Do we have or follow a standard on patch granularity? When I started, I picked up on the culture that we do small, logical commits -- as much as possible, each commit should be focused on a specific purpose. I've perceived some reviewers prefer to have all orthogonal changes (fix a random spelling error, remove a duplicate semicolon) extracted to other patches for clarity. Others don't seem to mind. I feel like I always want to ask, but I feel bad because it's a hassle. Also, when you are asked to extract something, do you have a trick to make it as easy as possible? Best wishes, Greg -- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme(a)redhat.com

4 3