- Devel - oVirt List Archives

gerrit+ci improvement proposal
by Max Kovgan 07 Jun '15

07 Jun '15

Hi everyone! We really want to have reliable and snappy CI: to allow short cycles and encourage developers to write tests. # Problem Many patches are neither ready for review nor for CI upon submission, which is OK. But running all the jobs on those patches with limited resources results in: overloaded resources, slow response time, unhappy developers. # Proposed Solution To run less jobs we know we don’t need to, thus making more resources for the jobs we need to run. We have been experimenting to make our CI stabler and quicker to respond by using gerrit flags. This has improved in both directions very well internally. Now it seems a good time to let all the oVirt projects to use this. This solution indirectly promotes reviews and quick tests - “to fail early”, yet full blown static code analysis and long tests to run “when ready”. # How it works 2 new gerrit independent flags are added to gerrit. ## CI flag Will express patch CI status. Values: * +1 CI passed * 0 CI did not run yet * -1 CI failed Permissions for setting: project maintainers (for special cases) should be able to set/override (except Jenkins). ## Workflow flag Will express patch “workflow” state. Values: * 0 Work In Progress * +1 Ready For Review * +2 Ready For Merge Permissions for setting: Owner can set +1, Project Maintainers can set +2 ## Review + CI Integration: Merging [“Submit” button to appear] will require: Review+1, CI+1, Workflow+2 Patch lifecycle now is: --------------------------------------------------------------- patch state |owner |reviewer |maintainer |CI tests |pass --------------------------------------------------------------- added/updated |- |- |- |quick |CI+1 review |Workflow+1|Review+1 |- |heavy |CI+1 merge ready |- |- |Workflow+2 |gating |CI+1 merge |- |- |merge |merge |CI+1 Changes from current workflow: Owner only adds reviewers, now owner needs to set "Workflow+1" for the patch to be reviewed, and heavily auto-tested. Maintainer now needs to set "Workflow+2" and wait for "Submit" button to appear after CI has completed running gating tests. Next step will be to automate merge the change after Workflow+2 has been set by the Maintainer and gating tests passed. ## Why now? It is elimination of waste. The sooner - the better. The solution has been used for a while and it works. Resolving the problem without gerrit involved will lead to adding unreliable code into jobs, and will still be prone to problems: Just recently, 3d ago we’ve tried detecting what to run from jenkins relying only on gerrit comments so that upon Verified+1, we’d run the job. We could not use “Review+1”, because it makes no sense at all, so we left the job to set Verified+1. Meaning - re-trigger itself immediately more than 1 times. Jenkins and its visitors very unhappy, and we had to stop those jobs, clean up the queue, and spam developers. ## OK OK OK. Now what? Now we want your comments and opinions before pushing this further: Please participate in this thread, so we can start trying it out. Ask, Suggest better ideas, all this is welcome. Best Regards! N.B. Of course, this is not written in stone, in case we find a better approach on solving those issues, we will change to it. And we will keep improving so don't be afraid that it will be enforced: if this does not work out we will discard it. P.S. Kudos to dcaro, most of the work was done by him, and most of this text too. Max Kovgan Senior Software Engineer Red Hat - EMEA ENG Virtualization R&D Tel.: +972 9769 2060 Email: mkovgan [at] redhat [dot] com Web: http://www.redhat.com RHT Global #: 82-72060

9 23

Re: [ovirt-devel] [oVirt Jenkins] ovirt-engine_3.5_create-rpms_merged » fc20 - Build # 1151 - Failure!
by Eyal Edri 07 Jun '15

07 Jun '15

this unit test failed: testConcreateCreateTaskBackwardsComaptibility(org.ovirt.engine.core.bll.BackwardCompatibilityTaskCreationTest): testConcreateCreateTaskBackwardsComaptibility and i'm pretty sure its not the first time. can we disable this test until it is fixed? its causing too much noise in CI. Eyal. ----- Original Message ----- > From: "Yedidyah Bar David" <didi(a)redhat.com> > To: "infra" <infra(a)ovirt.org> > Sent: Sunday, June 7, 2015 8:32:04 AM > Subject: Re: [oVirt Jenkins] ovirt-engine_3.5_create-rpms_merged » fc20 - Build # 1151 - Failure! > > ----- Original Message ----- > > From: jenkins(a)ovirt.org > > To: didi(a)redhat.com, eedri(a)redhat.com, dcaroest(a)redhat.com > > Sent: Sunday, June 7, 2015 8:24:03 AM > > Subject: [oVirt Jenkins] ovirt-engine_3.5_create-rpms_merged » fc20 - Build > > # 1151 - Failure! > > > > Project: > > http://jenkins.ovirt.org/job/ovirt-engine_3.5_create-rpms_merged/label=fc20/ > > Build: > > http://jenkins.ovirt.org/job/ovirt-engine_3.5_create-rpms_merged/label=fc20… > > Build Number: 1151 > > Build Status: Failure > > Triggered By: Started by upstream project > > "ovirt-engine_3.5_create-rpms_merged" build number 1,151 > > 1150 succeeded, after 1149 failed, all 3 of them on same patch (below). > > Didn't look at actual logs. Please check... > > > > > ------------------------------------- > > Changes Since Last Success: > > ------------------------------------- > > Changes for Build #1151 > > [Yedidyah Bar David] packaging: setup: Disable pki renewal for 3.5 > > > > > > > > > > ----------------- > > Failed Tests: > > ----------------- > > No tests ran. > > > > > > -- > Didi > > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > > >

1 0

Frontend refresh flag in VdcQueryParameterBase
by Alexander Wels 05 Jun '15

05 Jun '15

Hi, For anyone working with the Frontend, please note the following gotcha you need to be aware of. Whenever you create a query parameter, please think about whether or not your query should refresh the user session. Guidelines for when to refresh. Any query that is a result of a user action, like clicking a button to open a pop-up, switch main/sub tabs. A refresh button on a dialog. When not to refresh. Any queries that are generated automatically, like the automatic refresh of grids or display forms. Also queries created in response to some data coming from the back-end. For instance the user clicked and opened a sub tab, the initial query generates the refresh query, but there are some subsequent queries that need to get extra information. Those do NOT need to have the refresh set to true. By DEFAULT the flag is set to true for historical reasons. So any new queries you create will also have the flag set to true. We have implemented a convenient method in VdcQueryParameterBase to allow you to switch the flag off. Often you will do something like 'new VdcQueryParameter(something)' inside a runQuery call. You can do 'new VdcQueryParameter(something).withoutRefresh()' to turn the refresh off, without having to make a temporary variable. If you don't follow the guidelines it is possible (and has happened, which prompted this email) that while a user is inactive your query is keeping the session alive and will cause the automatic log-out to not happen. This is usually not what we want. Thanks, Alexander

1 0

VDSM 3.5 branch is failing to build on Fedora 20
by Sandro Bonazzola 05 Jun '15

05 Jun '15

VDSM 3.5 branch is failing to build on Fedora 20 due to: detected by http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged pyflakes-0.7.3 find . -path './.git' -prune -type f -o \ -name '*.py' -o -name '*.py.in' | xargs /usr/bin/pyflakes | \ grep -w -v "\./vdsm/storage/lvm\.py.*: list comprehension redefines 'lv' from line .*" | \ while read LINE; do echo "$LINE"; false; done ./tests/functional/networkTests.py:80: redefinition of unused 'vdsm' from line 43 ./tests/functional/networkTests.py:88: redefinition of unused 'vdsm' from line 43 Please fix it. -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

2 1

[ANN] oVirt 3.5.3 Third Release Candidate is now available for testing
by Sandro Bonazzola 05 Jun '15

05 Jun '15

The oVirt team is pleased to announce that the 3.5.3 Third Release Candidate is now available for testing as of June 5th 2015. The release candidate is available now for Fedora 20, Red Hat Enterprise Linux 6.6, CentOS 6.6 (or similar) and Red Hat Enterprise Linux 7.1, CentOS 7.1 (or similar). This release of oVirt includes numerous bug fixes and one CVE fix for the VENOM Vulnerability. See the release notes [1] for a list of the new features and bugs fixed. Please refer to release notes [1] for Installation / Upgrade instructions. A new oVirt Live ISO is already available as well[2]. Please note that mirrors[3] may need usually one day before being synchronized. Please refer to the release notes for known issues in this release. [1] http://www.ovirt.org/OVirt_3.5.3_Release_Notes [2] http://resources.ovirt.org/pub/ovirt-3.5-pre/iso/ [3] http://www.ovirt.org/Repository_mirrors#Current_mirrors -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

Which bond mode do we support in ovirt 3.5?
by yangfeng 05 Jun '15

05 Jun '15

Hi I want to confirm which bond mode do we support in ovirt 3.5? We cannot get 3.5 doc. But from the following 3.4 doc, we get that "Modes 1, 2, 3 and 4 support both virtual machine (bridged) and non-virtual machine (bridgeless) network types. Modes 0, 5 and 6 support non-virtual machine (bridgeless) networks only. " https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Virtualiza… But from ovirt 3.5 engine web page, we can set bond mode 1, 2, 4, 5 and custom mode. So we want to know which bond mode do we support in ovirt 3.5? Thanks Feng Yang

1 0

API for executing commands on node?
by Christopher Pereira 04 Jun '15

04 Jun '15

Hi, What is the best practice to run custom console commands on a given oVirt host? Do we have some API for this? I need to pass arguments to this remote commands/scripts.

3 4

Re: [ovirt-devel] Fedora 22
by Shubhendu Tripathi 04 Jun '15

04 Jun '15

----_com.android.email_477458184382010 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SSBoYWQgdG8gZG8gdGhpcyBhdCBsZWFzdCBmb3IgZmVkb3JhIDIxLgpXb3JzdCBwYXJ0IGlzIEZp cmVmb3ggYXMgd2UgY2Fubm90IHVzZSBhbnl0aGluZyBncmVhdGVyIHRoYW4gMjUgZm9yIGd3dCBk ZWJ1Z2dpbmcuCgoKU2VudCBmcm9tIFNhbXN1bmcgTW9iaWxlCgotLS0tLS0tLSBPcmlnaW5hbCBt ZXNzYWdlIC0tLS0tLS0tCkZyb206IEdyZWcgU2hlcmVtZXRhIDxnc2hlcmVtZUByZWRoYXQuY29t PiAKRGF0ZTowMS8wNi8yMDE1ICAyMDoxNSAgKEdNVCswNTozMCkgClRvOiBkZXZlbEBvdmlydC5v cmcgClN1YmplY3Q6IFtvdmlydC1kZXZlbF0gRmVkb3JhIDIyIAoKQW55b25lIHVwZ3JhZGUgdG8g RjIyIHlldD8gTG9va2luZyBmb3IgdGlwcyBvbiBydW5uaW5nIGVuZ2luZQphZnRlciBJIHVwZ3Jh ZGUuIEkgYXNzdW1lIEknbGwgc3RpbGwgaGF2ZSB0byBpbnN0YWxsIEpESyAxLjcKYW5kIEpCb3Nz IDcuCgpUaGFua3MuCgpHcmVnIFNoZXJlbWV0YQpSZWQgSGF0LCBJbmMuClNyLiBTb2Z0d2FyZSBF bmdpbmVlciwgUkhFVgpDZWxsOiA5MTktODA3LTEwODYKZ3NoZXJlbWVAcmVkaGF0LmNvbQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRGV2ZWwgbWFpbGlu ZyBsaXN0CkRldmVsQG92aXJ0Lm9yZwpodHRwOi8vbGlzdHMub3ZpcnQub3JnL21haWxtYW4vbGlz dGluZm8vZGV2ZWwK ----_com.android.email_477458184382010 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+PGhlYWQ+PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0 L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPjwvaGVhZD48Ym9keSA+PGRpdj5JIGhhZCB0byBkbyB0aGlz IGF0IGxlYXN0IGZvciBmZWRvcmEgMjEuPC9kaXY+PGRpdj5Xb3JzdCBwYXJ0IGlzIEZpcmVmb3gg YXMgd2UgY2Fubm90IHVzZSBhbnl0aGluZyBncmVhdGVyIHRoYW4gMjUgZm9yIGd3dCBkZWJ1Z2dp bmcuPC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj48ZGl2IHN0eWxlPSJm b250LXNpemU6NzUlO2NvbG9yOiM1NzU3NTciPlNlbnQgZnJvbSBTYW1zdW5nIE1vYmlsZTwvZGl2 PjwvZGl2Pjxicj48YnI+LS0tLS0tLS0gT3JpZ2luYWwgbWVzc2FnZSAtLS0tLS0tLTxicj5Gcm9t OiBHcmVnIFNoZXJlbWV0YSA8Z3NoZXJlbWVAcmVkaGF0LmNvbT4gPGJyPkRhdGU6MDEvMDYvMjAx NSAgMjA6MTUgIChHTVQrMDU6MzApIDxicj5UbzogZGV2ZWxAb3ZpcnQub3JnIDxicj5TdWJqZWN0 OiBbb3ZpcnQtZGV2ZWxdIEZlZG9yYSAyMiA8YnI+PGJyPkFueW9uZSB1cGdyYWRlIHRvIEYyMiB5 ZXQ/IExvb2tpbmcgZm9yIHRpcHMgb24gcnVubmluZyBlbmdpbmU8YnI+YWZ0ZXIgSSB1cGdyYWRl LiBJIGFzc3VtZSBJJ2xsIHN0aWxsIGhhdmUgdG8gaW5zdGFsbCBKREsgMS43PGJyPmFuZCBKQm9z cyA3Ljxicj48YnI+VGhhbmtzLjxicj48YnI+R3JlZyBTaGVyZW1ldGE8YnI+UmVkIEhhdCwgSW5j Ljxicj5Tci4gU29mdHdhcmUgRW5naW5lZXIsIFJIRVY8YnI+Q2VsbDogOTE5LTgwNy0xMDg2PGJy PmdzaGVyZW1lQHJlZGhhdC5jb208YnI+PGJyPl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fPGJyPkRldmVsIG1haWxpbmcgbGlzdDxicj5EZXZlbEBvdmlydC5v cmc8YnI+aHR0cDovL2xpc3RzLm92aXJ0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RldmVsPGJyPjwv Ym9keT4= ----_com.android.email_477458184382010--

3 2

oVirt Engine in a container
by Fabian Deutsch 04 Jun '15

04 Jun '15

Hey, if you are using docker or atomic, then you might be interested that you can get a fully configured and running oVirt Engine (based on CentOS and oVirt 3.5) from the docker repositories. I'm not the first one who gave it a go, Moran [also] [did] this. My work is similar to his, I just tried to leverage some enhancements which popped up in the last 6 months - mainly the integration with the `atomic` command and a simpler integration with systemd. The image is based on this [Dockerfile] and [this atomic installation script] to perform the engine setup on deployment. With the `atomic` command the usage is quite easy: atomic install fabiand/ovirt-engine-3.5 # or ADMINPW=foo atomic install fabiand/ovirt-engine-3.5 With `docker` it's a few more lines: export IMAGE=docker.io/fabiand/ovirt-engine-3.5 export NAME=ovirt-engine-3.5 # Use a transient (--rm) container to create the real the container docker run --rm -v /:/host \ -e FQDN=$(hostname) \ -e ADMINPASSWORD=${ADMINPW:-ovirt} \ -e NAME=$NAME \ -e IMAGE=$IMAGE \ $IMAGE container/atomic-install.sh After this run you can access oVirt Engine on port 80 and 443 of that host. It would be great if someone could try this - also on a different distribution than Fedora or CentOS - i.e. on Ubuntu? Gentoo? - and provide some feedback. Greetings fabian -- [also](https://community.redhat.com/blog/2014/10/ovirt-dockerized/) [did](https://community.redhat.com/blog/2014/10/ovirt-dockerized-part-2/) [Dockerfile](https://gerrit.ovirt.org/gitweb?p=ovirt-container-engine.git;a=… [this atomic installation script](https://gerrit.ovirt.org/gitweb?p=ovirt-container-engine.git;a=blob…

1 0

Re: [ovirt-devel] Access to ovirt-srv08.ovirt.org
by Eyal Edri 04 Jun '15

04 Jun '15

----- Original Message ----- > From: "Tolik Litovsky" <tlitovsk(a)redhat.com> > To: eedri(a)redhat.com > Cc: infra(a)ovirt.org > Sent: Thursday, June 4, 2015 9:28:27 AM > Subject: RE: Access to ovirt-srv08.ovirt.org > > The question is the nesting depth. > We run currently in depth 2 . > VM inside VM. > > Will depth of 3 will work. > > VM slave, and another 2 VM nesting above it. > > KVM people? Plz help. adding devel, but please elaborate on the depth, does it have to be nested or you're doing it because you only had 1 bare metal host till now (think you'll have 2 nested vms for example) > > > Tolik. > > > > -------- Original message -------- > From: Eyal Edri <eedri(a)redhat.com> > Date: 03/06/2015 11:14 PM (GMT+02:00) > To: tlitovsk(a)redhat.com > Cc: infra(a)ovirt.org > Subject: Re: Access to ovirt-srv08.ovirt.org > > > I'd like to move the system testing framework to use > nested vms instead of directly using the baremetal hosts. > > we did use a single host to POC the system, i think now that we're > about to expand it will be much more managble and scalable if we'll > start using nested VMs which will be managed via the hosted engine. > > e. > > ----- Original Message ----- > > From: "Tolik Litvosky" <tlitovsk(a)redhat.com> > > To: infra(a)ovirt.org > > Sent: Wednesday, June 3, 2015 3:59:36 PM > > Subject: Access to ovirt-srv08.ovirt.org > > > > Hi > > > > I need access to the ovirt-srv08.ovirt.org in order to update the > > testenv CI repo directory. > > > > -- > > Best regards > > Tolik Litovsky > > RHEV-H Team > > Red Hat > > > > Red Hat: trustworthy, transformative technology. Powered by the > > community. > > Connect at redhat.com > > > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > >

3 8