- Devel - oVirt List Archives

[VDSM] pthreaing patches for review
by Nir Soffer 22 Apr '14

22 Apr '14

Hi all, Please review these patches for the pthreading package: import-check branch: - monkey_patch: Fail if it is too late to monkey-patch https://github.com/nirs/pthreading/commit/490e837e0afed37823803d9e180a5d3eb… Note: this patch is waiting for review since Mar 8 without any response on the list. event branch: - Fix return value of Condition.wait() https://github.com/nirs/pthreading/commit/2efade6ae9e9ad836cb9aa46bd203a976… - Fix handling of spurious wakeups during wait https://github.com/nirs/pthreading/commit/54b62c44526b4b3caf0f188738a66de6b… - Update README.md about reimplemented objects https://github.com/nirs/pthreading/commit/254e4c4b36075814d39f5f93671554c3a… - Improve README.md formatting https://github.com/nirs/pthreading/commit/6befacf0cc24932c1750291d4a030e0db… Thanks Nir

2 1

Re: [ovirt-devel] [Engine-devel] ui plugin problems, cannot read from a file.
by Vojtech Szocs 18 Apr '14

18 Apr '14

Hi guys, > hey, am trying to display the contents of a text file in a java > applet as a ui plugin in ovirt. > The same applet performs successfully when run as a standalone, but > fails to deliver when the it is run through ovirt. UI plugins are written in JavaScript and HTML. UI plugin is technically standalone web application sandboxed within invisible <iframe> element under WebAdmin's DOM. UI plugin uses API to extend existing WebAdmin functionality through custom UI components (main tab, dialog, etc). Java applet technology cannot be used to implement UI plugin because plugin vs. WebAdmin integration happens on JavaScript/HTML level. I suggest to check out samples-uiplugins git repo for examples: http://www.ovirt.org/Features/UIPlugins#Sample_UI_plugins If you really want to write UI plugin in Java language, you can use GWT (as suggested by Greg) which yields JavaScript/HTML output. In general, any technology/language that ultimately yields JavaScript code can be used to implement UI plugin. > isn't one of the points of a uiplugin it doesn't have to be GWT based > (as its not going to be part of the codebase)? In fact, UI plugins can be written in GWT, if desired. However, as you mentioned, plugins are decoupled from WebAdmin code base through the plugin infra/subsystem. Regards, Vojtech ----- Original Message ----- > From: "Greg Sheremeta" <gshereme(a)redhat.com> > To: "Itamar Heim" <iheim(a)redhat.com> > Cc: engine-devel(a)ovirt.org, "aditya mamidwar" <aditya.mamidwar(a)gmail.com>, users(a)ovirt.org > Sent: Monday, March 31, 2014 2:44:40 PM > Subject: Re: [Engine-devel] ui plugin problems, cannot read from a file. > > > > ----- Original Message ----- > > From: "Itamar Heim" <iheim(a)redhat.com> > > To: "Greg Sheremeta" <gshereme(a)redhat.com>, "aditya mamidwar" > > <aditya.mamidwar(a)gmail.com> > > Cc: engine-devel(a)ovirt.org, users(a)ovirt.org > > Sent: Monday, March 31, 2014 12:58:33 AM > > Subject: Re: [Engine-devel] ui plugin problems, cannot read from a file. > > > > On 03/30/2014 06:33 PM, Greg Sheremeta wrote: > > > I don't have any ideas. But: > > > > > > You really should use GWT to do this instead of an applet. I can't speak > > > for everyone, and I'm not a maintainer, but I would not accept an applet > > > into the ovirt-engine source code. It adds a very unnecessary dependency > > > for the user (to have Java installed in the browser). > > > > > > > isn't one of the points of a uiplugin it doesn't have to be GWT based > > (as its not going to be part of the codebase)? > > > Ah, yes, of course :) > So please disregard my comment. > /me and his bruised ego steps away from engine-devel > > Greg > > > > Greg > > > > > > > > > ------------------------------------------------------------------------ > > > > > > *From: *"aditya mamidwar" <aditya.mamidwar(a)gmail.com> > > > *To: *users(a)ovirt.org, engine-devel(a)ovirt.org, awels(a)redhat.com, > > > "Einav Cohen" <ecohen(a)redhat.com>, "Greg Sheremeta" > > > <gshereme(a)redhat.com> > > > *Sent: *Sunday, March 30, 2014 8:14:41 AM > > > *Subject: *ui plugin problems, cannot read from a file. > > > > > > > > > > > > hey, am trying to display the contents of a text file in a java > > > applet as a ui plugin in ovirt. > > > > > > The same applet performs successfully when run as a standalone, but > > > fails to deliver when the it is run through ovirt. > > > > > > any plausible explanation? > > > PFA the screenshot of both cases > > > > > > -- > > > -Aditya Mamidwar > > > > > > > > > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel(a)ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >

1 0

UI plugins: AngularJS Demo Plugin
by Vojtech Szocs 17 Apr '14

17 Apr '14

Hi guys, for those of you interested in AngularJS, there's now a sample oVirt UI plugin available from samples-uiplugins repo: http://www.ovirt.org/Features/UIPlugins#AngularJS_Demo_Plugin (It's very similar to one presented in our recent "Writing UI plugin with AngularJS" presentation.) When writing UI plugins beyond simple "hello world", it's important to keep the code well-structured and maintainable; utilizing proven patterns like Model-View-Controller, Dependency Injection, etc. seems to be a good way to go. Of course, some JavaScript ninjas might do things in a different way. :) Regards, Vojtech

1 0

Re: [ovirt-devel] problem debugging gwt
by Gilad Chaplik 17 Apr '14

17 Apr '14

----- Original Message ----- > From: "Vojtech Szocs" <vszocs(a)redhat.com> > To: "Tomas Jelinek" <tjelinek(a)redhat.com> > Cc: "Gilad Chaplik" <gchaplik(a)redhat.com>, "Alexander Wels" <awels(a)redhat.com>, "Einav Cohen" <ecohen(a)redhat.com> > Sent: Thursday, April 17, 2014 4:20:57 PM > Subject: Re: problem debugging gwt > > Hi Gilad, > > I've seen this error many times before. Try this: > > $ hostname > vszocs.laptop > > $ cat /etc/hosts > 127.0.0.1 localhost localhost.localdomain localhost4 > localhost4.localdomain4 vszocs.laptop > ::1 localhost localhost.localdomain localhost6 > localhost6.localdomain6 vszocs.laptop > > Notice I've added 'vszocs.laptop' in /etc/hosts. For some reason, GWT > debugger attempts to resolve the hostname. > > The reason we have bindAddress=0.0.0.0 as default value is to support > debugging browsers running outside the local machine (i.e. VM running IE). > > BTW, in future (GWT 2.6 hopefully) we will put focus on abandoning 'classic' > dev mode, and move towards 'super' dev mode. > > Vojtech Vojtech, you rock! cc'ing devel-list. I'm 100% sure someone will google it :-) Thanks, Gilad. > > > ----- Original Message ----- > > From: "Tomas Jelinek" <tjelinek(a)redhat.com> > > To: "Gilad Chaplik" <gchaplik(a)redhat.com> > > Cc: "Vojtech Szocs" <vszocs(a)redhat.com>, "Alexander Wels" > > <awels(a)redhat.com> > > Sent: Thursday, April 17, 2014 1:06:37 PM > > Subject: Re: problem debugging gwt > > > > > > > > ----- Original Message ----- > > > From: "Gilad Chaplik" <gchaplik(a)redhat.com> > > > To: "Tomas Jelinek" <tjelinek(a)redhat.com> > > > Cc: "Vojtech Szocs" <vszocs(a)redhat.com>, "Alexander Wels" > > > <awels(a)redhat.com> > > > Sent: Thursday, April 17, 2014 12:50:59 PM > > > Subject: Re: problem debugging gwt > > > > > > ----- Original Message ----- > > > > From: "Tomas Jelinek" <tjelinek(a)redhat.com> > > > > To: "Gilad Chaplik" <gchaplik(a)redhat.com> > > > > Cc: "Vojtech Szocs" <vszocs(a)redhat.com>, "Alexander Wels" > > > > <awels(a)redhat.com> > > > > Sent: Thursday, April 17, 2014 1:14:48 PM > > > > Subject: Re: problem debugging gwt > > > > > > > > not sure if you need to enable the 0.0.0.0 - unless you are connecting > > > > from > > > > outside... > > > > > > > > How do you run the debug mode? > > > > > > > > I use only the > > > > make gwt-debug DEBUG_MODULE=webadmin > > > > (in "new" devel environment) > > > > > > > > and than I reference the codeserver by 127.0.0.1 like this: > > > > ...?gwt.codesvr=127.0.0.1:9997 > > > > > > > > If you need to connect from outside than something like this: > > > > make gwt-debug DEBUG_MODULE=webadmin > > > > DEV_EXTRA_BUILD_FLAGS="-Dgwt.bindAddress=0.0.0.0" > > > > > > Thanks Tomas, > > > > > > tried everything with no luck :( > > > other ideas maybe? > > > > just some random: > > - maybe firewall blocks you > > - maybe an issue of GWT version + browser you are using - maybe try a > > different browser/version (I'm using FF23 still and I'm pretty scared to > > update it :) ) > > - if using chrome you need to explicitly enable the site you are visiting > > (click the little GWT icon at the end of the browser's address bar and add > > it) > > > > > > > > > > > > > Tomas > > > > > > > > ----- Original Message ----- > > > > > From: "Gilad Chaplik" <gchaplik(a)redhat.com> > > > > > To: "Vojtech Szocs" <vszocs(a)redhat.com>, "Tomas Jelinek" > > > > > <tjelinek(a)redhat.com>, "Alexander Wels" <awels(a)redhat.com> > > > > > Sent: Thursday, April 17, 2014 11:16:43 AM > > > > > Subject: problem debugging gwt > > > > > > > > > > hi guys, > > > > > > > > > > I'm installing my new T440s, and stumble across nagging issue: > > > > > getting the following error when I connecting from ide to the remote > > > > > app: > > > > > > > > > > [ERROR] [AppClassLoader@4b6e3f87] info register aspect > > > > > org.ovirt.engine.ui.gwtextension.DontPrune > > > > > [ERROR] -bindAddress host "0.0.0.0" unknown > > > > > [ERROR] Google Web Toolkit 2.5.1 > > > > > > > > > > tried to add 0.0.0.0 to /etc/hosts (read about it somewhere) with no > > > > > help, > > > > > any ideas? > > > > > > > > > > Thanks, > > > > > Gilad. > > > > > > > > > > > > > > >

1 0

Please help us to review our restful API design with NUMA feature on ovirt
by Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC) 17 Apr '14

17 Apr '14

--_000_B63C858E777679458338A30A991BB52401612D47G1W3647americas_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Juan, Please help us to review our restful API design with NUMA feature on ovirt http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interface_and_= data_structure_in_restful_API We are appreciate that you or some community members could give us some fee= dback and comments, and sorry for the nag. Best Regards, Jason Liao --_000_B63C858E777679458338A30A991BB52401612D47G1W3647americas_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang=3D"ZH-CN" link=3D"#0563C1" vlink=3D"#954F72" style=3D"text-justi= fy-trim:punctuation"> <div class=3D"WordSection1"> Hi Juan,<o:= p></o:p> <o:p> </o:p> Please help us to review our restfu= l API design with NUMA feature on ovirt<o:p></o:p> <a href=3D"http://www.ovirt.org/Fea= tures/Detailed_NUMA_and_Virtual_NUMA#Interface_and_data_structure_in_restfu= l_API">http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interfa= ce_and_data_structure_in_restful_API</a><o:p></o:p> <o:p> </o:p> We are appreciate that you or some = community members could give us some feedback and comments, and sorry for t= he nag.<o:p></o:p> <o:p> </o:p> Best= Regards, Jason Liao= <o:p></o:p> <o:p> </o:p> </div> </body> </html> --_000_B63C858E777679458338A30A991BB52401612D47G1W3647americas_--

3 4

Question about plan/work for javascript SDK
by Yair Zaslavsky 15 Apr '14

15 Apr '14

Hi, Unfortunately I could not attend the tech talk Vojtech presented this week (I did attend the 2nd one about UI-Plugins and Anjular JS). I was wondering if 3rd party developers will be able to use the ovirt.js library/framework for developing JS-based tools around oVirt (let's say - using the MEAN stack). Not sure how much we gave thought to this, so I'm asking here Thanks for any insights on this, Yair

4 3

Re: [Devel] cleaning statistics retrieval
by Dan Kenigsberg 14 Apr '14

14 Apr '14

On Tue, Apr 08, 2014 at 06:52:50AM -0400, Francesco Romani wrote: > Hello VDSM developers, Please use devel@ovirt, and mention "vdsm" at the subject. This thread in particular involves Engine as well. > > I'd like to discuss and explain the plans for cleaning up Vm.getStats() > in vdsm/virt/vm.py, and how it affects a bug we have: https://bugzilla.redhat.com/show_bug.cgi?id=1073478 > > Let's start from the bug. > > To make a long story short, there is a (small) race in VDSM, probably introduced by commit > 8fedf8bde3c28edb07add23c3e9b72681cb48e49 > The race can actually be triggered only if the VM is shutting down, so it is not that bad. > > Fixing the reported issue in the specific case can be done with a trivial if, and that it what I did > in my initial http://gerrit.ovirt.org/#/c/25803/1/vdsm/vm.py,cm Could you explain how an AttributeError there moved the VM to Down? > > However, this is just a bandaid and a proper solution is needed. This is the reason why > the following versions of http://gerrit.ovirt.org/#/c/25803 changed direction toward a more comprehensive > approach. > > And this is the core of the issue. > My initial idea is to either return success and a complete, well formed statistics set, or return an error. > However current engine seems to not cope properly with this, and we cannot break backward compatibility. Would you be more precise? If getAllVmStats returns an errCode for one of the Vms, what happens? > > Looks like the only way to go is to always return success and to add a field to describe the content of the > statistics (partial, complete...). THis is admittedly a far cry from the ideal solution, but it is dictated > by the need to preserve the compatibility with current/old engines. I don't think that I understand your suggestion, but it does not sound right to send a partial dictionary and to "appologize" about its paritiality elsewhere. The dictionary may be "partial" for engine-4.0 yet "complete" for engine-3.5. It's not for Vdsm to grade its own output. > > Moreover, I would like to take the chance and cleanup/refactor the statistics collection. I already started > adding the test infrastructure: http://gerrit.ovirt.org/#/c/26536/ > > To summarize, what I suggest to do is: > > * fix https://bugzilla.redhat.com/show_bug.cgi?id=1073478 using a simple ugly fix like the original > http://gerrit.ovirt.org/#/c/25803/1/vdsm/vm.py,cm (which I'll resubmit as new change) > * refactor and clean getStats() and friends > * on the cleaner base, properly fix the statistics collection by let getStats() always succeed and return > possibly partial stats, with a new field describing the content > > please note that I'm not really happy about this solution, but, given the constraint, I don't see better > alternatives. Please explain the benefits of describing the partial content, as I do not see them.

4 9

[Devel] Planned Gerrit maintenance
by Itamar Heim 13 Apr '14

13 Apr '14

planning to reboot gerrit tomorrow morning (GMT-ish) for some system updates

1 5

Clarify NUMA feature and CPU pinning
by Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC) 13 Apr '14

13 Apr '14

--_000_B63C858E777679458338A30A991BB52401613084G1W3647americas_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gilad & Einav Thanks for sharing your ideas about NUMA feature and CPU pinning. It makes = easier for users to understand. And something I want to clarify: 1. NUMA tuning feature and CPU pinning feature are individually in lib= virt ( ovirt backend ). 2. User could configure VM CPU pining ( NUMA not included ) separately= . 3. When configuring NUMA feature, user should configure VM NUMA tuning= ( pin to host NUMA node & tuning mode ) and VM CPU pinning ( NUMA included= ), otherwise VM will have low performance. 4. Single virtual NUMA node could pin to multiply host NUMA nodes. 5. Multiply virtual NUMA nodes could pin to single host NUMA node. 6. NUMA tuning mode have default value 'strict', and could change to '= prefer', 'interleave' Our proposal: OVirt 3.5 1. Keep current UX design, add NUMA tuning mode select box in VM dialo= g. 2. Keep current BE model, query and action command. 3. Consider the low performance scene ( user did not configure VM CPU = pinning ) When VdsBroker check the CPU pinning text is empty, then generate the right= CPU pinning text from virtual NUMA nodes ( pin to host NUMA nodes ) The next version 1. Remove current CPU pinning text feature. 2. Consider the NUMA node inside CPU pinning design. ( Should consider= the individually CPU pining design not includes NUMA ) 3. Add related CPU pinning BE model, query and action command. 4. Turn off VdsBroker generate function. Do you agree ? Best Regards, Jason Liao --_000_B63C858E777679458338A30A991BB52401613084G1W3647americas_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang=3D"ZH-CN" link=3D"#0563C1" vlink=3D"#954F72" style=3D"text-justi= fy-trim:punctuation"> <div class=3D"WordSection1"> Hi Gilad & Einav<o:p></o:p></sp= an> <o:p> </o:p> Thanks for sharing your ideas about= NUMA feature and CPU pinning. It makes e</span= >asier for users to understand.<o:p></o:p> <o:p> </o:p> And something I want to clarify:<o:= p></o:p> <![if !supportLists]>1.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>NUMA tuning feature and CPU= pinning feature are individually in libvirt ( ovirt backend ).<o:p></o:p><= /span> <![if !supportLists]>2.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>User could configure VM CPU= pining ( NUMA not included ) separately.<o:p></o:p> <![if !supportLists]>3.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>When configuring NUMA featu= re, user should configure VM NUMA tuning ( pin to host NUMA node & tuni= ng mode ) and VM CPU pinning ( NUMA included ), otherwise VM will have low performance.<o:p></o:p> <![if !supportLists]>4.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Single virtual NUMA node co= uld pin to multiply host NUMA nodes.<o:p></o:p> <![if !supportLists]>5.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Multiply virtual NUMA nodes= could pin to single host NUMA node.<o:p></o:p> <![if !supportLists]>6.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>NUMA tuning mode have defau= lt value ‘strict’, and could change to ‘prefer’, &#= 8216;interleave’<o:p></o:p> <o:p> </o:p> Our proposal:<o:p></o:p> OVirt 3.5<o:p></o:p> <![if !supportLists]>1.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Keep current UX design, add= NUMA tuning mode select box in VM dialog.<o:p></o:p> <![if !supportLists]>2.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Keep current BE model, quer= y and action command.<o:p></o:p> <![if !supportLists]>3.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Consider the low performanc= e scene ( user did not configure VM CPU pinning )<o:p></o:p> = When VdsBroker check the CPU pinning text is empty, then g= enerate the right CPU pinning text from virtual NUMA nodes ( pin to host NUMA nodes )<o:p></o:p> <o:p> </o:p> The next version<o:p></o:p><= /p> <![if !supportLists]>1.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Remove current CPU pinning = text feature.<o:p></o:p> <![if !supportLists]>2.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Consider the NUMA node insi= de CPU pinning design. ( Should consider the individually CPU pining design= not includes NUMA )<o:p></o:p> <![if !supportLists]>3.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Add related CPU pinning BE = model, query and action command.<o:p></o:p> <![if !supportLists]>4.<sp= an style=3D"font:7.0pt "Times New Roman"">   &nbsp= ;  <![endif]>Turn off VdsBroker generate= function.<o:p></o:p> <o:p> </o:p> Do you agree ?<o:p></o:p></p= > <o:p> </o:p> Best= Regards, Jason Liao= <o:p></o:p> <o:p> </o:p> </div> </body> </html> --_000_B63C858E777679458338A30A991BB52401613084G1W3647americas_--

2 1

Request to add Target Release for 3.6.0.
by Yaniv Dary 11 Apr '14

11 Apr '14

Hi, I'm in the process of evaluating RFEs for 3.5.0. I want to be able to push RFEs to next release, can anyone please create a 3.6.0 target release? Thanks! --- Yaniv Dary BI Software Engineer Red Hat Israel Ltd. 34 Jerusalem Road Building A, 4th floor Ra'anana, Israel 4350109 Tel : +972 (9) 7692306 72306 Email: ydary(a)redhat.com IRC : Yaniv D

2 1