- Devel - oVirt List Archives

[Engine-devel] java SDK question
by navin p 02 Feb '13

02 Feb '13

Hi, When i do the api call for events from , i only get 100 events. Can someone tell me how to get all the events ? List<Event> evlst=api.getEvents().list(); for(Event obj:evlst) { System.out.println(obj.getDescription() + ":" +obj.getSeverity() +":"+obj.getTime().toString()+":"+k.toString()); } Regards, Navin

3 2

Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3413 - Unstable!
by Eyal Edri 01 Feb '13

01 Feb '13

fyi, new HIGH priority bug has been detected via findbugs in Managedomains.java file: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3413/findbugsResult/HIG… it was inserted in one of the commits since jan 29: (git blames this commit ..http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git&a=commit&h=35722c064f876ab9ead4b62105f7031623ec4471) > ------------------------------------ > Changes Since Last Success: > ------------------------------------- > [alkaplan] webadmin: Showing more than one canDoMessage for action in > multiple action > [alkaplan] engine: Extended error for pinned host missing non > required network > [alkaplan] webadmin: Add default description to multiple action > result > [gerrit2] engine: Moving Duplicate Code to Base Class > [juan.hernandez] packaging: Bump version number to 3.3.0-SNAPSHOT > [gerrit2] frontend: force admin-console only on AdminPortal > [mkublin] engine: Stop flood a logs by Autorecovering 0 .... > [rgolan] core: cancel migration better error handling > [amureini] core: Remove dead JPA implementation > [gerrit2] gluster: fixed NPE in GlusterAuditLogUtil > [gerrit2] packaging: suggest path for local storage during AIO setup > [ofrenkel] core: add support for tunnel migration > [ofrenkel] restapi: Add support for tunnel migration > [gerrit2] core: cleanup Handler classes > [amureini] packaging: Complete removal of Hibernate > [gerrit2] core: prevent changing display settings when vm isn't down > [ahadas] webadmin: replace 'VM' with 'Virtual Machine' > [alonbl] packaging: set both PGPASSFILE and ENGINE_PGPASS > [alonbl] packaging: substitute engineVersion.js in target that > actually create it > [amureini] core,ui: test duplicate keys in appErrors > [gerrit2] core: Make dependency on commons-collections explicit > [gerrit2] compat: convert to base64 without line feed > [gerrit2] pki: process template files not in-place > [gerrit2] pki: install private directories not world readable > [gerrit2] pki: encryptpasswd: remove unneeded pushd/popd > [gerrit2] cleanup: update .gitignore > ----- Original Message ----- > From: "Jenkins oVirt Server" <jenkins(a)ovirt.org> > To: eedri(a)redhat.com, engine-patches(a)ovirt.org, oliel(a)redhat.com, yzaslavs(a)redhat.com, dcaro(a)redhat.com > Sent: Friday, February 1, 2013 3:40:56 PM > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3413 - Unstable! > > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3413/ > Build Number: 3413 > Build Status: Unstable > Triggered By: Started by user David Caro Estevez > > ------------------------------------- > Changes Since Last Success: > ------------------------------------- > Changes for Build #3402 > [alkaplan] webadmin: Showing more than one canDoMessage for action in > multiple action > > [alkaplan] engine: Extended error for pinned host missing non > required network > > [alkaplan] webadmin: Add default description to multiple action > result > > [gerrit2] engine: Moving Duplicate Code to Base Class > > [juan.hernandez] packaging: Bump version number to 3.3.0-SNAPSHOT > > > Changes for Build #3403 > > Changes for Build #3404 > [gerrit2] frontend: force admin-console only on AdminPortal > > > Changes for Build #3405 > [mkublin] engine: Stop flood a logs by Autorecovering 0 .... > > [rgolan] core: cancel migration better error handling > > > Changes for Build #3406 > > Changes for Build #3407 > [amureini] core: Remove dead JPA implementation > > [gerrit2] gluster: fixed NPE in GlusterAuditLogUtil > > > Changes for Build #3408 > > Changes for Build #3409 > [gerrit2] packaging: suggest path for local storage during AIO setup > > [ofrenkel] core: add support for tunnel migration > > [ofrenkel] restapi: Add support for tunnel migration > > [gerrit2] core: cleanup Handler classes > > [amureini] packaging: Complete removal of Hibernate > > [gerrit2] core: prevent changing display settings when vm isn't down > > [ahadas] webadmin: replace 'VM' with 'Virtual Machine' > > [alonbl] packaging: set both PGPASSFILE and ENGINE_PGPASS > > [alonbl] packaging: substitute engineVersion.js in target that > actually create it > > [amureini] core,ui: test duplicate keys in appErrors > > [gerrit2] core: Make dependency on commons-collections explicit > > > Changes for Build #3410 > [gerrit2] compat: convert to base64 without line feed > > [gerrit2] pki: process template files not in-place > > [gerrit2] pki: install private directories not world readable > > [gerrit2] pki: encryptpasswd: remove unneeded pushd/popd > > > Changes for Build #3411 > > Changes for Build #3412 > [gerrit2] cleanup: update .gitignore > > > Changes for Build #3413 > > > > ----------------- > Failed Tests: > ----------------- > No tests ran. > > ------------------ > Build Log: > ------------------ > [...truncated 32804 lines...] > Downloading: > http://repo1.maven.org/maven2/org/apache/maven/doxia/doxia-decoration-model… > > Downloaded: > http://repo1.maven.org/maven2/velocity/velocity/1.4/velocity-1.4.jar > (353 KB at 6298.4 KB/sec) > 4 KB 159 KB 27 KB > 8 KB 159 KB 27 KB > 12 KB 159 KB 27 KB > 16 KB 159 KB 27 KB > 20 KB 159 KB 27 KB > 24 KB 159 KB 27 KB > 28 KB 159 KB 27 KB > 32 KB 159 KB 27 KB > 36 KB 159 KB 27 KB > 38 KB 159 KB 27 KB > 38 KB 163 KB 27 KB > 38 KB 167 KB 27 KB > 38 KB 171 KB 27 KB > 38 KB 175 KB 27 KB > 38 KB 179 KB 27 KB > 38 KB 183 KB 27 KB > 38 KB 187 KB 27 KB > 38 KB 191 KB 27 KB > 38 KB 195 KB 27 KB > 38 KB 199 KB 27 KB > 38 KB 203 KB 27 KB > 38 KB 207 KB 27 KB > 38 KB 211 KB 27 KB > 38 KB 215 KB 27 KB > 38 KB 219 KB 27 KB > 38 KB 223 KB 27 KB > 38 KB 227 KB 27 KB > 38 KB 231 KB 27 KB > 38 KB 234 KB 27 KB > 38 KB 238 KB 27 KB > 38 KB 242 KB 27 KB > 38 KB 246 KB 27 KB > 38 KB 250 KB 27 KB > 38 KB 254 KB 27 KB > 38 KB 258 KB 27 KB > 38 KB 262 KB 27 KB > 38 KB 266 KB 27 KB > 38 KB 270 KB 27 KB > 38 KB 274 KB 27 KB > 38 KB 278 KB 27 KB > 38 KB 282 KB 27 KB > 38 KB 286 KB 27 KB > 38 KB 290 KB 27 KB > 38 KB 294 KB 27 KB > 38 KB 298 KB 27 KB > 38 KB 302 KB 27 KB > 38 KB 306 KB 27 KB > > Downloaded: > http://repo1.maven.org/maven2/org/apache/maven/doxia/doxia-decoration-model… > (38 KB at 1433.9 KB/sec) > 310 KB 27 KB > 314 KB 27 KB > 318 KB 27 KB > 322 KB 27 KB > 326 KB 27 KB > 330 KB 27 KB > 334 KB 27 KB > 338 KB 27 KB > 342 KB 27 KB > 346 KB 27 KB > 350 KB 27 KB > 354 KB 27 KB > 358 KB 27 KB > 362 KB 27 KB > 366 KB 27 KB > 370 KB 27 KB > 374 KB 27 KB > 378 KB 27 KB > 382 KB 27 KB > 386 KB 27 KB > 390 KB 27 KB > 394 KB 27 KB > 398 KB 27 KB > 402 KB 27 KB > 406 KB 27 KB > 410 KB 27 KB > 414 KB 27 KB > 418 KB 27 KB > 422 KB 27 KB > 426 KB 27 KB > 430 KB 27 KB > 434 KB 27 KB > 438 KB 27 KB > 442 KB 27 KB > 446 KB 27 KB > 450 KB 27 KB > 454 KB 27 KB > 458 KB 27 KB > 462 KB 27 KB > 466 KB 27 KB > 470 KB 27 KB > 474 KB 27 KB > 478 KB 27 KB > 482 KB 27 KB > 486 KB 27 KB > 490 KB 27 KB > 494 KB 27 KB > 498 KB 27 KB > 502 KB 27 KB > 506 KB 27 KB > 506 KB 27 KB > > Downloaded: > http://repo1.maven.org/maven2/velocity/velocity-dep/1.4/velocity-dep-1.4.jar > (506 KB at 4770.1 KB/sec) > > Downloaded: > http://repo1.maven.org/maven2/org/apache/maven/shared/maven-common-artifact… > (27 KB at 48.8 KB/sec) > 4 KB > 8 KB > 12 KB > 15 KB > 17 KB > 21 KB > 25 KB > 29 KB > 33 KB > 36 KB > 40 KB > 44 KB > 48 KB > 52 KB > 56 KB > 60 KB > 64 KB > 66 KB > 70 KB > 74 KB > 78 KB > 82 KB > 86 KB > 90 KB > 94 KB > 98 KB > 102 KB > 106 KB > 110 KB > 114 KB > 118 KB > 122 KB > 126 KB > 130 KB > 134 KB > 138 KB > 142 KB > 146 KB > 150 KB > 154 KB > 157 KB > > Downloaded: > http://repo1.maven.org/maven2/plexus/plexus-utils/1.0.2/plexus-utils-1.0.2.… > (157 KB at 166.1 KB/sec) > [INFO] Configured Artifact: org.quartz-scheduler:quartz:2.1.2:jar > [INFO] Copying quartz-2.1.2.jar to > /ephemeral0/ovirt_engine_find_bugs/ear/target/quartz/quartz-2.1.2.jar > [INFO] > [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ > engine-server-ear --- > [INFO] Installing > /ephemeral0/ovirt_engine_find_bugs/ear/target/engine.ear to > /home/jenkins/workspace/ovirt_engine_find_bugs/.repository/org/ovirt/engine/engine-server-ear/3.3.0-SNAPSHOT/engine-server-ear-3.3.0-SNAPSHOT.ear > [INFO] Installing /ephemeral0/ovirt_engine_find_bugs/ear/pom.xml to > /home/jenkins/workspace/ovirt_engine_find_bugs/.repository/org/ovirt/engine/engine-server-ear/3.3.0-SNAPSHOT/engine-server-ear-3.3.0-SNAPSHOT.pom > [INFO] > [INFO] --- findbugs-maven-plugin:2.5.2:findbugs (default-cli) @ > engine-server-ear --- > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] ovirt-root ........................................ SUCCESS > [4.746s] > [INFO] oVirt Build Tools root ............................ SUCCESS > [0.053s] > [INFO] oVirt checkstyle .................................. SUCCESS > [3.136s] > [INFO] oVirt Checkstyle Checks ........................... SUCCESS > [19.792s] > [INFO] oVirt Modules - backend ........................... SUCCESS > [0.094s] > [INFO] oVirt Manager ..................................... SUCCESS > [0.068s] > [INFO] oVirt DB Scripts .................................. SUCCESS > [0.421s] > [INFO] oVirt Modules - manager ........................... SUCCESS > [1.471s] > [INFO] CSharp Compatibility .............................. SUCCESS > [33.383s] > [INFO] Encryption Libraries .............................. SUCCESS > [19.692s] > [INFO] oVirt Tools ....................................... SUCCESS > [0.141s] > [INFO] oVirt Tools Common Library ........................ SUCCESS > [16.808s] > [INFO] Common Code ....................................... SUCCESS > [1:36.328s] > [INFO] Common utilities .................................. SUCCESS > [1:32.875s] > [INFO] Data Access Layer ................................. SUCCESS > [1:10.370s] > [INFO] engine beans ...................................... SUCCESS > [0.136s] > [INFO] engine scheduler bean ............................. SUCCESS > [22.034s] > [INFO] Vds broker ........................................ SUCCESS > [1:13.278s] > [INFO] Search Backend .................................... SUCCESS > [36.539s] > [INFO] Backend Logic @Service bean ....................... SUCCESS > [2:41.427s] > [INFO] oVirt RESTful API Backend Integration ............. SUCCESS > [6.955s] > [INFO] oVirt RESTful API interface ....................... SUCCESS > [0.274s] > [INFO] oVirt Engine API Definition ....................... SUCCESS > [1:03.362s] > [INFO] oVirt Engine API Commom Parent POM ................ SUCCESS > [0.179s] > [INFO] oVirt Engine API Common JAX-RS .................... SUCCESS > [34.356s] > [INFO] oVirt RESTful API Backend Integration Type Mappers SUCCESS > [39.349s] > [INFO] oVirt RESTful API Backend Integration JAX-RS Resources > SUCCESS [1:26.921s] > [INFO] oVirt RESTful API Backend Integration Webapp ...... SUCCESS > [1.273s] > [INFO] oVirt Engine Web Root ............................. SUCCESS > [17.907s] > [INFO] oVirt Configuration Tool .......................... SUCCESS > [27.626s] > [INFO] Notifier Service package .......................... SUCCESS > [0.033s] > [INFO] Notifier Service .................................. SUCCESS > [28.639s] > [INFO] Notifier Service Resources ........................ SUCCESS > [2.673s] > [INFO] oVirt Modules :: Frontend ......................... SUCCESS > [0.037s] > [INFO] oVirt Modules :: Webadmin ......................... SUCCESS > [0.059s] > [INFO] oVirt Modules - ui ................................ SUCCESS > [0.366s] > [INFO] Extensions for GWT ................................ SUCCESS > [23.554s] > [INFO] UI Utils Compatibility (for UICommon) ............. SUCCESS > [28.727s] > [INFO] Frontend for GWT UI Projects ...................... SUCCESS > [34.302s] > [INFO] UICommonWeb ....................................... SUCCESS > [2:06.210s] > [INFO] oVirt GWT UI common infrastructure ................ SUCCESS > [1:29.750s] > [INFO] WebAdmin .......................................... SUCCESS > [1:46.479s] > [INFO] UserPortal ........................................ SUCCESS > [53.177s] > [INFO] oVirt WARs ........................................ SUCCESS > [0.021s] > [INFO] oVirt Web Application Module ...................... SUCCESS > [19.788s] > [INFO] oVirt Server EAR .................................. SUCCESS > [8.156s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:16.123s > [INFO] Finished at: Fri Feb 01 08:41:09 EST 2013 > [INFO] Final Memory: 310M/665M > [INFO] > ------------------------------------------------------------------------ > [FINDBUGS] Collecting findbugs analysis files... > [FINDBUGS] Finding all files that match the pattern > **/findbugsXml.xml > [FINDBUGS] Parsing 26 files in > /home/jenkins/workspace/ovirt_engine_find_bugs > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/beans/scheduler/target/findbugsXml.xml > of module with 0 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/bll/target/findbugsXml.xml > of module with 263 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/common/target/findbugsXml.xml > of module with 260 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/compat/target/findbugsXml.xml > of module with 56 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/dal/target/findbugsXml.xml > of module with 28 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/engineencryptutils/target/findbugsXml.xml > of module with 6 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/restapi/interface/common/jaxrs/target/findbugsXml.xml > of module with 16 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/restapi/interface/definition/target/findbugsXml.xml > of module with 1 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/restapi/jaxrs/target/findbugsXml.xml > of module with 28 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/restapi/types/target/findbugsXml.xml > of module with 13 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/root/target/findbugsXml.xml > of module with 1 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/searchbackend/target/findbugsXml.xml > of module with 12 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/utils/target/findbugsXml.xml > of module with 82 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/modules/vdsbroker/target/findbugsXml.xml > of module with 241 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/tools/engine-config/target/findbugsXml.xml > of module with 8 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/tools/engine-notifier/engine-notifier-service/target/findbugsXml.xml > of module with 11 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/backend/manager/tools/engine-tools-common/target/findbugsXml.xml > of module with 2 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/build-tools-root/ovirt-checkstyle-extension/target/findbugsXml.xml > of module with 1 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/frontend/wars/rmw-war/target/findbugsXml.xml > of module with 0 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/frontend/webadmin/modules/frontend/target/findbugsXml.xml > of module with 41 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/frontend/webadmin/modules/gwt-common/target/findbugsXml.xml > of module with 83 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/frontend/webadmin/modules/gwt-extension/target/findbugsXml.xml > of module with 2 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/frontend/webadmin/modules/uicommonweb/target/findbugsXml.xml > of module with 668 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/frontend/webadmin/modules/uicompat/target/findbugsXml.xml > of module with 34 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/frontend/webadmin/modules/userportal-gwtp/target/findbugsXml.xml > of module with 14 warnings. > [FINDBUGS] Successfully parsed file > /home/jenkins/workspace/ovirt_engine_find_bugs/frontend/webadmin/modules/webadmin/target/findbugsXml.xml > of module with 69 warnings. > [FINDBUGS] Computing warning deltas based on reference build #3401 > Build step 'Publish FindBugs analysis results' changed build result > to UNSTABLE > IRC notifier plugin: Sending notification to: #ovirt-jenkins > IRC notifier plugin: [ERROR] not connected. Cannot send message to > '#ovirt-jenkins' > Email was triggered for: Unstable > Sending email for trigger: Unstable >

1 0

[Engine-devel] oVirt 3.2 test-day
by Moran Goldboim 31 Jan '13

31 Jan '13

we were supposed to have test day tomorrow, but we decided to push it to Thursday (Jan 31) to have ovirt-node and proper infra for test day (Mike should announce it's officially soon). I have refreshed http://www.ovirt.org/Testing/OvirtTestDay, but there is action from your part as well: -go over the scenarios (regressions), see if those relevant, add more if needed remove if not. -add basic tests for your new 3.2 features. -assign a contributor to be actively present on helping users on his area -make commitment and participate the test day I would like to review this document by Wednesday on users meeting, please make sure your part is updated by than. Thanks, Moran.

7 8

[Engine-devel] when import ovirt-engine to eclipse, it cann't find the .project file.
by 陈超 31 Jan '13

31 Jan '13

Hi all, I am trying to set up an eclipse development environment for ovirt-engine and am running into a stubborn problem with missing classes. I have followed the directions for importing the Maven projects as written here: http://ovirt.org/wiki/Building_Ovirt_Engine/IDE,but there is no '.project' file,when I git clone from the gerrit.I should have a complete ovirt-engine source repository (I cloned the ovirt-engine git repo). Has anyone seen this problem before? Can you offer any suggestions to help me resolve it? Thanks! chenchao. thanks

3 2

[Engine-devel] jpa annotations
by Laszlo Hornyak 31 Jan '13

31 Jan '13

Hi, We have JPA annotations on the backend entity beans, but they have never been actually used as far as I know and now that I looked into VmTemplate for example we do not even have a vm_template table anymore, while VmTemplate still refers to it. Any plans with the JPA? Laszlo

6 8

[Engine-devel] Time to move to 3.3.0-SNAPSHOT?
by Juan Hernandez 30 Jan '13

30 Jan '13

Once 3.2.0 is released I think we should move to 3.3.0-SNAPSHOT in the master branch: http://gerrit.ovirt.org/11143 -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.

6 26

[Engine-devel] [engine-devel] frontend builders proposal
by Tomas Jelinek 30 Jan '13

30 Jan '13

Hi All, as many of you may know, the way how the frontend and backend models are built on frontend (uicommonweb project) is not really ideal. Currently this logic is copy pasted over and over again to different places where it is needed with minor changes to fulfill the specific requirements. It is not only aesthetically problematic, but I recall tons of bugs caused by introducing a new field and forgetting to add it to every place it is used in GUI. Now, as there will be big changes in the VM/Template models (http://www.ovirt.org/Features/Instance_Types) so the way how the VM, Template, Pool and also the newly created Instance Types models are being built has to be touched anyhow, it is a great opportunity to rethink the way how we do it. I have created a simple infrastructure (http://gerrit.ovirt.org/#/c/10874/) which could be used for it, and a PoC patch which uses this infrastructure (http://gerrit.ovirt.org/#/c/11354/) Please note that the PoC is not really impressive in means of removing duplications, I wanted to start with the simplest possibility. The principles behind the infrastructure: - have small, well named, easy to understand and reuse builders - this builders can be chained together or embedded to each other to build the full resulting object (composite pattern) - this builders can be asynchronous, and the next builder in the chain has to be executed only when the current is completely done The structure: - the base is an interface called Builder which has a method build(source, destination, rest) - the builder implementing this interface + will get the source and destination objects + copies whatever he wants from source to destination + when done, executes build on the first element of the rest + this may sound awkward, but this is the way how the async calls can be "linearized" in a general way, not embedding anonymous class into anonymous class into anonymous class... as we do it today. + for synchronous builders, there is a BaseSyncBuilder which takes care of this boilerplate calling of next and exposes a simple method build(S source, D destination) + to simplify the creating and running the chain of builders, there is a BuilderExecutor class (can be created as sync or async) So, a simple example - even more simple than the PoC patch :) //create the first builder class FirstLetterBuilder extends BaseSyncBuilder<String, StringBuilder> { @Override protected void build(String source, StringBuilder destination) { // copy the first letter to the destination destination.append(source.charAt(0)); } } //create the second builder class SecondLetterBuilder extends BaseSyncBuilder<String, StringBuilder> { @Override protected void build(String source, StringBuilder destination) { // copy the second letter to the destination destination.append(source.charAt(1)); } } // usage ... // create the destination object StringBuilder res = new StringBuilder(); // configure the executor with the two builders BuilderExecutor<String, StringBuilder> executor = new BuilderExecutor<String, StringBuilder>( new FirstLetterBuilder(), new SecondLetterBuilder() ); // execute the builder chain ("ab" is the source, res the destination) executor.build("ab", res); // use the result ... That's it. And the nice part is, that this FirstLetterBuilder and SecondLetterBuilder can be reused anywhere or combined with any other builders. Any comments on this will be more than welcome! Thank you, Tomas

4 6

[Engine-devel] ovirt-engine-sdk-java 1.0.0.3-1 released
by Michael Pasternak 30 Jan '13

30 Jan '13

- added persistent authentication support - added support for the methods overloads based on url/headers params - added delete methods overloads with body as parameters holder - to host added [display.address] property for overriding display address - user can specify own ticket now in vm.ticket() via [action.ticket.value] More details can be found at [1]. [1] http://www.ovirt.org/Java-sdk-changelog -- Michael Pasternak RedHat, ENG-Virtualization R&D

1 0

Re: [Engine-devel] [engine-devel] frontend builders proposal
by Tomas Jelinek 30 Jan '13

30 Jan '13

Hi Tal, > I was wondering, for entity such as VM, isn't it better to make a > builder for the entity as a whole? Unless you know of a specific parts > that are used in smaller units? well, when you create a new VM or a Template, in both cases you need to build the VM entity from UnitVmModel. But, not all the fields which are taken from the UnitVmModel in case of creating the new VM are used also for new Template. So, in this case both can use CommonUnitToVmBuilder and QuotaUnitToVmBuilder, but the creating of the VM uses also others (e.g. UsbPolicyUntiToVmBuilder etc) The situation will be even more complex when the Instance Types and the Images will be introduced which all will be basically VM and UnitVmModel subsets. So, they will be able to use some of the common builders but not all and will have some custom. Tomas ----- Original Message ----- From: "Tal Nisan" <tnisan(a)redhat.com> To: "Tomas Jelinek" <tjelinek(a)redhat.com> Sent: Monday, January 28, 2013 5:44:31 PM Subject: Re: [Engine-devel] [engine-devel] frontend builders proposal Hi Tomas, I was wondering, for entity such as VM, isn't it better to make a builder for the entity as a whole? Unless you know of a specific parts that are used in smaller units? Tal. On 01/25/2013 11:55 AM, Tomas Jelinek wrote: > Hi All, > > as many of you may know, the way how the frontend and backend models are built on frontend (uicommonweb project) is not really ideal. Currently this logic is copy pasted over and over again to different places where it is needed with minor changes to fulfill the specific requirements. It is not only aesthetically problematic, but I recall tons of bugs caused by introducing a new field and forgetting to add it to every place it is used in GUI. > > Now, as there will be big changes in the VM/Template models (http://www.ovirt.org/Features/Instance_Types) so the way how the VM, Template, Pool and also the newly created Instance Types models are being built has to be touched anyhow, it is a great opportunity to rethink the way how we do it. > > I have created a simple infrastructure (http://gerrit.ovirt.org/#/c/10874/) which could be used for it, and a PoC patch which uses this infrastructure (http://gerrit.ovirt.org/#/c/11354/) Please note that the PoC is not really impressive in means of removing duplications, I wanted to start with the simplest possibility. > > The principles behind the infrastructure: > - have small, well named, easy to understand and reuse builders > - this builders can be chained together or embedded to each other to build the full resulting object (composite pattern) > - this builders can be asynchronous, and the next builder in the chain has to be executed only when the current is completely done > > The structure: > - the base is an interface called Builder which has a method build(source, destination, rest) > - the builder implementing this interface > + will get the source and destination objects > + copies whatever he wants from source to destination > + when done, executes build on the first element of the rest > + this may sound awkward, but this is the way how the async calls can be "linearized" in a general way, not embedding anonymous class into anonymous > class into anonymous class... as we do it today. > + for synchronous builders, there is a BaseSyncBuilder which takes care of this boilerplate calling of next and exposes a simple method > build(S source, D destination) > + to simplify the creating and running the chain of builders, there is a BuilderExecutor class (can be created as sync or async) > > So, a simple example - even more simple than the PoC patch :) > > //create the first builder > class FirstLetterBuilder extends BaseSyncBuilder<String, StringBuilder> { > @Override > protected void build(String source, StringBuilder destination) { > // copy the first letter to the destination > destination.append(source.charAt(0)); > } > } > > //create the second builder > class SecondLetterBuilder extends BaseSyncBuilder<String, StringBuilder> { > @Override > protected void build(String source, StringBuilder destination) { > // copy the second letter to the destination > destination.append(source.charAt(1)); > } > } > > // usage > ... > // create the destination object > StringBuilder res = new StringBuilder(); > > // configure the executor with the two builders > BuilderExecutor<String, StringBuilder> executor = new BuilderExecutor<String, StringBuilder>( > new FirstLetterBuilder(), > new SecondLetterBuilder() > ); > > // execute the builder chain ("ab" is the source, res the destination) > executor.build("ab", res); > > // use the result > ... > > That's it. And the nice part is, that this FirstLetterBuilder and SecondLetterBuilder can be reused anywhere or combined with any other builders. > > Any comments on this will be more than welcome! > > Thank you, > Tomas > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel

1 0

[Engine-devel] 3.2 features for release notes
by Cheryn Tan 30 Jan '13

30 Jan '13

Hi all, I'm preparing the oVirt 3.2 release notes, starting with the features listed here: http://www.ovirt.org/OVirt_3.2_release-management#Features Can you please go through the list, and reply to this thread if: a) There are features being released for 3.2 which should be documented, but are not on the list; or b) Some of the planned features on this list are not being released for 3.2; or c) Some of the features on this list are being released for 3.2, but should not be documented. For features which aren't on the wiki, please send a short description or Bugzilla numbers of each feature. Please reply no later than Jan 28. Thank you very much for your help! Cheryn

13 15