- Devel - oVirt List Archives

[Engine-devel] upgrade script
by Yair Zaslavsky 12 Dec '12

12 Dec '12

Hi all, Please pay attention - when you send patches with upgrade script the prefix should be 03_02_XXXX_ and not 03_01_XXXX_ For example - this script was originally 03_01_XXXX once, and it's in correct backend/manager/dbscripts/upgrade/03_02_0020_add_libvirt_version_col.sql Yair

1 0

[Engine-devel] another datamodel cleanup
by Laszlo Hornyak 11 Dec '12

11 Dec '12

Hi, Another datamodel cleanup patch is waiting for review: http://gerrit.ovirt.org/9824 Thx, Laszlo

1 0

[Engine-devel] compatibility version
by Laszlo Hornyak 11 Dec '12

11 Dec '12

Hi, When I install an ovirt engine from scratch, the Default DC is set to Compatibility version 3.1, but when I create a new DC, it's Compatibility version is set to 3.2 by default. Is this intentional? Why? Laszlo

2 2

[Engine-devel] Inherited Permissions from System
by Ravi Nori 11 Dec '12

11 Dec '12

I am currently working on a bug to show the inherited permissions on an object. So if the user has permissions assigned on a Cluster, the user should have permissions on the VMs in the cluster. My question is if the user has permissions on the System, should the permissions be inherited to all the entities? Link to the bug https://bugzilla.redhat.com/show_bug.cgi?id=871365 Thanks Ravi

2 1

[Engine-devel] Attaching a console should be controllable
by Frantisek Kobzik 10 Dec '12

10 Dec '12

Hi guys, Just a simple question. I'm writing an engine counterpart for this vdsm feature: https://bugzilla.redhat.com/show_bug.cgi?id=878459 http://gerrit.ovirt.org/#/c/9359 Long story short, it adds the possibility of controlling adding the virtio serial console to a VM. I'm going to add a new column "console_enabled" to vm_static and a new field "bool consoleEnabled" to appropriate entities. I'm just worried about the naming of the column and the field - could I use these names? Isn't it confusing? I just want to avoid unneeded refactoring when the patch is done. Any feedback is welcome! Thanks, Frank

3 2

[Engine-devel] UI Plugins: PoC patch revision 7 update 3 is now available
by Vojtech Szocs 10 Dec '12

10 Dec '12

------=_Part_16659810_2134251194.1355163009146 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi everyone, just a quick update on UI Plugins proof-of-c on cept patch - new patch for revision 7 (update 3) is now available. You can download and apply latest patches from oVirt Gerrit code review system: * rev is ion 6 - http://gerrit.ovirt.org/#/c/8120/ * rev is ion 7 update 3 - http://gerrit.ovirt.org/#/c/9250/ * REST API session patch: http://gerrit.ovirt.org/#/c/9820/ Please read on to learn what's new. Engine REST API integration REST API session patch (see above) now ensures that new session is acquired each time the user logs into WebAdmin, despite the fact that UI plugin infrastructure doesn't close existing REST API session on server after user logout. This means each user login equals new REST API session, based on provided login credentials. This fixes the problem of reusing existing (un-closed) session from previous user login. Many thanks to Michael Pasternak and Oved Ourfalli for the patch! Additionally, known limitation with regard to auto login has been fixed - UI plugin infrastructure now remembers REST API session ID on client (using HTML5 storage / cookie fallback) and uses it for auto login process. UI plugin infrastructure assumes that for auto login, REST API session has already been acquired (via classic login) and is still active at the time of auto login. Updated API function: register To make it clear that api.register function should be called exactly once , the function behavior has been changed in the following way: * previously, you could call api.register multiple times, last call would "win" with regard to passed event handler object * now, you can call api.register only once, subsequent calls will have no effect (the event handler object has already been set ) Regards, Vojtech ------=_Part_16659810_2134251194.1355163009146 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head><style type=3D'text/css'>p { margin: 0; }</style></head><body><= div style=3D'font-family: times new roman,new york,times,serif; font-size: = 12pt; color: #000000'>Hi everyone, just a quick update on UI</sp= an> Plugins<= /span> proof-of-concept patch = - new patch for revision 7 (update 3) is now available. You can down= load and apply latest = patches from oVirt Gerrit code review system: <ul><li>revision 6 - <a target=3D"_blank" href=3D"http://gerrit.ovir= t.org/#/c/8120/">http://gerrit.ovirt.org/#/c/8120/</a></li><l= i>revision 7 update 3 = - <a target=3D"_blank"= href=3D"http://gerrit.ovirt.org/#/c/9250/">http://gerrit.ovirt.org/#/c/925= 0/</a></li><li>REST API session patch: http://gerrit.ovirt.org/#/c/9820/</sp= an></li></ul>Please read on to learn what's new. <hr style= =3D"width: 100%; height: 2px;"> Engine REST API integration</= strong> REST API session patch (see above) now ensures that new session= is acquired each time the user logs into WebAdmin, despite the fact that <= /span>UI plugin infrastructure doesn't close existing REST API ses= sion on server after user logout. This means each user login equals new RES= T API session, based on provided login credentials. This fixes the problem = of reusing existing (un-closed) session from previous user login. Many than= ks to Michael Pasternak and Oved Ourfalli for the patch! = Additionally, known limitation with regard to auto login has been fixed = - UI plugin in= frastructure now remembers REST API session ID on client (using HTML5 stora= ge / cookie fallback) and uses it for auto login process. UI plugin infrastructure assume= s that for auto login, REST API session has already been acquired (via clas= sic login) and is still active at the time of auto login. <hr style=3D"width: 100%; height: = 2px;"> Updated API function: register To make it clear that api.register function sho= uld be called exactly once, the function behavior has been changed i= n the following way: <ul><li>previously, you could call api.register multiple times, last call would "wi= n" with regard to passed event handler object</li><li>now, you can call <sp= an style=3D"font-style: italic;">api.register only once, subsequent = calls will have no effect (the event handler object has already been set)<b= r></li></ul> <hr style=3D"width: 100%; height: 2px;"> R= egards, Vojtech </div></body></html> ------=_Part_16659810_2134251194.1355163009146--

1 0

[Engine-devel] Report vNic Information - Round 2
by Moti Asayag 10 Dec '12

10 Dec '12

Hi, According to the latest discussion of vNic info feature, I've updated its feature page [1]. Note that both feature page and detailed design page are updated. The feature page contains also a suggested mockup for the vm interface sub-tab. [1] http://www.ovirt.org/Feature/ReportingVnicInformation Thanks, Moti

1 0

[Engine-devel] host cpu feature
by Laszlo Hornyak 07 Dec '12

07 Dec '12

Hi, CPU-Host support allows the virtual machines to see and utilize the host's CPU flags, this enables better performance in VM's, at the price of worse portablity. http://www.ovirt.org/Features/Cpu-host_Support Your feedback is welcome! Thank you, Laszlo

7 26

[Engine-devel] UI Plugins: PoC patch revision 7 update 2 is now available
by Vojtech Szocs 07 Dec '12

07 Dec '12

------=_Part_15061948_104424654.1354837817204 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi guys, an updated version of UI Plugins proof-of-c on cept patch is now available for you to experiment with. It's basically revision 7 with new features, driven mostly by the feedback received so far. You can download and apply latest UI Plugins patches from oVirt Gerrit code review system: * rev is ion 6 - http://gerrit.ovirt.org/#/c/8120/ * rev is ion 7 update 2 - http://gerrit.ovirt.org/#/c/9250/ Please read on to learn what's new. If you have any comments, questi on s or ideas, please let me know! Engine REST API integration UI plugin infrastructure no longer closes current REST API session upon WebAdmin user logout. Since REST API session management uses JSESSIONID cookie to transmit session ID from client to server, the cookie will be present even after user signs out of WebAdmin. Upon subsequent login, this cookie will be sent as part of another "acquire REST API session" request, which means REST API will potentially reuse existing session based on JSESSIONID cookie value. Known limitation: due to REST API integration requiring WebAdmin user password when acquiring session, RestApiSessionAcquired function will NOT be called in case of auto login. This happens when the user signs into WebAdmin, closes the browser window (tab) without signing out, and opens it again - WebAdmin signs the user in automatically. In this case, there is no way (yet) to query for user password, which is required when acquiring REST API session. To work around this limitation, just sign out and sign in again. We're planning to address this limitation in future update. Other than that, REST API integration works the same as before, calling RestApiSessionAcquired function on plugins each time new or existing session is acquired, and keeping the session alive through heartbeat requests while the user stays authenticated. It is therefore guaranteed that RestApiSessionAcquired function will be called each time the user signs into WebAdmin. New API function: addSubTab It's now possible to add custom sub tabs under existing main tabs. For example, to add custom sub tab under Host main tab: api.addSubTab('Host', 'My Host Sub Tab', 'my-host-sub-tab', 'http://www.ovirt.org/'); The signature of addSubTab function is following: addSubTab(entityTypeName, label, historyToken, contentUrl) entityTypeName indicates the main tab entity type, i.e. under which main tab the sub tab should be added. See org.ovirt.engine.ui.webadmin.plugin.entity.EntityType enum for supported values. label , historyToken and contentUrl have same semantics as in addMainTab function. New API function: setTabContentUrl Use this function to update custom main or sub tab content URL, for example: api.setTabContentUrl( 'my-host-sub-tab' , 'http://www.example.org/' ); New API function: setTabAccessible Use this function to control access to custom main or sub tab, for example: api.setTabAccessible( 'my-host-sub-tab' , false); In the example above, the custom tab is set as not accessible. In practice, this means two things: * corresponding tab header will be hidden on GUI * any attempt to navigate to this tab (e.g. by modifying URL with token representing the tab) will be denied by the plugin infrastructure New events: UserLogin and UserLogout Plugins can now be notified when user logs into or out of WebAdmin GUI. For example: api.register({ UserLogin: function(userName, userId) { ... }, UserLogout: function() { ... } }); New events: {EntityTypeName}SelectionChange Plugins can now be notified whenever existing main tab selection changes . For example, a plugin could listen to Host main tab selection change like so: api.register({ HostSelectionChange: function() { var hostsSelected = arguments.length; var firstHostId = arguments[0].entityId; } }); For each supported entity type, {EntityTypeName}SelectionChange event is defined: ClusterSelectionChange, DataCenterSelectionChange, DiskSelectionChange, HostSelectionChange, StorageSelectionChange, TemplateSelectionChange, VirtualMachineSelectionChange. Note that each {EntityTypeName}SelectionChange event handler function receives currently selected items as arguments. Minor improvements Browser popup window triggered via showDialog API function now shows scrollbars if the content doesn't fit the window. Note on showDialog function implementation: we're planning to replace the current (browser-based) popup implementation with one that properly integrates with WebAdmin dialog infrastructure. This is something that's still on my TODO list, planning to do this in near future. Regards, Vojtech ------=_Part_15061948_104424654.1354837817204 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head><style type=3D'text/css'>p { margin: 0; }</style></head><body><= div style=3D'font-family: times new roman,new york,times,serif; font-size: = 12pt; color: #000000'>Hi guys, an updated version of UI <sp= an id=3D"DWT4659" class=3D"ZmSearchResult">Plugins<= /span> proof-of-c<span= id=3D"DWT4665" class=3D"ZmSearchResult">oncept patch is now available for you to e= xperiment with. It's basically revision 7 with new features, driven mostly = by the feedback received so far. You can download and apply latest <= span id=3D"DWT3757" class=3D"ZmSearchResult">UI Plugins patches from oVirt Gerrit code rev= iew system: <ul><li>revis<= /span>ion 6 - <a target=3D"_blank" href=3D"http://gerrit.ovirt.org/#/c/8120/">http://g= errit.ovirt.org/#/c/8120/</a></li><li>revision 7 update 2 - <a target=3D"_blank" href=3D"http://gerr= it.ovirt.org/#/c/9250/">http://gerrit.ovirt.org/#/c/9250/</a></li></= ul>Please read on to learn what's new. If yo= u have any comments, questi<s= pan id=3D"DWT4679" class=3D"ZmSearchResult">ons or ideas, ple= ase let me know! <hr style=3D"width: 100%; height: 2px;"> <strong= >Engine REST API integration U= I plugin infrastructure no longer closes current REST API session upon WebA= dmin user logout. Since REST API session management uses JSESSIONID = cookie to transmit session ID from client to server, the cookie will be pre= sent even after user signs out of WebAdmin. Upon subsequent login, this coo= kie will be sent as part of another "acquire REST API session" request, whi= ch means REST API will potentially reuse existing session based on JSESSION= ID cookie value. Known limitation: due to REST API integration requiring= WebAdmin user password when acquiring session, RestApiSessionAcquired<= /em> function will NOT be called in case of auto login. This happens when t= he user signs into WebAdmin, closes the browser window (tab) without signin= g out, and opens it again - WebAdmin signs the user in automatically. In th= is case, there is no way (yet) to query for user password, which is require= d when acquiring REST API session. To work around this limitation, just sig= n out and sign in again. We're planning to address this limitation in futur= e update. Other than that, REST API integration works the same as be= fore, calling RestApiSessionAcquired</s= pan> function on plugins each time new or existing session is acquired, and= keeping the session alive through heartbeat requests while the user stays = authenticated. It is therefore guaranteed that RestApiSessionAcquired function will be called each time the= user signs into WebAdmin. <hr style=3D"width: 100%; height: 2px;"><= br>New API function: addSubTab<br= style=3D"font-weight: bold;"> It's now possible to add custom sub tabs = under existing main tabs. For example, to add custom sub tab under H= ost main tab: api.addSubTab('Host', 'My Host Sub Tab', 'my-host-s= ub-tab', 'http://www.ovirt.org/'); The signature of addSubTab function is following: <sp= an style=3D"font-style: italic;">addSubTab(entityTypeName, label, historyTo= ken, contentUrl) entityTypeName indicates the main tab entity t= ype, i.e. under which main tab the sub tab should be added. See org.ovirt.engine.ui.webadmin.plugin.entity.EntityT= ype enum for supported values. label, historyToken= and contentUrl have same semant= ics as in addMainTab function.<b= r> <hr style=3D"width: 100%; height: 2px;"> New API function: setTabContentUrl Use this function to update custom main or sub tab content URL= , for example: api.setTabContentUrl('my-host-sub-tab'</= span>, 'http://www.example.org/'); <hr= style=3D"width: 100%; height: 2px;"> New API function: setTabAccessible = Use this function to control access to custom main or sub tab, for exam= ple: api.setTabAccessible('my-host-sub-tab'<span= style=3D"font-family: courier new,courier,monaco,monospace,sans-serif;"></= span>, false); In the example above, the custom tab is set= as not accessible. In practice, this means two things: <ul><li>correspo= nding tab header will be hidden on GUI</li><li>any attempt to navigate to t= his tab (e.g. by modifying URL with token=20 representing the tab) will be denied by the plugin infrastructure</li></ul>= <hr style=3D"width: 100%; height: 2px;"> New events: UserLogin and UserLogout Plugins can now be notified when user logs into or out of WebA= dmin GUI. For example: api.register({   UserLo= gin: function(userName, userId) {     ...<b= r style=3D"font-family: courier new,courier,monaco,monospace,sans-serif;"><= span style=3D"font-family: courier new,courier,monaco,monospace,sans-serif;= ">  },   UserLogout: function() {  &nbsp= ;  ...   } }); <hr style=3D"wid= th: 100%; height: 2px;"> New events: = {EntityTypeName}SelectionChange = Plugins can now be notified whenever existing main tab selection changes.<b= r> For example, a plugin could listen to Host main tab selection change = like so: api.register({   HostSelectionChange: function() {     var hostsSelected =3D arguments.length;  &nbs= p;  var firstHostId =3D arguments[0].entityId;   } }); For each supported entity type, <sp= an style=3D"font-style: italic;">{EntityTypeName}SelectionChange eve= nt is defined: ClusterSelectionChange, DataCenterSelectionChange, DiskSelec= tionChange, HostSelectionChange, StorageSelectionChange, TemplateSelectionC= hange, VirtualMachineSelectionChange. Note that each {EntityTypeName}SelectionChange event handler f= unction receives currently selected items as arguments. <hr style=3D= "width: 100%; height: 2px;"> Minor im= provements Browser popup window = triggered via showDialog API fun= ction now shows scrollbars if the content doesn't fit the window. <s= pan style=3D"text-decoration: underline; font-style: italic;">Note on showD= ialog function implementation: we're planning to replace the current= (browser-based) popup implementation with one that properly integrates wit= h WebAdmin dialog infrastructure. This is something that's still on my TODO= list, planning to do this in near future. <hr style=3D"width: 100%;= height: 2px;"> Regards, Vojtech </div></body></html> ------=_Part_15061948_104424654.1354837817204--

1 0

[Engine-devel] JUnit 4.10 Upgrade
by Allon Mureinik 06 Dec '12

06 Dec '12

Hi guys, Earlier this week I upgraded ovirt-engine to use JUnit 4.10. The nifty new features can be found here: https://github.com/KentBeck/junit/blob/master/doc/ReleaseNotes4.10.md -Allon

1 0