- Devel - oVirt List Archives

[Engine-devel] Question about hasMemoryToRunVM() in RunVmCommandBase
by ly pan 31 Oct '12

31 Oct '12

Hi: This is my test environment: hardware: Dell PowerEdge 2710 ,Memory 48G Software: OVirt engine 3.0 ,VDSM 4.9.4 ,kernel 2.6.32-279.2.1.el6.x86_64 I create 100 vms from pool(each vm has 512M memory and has 1M memory garanteed, with guest_overhead = 65 and reserved_mem = 256), but only 83 vms turn out to run. When I run the 84th vm, engine says there is not enough memory. However at this time KSM is enabled and 15G free memory is still left on the host. I checked the code and found out that before running a vm, the function hasMemoryToRunVM() in RunVmCommandBase would decide whether there is enough memory in the selected host to run it. The Algorithm in the function is like this: mem_avaliable >= mem_required = curVds.getmem_commited() + curVds.getpending_vmem_size() + curVds.getguest_overhead() + curVds.getreserved_mem() + vm.getMinAllocatedMem(); And here is my question: curVds.getmem_commited() is caculated from the memory of vm assigned by user. But when the host is running with KSM enabled, the actual memory of each running vm would be smaller than the memory the user assigned to. In this case, the following may occur: engine says there be no more memroy to run any vm while the host has much free space to run more vms(in my case, 15G). Therefore I think the actual memory size reported by vdsm(The KSM shared memory) should be taken into account when calculating curVds.getmem_commited(). Any ideas are welcome.

4 5

[Engine-devel] Splitting out the oVirt engine installer
by Derek Higgins 30 Oct '12

30 Oct '12

Hi All, First time poster here so let me know if this is better directed some where else I have been writing a installer for openstack and as a base for this I've split out the generic parts of your engine-setup utility[1]. In order to do this I've created a generic installer[2] that is basically all of the parts of the oVirt engine installer that I needed for my openstack installer[3] I'd now like to see if there is interest here to use this generic installer for oVirt. I may have stripped out some stuff from the installer that I should have left in, if that is the case I'm open to recreating this repository with anything generic I shouldn't have stripped out so that the original history is maintained. Would anybody here like to look into the work necessary to use this installer in oVirt? For openstack I've made exclusive use of the plugin functionality and I suspect most changes that would be needed for oVirt would be to move a lot of the code into a similar pattern. If you have any questions/comments just let me know, hopefully you will find this useful and other projects could make use of the great work you have done developing this setup utility Thanks, Derek. [1] https://github.com/derekhiggins/ovirt-engine/tree/master/packaging/fedora/s… [2] https://github.com/derekhiggins/installer [3] https://github.com/derekhiggins/os-installer

2 2

[Engine-devel] unmanaged devices thrown into 'custom' feature
by Dan Kenigsberg 27 Oct '12

27 Oct '12

I have just noticed that when a VM is started for the second time, Engine issues the "create" vdsm verb with some information regarding "unmanaged" devices (an example is shown below[1]) in the 'custom' propery bag. I'm surprised about this, as I was not aware of this usage of the 'custom' dictionary, and Vdsm is not doing anything with the data. Would anyone elaborate about it? On the face of it, it does not seem like a pleasant API. If Engine wants to tell Vdsm about the location of various devices, we should probably be using the 'devices' property, not the bag of 'custom' property made for user-defined hooks. I hope this API pecularity can be avoided, and very much hope that no one is depending on it. Dan. [1] 'custom': { 'device_e97a9759-1c1b-45ed-9ed9-7136ef538315': 'VmDevice {vmId=068d4914-4191-400d-a220-17a7f2d8e80c, deviceId=e97a9759-1c1b-45ed-9ed9-7136ef538315, device=ide, type=controller, bootOrder=0, specParams={}, address={bus=0x00, domain=0x0000, type=pci, slot=0x01, function=0x1}, managed=false, plugged=true, readOnly=false, alias=ide0}', 'device_e97a9759-1c1b-45ed-9ed9-7136ef538315device_133d9bfa-c531-414e-ad20-208d67d5a5e6device_7bfffa34-2e27-4b01-b499-6ac79c997709': 'VmDevice {vmId=068d4914-4191-400d-a220-17a7f2d8e80c, deviceId=7bfffa34-2e27-4b01-b499-6ac79c997709, device=unix, type=channel, bootOrder=0, specParams={}, address={port=1, bus=0, controller=0, type=virtio-serial}, managed=false, plugged=true, readOnly=false, alias=channel0}', 'device_e97a9759-1c1b-45ed-9ed9-7136ef538315device_133d9bfa-c531-414e-ad20-208d67d5a5e6': 'VmDevice {vmId=068d4914-4191-400d-a220-17a7f2d8e80c, deviceId=133d9bfa-c531-414e-ad20-208d67d5a5e6, device=virtio-serial, type=controller, bootOrder=0, specParams={}, address={bus=0x00, domain=0x0000, type=pci, slot=0x04, function=0x0}, managed=false, plugged=true, readOnly=false, alias=virtio-serial0}', 'device_e97a9759-1c1b-45ed-9ed9-7136ef538315device_133d9bfa-c531-414e-ad20-208d67d5a5e6device_7bfffa34-2e27-4b01-b499-6ac79c997709device_7c107c63-605f-4b21-9893-c052ec211424device_48007de9-467d-46a1-aa84-cc1a6419b5fb': 'VmDevice {vmId=068d4914-4191-400d-a220-17a7f2d8e80c, deviceId=48007de9-467d-46a1-aa84-cc1a6419b5fb, device=spicevmc, type=channel, bootOrder=0, specParams={}, address={port=3, bus=0, controller=0, type=virtio-serial}, managed=false, plugged=true, readOnly=false, alias=channel2}', 'device_e97a9759-1c1b-45ed-9ed9-7136ef538315device_133d9bfa-c531-414e-ad20-208d67d5a5e6device_7bfffa34-2e27-4b01-b499-6ac79c997709device_7c107c63-605f-4b21-9893-c052ec211424': 'VmDevice {vmId=068d4914-4191-400d-a220-17a7f2d8e80c, deviceId=7c107c63-605f-4b21-9893-c052ec211424, device=unix, type=channel, bootOrder=0, specParams={}, address={port=2, bus=0, controller=0, type=virtio-serial}, managed=false, plugged=true, readOnly=false, alias=channel1}' }

8 11

[Engine-devel] New component 'mom' added to Bugzilla
by Adam Litke 25 Oct '12

25 Oct '12

Hi all, MOM is becoming a bigger part of oVirt and unfortunately it may have bugs at some point :( Thanks to Yaniv we have a new 'mom' component in oVirt's bugzilla where you can report these. To file a new bug against MOM: https://bugzilla.redhat.com/enter_bug.cgi?product=oVirt;component=mom Thanks! -- Adam Litke <agl(a)us.ibm.com> IBM Linux Technology Center

1 0

[Engine-devel] alias in disk instead of name
by Michael Pasternak 25 Oct '12

25 Oct '12

The problem we caused by using alias in disk instead of name is break of search-by-name paradigm in engine.search dialect, not sure why we do not want forcing disk name to be unique [1], but lack of "name" in disk search is does not look good in my view. thoughts? [1] can be easily achieved via appropriate can-do-action verification. background: ========== On 10/15/2012 02:09 PM, Einav Cohen wrote: > we didn't exactly renamed "name" to "alias"; "name" is an automatic identifier of the disk, which is: "Disk n", n=internal drive mapping; "alias" is a *user-defined* identifier. > > IIRC, once we understood that we need a user-defined identifier for the disk business entity, we indeed had in mind re-using "name", however, the "name" field in other business entities is unique across the system, and we didn't want the disk user-defined identifier to be unique, so we preferred to not (re)use the term "name" and came up with "alias", to avoid confusion. > > ----- Original Message ----- >> From: "Michael Pasternak" <mpastern(a)redhat.com> >> To: "Einav Cohen" <ecohen(a)redhat.com> >> Sent: Monday, October 15, 2012 1:58:26 PM >> Subject: alias in disk instead of name >> >> hi, >> >> can you remind me why did we renamed name to alias in disk? >> >> -- >> >> Michael Pasternak >> RedHat, ENG-Virtualization R&D >> -- Michael Pasternak RedHat, ENG-Virtualization R&D

5 20

[Engine-devel] UI Plugins: PoC patch revision 6 now available
by Vojtech Szocs 24 Oct '12

24 Oct '12

------=_Part_9716068_484635069.1350571769689 Content-Type: multipart/alternative; boundary="----=_Part_9716069_2003615259.1350571769689" ------=_Part_9716069_2003615259.1350571769689 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi guys, the latest revision of UI Plugins proof-of-concept patch is now available for you to experiment with. You can download the patch from oVirt Gerrit at http://gerrit.ovirt.org/#/c/8120/2 (patch set 2). Please read on to learn what's new in this revision. If you have any comments, questions or ideas, please let me know! 0. UI plugin path information resolved using local Engine configuration Server-side UI plugin infrastructure now uses local (machine-specific) Engine configuration instead of global ( vdc_options database table) Engine configuration: * Previously, path information was resolved through org.ovirt.engine.core.common.config.Config class - Engine configuration values were retrieved from vdc_options database table. * Currently, path information is resolved through org.ovirt.engine.core.utils.LocalConfig class - Engine configuration values are retrieved from local file system. In case you're not working with oVirt Engine through RPM package system, e.g. you have a local development environment set up and you build and deploy oVirt Engine through Maven, please follow these steps: a. Copy default Engine configuration into /usr/share/ ovirt-engine /conf # mkdir -p /usr/share/ovirt-engine/conf # cp <OVIRT_HOME>/backend/manager/conf/engine.conf.defaults /usr/share/ovirt-engine/conf/engine.conf.defaults b. If necessary, copy UI plugin data files from /usr/share/engine/ui-plugins to /usr/share/ ovirt-engine /ui-plugins c. If necessary, copy UI plugin config files from /etc/engine/ui-plugins to /etc/ ovirt-engine /ui-plugins d, In case you want to override the default Engine configuration, put your custom property file into /etc/sysconfig/ovirt-engine The reason behind this change is that path information for UI plugin data and configuration is typically machine-specific, and should be customizable per machine through Engine local configuration. 1. New plugin API function: addMainTabActionButton The "addMainTabActionButton" API adds custom context-sensitive button to the given main tab's data grid, along with corresponding data grid context menu item. addMainTabActionButton(entityTypeName, label, actionButtonInterface) entityTypeName indicates which main tab's data grid the button should be added to, according to the entity type associated with the main tab. entityTypeName values are strings reflecting org.ovirt.engine.ui.webadmin.plugin.entityEntityType enum members. Following entityTypeName values are currently supported (values are case-sensitive): "DataCenter", "Cluster", "Host", "Storage", "Disk", "VirtualMachine", "Template". Note: "Pool" value is currently not supported, because of org.ovirt.engine.core.common.businessentities.vm_pools entity not implementing the BusinessEntity interface, not sure why though. Maybe we should switch from BusinessEntity to IVdcQueryable interface and always cast getQueryableId method result value to Guid? label is the title displayed on the button . actionButtonInterface represents an object that "implements the button interface" by declaring its functions: onClick , isEnabled , isAccessible . All functions of actionButtonInterface receive currently selected item(s) as function arguments. Let's take a closer look at the concept behind actionButtonInterface . In traditional class-based object-oriented languages, such as Java, interface is an abstract type that contains method declarations without an implementation. A class that implements the given interface must implement all methods declared by that interface (unless it's an abstract class, but this isn't relevant in our case). In contrast with traditional class-based object-oriented languages, JavaScript supports OOP through prototype-based programming model (https://developer.mozilla.org/en-US/docs/JavaScript/Introduction_to_Object-…) At the same time, JavaScript language is dynamically-typed and therefore doesn't support traditional concept of interface in OOP, it uses "duck typing" technique instead (http://en.wikipedia.org/wiki/Duck_typing) The simplest way to provide an object that "implements the given interface" in JavaScript is to use "duck typing" technique: providing an object that contains well-known functions. In UI plugin infrastructure, I call this concept "interface object", represented by org.ovirt.engine.ui.webadmin.plugin.jsni.JsInterfaceObject class. Unlike the traditional concept of interface abstract type in object-oriented languages, an "interface object" does not necessarily have to declare all functions of the given interface in order to "implement" such interface. In fact, an empty object can be used as a valid "interface object". Missing functions will be simply treated as empty (no-op) functions. Furthermore, an "interface object" can "implement" multiple interfaces by declaring functions of those interfaces (interface composition). Getting back to "addMainTabActionButton" API, here's a sample code that adds new button to "Host" main tab data grid, as part of UiInit event handler function: UiInit: function () { api. addMainTabActionButton ('Host', 'Single-Host Action', // Action button interface object // All functions receive currently selected item(s) as function arguments { // Called when the user clicks the button onClick : function () { // Calling 'arguments[0]' is safe, because onClick() can be called // only when exactly one item is currently selected in the data grid window.alert('Selected host entity ID = ' + arguments[0].entityId); }, // Returning 'true' means the button is enabled (clickable) // Returning 'false' means the button is disabled (non-clickable) // Default value = 'true' isEnabled : function () { // Enable button only when exactly one item is selected return arguments.length == 1; }, // Returning 'true' means the button is visible // Returning 'false' means the button is hidden // Default value = 'true' isAccessible : function () { // Always show the button in the corresponding data grid return true ; } } ); } As mentioned above, all functions of an interface object are optional. For functions expecting return value, default value is defined by UI plugin infrastructure. For example: * onClick - no default value (no return value expected) * isEnabled / isAccessible - default value "true" (boolean return value expected) Note: UI plugin infrastructure checks the actual return value type, and uses default value in case the function returned something of wrong (unexpected) type. In the example above, "currently selected item(s)" maps to JSON-like representations of business entities currently selected in the corresponding data grid. For now, the entity representation is quite simple and same for all entity types: { entityId: "[BusinessEntityGuidAsString]" } In future, we will create specific JSON-like representations for specific business entities, in compliance with Engine REST API entity structure. For a more extensive example of using "addMainTabActionButton" API, please see the attached "addMainTabActionButton.html.example" file. 2. Improved plugin API function: addMainTab The "addMainTab" API was improved to address following issues: * "addMainTab" can now be called at any moment during UI plugin runtime, given that the plugin is allowed invoke plugin API functions (plugin is either INITIALIZING or IN_USE). Previously, "addMainTab" worked reliably only when called from within UiInit event handler function. Currently, it's possible to call "addMainTab" at any moment, e.g. from within some other event handler function (after UiInit has completed). * "addMainTab" now retains "active" tab (highlighted tab GUI). "addMainTab" works by adding new tab component (GWTP presenter proxy) and refreshing main tab panel GUI by removing all related tabs and re-adding them again. This logic is handled by org.ovirt.engine.ui.common.presenter.DynamicTabContainerPresenter class, which makes sure that "active" tab is retained even after main tab panel was refreshed. Furthermore, custom main tab implementation now displays the content of the given URL through HTML iframe element. 3. Improved native JavaScript function handling (GWT JSNI) This patch introduces org.ovirt.engine.ui.webadmin.plugin.jsni.JsFunction and org.ovirt.engine.ui.webadmin.plugin.jsni.JsFunctionResultHelper classes providing Java abstraction for invoking native JavaScript functions. These classes follow the general contract of "interface object" as mentioned above. JsFunctionResultHelper is particularly useful when dealing with functions which are expected to return value of a certain type. Too bad standard GWT JSNI classes don't provide such abstraction for working with native functions out-of-the-box... 4 . ActionPanel and ActionTable type hierarchy refactoring (related to "addMainTabActionButton" API) Previously, AbstractActionPanel and AbstractActionTable classes didn't implement any reasonable interface that would allow other components (client-side UI plugin infrastructure) to depend on their functionality in a loosely-coupled manner. This would make code that implements "addMainTabActionButton" API "ugly": main tab view interface would have to reference AbstractActionTable class directly. In MVP design pattern, view interface should avoid referencing specific GWT Widget classes directly. This patch introduces new interfaces for ActionPanel and ActionTable components while eliminating code redundancy (duplicate or unnecessary code). 5. ActionPanel type hierarchy refactoring (related to "addMainTab" API) Since org.ovirt.engine.ui.common.presenter.DynamicTabContainerPresenter defines new DynamicTabPanel interface that extends standard GWTP TabPanel interface, some refactoring had to be done in related ActionPanel classes. This patch makes sure that both org.ovirt.engine.ui.common.widget.tab.AbstractTabPanel (widget) and org.ovirt.engine.ui.common.view.AbstractTabPanelView (view) support DynamicTabPanel interface. Note that for now, only main tab panel (org.ovirt.engine.ui.webadmin.section.main.presenter.MainTabPanelPresenter) supports dynamic tabs within its view. Where is addSubTab API function? Implementing "addSubTab" API requires some more changes, and I didn't want to delay this PoC patch just because of it... Here's a sample code that illustrates proposed "addSubTab" API usage: UiInit: function () { api. addSubTab ('Host', // entityTypeName 'Custom Host Sub Tab', // label 'custom-host-sub-tab', // historyToken 'http://www.ovirt.org/', // contentUrl // Sub tab interface object // All functions receive currently selected item(s) // within the main tab data grid as function arguments { // Returning 'true' means the sub tab is visible // Returning 'false' means the sub tab is hidden // Default value = 'true' isAccessible : function () { return arguments.length == 1 && arguments[0].entityId == '<MyHostEntityId>' ; } } ); } As part of "addSubTab" API implementation, I'll refactor custom main tab components, in order to use one "tab type" for both main and sub tabs. Currently, we have one (and only one) "tab type" - a tab that shows content of the given URL through HTML iframe element. We could also create new "tab types", e.g. form-based tab that shows key/value pairs (IMHO this could be quite useful for custom sub tabs). Let me know what you think! Cheers, Vojtech ------=_Part_9716069_2003615259.1350571769689 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head><style type=3D'text/css'>p { margin: 0; }</style></head><body><= div style=3D'font-family: times new roman,new york,times,serif; font-size: = 12pt; color: #000000'>Hi guys, the latest revision of UI Plugins pro= of-of-concept patch is now available for you to experiment with. You can do= wnload the patch from oVirt Gerrit at http://gerrit.ovirt.org/#/c/8120/2 (p= atch set 2). Please read on to learn what's new in this revision. If= you have any comments, questions or ideas, please let me know! <hr = style=3D"width: 100%; height: 2px;"> 0. UI plugin path informati= on resolved using local Engine configuration Server-side UI plugin infrastructure now uses local (machine= -specific) Engine configuration instead of global (vdc_options dat= abase table) Engine configuration: <ul><li>Previously, path information = was resolved through org.ovirt.engine.core.common.config.Config=20 class - Engine configuration values were retrieved from vdc_options database table.</li><li>Currently, path= information is resolved through org.ovirt.engine.core.utils.LocalConfig=20 class - Engine configuration values are retrieved from local file system.</li></ul>In case you're not working with oVirt Engine through= RPM package system, e.g. you have a local development environment set up a= nd you build and deploy oVirt Engine through Maven, please follow these ste= ps: a. Copy default Engine configuration into /usr/share/ovirt-engine/conf <div style=3D"margi= n-left: 40px; font-family: courier new,courier,monaco,monospace,sans-serif;= "># mkdir -p /usr/share/ovirt-engine/conf # cp <OVIRT_HOME>/backen= d/manager/conf/engine.conf.defaults /usr/share/ovirt-engine/conf/engine.con= f.defaults</div> b. If necessary, copy UI plugin data files from /usr/sh= are/engine/ui-plugins to /usr/share/ovir= t-engine/ui-plugins c. If necessary, copy UI plugin config fi= les from /etc/engine/ui-plugins to /etc/= ovirt-engine/ui-plugins d, In case you want to override the d= efault Engine configuration, put your custom property file into /etc/syscon= fig/ovirt-engine The reason behind this change is that path informat= ion for UI plugin data and configuration is typically machine-specific, and= should be customizable per machine through Engine local configuration. = <hr style=3D"width: 100%; height: 2px;"> 1. New plugin API function: addMainTabActionButton The "addMainTabActionButton" API adds custom co= ntext-sensitive button to the given main tab's data grid, along with corres= ponding data grid context menu item. addMainTabActionButton(entit= yTypeName, label, actionButtonInterface) entityTypeName indicates which main tab's data gr= id the button should be added to, according to the entity type associated w= ith the main tab. entityTypeName= values are strings reflecting org.ovirt.engine.ui.webadmin.plugin.entityEn= tityType enum members. Following entity= TypeName values are currently supported (values are case-sensitive):= "DataCenter", "Cluster", "Host", "Storage", "Disk", "VirtualMachine", "Tem= plate". Note: "Pool" value is currently not supported, because of or= g.ovirt.engine.core.common.businessentities.vm_pools entity not implementin= g the BusinessEntity interface, not sure why though. Maybe we should switch= from BusinessEntity to IVdcQueryable interface and always cast getQueryabl= eId method result value to Guid? label is the title displayed on the button. actionButton= Interface represents an object that "implements the button interface= " by declaring its functions: onClick</= span>, isEnabled, isAccessible. All functions of actionButtonInterface receive currently selecte= d item(s) as function arguments. Let's take a closer look at the con= cept behind actionButtonInterface</span= >. In traditional class-based object-oriented languages, such as Java, inte= rface is an abstract type that contains method declarations without an impl= ementation. A class that implements the given interface must implement all = methods declared by that interface (unless it's an abstract class, but this= isn't relevant in our case). In contrast with traditional class-bas= ed object-oriented languages, JavaScript supports OOP through prototype-bas= ed programming model (https://developer.mozilla.org/en-US/docs/JavaScript/I= ntroduction_to_Object-Oriented_JavaScript). At the same time, JavaScript la= nguage is dynamically-typed and therefore doesn't support traditional conce= pt of interface in OOP, it uses "duck typing" technique instead (http://en.= wikipedia.org/wiki/Duck_typing) The simplest way to provide an obje= ct that "implements the given interface" in JavaScript is to use "duck typi= ng" technique: providing an object that contains well-known functions. In U= I plugin infrastructure, I call this concept "interface object", represente= d by org.ovirt.engine.ui.webadmin.plugin.jsni.JsInterfaceObject class. Unli= ke the traditional concept of interface abstract type in object-oriented la= nguages, an "interface object" does not necessarily have to declare all = functions of the given interface in order to "implement" such interface= . In fact, an empty object can be used as a valid "interface object". Missi= ng functions will be simply treated as empty (no-op) functions. Furthermore= , an "interface object" can "implement" multiple interfaces by declaring fu= nctions of those interfaces (interface composition). Getting back to= "addMainTabActionButton" API, here's a sample code that adds new button to= "Host" main tab data grid, as part of UiInit event handler function: <b= r>UiInit: func= tion() {     api.addMainTabActionButton('Host', 'Single-Hos= t Action',    =      // Action button interface object  &n= bsp;      // All functions receive currently selec= ted item(s) as function arguments         {             // Cal= led when the user clicks the button        &nb= sp;    onClick: <sp= an style=3D"font-weight: bold; color: rgb(153, 0, 0);">function() {<= br>      &nb= sp;         // Calling 'arguments[0]' is safe, bec= ause onClick() can be called        &= nbsp;        // only when exactly one item is curr= ently selected in the data grid  &n= bsp;          &= nbsp;   window.alert('Selected host entity ID =3D ' + a= rguments[0].entityId);         <s= pan style=3D"font-family: courier new,courier,monaco,monospace,sans-serif;"= >    }, &n= bsp;           // Returning 'true' means= the button is enabled (clickable)           &= nbsp; // Returning 'false' means the button is disabled (non-clickable)</sp= an>    &nbs= p;        // Default value =3D 'true'</s= pan>             = isEnabled: function() { </= span>       &n= bsp;        // Enable button only when exactly one= item is selected     </spa= n>          &nbsp= ; retur= n arguments.length =3D=3D 1;         <= /span>    },             // Returning 'tru= e' means the button is visible       &nbsp= ;     // Returning 'false' means the button is hidden</= span>      =       // Default value =3D 'true'           &n= bsp; isAccessible: = function()= {       =           // Always show the button in the co= rresponding data grid     <= /span>          &= nbsp; r= eturn true= ;         &nb= sp;   }      &nb= sp;  }     ); } <b= r>As mentioned above, all functions of an interface object are optional. Fo= r functions expecting return value, default value is defined by UI plugin i= nfrastructure. For example: <ul><li>onClick - no default value (no retur= n value expected)</li><li>isEnabled / isAccessible - default value "true" (= boolean return value expected)</li></ul>Note: UI plugin infrastru= cture checks the actual return value type, and uses default value in case t= he function returned something of wrong (unexpected) type. In th= e example above, "currently selected item(s)" maps to JSON-like representat= ions of business entities currently selected in the corresponding data grid= . For now, the entity representation is quite simple and same for all entit= y types: { entityId: "[BusinessEntityGuidAsString]" } = In future, we will create specific JSON-like representations for specific b= usiness entities, in compliance with Engine REST API entity structure. <= br>For a more extensive example of using "addMainTabActionButton" API, plea= se see the attached "addMainTabActionButton.html.example" file. <hr = style=3D"width: 100%; height: 2px;"> = 2. Improved plugin API function: addMainTab The "addMainTab" API was improved to address following issues:<= br><ul><li>"addMainTab" can now be called at any moment during UI plugin ru= ntime, given that the plugin is allowed invoke plugin API functions (plugin= is either INITIALIZING or IN_USE). Previously, "addMainTab" worked reli= ably only when called from within UiInit event handler function. Current= ly, it's possible to call "addMainTab" at any moment, e.g. from within some= other event handler function (after UiInit has completed).</li></ul><ul><l= i>"addMainTab" now retains "active" tab (highlighted tab GUI). "addMainT= ab" works by adding new tab component (GWTP presenter proxy) and refreshing= main tab panel GUI by removing all related tabs and re-adding them again.<= br>This logic is handled by org.ovirt.engine.ui.common.presenter.DynamicTab= ContainerPresenter class, which makes sure that "active" tab is retained ev= en after main tab panel was refreshed. </li></ul>Furthermore, cus= tom main tab implementation now displays the content of the given URL throu= gh HTML iframe element. <hr style=3D"width: 100%; height: 2px;"> = 3. Improved native JavaScript function h= andling (GWT JSNI) This patch introduces org.ovirt.engine.ui.= webadmin.plugin.jsni.JsFunction and org.ovirt.engine.ui.webadmin.plugin.jsn= i.JsFunctionResultHelper classes providing Java abstraction for invoking na= tive JavaScript functions. These classes follow the general contract of "in= terface object" as mentioned above. JsFunctionResultHelper is partic= ularly useful when dealing with functions which are expected to return valu= e of a certain type. Too bad standard GWT JSNI classes don't provide such a= bstraction for working with native functions out-of-the-box... <hr s= tyle=3D"width: 100%; height: 2px;"> 4= . ActionPanel and ActionTable type hierarchy refactoring (related to= "addMainTabActionButton" API) Previous= ly, AbstractActionPanel and AbstractActionTable classes didn't implement an= y reasonable interface that would allow other components (client-side UI pl= ugin infrastructure) to depend on their functionality in a loosely-coupled = manner. This would make code that implements "addMainTabActionButton" API "= ugly": main tab view interface would have to reference AbstractActionTable = class directly. In MVP design pattern, view interface should avoid referenc= ing specific GWT Widget classes directly. This patch introduces new = interfaces for ActionPanel and ActionTable components while eliminating cod= e redundancy (duplicate or unnecessary code). <hr style=3D"width: 10= 0%; height: 2px;"> 5. ActionPanel typ= e hierarchy refactoring (related to "addMainTab" API) Since o= rg.ovirt.engine.ui.common.presenter.DynamicTabContainerPresenter defines ne= w DynamicTabPanel interface that extends standard GWTP TabPanel interface, = some refactoring had to be done in related ActionPanel classes. This= patch makes sure that both org.ovirt.engine.ui.common.widget.tab.AbstractT= abPanel (widget) and org.ovirt.engine.ui.common.view.AbstractTabPanelView (= view) support DynamicTabPanel interface. Note that for now, only mai= n tab panel (org.ovirt.engine.ui.webadmin.section.main.presenter.MainTabPan= elPresenter) supports dynamic tabs within its view. <hr style=3D"wid= th: 100%; height: 2px;"> Where is add= SubTab API function? Implementing "addSubTab" API requires so= me more changes, and I didn't want to delay this PoC patch just because of = it... Here's a sample code that illustrates proposed "addSubTab" API= usage: UiInit: function() {     api.addSubTab('Host',        // entityTypeName    =      'Custom Host Sub Tab',   // label      &n= bsp;  'custom-host-sub-tab',   // historyToken         '= http://www.ovirt.org/', // contentUr= l         // Sub tab int= erface object         // </spa= n>All functions receive currently= selected item(s)         // within t= he main tab data grid as function arguments         {   &nbs= p;         // Returning 'true' means the sub tab i= s visible             // Retur= ning 'false' means the sub tab is hidden           &nbs= p; // Default value =3D 'true'           &n= bsp; isAccessible: = function()= {         <spa= n style=3D"font-family: courier new,courier,monaco,monospace,sans-serif;">&= nbsp;       return arguments.length= =3D=3D 1 && arguments[0].entityId =3D=3D '<= MyHostEntityId>';             = }         }     ); } As part of "addSubTab" API implementation, I'll refactor= custom main tab components, in order to use one "tab type" for both main a= nd sub tabs. Currently, we have one (and only one) "tab type" - a ta= b that shows content of the given URL through HTML iframe element. W= e could also create new "tab types", e.g. form-based tab that shows key/val= ue pairs (IMHO this could be quite useful for custom sub tabs). <hr = style=3D"width: 100%; height: 2px;"> Let me know what you think! = Cheers, Vojtech </div></body></html> ------=_Part_9716069_2003615259.1350571769689-- ------=_Part_9716068_484635069.1350571769689 Content-Type: application/x-compressed-tar; name=poc-6-examples.tar.gz Content-Disposition: attachment; filename=poc-6-examples.tar.gz Content-Transfer-Encoding: base64 H4sIAGMRgFAAA+2WXU/bMBSGuU1/xZl2kVSUJKWlSFCQOmAaF2iTYBcT4yJNTOIttSPboesQ/33H SQv9IApsFQPJz0X9bR+f8x6nQRSdBZRdBEM3UaPUJb+CUZaSjXXiI71utyh3e4ulpoP19rbf9f22 v9PB/vaOv729Af5aragglyoQABs38jcPZfW8uvE3Sv/d8eeji29fTkCH/7DRnxUkiLCQoaCZOmxY N+ikIKNwAFkgCFNuluYxZYOMOvY153Zzv2HhuCtITKUiwrltWNZXesqo2oPrnIWKcuY0QXcXE4N7 4Tn2R84BK3YL9F5bqqwmSmV7njcej11+Q4VyuYi94iDrrmHdPZwYRBMHW31vZm3fm5o/5NFEN2dl ebn/7fPXxEMYBkWIPuRKcbbet6Am/7vtdu8+/zs9H/N/t7Pjm/x/CdaR/8NAPC//PQ/OqZYWDAu5 rb4J82J07KM013vqR2HAJlvTJpSTsPe2ATVwdpTS8OeSKXWrZowpi/jYDVIilGNfJEQQQC+ADZtY xvkIHSLdlLBYJdhlQ1ha6MgmSJKSUJFIe6junLtW7RQqT1gwTEn0l1cRROWCgRI5WZM9gzAkUlK0 6UVMqpyhPwhTcZW6AVJ6CsYJYSApi1FwVJERGn0fljrpfeJSad2dF8u3dHNed7jaelxbesRaFM75 9ExI9C6oGaomcHqMObUgpEv/yi0HT6Pia4ffu1ZRVAW/OGvqxhU9HhxAe2mXypDNb1TGo1inf2vc O+KYDyoJGKbaI16uCtpTXH+Wp4queL5OKP+W8fq5G8kYQ3P5lHzXAZ1P9j37ql7KM665AEcfqF9X vwW4L1aWz9nH4b4ew8rm5nPuMgPv42a5TBz7Oyu8+V7fhxYXqBYjXRDjU8+qTtNlFlJEm/iDUwy+ 3XxV7+VK1A91Uq3Fvtf0fpp/1gaDwWAwGAwGg8FgMBgMBoPBYDAYDG+dP/59M0oAKAAA ------=_Part_9716068_484635069.1350571769689--

4 11

[Engine-devel] Cancelled: ovirt network
by Livnat Peer 24 Oct '12

24 Oct '12

------=_Part_1266476_408980827.1351085096193 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit A single instance of the following meeting has been cancelled: Subject: ovirt network Organiser: "Livnat Peer" <lpeer(a)redhat.com> Time: Wednesday, 24 October, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem Invitees: engine-devel(a)ovirt.org; vdsm-devel(a)lists.fedorahosted.org; GARGYA(a)de.ibm.com; dyasny(a)redhat.com; simon(a)redhat.com; mkolesni(a)redhat.com; atal(a)redhat.com; ilvovsky(a)redhat.com; dfediuck(a)redhat.com; pradipta.banerjee(a)gmail.com; gkotton(a)redhat.com ... *~*~*~*~*~*~*~*~*~* Hi All, Due to day-light saving change in Israel this meeting collides with ovirt sync meeting this week. I am cancelling this instance of the meeting, If there is a specific items you'd like to discuss related to networking please reply and we'll schedule a dedicated meeting. Thanks, Livant ------=_Part_1266476_408980827.1351085096193 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit <html><body><h3>A single instance of the following meeting has been cancelled:</h3> <table border='0'> <tr><th align=left>Subject:</th><td>ovirt network </td></tr> <tr><th align=left>Organiser:</th><td>"Livnat Peer" <lpeer(a)redhat.com> </td></tr> </table> <table border='0'> <tr><th align=left>Time:</th><td>Wednesday, 24 October, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem </td></tr></table> <table border='0'> <tr><th align=left>Invitees:</th><td>engine-devel(a)ovirt.org; vdsm-devel(a)lists.fedorahosted.org; GARGYA(a)de.ibm.com; dyasny(a)redhat.com; simon(a)redhat.com; mkolesni(a)redhat.com; atal(a)redhat.com; ilvovsky(a)redhat.com; dfediuck(a)redhat.com; pradipta.banerjee(a)gmail.com; gkotton(a)redhat.com ... </td></tr> </table> <div>*~*~*~*~*~*~*~*~*~*</div> Hi All, Due to day-light saving change in Israel this meeting collides with ovirt sync meeting this week. I am cancelling this instance of the meeting, If there is a specific items you'd like to discuss related to networking please reply and we'll schedule a dedicated meeting. Thanks, Livant</body></html> ------=_Part_1266476_408980827.1351085096193 Content-Type: text/calendar; charset=utf-8; method=CANCEL; name=meeting.ics Content-Transfer-Encoding: 7bit BEGIN:VCALENDAR PRODID:Zimbra-Calendar-Provider VERSION:2.0 METHOD:CANCEL BEGIN:VTIMEZONE TZID:Asia/Jerusalem BEGIN:STANDARD DTSTART:19710101T020000 TZOFFSETTO:+0200 TZOFFSETFROM:+0300 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=9;BYDAY=4SU TZNAME:IST END:STANDARD BEGIN:DAYLIGHT DTSTART:19710101T020000 TZOFFSETTO:+0300 TZOFFSETFROM:+0200 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=-1FR TZNAME:IDT END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT UID:cfd70d5d-b663-41f3-b72a-15b532782b23 SUMMARY:Cancelled: ovirt network COMMENT:A single instance of a recurring meeting has been cancelled. ATTENDEE;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE:mailto:engine- devel(a)ovirt.org ATTENDEE;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE:mailto:vdsm-de vel(a)lists.fedorahosted.org ATTENDEE;CN=Tony Gargya/Germany/IBM;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTI ON;RSVP=TRUE:mailto:GARGYA@de.ibm.com ATTENDEE;CN=Dan Yasny;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRUE:mail to:dyasny@redhat.com ATTENDEE;CN=Simon Grinberg;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE: mailto:simon@redhat.com ATTENDEE;CN=Mike Kolesnik;PARTSTAT=ACCEPTED:mailto:mkolesni@redhat.com ATTENDEE;CN=Avi Tal;PARTSTAT=ACCEPTED:mailto:atal@redhat.com ATTENDEE;CN=Igor Lvovsky;PARTSTAT=ACCEPTED:mailto:ilvovsky@redhat.com ATTENDEE;CN=Doron Fediuck;PARTSTAT=ACCEPTED:mailto:dfediuck@redhat.com ATTENDEE;CN=Pradipta Kumar Banerjee;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED:m ailto:pradipta.banerjee@gmail.com ATTENDEE;CN=Gary Kotton;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED:mailto:gkotto n(a)redhat.com ATTENDEE;CN=Keith Robertson;PARTSTAT=ACCEPTED:mailto:kroberts@redhat.com ATTENDEE;CN=Antoni Segura Puimedon;PARTSTAT=ACCEPTED:mailto:asegurap@redhat. com ATTENDEE;CN=Thang Pham/Poughkeepsie/IBM;SENT-BY="mailto:thang.pham@us.ibm.co m";PARTSTAT=ACCEPTED:mailto:thang.pham@us.ibm.com ORGANIZER;CN=Livnat Peer:mailto:lpeer@redhat.com DTSTART;TZID="Asia/Jerusalem":20121024T160000 DTEND;TZID="Asia/Jerusalem":20121024T170000 STATUS:CANCELLED CLASS:PUBLIC X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY TRANSP:OPAQUE RECURRENCE-ID;TZID="Asia/Jerusalem":20121024T160000 LAST-MODIFIED:20121024T132456Z DTSTAMP:20121024T132456Z SEQUENCE:2 DESCRIPTION:A single instance of the following meeting has been cancelled:\n \nSubject: ovirt network \nOrganiser: "Livnat Peer" <lpeer(a)redhat.com> \n\n Time: Wednesday\, 24 October\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jer usalem\n \nInvitees: engine-devel(a)ovirt.org\; vdsm-devel(a)lists.fedorahosted. org\; GARGYA(a)de.ibm.com\; dyasny(a)redhat.com\; simon(a)redhat.com\; mkolesni@re dhat.com\; atal(a)redhat.com\; ilvovsky(a)redhat.com\; dfediuck(a)redhat.com\; pra dipta.banerjee(a)gmail.com\; gkotton(a)redhat.com ... \n\n\n*~*~*~*~*~*~*~*~*~*\ n\nHi All\,\nDue to day-light saving change in Israel this meeting collides with ovirt sync meeting this week.\n\nI am cancelling this instance of the m eeting\, If there is a specific items you'd like to discuss related to netwo rking please reply and we'll schedule a dedicated meeting.\n\nThanks\, Livan t X-ALT-DESC;FMTTYPE=text/html:<html><body><h3>A single instance of the follow ing meeting has been cancelled:</h3>\n\n\n<table border='0'>\n<tr><th ali gn=left>Subject:</th><td>ovirt network </td></tr>\n<tr><th align=left>Organ iser:</th><td>"Livnat Peer" &lt\;lpeer(a)redhat.com&gt\; </td></tr>\n</table>\ n\n<table border='0'>\n<tr><th align=left>Time:</th><td>Wednesday\, 24 Oc tober\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem\n </td></tr></ta ble>\n\n<table border='0'>\n<tr><th align=left>Invitees:</th><td>engine-d evel(a)ovirt.org\; vdsm-devel(a)lists.fedorahosted.org\; GARGYA(a)de.ibm.com\; dya sny(a)redhat.com\; simon(a)redhat.com\; mkolesni(a)redhat.com\; atal(a)redhat.com\; ilvovsky(a)redhat.com\; dfediuck(a)redhat.com\; pradipta.banerjee(a)gmail.com\; gk otton(a)redhat.com ... </td></tr>\n</table>\n<div>*~*~*~*~*~*~*~*~*~*</div> Hi All\, Due to day-light saving change in Israel this meeting collides with ovirt sync meeting this week. I am cancelling this instance of t he meeting\, If there is a specific items you'd like to discuss related to n etworking please reply and we'll schedule a dedicated meeting. Thanks \, Livant</body></html> END:VEVENT END:VCALENDAR ------=_Part_1266476_408980827.1351085096193--

1 0

[Engine-devel] AsyncTaskManager and the irsbroker
by Laszlo Hornyak 24 Oct '12

24 Oct '12

hi, I have just noticed that AsyncTaskManager is - almost all of the public methods are synchronized - and it is singleton - calling to VDS operations (line 291) Therefore this may be a performance bottleneck. Even when you want to create an asynchronous task or query a task's state, you may have to wait till a remote vdsm responds. Would it be ok to remove the synchronization from e.g. the query-like methods? Or the one initiating remote calls? Laszlo

2 1

[Engine-devel] Quota in 3.2 - design
by Ofri Masad 23 Oct '12

23 Oct '12

Hi, The new design for quota in 3.2 is available here: http://wiki.ovirt.org/wiki/Features/Design/Quota-3.2 Most of the changes would be in the backend. Feedbacks would be more than welcome. We are trying to make quota more inherent (more framework like) and easier to handle when you create a new command. Other than the design described in the wiki, we thought of two other designs which would help us identify the commands which are dependent on quota: 1. Using annotations - by this approach we would add an annotation to the command class telling us it's a quota consumer and a second annotation to the method returning the consumption parameters. 2. Using just interfaces without the markings in VdcActionType (this is the current implementation) - in this case the implemented interfaces are inherited by extending commands. So if one inherits some command without handling the quota parameters - we get wrong quota consumption and even holes in the quota. again, any feedbacks would be more than welcome. Thanks ahead, Ofri

1 0

[Engine-devel] git-review
by Saggi Mizrahi 22 Oct '12

22 Oct '12

I've recently encountered more and more people not using the git-review tool and manually pushing their changes to Gerrit using raw git commands. Even though there is nothing wrong with doing things the hard way. I prefer not using an overly complicated error prone way to interact with Gerrit. Last I checked the version of git-review in Fedora is broken but I suggest using pip anyway as it is always synced with the master branch. Also, please use topics. Either use a BZ# or a topic codename (eg. live_migration, vdsm_api, nfs4_support) so people can skim the review list for topics they might want to review. Be careful, it automatically uses current the branch name (unless you use -t) so if you giving your branches funny names (I know I do) don't forget to manually specify a topic. More information. http://wiki.openstack.org/GerritWorkflow https://github.com/openstack-ci/git-review

1 0