November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: db: add a common function for index creation
by emesika＠redhat.com 12 Nov '14

12 Nov '14

Eli Mesika has submitted this change and it was merged. Change subject: db: add a common function for index creation ...................................................................... db: add a common function for index creation This patch adds a common function that drop the index if exists and creates it after that. This is done in order to prevent scripts failures when the index is not dropped and an attempt to re-create it is done Change-Id: I6e6e2577ceac435e25030dfde6ff6c4c3f8a7278 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Allon Mureinik: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e6e2577ceac435e25030dfde6ff6c4c3f8a7278 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: janitorial: guest monitor: simplify getGuestName()
by alitke＠redhat.com 12 Nov '14

12 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: janitorial: guest monitor: simplify getGuestName() ...................................................................... janitorial: guest monitor: simplify getGuestName() The get() method of the dictionaries has the same semantic of the old method, but just one line of code. Change-Id: I73e2fd6e6eb97cc51d28f70c8ade818fdc74e0be Signed-off-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/31588 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/GuestMonitor.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Adam Litke: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/31588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73e2fd6e6eb97cc51d28f70c8ade818fdc74e0be Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: Add valid function to the policy parser
by alitke＠redhat.com 12 Nov '14

12 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: Add valid function to the policy parser ...................................................................... Add valid function to the policy parser This new valid function accepts any number of arguments and returns True when none of the arguments evaluates to nil (None). It returns False in all other cases. The Common Lisp way of doing this is by using higher order functions like this: (every #'null my-list) Our parser lacks support for such constructs so I decided to add the new function. This will allow us to escape parts of the policy with checks for the presence of optional collector fields. For example: (if (valid guest.balloon_min guest.balloon_cur) (process_ballooning)) Change-Id: I5aa31886811593860c75cf13bf7743e85fde7358 Related-To: https://bugzilla.redhat.com/1143992 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/34791 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Policy/Parser.py M tests/ParserTests.py 2 files changed, 60 insertions(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/34791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aa31886811593860c75cf13bf7743e85fde7358 Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: Documentation: document the mandatory field behavior
by alitke＠redhat.com 12 Nov '14

12 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: Documentation: document the mandatory field behavior ...................................................................... Documentation: document the mandatory field behavior Make it clear how mandatory field absence should be affect the policy. Change-Id: Iba2f96ec6edca93002dd79ca7c66c4f1ab411141 Bug-Url: https://bugzilla.redhat.com/1143992 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35011 Reviewed-by: Martin Sivák <msivak(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> Tested-by: Adam Litke <alitke(a)redhat.com> --- M mom/Collectors/Collector.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba2f96ec6edca93002dd79ca7c66c4f1ab411141 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: validate vmNotDuringSnapshot on LiveMigrateVmDisks
by derez＠redhat.com 12 Nov '14

12 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: core: validate vmNotDuringSnapshot on LiveMigrateVmDisks ...................................................................... core: validate vmNotDuringSnapshot on LiveMigrateVmDisks LiveMigrateVmDisksCommand: valifate VM is not during snapshot on canDoAction. Change-Id: Ide91ad3042bbf0889ba948763ce88444045fc104 Bug-Url: https://bugzilla.redhat.com/1162120 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide91ad3042bbf0889ba948763ce88444045fc104 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: filter shareable disks on preview snapshot
by derez＠redhat.com 12 Nov '14

12 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: core: filter shareable disks on preview snapshot ...................................................................... core: filter shareable disks on preview snapshot TryBackToAllSnapshotsOfVm -> getImagesToPreview: filter out shareable/nonsnapable disks. Change-Id: I232d3387e203933bdbb12a5e3401c096278a41d3 Bug-Url: https://bugzilla.redhat.com/1161916 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I232d3387e203933bdbb12a5e3401c096278a41d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: exportfs after restarting nfs services
by piotr.kliczewski＠gmail.com 12 Nov '14

12 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: exportfs after restarting nfs services ...................................................................... packaging: setup: exportfs after restarting nfs services Bug-Url: https://bugzilla.redhat.com/1163395 Change-Id: I4d231c28d2fd2e28163fbe382debbf080628d9b9 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit f179315e6a77e27b3d9894ec8d20ebfd3aa1a461) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d231c28d2fd2e28163fbe382debbf080628d9b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: exportfs after restarting nfs services
by sbonazzo＠redhat.com 12 Nov '14

12 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: exportfs after restarting nfs services ...................................................................... packaging: setup: exportfs after restarting nfs services Change-Id: I4d231c28d2fd2e28163fbe382debbf080628d9b9 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d231c28d2fd2e28163fbe382debbf080628d9b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Add some usage documentation
by juan.hernandez＠redhat.com 12 Nov '14

12 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add some usage documentation ...................................................................... sdk: Add some usage documentation This patch improves the README.md file adding some documentation about how to use the SDK with Maven, and about the dependencies required. Change-Id: Ic4b76369f4573465c6779e249664b104275e99e6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 25eddda411974849fbb3ea423298e085b1dd2ada) --- M ovirt-engine-sdk-java/README.md 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4b76369f4573465c6779e249664b104275e99e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Add some usage documentation
by juan.hernandez＠redhat.com 12 Nov '14

12 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add some usage documentation ...................................................................... sdk: Add some usage documentation This patch improves the README.md file adding some documentation about how to use the SDK with Maven, and about the dependencies required. Change-Id: Ic4b76369f4573465c6779e249664b104275e99e6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/README.md 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4b76369f4573465c6779e249664b104275e99e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0