November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Refactor network compliance enforcement
by masayag＠redhat.com 12 Nov '14

12 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Refactor network compliance enforcement ...................................................................... engine: Refactor network compliance enforcement The motivation of this change is: 1. To decouple network incompatibility auditing from the network compliance check. 2. To extract clusterNetworks which will be used by the network interfaces topology persisters in the following patches. Change-Id: I5ced33a7ddfe71ea1c69ef5a18cbf468c126ec1c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/34565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ced33a7ddfe71ea1c69ef5a18cbf468c126ec1c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Lay foundation for method refactor
by masayag＠redhat.com 12 Nov '14

12 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Lay foundation for method refactor ...................................................................... engine: Lay foundation for method refactor Extracts the clusterNetworks into an argument, so auditNetworkCompliance would be pulled out of this method. Change-Id: I3907cde04cc5c90d47958871b177f5aa61e83ae1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/34564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3907cde04cc5c90d47958871b177f5aa61e83ae1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract method of network compliance check
by masayag＠redhat.com 12 Nov '14

12 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract method of network compliance check ...................................................................... engine: Extract method of network compliance check Change-Id: Iadc66b853055b7237f9dbe78793f53bb20299b04 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/34563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadc66b853055b7237f9dbe78793f53bb20299b04 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Support replacements in ValidationResult
by masayag＠redhat.com 12 Nov '14

12 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Support replacements in ValidationResult ...................................................................... engine: Support replacements in ValidationResult The static validation methods of ValidationResult are enhanced with the support of replacements, which are already supported by the ValidationResult instantiation. Change-Id: I5f2bd85af2d129e0647b100b90908a1314419da2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ValidationResultTest.java 2 files changed, 43 insertions(+), 23 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified Objections: Yevgeny Zaspitsky: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/34855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f2bd85af2d129e0647b100b90908a1314419da2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: filters: fix formatting
by oourfali＠redhat.com 12 Nov '14

12 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: filters: fix formatting ...................................................................... aaa: filters: fix formatting Change-Id: I03ee9a1e9c7c57751eb206e633efeef721fe98ef Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ee9a1e9c7c57751eb206e633efeef721fe98ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Warning message for cloning a VM with LUN.
by tnisan＠redhat.com 12 Nov '14

12 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Warning message for cloning a VM with LUN. ...................................................................... webadmin: Warning message for cloning a VM with LUN. When cloning a VM with an attached LUN, a warning message added which informs the user that the LUN won't be cloned as well. the user should know this when cloning a VM. Change-Id: Icb2d5205baaadd17646b5076bf5f3add481f0709 Bug-Url: https://bugzilla.redhat.com/1152023 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloneVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 4 files changed, 55 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/35073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb2d5205baaadd17646b5076bf5f3add481f0709 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: New tests for AddVmTemplateCommand
by tnisan＠redhat.com 12 Nov '14

12 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: New tests for AddVmTemplateCommand ...................................................................... core: New tests for AddVmTemplateCommand While making a new template based on a VM, providing the template's allocated disks' alias as an empty string is now disabled. The user should not be able to create a template with disks that have an empty alias. This patch adds tests to AddVmTemplateCommandTest to verify that this will be disabled at the backend level. Change-Id: I614239c750096b1c3585e0e56bc0d77d328e4c8f Bug-Url: https://bugzilla.redhat.com/1110304 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java 1 file changed, 48 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/35074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I614239c750096b1c3585e0e56bc0d77d328e4c8f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: New tests for AddVmTemplateCommand
by tnisan＠redhat.com 12 Nov '14

12 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: New tests for AddVmTemplateCommand ...................................................................... core: New tests for AddVmTemplateCommand While making a new template based on a VM, providing the template's allocated disks' alias as an empty string is now disabled. The user should not be able to create a template with disks that have an empty alias. This patch adds tests to AddVmTemplateCommandTest to verify that this will be disabled at the backend level. Change-Id: I614239c750096b1c3585e0e56bc0d77d328e4c8f Bug-Url: https://bugzilla.redhat.com/1110304 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java 1 file changed, 48 insertions(+), 0 deletions(-) Approvals: Amit Aviram: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I614239c750096b1c3585e0e56bc0d77d328e4c8f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: When ISO domain is attached to multiple DCs it appears...
by tnisan＠redhat.com 12 Nov '14

12 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: When ISO domain is attached to multiple DCs it appears multiple times ...................................................................... core: When ISO domain is attached to multiple DCs it appears multiple times In the storage main tab, when an ISO domain is attached to multipe data center, it appears in the list one time for each data centers Change-Id: I0b874fc33c660af29c2e20a15898444db12f6f6b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1150525 --- M packaging/dbscripts/create_views.sql 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b874fc33c660af29c2e20a15898444db12f6f6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: iscsi: add HE disk to the engine as direct lun
by sbonazzo＠redhat.com 12 Nov '14

12 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: iscsi: add HE disk to the engine as direct lun ...................................................................... iscsi: add HE disk to the engine as direct lun Add Hosted Engine disk to the engine as direct lun in order to allow the engine to know about the LUN used by Hosted engine, so the engine can block actions like: - import the hosted-engine's storage domain - put the iSCSI domain in maintenance while the hosted-engine is installed on it - pick the lun for storage domain creation/extension Change-Id: I9c5640bde713fc4d09cf74a7037c62e833495934 Bug-Url: https://bugzilla.redhat.com/1157243 Bug-Url: https://bugzilla.redhat.com/1157239 Bug-Url: https://bugzilla.redhat.com/1157238 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 376fa6d76082460b8f7843a580562921af5c0485) --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/Makefile.am M src/plugins/ovirt-hosted-engine-setup/engine/__init__.py A src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py 6 files changed, 218 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c5640bde713fc4d09cf74a7037c62e833495934 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0