March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Disabling unsupported storage types when adding a ...
by derez＠redhat.com 15 Mar '15

15 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disabling unsupported storage types when adding a domain. ...................................................................... webadmin: Disabling unsupported storage types when adding a domain. Some storage types are unsupported for low DC versions. still, these storage types are currently available for choosing when creating a new domain in a DC. This patch adds a limitation in the StorageModel for the available storage types to choose from in the new domain window. Change-Id: I5fcc131454e0722fbf8d6e84607a71381e1d04fb Bug-Url: https://bugzilla.redhat.com/1136789 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/FileStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/IStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 7 files changed, 38 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Amit Aviram: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fcc131454e0722fbf8d6e84607a71381e1d04fb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Suppress warnings in CommandCoordinatorImpl
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Suppress warnings in CommandCoordinatorImpl ...................................................................... engine: Suppress warnings in CommandCoordinatorImpl Change-Id: I4ff79870443e2e24ed31cecf5269d0a1b7285868 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ff79870443e2e24ed31cecf5269d0a1b7285868 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Javanize SPMAsyncTask
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Javanize SPMAsyncTask ...................................................................... engine: Javanize SPMAsyncTask * Declare class variable at the beginning of the class * Use proper naming convention * Initial members in c'tor Change-Id: I2c76afd1779dff9d80fb97adbf81f9ae30741324 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java 1 file changed, 27 insertions(+), 32 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c76afd1779dff9d80fb97adbf81f9ae30741324 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove redundant modifier from CommandContextsCache
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove redundant modifier from CommandContextsCache ...................................................................... engine: Remove redundant modifier from CommandContextsCache Change-Id: I9b949038082dcd5e67a39b6daecb1cf99ba75af3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandContextsCache.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b949038082dcd5e67a39b6daecb1cf99ba75af3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Format AsyncCommandCallBack
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Format AsyncCommandCallBack ...................................................................... engine: Format AsyncCommandCallBack Change-Id: Ia86a756c3ed3ec52763ab72bce03eab513da5c49 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallBack.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86a756c3ed3ec52763ab72bce03eab513da5c49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Format and remove default modifiers from AsyncTaskCR...
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Format and remove default modifiers from AsyncTaskCRUDOperations ...................................................................... engine: Format and remove default modifiers from AsyncTaskCRUDOperations Change-Id: Icb3521f38c2f53d017090f27d7ced05b8a76a2bd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncTaskCRUDOperations.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb3521f38c2f53d017090f27d7ced05b8a76a2bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use formatter for Command
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use formatter for Command ...................................................................... engine: Use formatter for Command Change-Id: I03554ca006cce684a57fbf0720e3382f0d018bf4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/Command.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03554ca006cce684a57fbf0720e3382f0d018bf4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove default modifiers in CommandScheduler
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove default modifiers in CommandScheduler ...................................................................... engine: Remove default modifiers in CommandScheduler The public abstract are default modifiers in interface and no need to specify it. Change-Id: Ie58cc4712b190d6a3ca433f7b83245bd4ed19d51 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandScheduler.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie58cc4712b190d6a3ca433f7b83245bd4ed19d51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Decrease visibility of variable in CommandsCacheImpl
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Decrease visibility of variable in CommandsCacheImpl ...................................................................... engine: Decrease visibility of variable in CommandsCacheImpl Change-Id: I12c549c1278a60dda29a0889a394c8938f7a059e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c549c1278a60dda29a0889a394c8938f7a059e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove redundant public modifier CacheWrapper
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove redundant public modifier CacheWrapper ...................................................................... engine: Remove redundant public modifier CacheWrapper Change-Id: Idd4e62b4fed3a1414ccebc97b841389be744456c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheWrapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd4e62b4fed3a1414ccebc97b841389be744456c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0