Change in ovirt-engine[master]: webadmin: StorageListModel fix for Coveritiy scan.
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: StorageListModel fix for Coveritiy scan.
......................................................................
webadmin: StorageListModel fix for Coveritiy scan.
A coveritiy scan have found a null dereference in a recent
StorageListModel patch. Although the scenerio tested can never
happen, this patch updates the code to still check nullity and
prevent any chance of NullPointerException resulting from another
potential bug.
Change-Id: I028eaeb0c6f579cedaf135692b3c23bcdda0d0b9
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/38642
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I028eaeb0c6f579cedaf135692b3c23bcdda0d0b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: packaging: setup: using the right type to detect zombie tasks
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: packaging: setup: using the right type to detect zombie tasks
......................................................................
packaging: setup: using the right type to detect zombie tasks
A zombie task is task that is running since more than
AsyncTaskZombieTaskLifeInMinutes without completing.
In order to cerretly detect it we must compute the zombie
starting date as a timestamp and not as data with doesn't
include time attributes.
Change-Id: I96de0ddf6f7f8f3dcc4a8ccbefa9e43504d2c75b
Bug-Url: https://bugzilla.redhat.com/1161012
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/dbutils/taskcleaner_sp.sql
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96de0ddf6f7f8f3dcc4a8ccbefa9e43504d2c75b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: Could not clear external job
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Could not clear external job
......................................................................
core: Could not clear external job
This patch fixes two problems when attempting to clear an external job
from the API
1) The parameters in the UpdateJob SP did not match the parameters sent
from the DAO
2) The command did not set the return value when succeeded, causing the
whole command to rollback
Change-Id: Ie838897d389ad9bf253cfe3edc8a363f73d584bb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156055
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java
M packaging/dbscripts/job_sp.sql
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie838897d389ad9bf253cfe3edc8a363f73d584bb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: core: Fix search for templates on username
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix search for templates on username
......................................................................
core: Fix search for templates on username
[search] Templates: Users.usrname = causes PSQLException:
ERROR: missing FROM-clause entry for table "vms"
This patch fixes this behavior
Change-Id: Ia3051c13fce1a7e1733624e078bad28fa7e0dfb7
Bug-Url: https://bugzilla.redhat.com/1187703
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit https://gerrit.ovirt.org/38511
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3051c13fce1a7e1733624e078bad28fa7e0dfb7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: [search] Users: role = * returns nothing / ERROR
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: [search] Users: role = * returns nothing / ERROR
......................................................................
core: [search] Users: role = * returns nothing / ERROR
Error message is
[search] Users: role = * returns nothing / ERROR: column vdc_users.mla_role
does not exist.
This patch adds an infrastructure that allows us to map specific columns that
exist in the tag tables but not in the regular tables to solve
this specific scenario, and any such future scenario.
Change-Id: I742877bf4debfdacc44659359c40e9d6d0a99a3b
Bug-Url: https://bugzilla.redhat.com/1187693
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
4 files changed, 27 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit https://gerrit.ovirt.org/38502
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I742877bf4debfdacc44659359c40e9d6d0a99a3b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: build: fix recent pep8 warnings
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: fix recent pep8 warnings
......................................................................
build: fix recent pep8 warnings
Fixed errors detected with pep8 1.6.2:
E402 module level import not at top of file.
E731 do not assign a lambda expression, use a def
sorting all the imports
Change-Id: I0b6ee66fb522e542e567c4024cbd8c6ad169d378
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M build/helptag.py
M packaging/pythonlib/ovirt_engine/base.py
M packaging/pythonlib/ovirt_engine/configfile.py
M packaging/pythonlib/ovirt_engine/java.py
M packaging/pythonlib/ovirt_engine/service.py
M packaging/pythonlib/ovirt_engine/ticket.py
M packaging/pythonlib/ovirt_engine/util.py
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py
M packaging/services/ovirt-engine/ovirt-engine.py
M packaging/services/ovirt-fence-kdump-listener/db.py
M packaging/services/ovirt-fence-kdump-listener/listener.py
M packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.py
M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/ovirt_engine_setup/dialog.py
M packaging/setup/ovirt_engine_setup/domains.py
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/ovirt_engine_setup/engine/vdcoption.py
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/database.py
M packaging/setup/ovirt_engine_setup/engine_common/dwh_history_timekeeping.py
M packaging/setup/ovirt_engine_setup/engine_common/postgres.py
M packaging/setup/ovirt_engine_setup/firewall_manager_base.py
M packaging/setup/ovirt_engine_setup/hostname.py
M packaging/setup/ovirt_engine_setup/remote_engine.py
M packaging/setup/ovirt_engine_setup/remote_engine_base.py
M packaging/setup/ovirt_engine_setup/util.py
M packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py
M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py
M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py
M packaging/setup/plugins/ovirt-engine-common/base/core/offlinepackager.py
M packaging/setup/plugins/ovirt-engine-common/base/core/postinstall.py
M packaging/setup/plugins/ovirt-engine-common/base/core/reconfigure.py
M packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py
M packaging/setup/plugins/ovirt-engine-common/base/dialog/titles.py
M packaging/setup/plugins/ovirt-engine-common/base/distro-rpm/log_setup_event.py
M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager.py
M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_firewalld.py
M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_human.py
M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py
M packaging/setup/plugins/ovirt-engine-common/base/network/hostname.py
M packaging/setup/plugins/ovirt-engine-common/base/network/process_firewalld_services.py
M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine.py
M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_manual_files.py
M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py
M packaging/setup/plugins/ovirt-engine-common/base/system/hostile_services.py
M packaging/setup/plugins/ovirt-engine-common/base/system/mem.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/misc.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/protocols.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/apache.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/environment.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/engine.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/fence_kdump_listener.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/misc.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/config.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/pgpass.py
M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py
M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py
M packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py
M packaging/setup/plugins/ovirt-engine-remove/base/network/firewall_manager.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-common/system/sysctl.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/ca.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/engine.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/fence_kdump_listener.py
M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/engine.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/pki.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/protocols.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/tools.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/uninstall.py
M packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py
M packaging/setup/plugins/ovirt-engine-setup/base/dialog/preview.py
M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py
M packaging/setup/plugins/ovirt-engine-setup/base/system/environment.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/core.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/misc.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/selinux.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/ssl.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/java.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/core.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/firewall.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/sshd.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/storage.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsmi.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/engine.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/root.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/firewall.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/java.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/macrange.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/protocols.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/tools.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/engine.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/selinux.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/answerfile_fixup.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/packages.py
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py
133 files changed, 912 insertions(+), 1,047 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38487
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b6ee66fb522e542e567c4024cbd8c6ad169d378
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: asking about retriyng VG creation with for...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: asking about retriyng VG creation with force option
......................................................................
packaging: setup: asking about retriyng VG creation with force option
On dirty storage devices CreateVG could fail, force option can
prevent failures destroying any existent data.
If VDSM detect that the LUN is alredy used it ask to the user
if he want to use the force option to explicitly clean it
up.
If, for any reasons, createVG still fails, it asks again
to the user if he want to retry with force option to
clean it or if he prefer to abort.
Change-Id: I496c34e6b9f0d84443a8d5bc68d77916be6cb504
Bug-Url: https://bugzilla.redhat.com/1142098
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py
2 files changed, 83 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/37845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I496c34e6b9f0d84443a8d5bc68d77916be6cb504
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: Cleanup AsyncTaskCreationInfo
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Cleanup AsyncTaskCreationInfo
......................................................................
engine: Cleanup AsyncTaskCreationInfo
- add serial version uuid
- omit 'private' prefix
- maintain camelCase for class members
Change-Id: Ia9f02dafc60e84111d3e11b4adb16103d707a3e8
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskCreationInfo.java
1 file changed, 14 insertions(+), 12 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38580
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9f02dafc60e84111d3e11b4adb16103d707a3e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: Format method parameters
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Format method parameters
......................................................................
engine: Format method parameters
Change-Id: Iada23ac0bbbfb565d6c56b9cd0172d12b7a59209
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iada23ac0bbbfb565d6c56b9cd0172d12b7a59209
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: replace for loop with while
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: replace for loop with while
......................................................................
engine: replace for loop with while
While loop seems better match for the need of this
use case.
Change-Id: I92cf88219ce47273150a5b6789b7f2dc099c0240
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38578
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92cf88219ce47273150a5b6789b7f2dc099c0240
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months