- Devel - oVirt List Archives

[Engine-devel] find-bugs errors - please investigate/fix
by Einav Cohen 24 Apr '13

24 Apr '13

ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NOR… caused by: http://gerrit.ovirt.org/#/c/13831/ @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NOR… caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NOR… [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NOR… when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NOR… [again - not sure when introduced - seems old, hence I suspect it is a false positive] ---- Thanks, Einav

5 6

[Engine-devel] Database Caching
by Liran Zelkha 24 Apr '13

24 Apr '13

Hi I've created Change I04d7edea (http://gerrit.ovirt.org/#/c/14188/) that adds automatic database caching capabilities to the engine. To cache a business entity, just add an annotation called TimeToLiveInCache that accepts as a parameter the number of seconds this object can live in the cache until it is refreshed from the database. The next stage is improving the cache update mechanism, using Infinispan, and the ability to capture more query types. Would love input and suggestions. Thanks, Liran

1 0

[Engine-devel] storage overallocation ratio
by Michal Skrivanek 23 Apr '13

23 Apr '13

Hi, I was trying to find out how is this actually calculated. Doesn't look very straightforward…:) I'm curious about the following - vdsm reports something like truesize and apparentsize which IIUC should be distinct but then in engine, in backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java it's written to the same engine property actual_size. That doesn't sound right. Can someone enlighten me please? Thanks, michal

2 1

[Engine-devel] rewrite the engine-notifier service wrapper
by Alon Bar-Lev 23 Apr '13

23 Apr '13

Hello, After finish to cleanup the engine-service to use downstream services and be portable to other distributions (upstart, openrc), we can use the same infrastructure for the engine notifier script. It is very similar to the engine-service in operation (running java), except it is written in bash instead of python and has no systemd support, and have its own configuration. What I suggest is to rewrite the notifier service in python and reuse the engine-service code. Also, drop the /etc/ovirt-engine/notifier/notifier.conf in favor of variables within the /etc/ovirt-engine/engine.conf[.d/*], this will provide a single point of configuration for all services. And of course proper systemd support and development environment support. Any comments? thoughts? Alon

3 2

[Engine-devel] some cleanup
by Laszlo Hornyak 23 Apr '13

23 Apr '13

Hi, Some of my patches are waiting for a brave reviewer to +2 them :) - entity cleanups http://gerrit.ovirt.org/13531 http://gerrit.ovirt.org/13705 http://gerrit.ovirt.org/13940 http://gerrit.ovirt.org/13705 - command cleanups http://gerrit.ovirt.org/13945 http://gerrit.ovirt.org/13946 http://gerrit.ovirt.org/13947 Thx, Laszlo

2 2

[Engine-devel] Introducing Infinispan cache and some required actions after change
by Michael Kublin 23 Apr '13

23 Apr '13

Hi All, The following commit I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7 will introduce a in memory cache inside ovirt-engine The cache which was chosen is infinispan (http://www.jboss.org/infinispan/) The reasons are following: cache has all required functionality, it is open source project and has built-in integration with JBOSS, all cache configuration can be accessed or edited via JBOSS admin console. By introducing this commit the first stage is finished: 1. Cache implementation is added to project 2. Show example how to add and use a cache in ovirt-engine, if it is required 3. Solved bug with possible memory leak in audit log event The next stages are: 1. Second stage - replace all custom made implementation by standard central cache implementation 2. Third stage - introduce second level cache for work with DB 3. Fourth stage (Future) - make cluster wise cache or make cache as service, if we will have more than one instance of JBOSS Now, after the applying the following commit I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7, everyone who works with ovirt-engine will be required to perform the following operation 1. Run mvn clean install -Pdep,setup in order to replace an old standalone.xml with new version of it Or 1. Use regular deploy: mvn clean install -Pdep 2. Access to $JBOSS_HOME/bin/standalone.xml and replace or add infinispan subsystem: <subsystem xmlns="urn:jboss:domain:infinispan:1.1" default-cache-container="ovirt-engine"> <cache-container name="ovirt-engine" default-cache="timeout-base" jndi-name="java:jboss/infinispan/ovirt-engine" start="EAGER"> <local-cache name="timeout-base"> <transaction mode="NONE"/> <eviction max-entries="10000"/> <expiration interval="60000"/> </local-cache> </cache-container> </subsystem> 3. Add or check that exists <extension module="org.jboss.as.clustering.infinispan"/> under <extensions> element Thanks and Regards Michael

3 2

Re: [Engine-devel] Question about reports generating when running mvn site
by Yair Zaslavsky 22 Apr '13

22 Apr '13

Mike came up with a simpler solution - mvn findbugs:findbugs - from root pom Works like a charm. Many thanks! ----- Original Message ----- > From: "Yair Zaslavsky" <yzaslavs(a)redhat.com> > To: "Mike Kolesnik" <mkolesni(a)redhat.com> > Sent: Monday, April 22, 2013 9:35:12 AM > Subject: Re: [Engine-devel] Question about reports generating when running mvn site > > No, > I will try. > Thanks. > > > ----- Original Message ----- > > From: "Mike Kolesnik" <mkolesni(a)redhat.com> > > To: "Yair Zaslavsky" <yzaslavs(a)redhat.com> > > Sent: Monday, April 22, 2013 9:30:35 AM > > Subject: Re: [Engine-devel] Question about reports generating when running > > mvn site > > > > have you tried > > > > mvn findbugs:findbugs > > > > ? > > > > Regards, > > Mike > > > > ----- Original Message ----- > > > Hi all, > > > It seems that generating all the reports when running mvn:site takes > > > quite > > > some time. > > > > > > Do we really need all these reports? > > > > > > Here is a snippet from the execution - > > > > > > [INFO] Generating "About" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Project Team" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Dependency Information" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Dependency Management" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Project Plugins" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Continuous Integration" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Issue Tracking" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Source Repository" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Dependency Convergence" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Project License" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Plugin Management" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Distribution Management" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Project Summary" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Mailing Lists" report --- > > > maven-project-info-reports-plugin:2.6 > > > [INFO] Generating "Dependencies" report --- > > > maven-project-info-reports-plugin:2.6 > > > > > > > > > These reports are being generated when I run mvn site in order to > > > generate > > > a > > > find-bugs report. > > > > > > > > > Many thanks, > > > Yair > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel(a)ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > >

1 0

[Engine-devel] Question about reports generating when running mvn site
by Yair Zaslavsky 22 Apr '13

22 Apr '13

Hi all, It seems that generating all the reports when running mvn:site takes quite some time. Do we really need all these reports? Here is a snippet from the execution - [INFO] Generating "About" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Project Team" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Dependency Information" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Dependency Management" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Project Plugins" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Continuous Integration" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Issue Tracking" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Source Repository" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Dependency Convergence" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Project License" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Plugin Management" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Distribution Management" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Project Summary" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Mailing Lists" report --- maven-project-info-reports-plugin:2.6 [INFO] Generating "Dependencies" report --- maven-project-info-reports-plugin:2.6 These reports are being generated when I run mvn site in order to generate a find-bugs report. Many thanks, Yair

1 0

[Engine-devel] Location of findbugs filter.xml file
by Yair Zaslavsky 22 Apr '13

22 Apr '13

Hi all, I sent a patch upstream to add findbugs filter that will filter out bug reports that we decided that are not bugs. We have a debate on whether to have the findbugs filter definition in the root pom.xml or to put it in the jenkins jobs repo and treat it as an external tool. I would like to hear opinions about what you think should be the proper location Thanks, Yair

5 5

[Engine-devel] Changes in DB scripts that need your attension
by Eli Mesika 21 Apr '13

21 Apr '13

Hi As part of solving https://bugzilla.redhat.com/show_bug.cgi?id=947344 I am doing the following changes: 1) Create all *.md5 files in /tmp/db 2) Create db log files by default under /var/log/ovirt-engine/db 3) Do not automatically create a *.schema file that represent the up-to-date schema (after all upgrades took place) A new utility script exportDbSchema.sh will be available for that (manual only, no auto-generation schema) In order that DB scripts in development environment will keep working, please do > sudo mkdir -p /var/log/ovirt-engine/db > sudo chmod 777 /var/log/ovirt-engine/db If you are getting "Permission Denied" errors while running the scripts it means that you didn't run the 2 commands above. If you have any comments/suggestions to this solution, please respond before this patch is merged, I will wait with this change to next SUN , APR 21 2013 Best Regards Eli

2 6