- Devel - oVirt List Archives

[Engine-devel] Please review: All In One Feature page
by Alex Lourie 04 Apr '12

04 Apr '12

Hi All I've written a new wiki page [1] for a feature we've developed, called All in One. This allows configuring VDSM on the same host with rhevm (ovirt) automatically during setup. Please review and provide feedback :-) Thanks [1] http://www.ovirt.org/wiki/Feature/AllInOne

5 10

[Engine-devel] [Jenkins] Warning - the following commits inserted 2 new HIGH priority bugs into into engine code
by Eyal Edri 04 Apr '12

04 Apr '12

core: Ovirt-engin-backend: Run Once does not send Attach CD/Floppy (detail / gitweb) webadmin: Changing a call at webamin from UpdateVmDiskCommand to HotPlug/HotUnPlugCommand (detail / gitweb) core : Changes for required error messages in order to supposrt a new commands (detail / gitweb) core : Introducing HotPlug and HotUnplug commands (detail / gitweb) url: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/491/ Both in class: VmInfoBuilder.java http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/491/findbugsResult/new/… Please check, Eyal Edri oVirt Infra Team

1 0

[Engine-devel] Storage Domain level 3
by Tomas Jelinek 03 Apr '12

03 Apr '12

Hi all, this is about supporting of I18N (https://bugzilla.redhat.com/show_bug.cgi?id=786448) The VDSM already supports it, but only for storage domain level 3. >From Dan Kenigsberg's mail: "I hope ovirt-Engine learns to do storage domain upgrade, and uses level 3, so that this feature can be used." So, how is it with supporting this in the engine? Thank you, Tomas

2 1

[Engine-devel] Reloadable Configuration - Wiki Page
by Muli Salem 02 Apr '12

02 Apr '12

Hi All, Below please find a wiki page regarding the design of the Reloadable Configuration feature. You are more than welcome to review and comment. http://www.ovirt.org/wiki/Features/ReloadableConfiguration Thanks, Muli

6 13

[Engine-devel] advanced nfs options in vdsm
by Laszlo Hornyak 02 Apr '12

02 Apr '12

Hi Saggi, The wiki page of the Advanced NFS options says that the changes needed in vdsm are already done http://www.ovirt.org/wiki/Features/AdvancedNfsOptions Which VDSM release has this feature built in? Also, could you send me what changes have been done on vdsm? Thank you, Laszlo

2 2

[Engine-devel] Fwd: Re: Please review: All In One Feature page
by Alex Lourie 02 Apr '12

02 Apr '12

On 04/01/2012 04:26 PM, Itamar Heim wrote: > On 04/01/2012 12:09 PM, Alex Lourie wrote: >> Hi All >> >> I've written a new wiki page [1] for a feature we've developed, >> called All in One. This allows configuring VDSM on the same host with >> rhevm (ovirt) automatically during setup. >> > > 1. "Plugin will wait to allow JBoss to start correctly. This is done > because other steps involve using REST API (with ovirtsdk), which > requires JBoss to be up. " > > how are you planning to perform this check? > Currently we do not check for it. The following operations will fail though if it is not up. > 2. "Plugin will create a local host and add it to host list." > worth mentioning bootstrapping code was changed to allow to not reboot > a host for this. > Sure, I'll add a note. > 3. "The plugin works by providing parameters, group and sequences and > adding them into the Controller object (the main object of the setup > flow), which will invoke appropriate logic during the setup operation. " > > nice - I like it is modular code. > -- Alex Lourie.

2 1

[Engine-devel] 'Import VM/Template More Than Once' feature
by Gilad Chaplik 30 Mar '12

30 Mar '12

Hello all, The 'Import VM/Template More Than Once' feature description can be found under the following link: http://www.ovirt.org/wiki/Features/ImportMoreThanOnce Please review, and feel free to share your comments and thoughts. Thanks, Gilad.

7 10

[Engine-devel] [Jenkins] new high priority bug still open in ovirt-engine
by Eyal Edri 29 Mar '12

29 Mar '12

fyi, these commits caused a new high priority bug: common: Changes to image_storage_domain_map (detail / gitweb) core: Extracting ImageStorageDomainMap Dao (detail / gitweb) details here: http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_find_bugs/470/ please check, Eyal Edri oVirt Infra Team

2 1

[Engine-devel] Manual DB change required - remove grant_mode column from DB
by Moti Asayag 29 Mar '12

29 Mar '12

Hi, The commit which added the grant_mode column to the permissions table was reverted (604ae480ab677b06e53abd0edfaf0ec04f017fb8). If you upgraded the DB since the 25/3, please run manually the next command in order to drop that column and run refresh procedure afterwards/run upgrade script: echo 'alter table permissions drop column grant_mode' | psql engine postgres (supply database name if differ from engine). Thanks, Moti

1 0

[Engine-devel] Getting rid of PowerMock?
by Yair Zaslavsky 29 Mar '12

29 Mar '12

Hi all, As (almost) all of us can see, Running BLL tests both takes considerable time, and also we have to take class loading dependencies between classes with static methods when we use mockStatic - IMHO, this is kinda frustrating. Maybe we should start get rid of PowerMock. Here is what I'm thinking of - Currently, as we use no IoC for DAOs , for tested class we do not use DbFacade.getInstance().getXXXDao() instead we define: protected XXXDao getXXXDao() { return DBFacade.getInstance().getXXXDao(); } And then in our tests we use Mockito to define how getXXDao acts in the test. The following can be achieved also for config values , the following way - protected <T> T getConfig(ConfigValues key) { return Config.<T> GetValue(key); } And then in code (for example, in a query test) - doReturn(5).when(query).<Integer> getConfig(any(ConfigValues.SomeIntegerConstant)); This effort can be done in small steps - a. Define getConfig method in base classes (i.e AuditLoggalbeBase). b. Rewrite parts (i.e Commands, and their tests) step by step (small commits) Thoughts and ideas are more than welcome, Yair

5 9