- Devel - oVirt List Archives

[Engine-devel] Getting into memory allocation problems in git?
by Yair Zaslavsky 16 Apr '12

16 Apr '12

Hi all, I got a strange error while trying to fetch a patch from ovrit gerrit. The error looked like this - git fetch http://gerrit.ovirt.org/p/ovirt-engine refs/changes/41/3541/1 && git checkout FETCH_HEAD error: Could not resolve host: gerrit.ovirt.org; Cannot allocate memory while accessing http://gerrit.ovirt.org/p/ovirt-engine/info/refs fatal: HTTP request failed Could not find anything interesting in google, and out of despair started to pass on manual of git. I then encountered git gc. My java instincts told me to give it a shot (after all, garbage collection sounds good), and it worked! (Nothing helped before - not removing local branches, not trying to perform this from various branches, etc...) FYI Yair

1 0

[Engine-devel] Issue with XML namespaces in engine-setup
by Juan Hernandez 14 Apr '12

14 Apr '12

Hello, The code that we use in engine-setup to modify JBoss AS XML configuration files uses the following pattern: datasourceStr = ''' <datasource ...> ... </datasource> ''' xmlObj.addNodes("//datasource:subsystem/datasource:datasources", datasourceStr) This looks correct but is in fact generating a incorrect XML document, as the tags being added are not associated to a namespace. The resulting XML file will be correct, but the temporary representation in memory is not. This causes problems if you later, before writing out the modified file, try to use xpath expressions matching the added nodes: there will be no match. I would suggest that we change the pattern to something like this: datasourceStr = ''' <any_dummy_tag xmlns="urn:jboss:domain:datasources:1.0"> <datasource ...> ... </datasource> </any_dummy_tag> ''' datasourceNodes = libxml2.parseDoc(datasourceStr).getRootElement().children xmlObje.addNodes("//datasource:subsystem/datasource:datasources", datasourceNodes) This way both the representation in memory and the resulting file are correct. Le me know what you think. Regards, Juan Hernandez -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.

4 5

[Engine-devel] Hot-plug of disks and nics
by Ori Liel 11 Apr '12

11 Apr '12

On the subject of activate/deactivate disks and nics ("hot-plug"), I'd like to hear opinions about the correct modelling. I see two possible options (I will use disks as an example, but the chosen modelling should be the same for nics and disks). Option 1 - update: ================= PUT .../api/vms/{vm:id}/disks/{disk:id} <disk> <activated>true</activated> </disk> Pros: ----- * RESTful, no need for new action Cons: ----- * Inconsistent with other flows. We do not normally update status fields to perform actions. For example to run a VM, we do not update it's status to 'activated', we run an action (start). * Enables user to update disk properties AND activate/deactivate in the same operation. Updating certain disk properties is forbidden while the VM is up, but activating/deactivating the disk is allowed always. This requires business-logic in REST-API: if the user activates the disk and changes properties on it - REST-API must first change the properties and then activate the disk (if disk is activated first, update properties will fail). If, on the other hand, the user *deactivates* the disk and changes properties on it - REST-API must first deactivate the disk and then change the properties (changing properties while disk is still active will fail). This bug-prone logic is only necessary because when activate/deactivate is merged with update. Option 2 - action ================= .../api/vms/{vm:id}/disks/{disk:id}/attach Pros: ---- * Less RESTful Cons: ----- * Consistent with other flows * Does not have the drawback of the additional business-logic described above Opinions? Thanks, Ori.

4 5

[Engine-devel] Canceled: oVirt sync meeting (11.04.2012)
by Ofer Schreiber 11 Apr '12

11 Apr '12

Due to low number of attendees, the weekly sync meeting [1] is canceled. Happy holiday, Ofer Schreiber oVirt Release Manager [1] Happens every Wednesday on 14:00 UTC, #ovirt irc channel (oftc)

1 0

[Engine-devel] Floating Disks implementation in REST-API
by Ori Liel 11 Apr '12

11 Apr '12

The "Floating Disks" feature makes disks into stand-alone entities: a given disk may be attached to a VM (as all disks are today), or it may be not attached to any VM, which makes it a floating disk (http://www.ovirt.org/wiki/Features/FloatingDisk) To implement attach/detach of disk to/from VM in REST-API, we intend to introduce two new actions: POST .../api/vms/{vm:id}/disks/{disk:id}/attach POST .../api/vms/{vm:id}/disks/{disk:id}/detach Since we try not to add new actions unless we have to, I want to explain why I believe that these actions are necessary. The other implementation would use existing add/remove flows: POST .../api/vms/{vm:id}/disks - if the disk was passed with an ID, attach it to this VM. If no id - create a new disk. DELETE .../api/vms/{vm:id}/disks/{disk:id} - *ambiguity problem, need to add a flag* We can't break existing API, so regular DELETE must remove the disk, as it does today. To detach a disk using DELETE we'd have to add a flag to the DETELE command. This is quite risky, because if the user forgets to pass this flag, the disk which he wanted to detach will actually be deleted. Theoretically, if we could break the API, the following modelling would resolve the ambiguity and perhaps be ideal: - POST/DELETE disk in root context means create or delete it. - POST/DELETE disk in VM context means attach or detach it. But we don't have the privilege of breaking the API. Considering all of the above - and the fact that attach/detach nics to/from host is also implemented using actions - I believe that the new actions are justifiable. Any comments? Thanks, Ori

6 10

[Engine-devel] ovirt core sync agenda
by Livnat Peer 11 Apr '12

11 Apr '12

Hi All, We have nothing on the agenda for today. If you have something you would like to discuss please reply to this mail otherwise we'll cancel today's meeting. Thanks, Livnat

2 1

[Engine-devel] Problem with detachment of host interface using ovirt-sdk
by Itzik Brown 11 Apr '12

11 Apr '12

--_000_4488206DC085244C886DBC9E7038B68918D382CEMTRDAG01mtlcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, I'm using ovirt-sdk to attach and detach a network to a host's Interface. Once the network is attached to the interface I try to detach the network f= rom the interface using the following steps: 1.Detach the network from the cluster through the GUI. 2.Remove the network from the datacenter through the GUI. 3.Detach the network from the host's interface using the SDK: nic =3D api.hosts.get(name=3Dhost).nics.get(name=3Dif_name) net =3D params.Network(name=3Dnet_name) act =3D params.Action(network=3Dnet) nic.detach(act) api.hosts.get(name=3Dhost).commitnetconfig() Then I get the error: http://pastebin.com/3Md07huE The same flow using the GUI works fine. Network removal from the Datacenter is a trigger for me to run the detachme= nt operation therefore I use this flow. I use the following components: rhevm-3.0.2_0001-2 ovirt-sdk (Using the latest from git repository) Please advise how to proceed. Thanks, Itzik --_000_4488206DC085244C886DBC9E7038B68918D382CEMTRDAG01mtlcom_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> Hi,<o:p></o:p> <o:p> </o:p> I'm using ovirt-sdk to attach and detach a network to a host's Inter= face.<o:p></o:p> Once the network is attached to the interface I try to detach the ne= twork from the interface using the following steps:<o:p><= /o:p> <o:p> </o:p> 1.Detach the network from the cluster through the GUI.<o:p></o:p></p= > 2.Remove the network from the datacenter through the GUI.<o:p></o:p>= 3.Detach the network from the host's interface using the SDK:<o:p></= o:p> <o:p> </o:p> nic = =3D api.hosts.get(name=3Dhost).nics.get(name=3Dif_name)<o:p></o:p> net = =3D params.Network(name=3Dnet_name)<o:p></o:p> act = =3D params.Action(network=3Dnet)<o:p></o:p> nic.d= etach(act)= <o:p></o:p> api.h= osts.get(name=3Dhost).commitnetconfig()<o:p></o:p> <o:p> </o:p> Then I get the error:<o:p></o:p> <a href=3D"http://pastebin.com/3Md07huE">http://pastebin.com/3Md07hu= E</a><o:p></o:p> <o:p> </o:p> The same flow using the GUI works fine.<o:p></o:p> <o:p> </o:p> Network removal from the Datacenter is a trigger for me to run the d= etachment operation therefore I use this flow.<o:p></o:p> <o:p> </o:p> I use the following components:<o:p></o:p> <o:p> </o:p> rhevm-3.0.2_0001-2<o:p></o:p> ovirt-sdk (Using the latest from git repository)<o:p></o:p> <o:p> </o:p> Please advise how to proceed.<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Itzik<o:p></o:p> </div> </body> </html> --_000_4488206DC085244C886DBC9E7038B68918D382CEMTRDAG01mtlcom_--

3 3

[Engine-devel] Jenkins Support next week 15/04-18/04
by Eyal Edri 11 Apr '12

11 Apr '12

I will be OOO next week, for any urgent issues with jenkins.ovirt.org, please contact infra(a)ovirt.org. Eyal Edri oVirt Infra Team

1 0

[Engine-devel] "add permission to user" dialog - nothing shown by default
by Einav Cohen 11 Apr '12

11 Apr '12

[https://bugzilla.redhat.com/show_bug.cgi?id=810287] When opening the "add permission to user" dialog, no user is shown in the grid by default; user has to enter something in the search text-box within the dialog (or leave it empty) and hit "Go"; only then the list of users is being filled (according to the search text-box contents). This behavior is by design. Do you think that this behavior should change? i.e. do you think that the users grid should be filled right after opening the dialog with a list of all users? Please consider the following: - calling to the search query and rendering its results may take a while, so user may open the dialog, but will be able to do something only after waiting a while (when originally, all he intended to do was to search a very particular user, which would have taken a short time). - we may have several domains, so grid will be filled with results of the first domain selected (which might not be the domain that the user intended to search originally), so this may be annoying. Due to the reasons above, my personal take is that the current behavior is OK and shouldn't be changed (i.e. BZ should be closed). Any comments?

2 1

[Engine-devel] Unable to Run 'make install-tools'
by Schoenbrun, Dustin 10 Apr '12

10 Apr '12

--_000_0A1534657992624AACDCA570F1D3E2000D3CBASACEXCMBX03PRDhqn_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Greetings, I'm running into an issue at the "Deploying engine-config and engine-manage= -domains" section of the "Building oVirt Engine" article on the wiki. Buil= ding from the source using maven2 has completed successfully and I'm stuck = on the series of commands listed below: # cd $OVIRT_HOME # make create_dirs # make install_tools # make install_config My build fails on the 'make install-tools' command. The output of the comm= and is below: [root@ovirt ovirt-engine]# make install_tools *** Installing Common Tools cp -f /root/ovirt-engine/rpmbuild/SOURCES/engine-tools-common-3.1.0-0001.ja= r /usr/share/java/ cp: cannot stat `/root/ovirt-engine/rpmbuild/SOURCES/engine-tools-common-3.= 1.0-0001.jar': No such file or directory make: *** [install_tools] Error 1 [root@ovirt ovirt-engine]# pwd /root/ovirt-engine [root@ovirt ovirt-engine]# ls backend build-tools deployment frontend Makefile pom.xml build_mvn config ear LICENSE packaging [root@ovirt ovirt-engine]# Any insight into how to proceed would be greatly appreciated. Thanks! -- Dustin Schoenbrun Software Engineer NetApp - Data Center Platforms 919-476-5919 (office) dustin.schoenbrun(a)netapp.com --_000_0A1534657992624AACDCA570F1D3E2000D3CBASACEXCMBX03PRDhqn_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> Greetings,<o:p></o:p> <o:p> </o:p> I’m running into an issue at the “Deploy= ing engine-config and engine-manage-domains” section of the “Bu= ilding oVirt Engine” article on the wiki.  Building from the sou= rce using maven2 has completed successfully and I’m stuck on the seri= es of commands listed below:<o:p></o:p> <o:p> </o:p> # cd $OVIRT_HOME<o:p></o:p> # make create_dirs<o:p></o:p> # make install_tools<o:p></o:p> # make install_config<o:p></o:p> <o:p> </o:p> My build fails on the ‘make install-tools&#821= 7; command.  The output of the command is below:<o:p></o:p> <o:p> </o:p> [root@ovirt ovirt-engine]# make install_tools<o:p></= o:p> *** Installing Common Tools<o:p></o:p> cp -f /root/ovirt-engine/rpmbuild/SOURCES/engine-too= ls-common-3.1.0-0001.jar /usr/share/java/<o:p></o:p> cp: cannot stat `/root/ovirt-engine/rpmbuild/SOURCES= /engine-tools-common-3.1.0-0001.jar': No such file or directory<o:p></o:p><= /p> make: *** [install_tools] Error 1<o:p></o:p> [root@ovirt ovirt-engine]# pwd<o:p></o:p> /root/ovirt-engine<o:p></o:p> [root@ovirt ovirt-engine]# ls<o:p></o:p> backend    build-tools  deployme= nt  frontend  Makefile   pom.xml<o:p></o:p> build_mvn  config     =   ear         LICENSE &nb= sp; packaging<o:p></o:p> [root@ovirt ovirt-engine]#<o:p></o:p> <o:p> </o:p> Any insight into how to proceed would be greatly app= reciated.  Thanks!<o:p></o:p> <o:p> </o:p> --<o:p></o:p> Dustin Schoenbrun<o:p></o:p> Software Engineer<o:p></o:p> NetApp – Data Center Platforms<o:p></o:p> 919-476-5919 (office)<o:p></o:p> dustin.schoenbrun(a)netapp.com <o:p></o:p> <o:p> </o:p> </div> </body> </html> --_000_0A1534657992624AACDCA570F1D3E2000D3CBASACEXCMBX03PRDhqn_--

2 4