- Devel - oVirt List Archives

Failure in travis CI
by Sandro Bonazzola 13 Mar '20

13 Mar '20

Hi, can you please have a look at https://travis-ci.org/github/oVirt/ovirt-engine/builds/661605510?utm_medium… ? Looks like a real issue. -- Sandro Bonazzola MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV Red Hat EMEA <https://www.redhat.com/> sbonazzo(a)redhat.com <https://www.redhat.com/>*Red Hat respects your work life balance. Therefore there is no need to answer this email out of your office hours.*

2 2

Gerrit is not sending notifications
by Ales Musil 12 Mar '20

12 Mar '20

Hi, I did not receive notification from gerrit about being added as review. Can someone please take a look at it? Thanks. Regards, Ales -- Ales Musil Software Engineer - RHV Network Red Hat EMEA <https://www.redhat.com> amusil(a)redhat.com IM: amusil <https://red.ht/sig>

2 1

Ovirt engine thread-per-core(-T1C) maven execution
by Artur Socha 11 Mar '20

11 Mar '20

Hi, I have been using thread-per-core (-T1C) maven flag for couple months when building engine on my machine. I have not seen any issues related to such parallel maven goals execution so I submitted a patch that enables it by default: https://gerrit.ovirt.org/#/c/107567/ The main benefit is significantly reduced build time ( ~30% in my case but it greatly depends on the hardware/vm you run the build on) Please let me know if you can think about any corner cases when this setting would cause some instability. Posting review comments would be the preferred option :) thanks! -- Artur Socha Senior Software Engineer, RHV Red Hat

1 0

100_basic_ui_sanity.virtual_machines failed (was: [CQ]: 106261, 17 (cockpit-ovirt) failed "ovirt-master" system tests, but isn't the failure root cause)
by Yedidyah Bar David 11 Mar '20

11 Mar '20

Hi all, On Wed, Mar 11, 2020 at 8:41 AM oVirt Jenkins <jenkins(a)ovirt.org> wrote: > > A system test invoked by the "ovirt-master" change queue including change > 106261,17 (cockpit-ovirt) failed. However, this change seems not to be the root > cause for this failure. Change 107220,13 (cockpit-ovirt) that this change > depends on or is based on, was detected as the cause of the testing failures. > > This change had been removed from the testing queue. Artifacts built from this > change will not be released until either change 107220,13 (cockpit-ovirt) is > fixed and this change is updated to refer to or rebased on the fixed version, > or this change is modified to no longer depend on it. > > For further details about the change see: > https://gerrit.ovirt.org/#/c/106261/17 > > For further details about the change that seems to be the root cause behind the > testing failures see: > https://gerrit.ovirt.org/#/c/107220/13 > > For failed test results see: > https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21164/ This failed with: Message: Element <a class="" href="javascript:;"> is not clickable at point (1230,153) because another element <div> obscures it At: File "/home/jenkins/workspace/ovirt-master_change-queue-tester@2/ovirt-system-tests/basic-suite-master/test-scenarios/100_basic_ui_sanity.py", line 396, in virtual_machines vm_list_view.poweroff() The screenshot [1] indeed shows a message "Finished Launching VM vm0" partially hiding the "Shutdown" button. IIUC this is a new test added recently [2]. Lucia, can you please quickly have a look at this and fix the test (to press the "X", or the "Dismiss all", or "Do not disturb", or whatever you think is best)? If you are too busy with other stuff, perhaps revert [2] for now. Thanks! Best regards, [1] https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21164/artifa… [2] https://gerrit.ovirt.org/107394 -- Didi

2 2

Imageio download of qcow2 images
by Jakub Dżon 11 Mar '20

11 Mar '20

Hi, I'm looking into how current state of a volume (as seen by the VM) can be downloaded in raw format using imageio and I wonder what is the behavior when I request a qcow2 volume. Will it always return the top snapshot in qcow2 format? I understand that in 4.4 I can explicitly specify format=types.DiskFormat.RAW when creating the transfer to get the current state of the disk converted to raw format. Is that also possible in older versions and how? -- Thanks, Jakub Dżon

2 3

OST basic suite fails on 002_bootstrap.add_secondary_storage_domains
by Yedidyah Bar David 10 Mar '20

10 Mar '20

Hi all, Anyone looking at this? See e.g.: https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21146/ Thanks, -- Didi

3 3

ovirt-engine has been tagged (ovirt-engine-4.3.9.3)
by Tal Nisan 10 Mar '20

10 Mar '20

1 0

Propose Sharon Gratch as oVirt FE maintainer
by Tomas Jelinek 10 Mar '20

10 Mar '20

Hey all, Sharon have started to contribute to oVirt ~4 years ago. In that time she contributed 100+ patches ranging from small bug fixes to large features gaining good understanding of the system. I had a pleasure to closely collaborate with her for quite a significant time and I can say that her diligence and pedantic nature made her a great developer and I believe the same qualities will make her a great UI maintainer. So, I would like to propose Sharon to become an oVirt UI maintainer. thank you, Tomas

8 7

Ovirt SDK does not assign role to user
by raymond.francis＠oracle.com 09 Mar '20

09 Mar '20

In my code below I create a user in Ovirt SDK via its CLI. UserUtils.addUser(engineHost, USER, "John12", "Doe12"); UserUtils.setPassword(engineHost, USER, "abcdef"); I then create a Map of permissions for a new role Role addedRole = addRole(sysService, new RoleBuilder() .administrative(true) .name(expName) .description(expDescription) .permits(RoleUtils.createTestPermits(new ArrayList<>(expectedPermits.keySet()))) .build()); And build the user with same role. UserBuilder builder = new UserBuilder().userName(USER).lastName("Doe").name("John").domain(domainBuilder).roles(addedRole); However, when i create my connection as follows... connection = ConnectionUtils.createConnection(engineUrl, USER + "@internal-authz", "abcdef"); sysService = ConnectionUtils.getReferenceToSystemServices(connection); It doesnt allow user login 2020-03-09 16:12:04,686/GMT [main] ERROR framework (StepLogger.java:96:onTestFailure) - ------------------- Test failed UserRoleTest.testUserRole() @68d6972f [pri:0] ----- org.ovirt.engine.sdk4.Error: Error during SSO authentication "access_denied" : "Cannot authenticate user 'a0e04eda-396c-46f1-9b4b-11d7c6@internal-authz': No valid profile f at org.ovirt.engine.sdk4.internal.HttpConnection.getAccessToken(HttpConnection.java:377) Full code below. As you can see, the new role includes login permissions. If i go in as the admin user, i can see that while the role has been successfully added, it does not get assigned to the user. @Test(description = "Test role assigned to user") public void testUserRole() throws NoSuchFieldException, IllegalAccessException { UserUtils.addUser(engineHost, USER, "John12", "Doe12"); UserUtils.setPassword(engineHost, USER, "abcdef"); DomainBuilder domainBuilder = new DomainBuilder().id("696E7465726E616C2D617574687A").name("internal-authz"); String typeName = "AAAA"; String expName = typeName + OvirtCommonUtils.returnUniqueID("");; String expDescription = "I am a new Test User"; Map<String,String> expectedPermits = new HashMap<>(); sysService.rolesService().roleService("UserVmManager").get(); // expectedPermits.put("1", "create_Vm"); expectedPermits.put("2", "delete_vm"); expectedPermits.put("3", "edit_vm_properties"); expectedPermits.put("5", "change_vm_cd"); expectedPermits.put("7", "connect_to_vm"); expectedPermits.put("9", "configure_vm_network"); expectedPermits.put("10", "configure_vm_storage"); expectedPermits.put("12", "manipulate_vm_snapshots"); expectedPermits.put("1100", "create_disk"); expectedPermits.put("1101", "attach_disk"); expectedPermits.put("1102", "edit_disk_properties"); expectedPermits.put("1104", "delete_disk"); expectedPermits.put("502", "manipulate_permissions"); expectedPermits.put("1300", "login"); expectedPermits.put("503", "add_users_and_groups_from_directory"); expectedPermits.put("17", "reboot_vm"); expectedPermits.put("18", "stop_vm"); expectedPermits.put("19", "shut_down_vm"); expectedPermits.put("21", "hibernate_vm"); expectedPermits.put("22", "run_vm"); expectedPermits.put("1664", "connect_to_serial_console"); expectedPermits.put("1668", "assign_cpu_profile"); expectedPermits.put("1108", "sparsify_disk"); expectedPermits.put("1109", "reduce_disk"); expectedPermits.put("1110", "backup_disk"); //create role Role addedRole = addRole(sysService, new RoleBuilder() .administrative(true) .name(expName) .description(expDescription) .permits(RoleUtils.createTestPermits(new ArrayList<>(expectedPermits.keySet()))) .build()); UserBuilder builder = new UserBuilder().userName(USER).lastName("Doe").name("John").domain(domainBuilder).roles(addedRole); PermissionBuilder permissionBuilder = new PermissionBuilder().id("1").name("Do something").user(builder); connection = ConnectionUtils.createConnection(engineUrl, USER + "@internal-authz", "abcdef"); sysService = ConnectionUtils.getReferenceToSystemServices(connection);

1 0

Porting basic suite to pytest
by Marcin Sobczyk 08 Mar '20

08 Mar '20

Hi All, I've been experimenting with porting basic suite from nose to pytest. The rationale behind my efforts were nose being deprecated since a long time [1] and the ability to use pytest's awesome fixtures. Turns out it's not really that hard - with two patches [2][3] I was able to lay the groundwork for non-distruptive and incremental process of porting the basic suite module by module. You can find the steps needed to port a certain module described in [2]. Please find the patches that do the actual porting in this topic [4]. One of the hurdles of using pytest vs nose is that the former executes the test functions in the order they appear in the module. This comes from the reasoning, that tests should be independent, which is not the case for OST. Reordering the test functions to match '_TEST_LIST' for '002_bootstrap' and '004_basic_sanity' modules would make a huge disruption, so I've decided to use a 'pytest-ordering' plugin that allows you to define the order with '@pytest.mark.run(order=)' decorators. In other modules, like '003_basic_networking' and '006_migrations', minor refactoring was done, since "test" functions like 'migrate_vm' were used more than once in the module [5][6]. I tried to keep the changes minimal though - my aim was to do the porting - refinements can be done later. The junitxml reports generated by pytest seem to work fine, example of pytest-based module failure can be seen here [7]. Please let me know what do you think. Regards, Marcin [1] https://nose.readthedocs.io/en/latest/#note-to-users [2] https://gerrit.ovirt.org/#/c/107395 [3] https://gerrit.ovirt.org/#/c/107396 [4] https://gerrit.ovirt.org/#/q/topic:basic-suite-on-pytest+(status:open+OR+st… [5] https://github.com/oVirt/ovirt-system-tests/blob/73ed33aa6fbd471eb92593972e… [6] https://github.com/oVirt/ovirt-system-tests/blob/73ed33aa6fbd471eb92593972e… [7] https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/8224/

3 2