- Devel - oVirt List Archives

[Engine-devel] CPU topology in the API
by Simon Grinberg 30 Apr '12

30 Apr '12

Hi list, The current status is that though they look the same, CPU topology for hosts and VMs differ. In both you have <topology cores="N" sockets="Y"/> for hosts: Cores = Total cores on the host, Y=number of sockets for VMs: Cores = Cores per socket, Y=number of sockets This means that for a hosts that has 4 sockets with 8 cores per socket the topology will be presented as: <topology cores="32" sockets="4"/> While for VM with the same requested topology will show: <topology cores="8" sockets="4"/> I think they should not be different to avoid confusion but: * The information we displayed for the host can't count on the fact that cores are distributed evenly across sockets, because theoretically a host could contain several different CPUs, so it can't be displayed as a multiplication. * On the other hand changing the VM topology will break the API though it will make it aligned both with hosts and with the 'New VM' dialogue in the UI. For oVirt 3.x it may be that nothing can be changed however for oVirt it is allowed in theory to break the API (a bit :)) so the options as I see it are: 1. Don't touch, leave the confusion. 2. Make host align to VMs with the risk that on some hosts this may be a bit misleading - should be rare. 3. Make host topology looks like VM but allow multiple CPU topologies in the CPUs sub collection of the host. (This also requires change in VDSM API) 4. Align VMs to Hosts I would go for 4 or 2 Current CPU topology for the hosts is a new commit, thus it may be allowed to change it now since no one is using it yet. This works in favour of 2. In any case only 3 discloses all the information in all possible cases. Thoughts? Thanks, Simon.

3 5

[Engine-devel] Moving oVirt engine to Jboss AS 7.1.1
by Oved Ourfalli 29 Apr '12

29 Apr '12

Hey all, We have pushed patches that make the necessary adjustments to allow working with the newest Jboss version, Jboss AS 7.1.1 Final. After fetching please do the following: * Download Jboss AS 7.1.1.Final from http://download.jboss.org/jbossas/7.1/jboss-as-7.1.1.Final/jboss-as-7.1.1.F… * Change the JBOSS_HOME wherever you defined it. * Change the Jboss Home in ~/.m2/settings.xml. * Run a full build, including setup: mvn clean install -DskipTests -Psetup,dep (consider using flags -Dgwt.userAgent=gecko1_8 and -Dgwt.draftCompile=true to avoid compiling GWT on all permutations). * Run jboss as usual. If you have any issues, reply here and we'll do anything to help. The oVirt engine wiki page (http://www.ovirt.org/wiki/Building_oVirt_engine) was changes accordingly. Thank you, Oved

1 0

[Engine-devel] +1 in gerrit
by Laszlo Hornyak 29 Apr '12

29 Apr '12

Hi, Just an idea for the gerrit reviews: if you review a patch and give "+1 Looks good to me, but someone else must approve", then please add someone as reviewer, who might be the right person. And then after a while the patch will get to someone who knows if the patch is good or not. Laszlo

3 2

[Engine-devel] namingcontexts getting ignored.
by Sharad Mishra 29 Apr '12

29 Apr '12

Hi, I enter "getDefaultNamingContextFromNamingContexts()" with namingContexts set to - namingcontexts: CN=SCHEMA, CN=LOCALHOST, CN=IBMPOLICIES, O=IBM.COM, O=DELETED.IBM.COM But this method only takes the first case "CN=SCHEMA" and ignores the rest. Actually I am interested in "O=IBM.COM". Is this working as designed or needs improvement? -Sharad Mishra IBM public class RootDSEData { private String domainDN = null; private LdapProviderType ldapProviderType = null; private final static String RHDS_NAMING_CONTEXT = "o=netscaperoot"; public static String getDefaultNamingContextFromNamingContexts(Attribute namingContexts) { for (int index = 0; index < namingContexts.size(); ++index) { String namingContext; try { namingContext = (String) namingContexts.get(index); } catch (NamingException e) { return null; } if (!RHDS_NAMING_CONTEXT.equalsIgnoreCase(namingContext)) { return namingContext; } } return null; }

3 4

[Engine-devel] bi-weekly status
by Livnat Peer 24 Apr '12

24 Apr '12

Hi All, It is memorial day in Israel tomorrow, so I am canceling tomorrow's ovirt-engine-core meeting. Please reply on the list if there is something that can't/shouldn't wait for next meeting and I'll schedule a meeting for next week instead of this one. Thanks, Livnat

1 0

[Engine-devel] upstream/downstream compat
by Ryan Harper 23 Apr '12

23 Apr '12

I've submitted some changes to start some of the work of removing the RHEV/RHEVM names throughout the vdsm code. In one of the patches, there's a good discussion on compatibility with downstream[1] And I wanted to continue that on the mailing list so we could have more eyes; it's not clear to me if everyone is able to see/participate in an inline thread to just one of my patches. To the point; as we look at moving toward an upstream vdsm which may be used stand-alone; ie, it may or may not having ovirt-engine/RHEVM driving actions. I'm interested in hearing details what our requirements for compatibility are and which parts of the tree might be affected. I'd like to posit that downstream compat is the responsibility of the distro versus the upstream community; though that's not a license to make things difficult. IMHO, this means we can do things that help clean up the code or move the project in a particular direction without having to always worry about what the package looks like in a particular distro. The other aspect to compatibility I'd like to hear details/discussion on the interfaces (explicit or implicit) between vdsm and ovirt-engine. I rekindled a discussion[2] on at least one known issue around engine including the qemu machine type in the database; Any pointers to other places would be helpful as I'm wrapping my head around the back and forth between vdsm and engine. 1. http://gerrit.ovirt.org/#patch,unified,3287,1,vds_bootstrap/vds_bootstrap.py 2. http://lists.ovirt.org/pipermail/engine-devel/2012-April/001209.html -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh(a)us.ibm.com

2 4

[Engine-devel] StorageHelperDirector "factory" and StorageType
by Yair Zaslavsky 23 Apr '12

23 Apr '12

Hi all, StorageHelperDirector.java implements a mechanism that creates instances of classes implementing IStorageHelper based on String value of StorageType enum. Although the InitializeHelpers method has an "automated" mechanism for creating the helpers, I think it causes some bad practice - It creates a tight coupling between the StorageType values and the class names of storage helpers, and a result of that, Java naming convention is broken (we use upper case enum literals at StorageType which yield class names such as LOCALFSStorageHelper. I think that this mechanism is an overkill, and during addition of new storage type, its easily to detect during development if one has forgotten to add the helper to the factory (if done manually). Thoughts about this issue are more than welcome Yair

3 2

[Engine-devel] [Jenkins] ovirt engine unit tests fails
by Eyal Edri 23 Apr '12

23 Apr '12

fyi, 2 unit tests fails currently on ovirt-engine: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/657/#showFailuresLink org.ovirt.engine.core.bll.QueriesCommandBaseTest.testQueryCreation org.ovirt.engine.core.bll.GetAllDisksByVmIdQueryTest.testExecuteQueryCommand Please check, Eyal.

1 0

[Engine-devel] oVirt database upgrade procedure moved
by Eli Mesika 20 Apr '12

20 Apr '12

New location http://www.ovirt.org/wiki/OVirt-database-upgrade-procedure

1 0

[Engine-devel] [Jenkins] unit test fails
by Eyal Edri 19 Apr '12

19 Apr '12

fyi, 1 unit test fails after these commits: (lots of commits, since the Jenkins server was stuck during that time). http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/626/ the failed test: org.ovirt.engine.core.utils.serialization.json.JsonObjectSerializerTest.testSerialize Eyal Edri oVirt Infra Team.

2 1