- Devel - oVirt List Archives

Re: [Engine-devel] Problem with detachment of host interface using ovirt-sdk
by Itzik Brown 07 May '12

07 May '12

Juan, I used the repository git://gerrit.ovirt.org/ovirt-engine-sdk Commit 3c721e60ab3af3ad07e1a20bc6fdbcdbc1344df0 The test script : #!/usr/bin/python import sys from ovirtsdk.api import API from ovirtsdk.xml import params OVIRT_ENGINE_SERVER = 'server1' OVIRT_ENGINE_PORT = '8080' OVIRT_ENGINE_USER = 'admin@internal' OVIRT_ENGINE_PASSWORD = 'password' url = 'http://%s:%s' % (OVIRT_ENGINE_SERVER, OVIRT_ENGINE_PORT) api = API(url = url, username = OVIRT_ENGINE_USER , password = OVIRT_ENGINE_PASSWORD) host = 'host1' if_name = 'eth4' net_name = 'net1' nic = api.hosts.get(name=host).nics.get(name=if_name) net = params.Network(name=net_name) act = params.Action(network=net) nic.detach(act) api.hosts.get(name=host).commitnetconfig() Thanks, Itzik

2 1

[Engine-devel] [Jenkins] new High priority bug in ovirt-engine
by Eyal Edri 06 May '12

06 May '12

fyi, a new HIGH priority bug was pushed to ovirt-engine, please check. bug details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/765/findbugsResult/HIGH… Found in file: VmPropertiesUtils.java:362, GC_UNRELATED_TYPES Introduced after these commits: engine: Create Gluster Volume enhancements (detail / gitweb) core: removing async tasks and compensation data on upgrade (detail / gitweb) engine: support versions for vm properties (detail / gitweb) webadmin: support versions for vm properties (detail / gitweb) core: Fixing bll tests (detail / gitweb) engine: New query to fetch Gluster Volume by ID (detail / gitweb) Eyal.

2 1

[Engine-devel] vds_bootstrap.py 's residency
by Shu Ming 03 May '12

03 May '12

Hi, I am checking the VDSM and ovirt-engine workspace for "vds_bootstrap.py" file. It was found that vds_bootstrap.py file was in VDSM workspace and was packaged into vdsm-bootstrap rpm package. Also, it was found that in the host installation process, host node will try to get the "vds_bootstrap.py" from the engine server. But "vds_bootstrap.py" is not included in any engine packages. Does that mean we should install vdsm-bootstrap package into engine server? Why not package this file into engine packages instead of vdsm packages? -- Shu Ming<shuming(a)linux.vnet.ibm.com> IBM China Systems and Technology Laboratory

3 2

Re: [Engine-devel] Logical network Usages collection problematic approach
by Eoghan Glynn 03 May '12

03 May '12

> The new design of logical network 'usages' collection came out a bit > problematic or shall i say annoying. > The idea is to send the entire collection elements every time a user > wants to update a single usage otherwise the missing elements will be > automatically removed from the collection. > > Example: > having <usages><usage>VM</usage><usages> > 1. in order to add 'display' usage to the collection i must send 'vm' > as well. > 2. to remove an element from the collection, i must send the entire > collection without the desired element > (note: in this case it is only one extra element for every update but > in other cases it could be much more) Yep, this seems to conflict with the general idiom around the interpretation of missing properties in a PUT representation - i.e. any properties omitted from the representation are ignored and not changed. > The solution should be: > <usages><vm>true</vm><display>false</display></usages> > That way we can send a single usage having different boolean text > without including the entire collection elements. I wonder would a POST/DELETE idiom be more natural, if the individual usages would be pressed into service as a psuedo-OID, e.g: POST .../networks/network_id/usages HTTP/1.1 <usage id="VM"/> 201 Created Location: .../networks/network_id/usages/VM <usage id="VM" href=".../networks/network_id/usages/VM"/> -- GET .../networks/network_id/usages HTTP/1.1 200 OK Location: .../networks/network_id/usages/VM <usages> <usage id="VM" href=".../networks/network_id/usages/VM"/> </usages> -- POST .../networks/network_id/usages HTTP/1.1 <usage id="display"/> 201 Created Location: .../networks/network_id/usages/display <usage id="display" href=".../networks/network_id/usages/display"/> -- GET .../networks/network_id/usages HTTP/1.1 200 OK <usages> <usage id="VM" href=".../networks/network_id/usages/VM"/> <usage id="display" href=".../networks/network_id/usages/display"/> <usages> -- DELETE .../networks/network_id/usages/VM 204 No Content -- GET .../networks/network_id/usages HTTP/1.1 200 OK <usages> <usage id="display" href=".../networks/network_id/usages/display"/> <usages> So from each usage would appear like a first class resource from the perspective of the creation/deletion idiom. If the client providing the ID is considered inconsistent, this could be a "name" child element instead, e.g.: POST .../networks/network_id/usages HTTP/1.1 <usage> <name>display</name> </usage> 201 Created Location: .../networks/network_id/usages/display <usage id="display" href=".../networks/network_id/usages/display"> <name>display</name> </usage> Cheers, Eoghan

2 2

[Engine-devel] Naming convention in db upgrade script temporary functions
by Eli Mesika 03 May '12

03 May '12

Hi >From now on, please use the prefix __temp_<function name> for temporary functions defined in a db upgrade scripts The reasons are 1) Each time that you have to rename your upgrade script after sync with master you have to rename the function as well 2) As a result, may function are pushed with a wrong suffix (for example upgrade 03_01_0950 had a function name suffix of 08200) Since the reason for that numbering was in the first place for avoiding dropping real installed functions, now you will have just to put in a temporary function created in an upgrade script just the prefix "__temp_" Hope that this will make handling upgrade scripts more accurate and less painful. This was documented as well at the oVirt db upgrade wiki page: http://www.ovirt.org/wiki/OVirt-database-upgrade-procedure (see section 1.5 Temporary Functions in Upgrade scripts)

1 0

[Engine-devel] Fwd: Checkstyle- Webadmin & userportal localization
by Alona Kaplan 02 May '12

02 May '12

Hi, Yesterday some changes were made in oVirt's checkstyle (http://gerrit.ovirt.org/#change,3760) 1. Renaming built-tools to build-tools-root and separating it into two packages: * checksyles- for checkstyle xml files. * ovirt-checkstyle-extension- for adding new (not built-in) checkstyle checks. 2. Adding to the checkstyle.xml a new check- NlsCheck, which fails the compilation in case non-externalized strings appear in the code. [To understand more about the need of this check, see http://gerrit.ovirt.org/#change,3612] >From now on, all strings in the web-admin/user-portal java code should be one of the following: - Externalized (in case the string should be localized) - Have a "//$NON-NLS-N$" comment next to them (in case the string shouldn't be externalized, e.g. HashName of a component) If there is a non externalized string in a web-admin/user-portal java file and there is no "//$NON-NLS-N$" comment next to it, mvn compilation will fail. Note: NlsCheck is currently configured to run only on web-admin/user-portal projects. If you want NlsCheck check to run on another project, please add the following to the configuration of the checkstyle in the project's pom file: <propertyExpansion>runNlsCheck=true</propertyExpansion> Alona.

3 2

[Engine-devel] Updating ovirt engine from 3.0 to the 3.1.0 version
by Shu Ming 02 May '12

02 May '12

Hi, I built a set of ovirt engine RPM packages from near the latest ovirt engine source code. However, when I try to access the engine server with URL "http://ovirt-engine-112:80", the browser displayed a blank page without http error returned. Any clue about what is going on here? Why didn't the engine administrator home page be shown? And the packages were also installed successfully in my target system, checked this by "rpm -q -a|grep engine". I) upgraded the packages to the 3.1 [root@ovirt-engine-112 ~]# rpm -q -a |grep engine ovirt-engine-restapi-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-dbscripts-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-log-collector-3.0.0_0001-1.6.fc16.x86_64 ovirt-engine-genericapi-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-backend-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-setup-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-jbossas-1.2-2.fc16.x86_64 ovirt-engine-jboss-deps-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-config-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-webadmin-portal-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-userportal-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-tools-common-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-image-uploader-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-notification-service-3.1.0_0001-1.8.fc16.x86_64 ovirt-engine-iso-uploader-3.1.0_0001-1.8.fc16.x86_64 gtk2-engines-2.20.2-2.fc15.x86_64 Step II) Then I used "engine-setup" to setup the engine. It seems that everything is ok, see the log below. ------------- [root@ovirt-engine-112 ~]# engine-setup Welcome to oVirt Engine setup utility HTTP Port [80] : HTTPS Port [443] : Host fully qualified domain name, note that this name should be fully resolvable [ovirt-engine-112] : ERROR: domain is not a valid domain name User input failed validation, do you still wish to use it? (yes|no): yes Password for Administrator (admin@internal) : Warning: Weak Password. Confirm password : Organization Name for the Certificate: cstl The default storage type you will be using ['NFS'| 'FC'| 'ISCSI'] [NFS] : Enter DB type for installation ['remote'| 'local'] [local] : Local database password : Warning: Weak Password. Confirm password : Should the installer configure NFS share on this server to be used as an ISO Domain? ['yes'| 'no'] [yes] : Mount point path: /iso-dom ERROR: mount point already exists in /etc/exports Mount point path: /iso-dom Display name for the ISO Domain: iso-domains Firewall ports need to be opened. You can let the installer configure iptables automatically overriding the current configuration. The old configuration will be backed up. Alternately you can configure the firewall later using an example iptables file found under /usr/share/ovirt-engine/conf/iptables.example Configure iptables ? ['yes'| 'no']: yes oVirt Engine will be installed using the following configuration: ================================================================= http-port: 80 https-port: 443 host-fqdn: ovirt-engine-112 auth-pass: ******** org-name: cstl default-dc-type: NFS db-remote-install: local db-local-pass: ******** nfs-mp: /iso-dom iso-domain-name: iso-domains config-nfs: yes override-iptables: yes Proceed with the configuration listed above? (yes|no): yes Installing: Configuring oVirt-engine... [ DONE ] Creating CA... [ DONE ] Editing JBoss Configuration... [ DONE ] Setting Database Configuration... [ DONE ] Setting Database Security... [ DONE ] Creating Database... [ DONE ] Updating the Default Data Center Storage Type... [ DONE ] Editing oVirt Engine Configuration... [ DONE ] Editing Postgresql Configuration... [ DONE ] Configuring the Default ISO Domain... [ DONE ] Configuring Firewall (iptables)... [ DONE ] Starting JBoss Service... [ DONE ] Handling HTTPD... [ DONE ] **** Installation completed successfully ****** (Please allow oVirt Engine a few moments to start up.....) Additional information: * SSL Certificate fingerprint: C6:01:83:93:4B:2C:2A:38:65:C8:49:C9:17:34:FE:4B:1C:10:D5:FF * SSH Public key fingerprint: 69:8c:bd:05:43:17:0a:43:a3:cc:62:7e:f7:be:0c:42 * A default ISO share has been created on this host. If IP based access restrictions are required, please edit /iso-dom entry in /etc/exports * The firewall has been updated, the old iptables configuration file was saved to /usr/share/ovirt-engine/conf/iptables.backup.011513-04282012_2225 * The installation log file is available at: /var/log/ovirt-engine/engine-setup_2012_04_28_01_13_01.log * Please use the user "admin" and password specified in order to login into oVirt Engine * To configure additional users, first configure authentication domains using the 'engine-manage-domains' utility * To access oVirt Engine please go to the following URL: http://ovirt-engine-112:80 [root@ovirt-engine-112 ~]# -- Shu Ming<shuming(a)linux.vnet.ibm.com> IBM China Systems and Technology Laboratory

2 8

[Engine-devel] Disk Cloning When Creating a VM via a Template
by Schoenbrun, Dustin 02 May '12

02 May '12

--_000_0A1534657992624AACDCA570F1D3E20003C29F05SACEXCMBX03PRDh_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Greetings, I know that floating disks are coming in the next version of oVirt, but in = the interim I want to know internally what the procedure is when a disk is = cloned when creating a VM from a template. I see the AddVmImages() method = in the AddVmFromTemplateCommand.java file, but could someone walk me throug= h exactly what is going on when the disk gets cloned? Thanks! -- Dustin --_000_0A1534657992624AACDCA570F1D3E20003C29F05SACEXCMBX03PRDh_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> <p class=3D"MsoNormal">Greetings,<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">I know that floating disks are coming in the next ve= rsion of oVirt, but in the interim I want to know internally what the proce= dure is when a disk is cloned when creating a VM from a template.  I s= ee the AddVmImages() method in the AddVmFromTemplateCommand.java file, but could someone walk me through exactly what is going on when the = disk gets cloned?  Thanks!<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">-- Dustin<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> </body> </html> --_000_0A1534657992624AACDCA570F1D3E20003C29F05SACEXCMBX03PRDh_--

3 4

[Engine-devel] Logical network Usages collection problematic approach
by avi tal 01 May '12

01 May '12

Hi, The new design of logical network 'usages' collection came out a bit problematic or shall i say annoying. The idea is to send the entire collection elements every time a user wants to update a single usage otherwise the missing elements will be automatically removed from the collection. Example: having <usages><usage>VM</usage><usages> 1. in order to add 'display' usage to the collection i must send 'vm' as well. 2. to remove an element from the collection, i must send the entire collection without the desired element (note: in this case it is only one extra element for every update but in other cases it could be much more) The solution should be: <usages><vm>true</vm><display>false</display></usages> That way we can send a single usage having different boolean text without including the entire collection elements.

2 1

Re: [Engine-devel] [vdsm] reserve virtio-balloon device created by libvirt
by Itamar Heim 01 May '12

01 May '12

On 04/29/2012 04:19 PM, Dan Kenigsberg wrote: > On Sun, Apr 29, 2012 at 07:24:52AM -0400, Andrew Cathrow wrote: >> >> >> ----- Original Message ----- >>> From: "Dan Kenigsberg"<danken(a)redhat.com> >>> To: "Gal Hammer"<ghammer(a)redhat.com> >>> Cc: vdsm-devel(a)lists.fedorahosted.org >>> Sent: Sunday, April 29, 2012 7:19:10 AM >>> Subject: Re: [vdsm] reserve virtio-balloon device created by libvirt >>> >>> On Mon, Apr 23, 2012 at 04:00:55PM +0300, Gal Hammer wrote: >>>> On 23/04/2012 12:26, Mark Wu wrote: >>>>> Hi guys, >>>>> >>>>> I saw that an option to create balloon device was added by Gal in >>>>> http://gerrit.ovirt.org/1573 >>>>> I have a question about it. Why don we preserve the old default >>>>> behaviour? I know it's not supported by ovirt-engine now, but I >>>>> can't >>>>> figure out what will break if it's not disabled explicitly. So do >>>>> you >>>>> think we can just make use of the balloon device added by libvirt? >>>> >>>> We didn't change the old behavior. >>>> >>>> Libvirt creates by default a memory-balloon device, so vdsm >>>> defaults >>>> was to disable it by adding a "none"-type device. This was done >>>> because vdsm didn't include an option to add such device. >>>> >>>> My patch added an option to create a memory-balloon through vdsm. >>>> If >>>> the user didn't request to add the device, the behavior is same as >>>> before, disabling the memory-balloon. >>> >>> I feel that it would be best not to flip Vdsm's default at the >>> moment, >>> even though it is the opposite of libvirt's. I would consider to flip >>> them only after your (Mark's) patches are in, tested, and proven >>> worthwhile for the common case. >>> >>> Currently, without any management for the balloon, reserving a guest >>> PCI >>> device was deemed wasteful. >> >> On the other side of the fence >> - We know that we do need to do ballooning >> - In the (next?) release we'll end up adding this support >> - There's no harm (see next point) in adding the device now in fact it saves a config change on upgrade. > > Well, there is a surprise factor, for someone running a guest generated > in a previous version. Suddenly, after Vdsm upgrade, it would see an > additional device. At the least, I would like Vdsm to have a > configurable option to keep the old behavior. please take into consideration engine has an algorithm testing max number of devices and it should be aware of newly introduced devices by vdsm or it will overflow. > >> - While it takes up a PCI slot it's going to be very, very rare deployments that will ever see the limit, libvirt/virtmanager/virt-install has done this forever without seeing push back. > > > _______________________________________________ > vdsm-devel mailing list > vdsm-devel(a)lists.fedorahosted.org > https://fedorahosted.org/mailman/listinfo/vdsm-devel

3 2