[Engine-devel] agenda for todays meeting
by Livnat Peer
Hi All,
We don't have an agenda for today - open for suggestions.
If no other requests will be suggested for today's agenda we'll discuss
storage live migration and who ever is interested can join us.
Federico/ayal can you make the slot today at 1600?
Thanks, Livnat
12 years, 8 months
[Engine-devel] [backend] logger declarations
by Laszlo Hornyak
Hi,
In general loggers are recommended to be private static final, also have the correct class. (e.g. commons logging standards from PMD http://pmd.sourceforge.net/rules/logging-jakarta-commons.html)
In oVirt backend, very often the logger is just package protected, which allows classes in the same package to use it. Actually the classes that really use it are usualy subclasses, but what I believe is misleading in this case is that when reading a log, you will see that e.g. org.foo.Bar logged 'X', and you look into the sourcecode of org.foo.Bar and you do not see any code that would ever log that message, you will have to look for that message in all of it's subclasses and this will make debugging harder especially if the number of subclasses is high.
I am trying to maintain a coding standard here, please feel free to edit:
http://www.ovirt.org/wiki/Backend_Coding_Standards
Thank you,
Laszlo
12 years, 8 months
[Engine-devel] setup newtorks UI sync meeting MOM
by Roy Golan
MTU
∘ provision MTU when network is down
∘ valid values? -1, minimum = 68, maximum = configurable
∘ MTU -1 -> dont send the value to VDSM let the default take place
∘ mtu checkbox, label : "override MTU" , unchecked, value box always blank when uncheck.
∘ mtu box checked, show a box for a value
∘ support matrix of co-exisiting networks MTU values on single interface - open issue
STP
• remove stp from the dialog
VM network
• checked by default for management network as well
Setup network
∘ On what host status we allow to run setup networks on ? - open issue
∘ boxes are a bit naked. Add icons for allowed actions on each interface box.
12 years, 8 months
[Engine-devel] network - UI Sync meeting
by Roy Golan
--=_ecaa160f-be85-47b6-8d28-5b3159110abb
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
The following meeting has been modified:
Subject: network - UI Sync meeting
Organizer: "Roy Golan" <rgolan(a)redhat.com>
Location: [MODIFIED]
Time: Monday, March 5, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem [=
MODIFIED]
Invitees: mkenneth(a)redhat.com; sgrinber(a)redhat.com; lpeer(a)redhat.com; dfedi=
uck(a)redhat.com; drankevi(a)redhat.com; ecohen(a)redhat.com; iheim(a)redhat.com; o=
vedo(a)redhat.com; acathrow(a)redhat.com; engine-devel(a)ovirt.org; kroberts@redh=
at.com ...
*~*~*~*~*~*~*~*~*~*
Follow-up meeting on setup networks UI.
Last meeting AIs:
=E2=88=98 "Edit..." button should be placed on the network to cover cases o=
f single interface to multiple network.
=E2=88=98 "i" icon on each logical network to have details: vlan, mtu, VmNe=
tworks, mandatoy...
=E2=88=98 right-hand breakdown VM-networks|VLAN/Non-VLAN|optional
issues to follow:
1. can VDSM attach many non-vlan and many vlan networks to a single nic? (D=
an - please reply if its doable)
Bridge ID: 1814335863
https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers=
ByCode.do?confCode=3D1814335863
--=_ecaa160f-be85-47b6-8d28-5b3159110abb
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable
<html><body><h3>The following meeting has been modified:</h3>
<p>
<table border=3D'0'>
<tr><th align=3Dleft>Subject:</th><td>network - UI Sync meeting </td></tr>
<tr><th align=3Dleft>Organizer:</th><td>"Roy Golan" <rgolan(a)redhat.com&g=
t; </td></tr>
</table>
<p>
<table border=3D'0'>
<tr><th align=3Dleft>Location:</th><td> [MODIFIED]</td></tr>
<tr><th align=3Dleft>Time:</th><td>Monday, March 5, 2012, 4:00:00 PM - 5:00=
:00 PM GMT +02:00 Jerusalem [MODIFIED]
</td></tr></table>
<p>
<table border=3D'0'>
<tr><th align=3Dleft>Invitees:</th><td>mkenneth(a)redhat.com; sgrinber@redhat=
.com; lpeer(a)redhat.com; dfediuck(a)redhat.com; drankevi(a)redhat.com; ecohen@re=
dhat.com; iheim(a)redhat.com; ovedo(a)redhat.com; acathrow(a)redhat.com; engine-d=
evel(a)ovirt.org; kroberts(a)redhat.com ... </td></tr>
</table>
<div>*~*~*~*~*~*~*~*~*~*</div><br><br>Follow-up meeting on setup networks U=
I. <br><br>Last meeting AIs:<br>=E2=88=98 "Edit..." button should be placed=
on the network to cover cases of single interface to multiple network.<br>=
=E2=88=98 "i" icon on each logical network to have details: vlan, mtu, VmNe=
tworks, mandatoy...<br>=E2=88=98 right-hand breakdown VM-networks|VLAN/Non=
-VLAN|optional<br><br>issues to follow: <br>1. can VDSM attach many non-vla=
n and many vlan networks to a single nic? (Dan - please reply if its doable=
) <br><br><br>Bridge ID: 1814335863 <br><br>https://www.intercallonline.com=
/portlets/scheduling/viewNumbers/listNumbersByCode.do?confCode=3D1814335863=
</body></html>
--=_ecaa160f-be85-47b6-8d28-5b3159110abb
Content-Type: text/calendar; charset=utf-8; method=REQUEST; name=meeting.ics
Content-Transfer-Encoding: quoted-printable
BEGIN:VCALENDAR
PRODID:Zimbra-Calendar-Provider
VERSION:2.0
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:Asia/Jerusalem
BEGIN:STANDARD
DTSTART:19710101T020000
TZOFFSETTO:+0200
TZOFFSETFROM:+0300
RRULE:FREQ=3DYEARLY;WKST=3DMO;INTERVAL=3D1;BYMONTH=3D9;BYDAY=3D2SU
TZNAME:IST
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:19710101T020000
TZOFFSETTO:+0300
TZOFFSETFROM:+0200
RRULE:FREQ=3DYEARLY;WKST=3DMO;INTERVAL=3D1;BYMONTH=3D3;BYDAY=3D-1FR
TZNAME:IDT
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VEVENT
UID:e6d6ce3a-e7f1-492b-9c52-65365ce2e235
SUMMARY:network - UI Sync meeting
ATTENDEE;CN=3DMiki Kenneth;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;R=
SVP=3DTRU
E:mailto:mkenneth@redhat.com
ATTENDEE;CN=3DSimon Grinberg;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION=
;RSVP=3DT
RUE:mailto:sgrinber@redhat.com
ATTENDEE;CN=3DLivnat Peer;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;RS=
VP=3DTRUE
:mailto:lpeer@redhat.com
ATTENDEE;CN=3DDoron Fediuck;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;=
RSVP=3DTR
UE:mailto:dfediuck@redhat.com
ATTENDEE;CN=3DDanny Rankevich;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTIO=
N;RSVP=3D
TRUE:mailto:drankevi@redhat.com
ATTENDEE;CN=3DEinav Cohen;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;RS=
VP=3DTRUE
:mailto:ecohen@redhat.com
ATTENDEE;CN=3DItamar Heim;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;RS=
VP=3DTRUE
:mailto:iheim@redhat.com
ATTENDEE;CN=3DOved Ourfalli;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;=
RSVP=3DTR
UE:mailto:ovedo@redhat.com
ATTENDEE;CN=3DAndrew Cathrow;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION=
;RSVP=3DT
RUE:mailto:acathrow@redhat.com
ATTENDEE;CN=3Dengine-devel;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;R=
SVP=3DTRU
E:mailto:engine-devel@ovirt.org
ATTENDEE;CN=3DKeith Robertson;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTIO=
N;RSVP=3D
TRUE:mailto:kroberts@redhat.com
ATTENDEE;CN=3DWilliam Henry;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;=
RSVP=3DTR
UE:mailto:whenry@redhat.com
ATTENDEE;CN=3DYaniv Kaul;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;RSV=
P=3DTRUE:
mailto:ykaul@redhat.com
ATTENDEE;CN=3DAyal Baron;ROLE=3DREQ-PARTICIPANT;PARTSTAT=3DNEEDS-ACTION;RSV=
P=3DTRUE:
mailto:abaron@redhat.com
X-MOZ-LASTACK:20120228T133242Z
X-MOZ-GENERATION:1
ORGANIZER;CN=3DRoy Golan:mailto:rgolan@redhat.com
DTSTART;TZID=3D"Asia/Jerusalem":20120305T160000
DTEND;TZID=3D"Asia/Jerusalem":20120305T170000
STATUS:CONFIRMED
CLASS:PUBLIC
X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY
TRANSP:OPAQUE
LAST-MODIFIED:20120305T131309Z
DTSTAMP:20120305T131309Z
SEQUENCE:4
DESCRIPTION:The following meeting has been modified:\n\nSubject: network - =
U
I Sync meeting \nOrganizer: "Roy Golan" <rgolan(a)redhat.com> \n\nLocation: =
[
MODIFIED]\nTime: Monday\, March 5\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +02=
:0
0 Jerusalem [MODIFIED]\n \nInvitees: mkenneth(a)redhat.com\; sgrinber@redhat=
.c
om\; lpeer(a)redhat.com\; dfediuck(a)redhat.com\; drankevi(a)redhat.com\; ecohen=
@r
edhat.com\; iheim(a)redhat.com\; ovedo(a)redhat.com\; acathrow(a)redhat.com\; en=
gi
ne-devel(a)ovirt.org\; kroberts(a)redhat.com ... \n\n\n*~*~*~*~*~*~*~*~*~*\n\n=
\n
Follow-up meeting on setup networks UI. \n\nLast meeting AIs:\n=E2=88=98 "=
Edit..." b
utton should be placed on the network to cover cases of single interface t=
o=20
multiple network.\n=E2=88=98 "i" icon on each logical network to have deta=
ils: vlan\
, mtu\, VmNetworks\, mandatoy...\n=E2=88=98 right-hand breakdown VM-netwo=
rks|VLAN/N
on-VLAN|optional\n\nissues to follow: \n1. can VDSM attach many non-vlan a=
nd
many vlan networks to a single nic? (Dan - please reply if its doable) \n=
\n
\nBridge ID: 1814335863 \n\nhttps://www.intercallonline.com/portlets/sched=
ul
ing/viewNumbers/listNumbersByCode.do?confCode=3D1814335863=20
X-ALT-DESC;FMTTYPE=3Dtext/html:<html><body><h3>The following meeting has be=
en=20
modified:</h3>\n\n<p>\n<table border=3D'0'>\n<tr><th align=3Dleft>Subject:=
</th><
td>network - UI Sync meeting </td></tr>\n<tr><th align=3Dleft>Organizer:</=
th><
td>"Roy Golan" <\;rgolan(a)redhat.com>\; </td></tr>\n</table>\n<p>\n<tab=
le
border=3D'0'>\n<tr><th align=3Dleft>Location:</th><td> [MODIFIED]</td></t=
r>\n<t
r><th align=3Dleft>Time:</th><td>Monday\, March 5\, 2012\, 4:00:00 PM - 5:=
00:0
0 PM GMT +02:00 Jerusalem [MODIFIED]\n </td></tr></table>\n<p>\n<table bor=
de
r=3D'0'>\n<tr><th align=3Dleft>Invitees:</th><td>mkenneth(a)redhat.com\; sgr=
inber@
redhat.com\; lpeer(a)redhat.com\; dfediuck(a)redhat.com\; drankevi(a)redhat.com\=
;=20
ecohen(a)redhat.com\; iheim(a)redhat.com\; ovedo(a)redhat.com\; acathrow(a)redhat.=
co
m\; engine-devel(a)ovirt.org\; kroberts(a)redhat.com ... </td></tr>\n</table>\=
n<
div>*~*~*~*~*~*~*~*~*~*</div><br><br>Follow-up meeting on setup networks U=
I.
<br><br>Last meeting AIs:<br>=E2=88=98 "Edit..." button should be placed =
on the net
work to cover cases of single interface to multiple network.<br>=E2=88=98 =
"i" icon o
n each logical network to have details: vlan\, mtu\, VmNetworks\, mandatoy=
..
.<br>=E2=88=98 right-hand breakdown VM-networks|VLAN/Non-VLAN|optional<br=
><br>issue
s to follow: <br>1. can VDSM attach many non-vlan and many vlan networks t=
o=20
a single nic? (Dan - please reply if its doable) <br><br><br>Bridge ID: 18=
14
335863 <br><br>https://www.intercallonline.com/portlets/scheduling/viewNum=
be
rs/listNumbersByCode.do?confCode=3D1814335863 </body></html>
BEGIN:VALARM
ACTION:DISPLAY
TRIGGER;RELATED=3DSTART:-PT5M
DESCRIPTION:Reminder
END:VALARM
END:VEVENT
END:VCALENDAR
--=_ecaa160f-be85-47b6-8d28-5b3159110abb--
12 years, 8 months
[Engine-devel] UI Related: Removal of SharedGwt module [imprtant notes]
by Asaf Shakarchi
All,
Gerrit ticket: http://gerrit.ovirt.org/#change,2164 was just merged,
This commit removes the SharedGwt module from oVirt maven structure,
This module aggregated backend source code of three modules: Common, Compat and SearchBackend for UI (gwt) modules during compile phase,
This is replaced now by a direct access to the backend modules using sources artifacts,
GWT module descriptor of SharedGwt maven module (named: SharedGwt.gwt.xml) contained a list of java classes that should be visible for the GWT compiler,
Since this module does not exist anymore, this file was split into three files per backend module:
Common.gwt.xml - Contains backend Common code that is visible to GWT compiler.
SearchBackend.gwt.xml - Contains SearchBackend code that is visible to GWT compiler.
Compat.gwt.xml - Contains backend Compat code that is visible to GWT compiler.
To avoid pushing UI related files directly into the backend modules, these files are located in gwt-common module, which contains shared code for UI modules.
In short: any backend source code that should be available during UI compilation which exist in Common|Compat|SearchBackend must be included in the appropriate GWT module descriptor according to its parent module.
Please contact me if this is causing any issue,
Regards,
+972-543094949
Asaf.
12 years, 8 months
[Engine-devel] Introducing virt / gluster flags at cluster level
by Shireesh Anjal
Hi,
In order to identify whether a cluster exposes Gluster / Virtualization
capabilities, we plan to introduce two boolean columns - virt_service
and gluster_service in the vds_groups table. As per immediate plans, it
is intended to support only one service per cluster, meaning only one of
these two values can be true.
We plan to make following changes as part of the patch:
1) Introduce an upgrade script for adding following columns to the table
"vds_groups"
- virt_service - boolean - NOT_NULL - default value true
- gluster_service - boolean - NOT_NULL - default value false
=> What is the naming convention for naming the upgrade script? Is it
<major-version>_<minor-version>_<running-sequence-with-step-10>_script_description.sql
? By that logic, the name of our script will be something like
03_01_0560_add_service_columns_to_vds_groups.sql
2) Modify vds_groups_sp.sql to introduce these arguments / variables in
save and update methods
3) Modify the DAO interface and implementation to introduce these
arguments / variables in the save/update methods and VdsGroupRawMapper.
4) Modify the DAO JUnit test class to take care of these new fields, if
required.
5) Modify class VDSGroup to introduce the two new boolean variables
virtService and glusterService and modify the methods equals and
hashCode to use these.
=> One question here. Most of the attributes of class VDSGroup have
annotations like @XmlElement and @Column. I think these are related to
jaxb and JPA. Are these annotations really required? If yes, how are
they useful?
6) REST API : Default populate these variables (virtService = true,
glusterService = false) before invoking the BLL command
(AddVdsGroupCommand / UpdateVdsGroupCommand). This makes sure that the
existing API won't break. No change in api.xsd for now.
7) webadmin create cluster code: Default populate the new variables,
same as above. No change in UI screen for now.
=> Alternatively, the variable declaration on VDSGroup itself can
initialize these variables with default values, so that changes to UI /
REST API code (points 6 and 7) may not be required immediately. What do
you suggest?
Inputs / comments / suggestions welcome.
--
Thanks,
Shireesh
12 years, 8 months
