October 2013 - Devel - oVirt List Archives

[Engine-devel] Introducing generics to UiCommon
by Tomas Jelinek 11 Oct '13

11 Oct '13

Hey all, as we have passed the oVirt feature freeze I would like to celebrate it with a little bit of cleanup :) A good candidate for this is to introduce generics into uicommonweb project. The fact that it is not generic brings quite some hidden expectations into our code, makes it unreadable and error prone. Also, the gwt-common and both webadmin and userportal are mostly prepared to be generic but because the uicommonweb is not, we have code like: new ListModelListBoxEditor<Object>(new NullSafeRenderer<Object>() { @Override public String renderNullSafe(Object object) return ((Version) object).getValue(); } }); which is quite ugly and error prone. So I have prepared two patches, one [1] which introduces the generic infrastructure (and prepares one widget for it, more about this below) and one [2] which uses it and refactors the DataCenterModel to use it (I have chosen this model because it is big enough to show how to do it and what the benefits are but small enough to be quickly review-able). The infrastructure change: - changes the ListModel and EntityModel to be genreic - adjusts the UiCommonEditorDriverGenerator to work with generics (e.g. to make it aware that ListModel<String> is indeed a ListModel, same for EntityModel) - created a String version of EntityModelTextBox The reason why the String EntityModelTextBox had to be created is that the EntityModelTextBox is an EditorWidget<Object, ...> so it can work only with EntityModel<Object>. I saw 2 ways how to make this work with EntityModel<String>: 1: Create a String version of this editor inside the .generic sub-package, incrementally replace the usage of the non-generic EntityModelTextBox and when the non-generic will be completely replaced, delete it and move the generic one out from the generic sub-package 2: Change the EditorWidget<Object, ...> to EditorWidget<T, ...> and replace each usage of the "EntityModelTextBox someWidget" by "EntityModelTextBox<Object> someWidget" and than incrementally replace the <Object> to <String> as the underlying models will be refactored. After the last one will be refactored, change the EditorWidget<T, ...> to EditorWidget<String, ...> and replace all "EntityModelTextBox<Object> someWidget" by "EntityModelTextBox someWidget" I have chosen the first option because: - much less classes touched at once (e.g. much more safe) - the EntityModelTextBox<T> invites to use something like EntityModelTextBox<VM> which is not correct and fails on class cast exceptions But at the same time I see the disadvantages of this approach (mostly that we have two versions of the same class). Please note that far not all the widgets will need two versions, only the ones editing only Strings which are declared as EditorWidget<Object> which are: - EntityModelLabel - EntityModelTextAreaLabel (used only in couple of places - can be refactored together without the need to have two versions) - EntityModelTextBox (already in the [1]) - EntityModelPasswordBox - EntityModelTextArea - ListModelSuggestBox (used only in couple of places - can be refactored together without the need to have two versions) The rest of the widgets should be already prepared to be used in generic environment. Please let me know what do you think about it, have a nice day, Tomas [1]: http://gerrit.ovirt.org/#/c/17604/ [2]: http://gerrit.ovirt.org/#/c/17605/

2 4

[Engine-devel] stale gerrit patches
by Itamar Heim 09 Oct '13

09 Oct '13

we have some very old gerrit patches. I'm for abandoning patches which were not touched over 60 days (to begin with, I think the number should actually be lower). they can always be re-opened by any interested party post their closure. i.e., looking at gerrit, the patch list should actually get attention, and not be a few worth looking at, with a "lot of old patches" thoughts? Thanks, Itamar

9 20

[Engine-devel] Cluster default with empty processor name with PPC64 support
by Leonardo Bianconi 08 Oct '13

08 Oct '13

--_000_50EB20226B72D6419356FC320AB62B8719173370SERV070corpeldo_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi everyone! During the development of PPC64 support in the engine, we faced some UX iss= ues regarding the default Cluster (that Cluster with empty processor name). Currently, oVirt engine allows the default Cluster to contain empty process= or name, and the administrator can add VMs and/or Templates to it. The proc= essor name can be assigned later, editing the cluster or assigning a valid = host to it. During the implementation of PPC64 support on the engine, the field "archit= ecture" was added to Clusters, VMs and Templates entities. So we have the following questions regarding how the UI should behave: - Shall we keep allowing the administrator to assign VMs and Templates to t= he Cluster with no processor name or assigned architecture ? -> If we have an "yes" for the question above: -- We will have to assign the architecture to the Cluster base= d on the OS of the first assigned VM, and the processor name could be defi= ned the same way as currently ... editing the Cluster or assigning a compat= ible Host to it. -- The VM creation popup will have to be able = to indicate the architecture of each OS ... some OSes have the same name, a= nd it may get ambiguous since the Cluster architecture is still undefined a= t that point (before the first VM get already created). Thanks! Regards. Leonardo Bianconi --_000_50EB20226B72D6419356FC320AB62B8719173370SERV070corpeldo_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"PT-BR" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> <p class=3D"MsoNormal"><span lang=3D"EN-US">Hi everyone!<o:p></o:p></span><= /p> <p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US">During the development of PPC64= support in the engine, we faced some UX issues regarding the default Clust= er (that Cluster with empty processor name).<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US">Currently, oVirt engine allows = the default Cluster to contain empty processor name, and the administrator = can add VMs and/or Templates to it. The processor name can be assigned late= r, editing the cluster or assigning a valid host to it.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US">During the implementation of PP= C64 support on the engine, the field “architecture“ was added t= o Clusters, VMs and Templates entities.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US">So we have the following questi= ons regarding how the UI should behave:<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US">- Shall we keep allowing the ad= ministrator to assign VMs and Templates to the Cluster with no processor na= me or assigned architecture ?<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US">     &= nbsp;       -> If we have an “yes&#8= 221; for the question above:<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US">     &= nbsp;       -- We will have to assign the arc= hitecture to the Cluster based on the OS of the first assigned VM, and&nbsp= ; the processor name could be defined the same way as currently … edi= ting the Cluster or assigning a compatible Host to it.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US">     &= nbsp;           &nbs= p;           -- The VM cr= eation popup will have to be able to indicate the architecture of each OS &= #8230; some OSes have the same name, and it may get ambiguous since the Clu= ster architecture is still undefined at that point (before the first VM get already created).<o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal">Thanks!<o:p></o:p></p> <p class=3D"MsoNormal">Regards.<o:p></o:p></p> <p class=3D"MsoNormal">Leonardo Bianconi<o:p></o:p></p> </div> </body> </html> --_000_50EB20226B72D6419356FC320AB62B8719173370SERV070corpeldo_--

3 13

[Engine-devel] How to validate no arg ctor existence in params?
by Yair Zaslavsky 08 Oct '13

08 Oct '13

Hi, I saw several patches that fixed serialization (json or gwt) issues that were introduced due to non existence of no-arg CTOR for parameters. Does anyone know a way to validate this using let's say some jenkins plugin? Yair

4 7

[Engine-devel] UseSecureConnectionWithServers
by Douglas Schilling Landgraf 04 Oct '13

04 Oct '13

Hi, This email is just a heads up about UseSecureConnectionWithServers option in database that got renamed [1] to EncryptHostCommunication to be more descriptive. Additionally, the EncryptHostCommunication was added to engine-config tool [2]. Fore more info: [1] http://gerrit.ovirt.org/#/c/19305/ [2] http://gerrit.ovirt.org/#/c/19202/ Thanks! -- Cheers Douglas

1 0

[Engine-devel] Lior Vernia as ovirt-UI maintainer
by Livnat Peer 03 Oct '13

03 Oct '13

I'd like to propose Lior Vernia as a ovirt-UI maintainer. Lior Vernia has been working on the UI for over a year, with a lot of dedication enthusiasm and motivation. He has more than 140 UI patches merged and hopefully many more in the pipeline :) Thanks, Livnat

10 9

[Engine-devel] make install-dev failure on second attempt
by Moti Asayag 01 Oct '13

01 Oct '13

Hi, Running "make install-dev PREFIX=~/ovirt-engine_test BUILD_UT=0 BUILD_GWT=0" fails with several errors: ln -s "/home/motia/ovirt-engine_test/etc/ovirt-engine/usbfilter.txt" "/home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt" ln: failed to create symbolic link `/home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt': File exists make[1]: *** [install-layout] Error 1 make[1]: Leaving directory `/home/motia/work/ovirt-engine' make: *** [install-dev] Error 2 and if /home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt is deleted, there are a couple of files which fail with the same error: /home/motia/ovirt-engine/share/ovirt-engine/files/spice-html5 /home/motia/ovirt-engine/share/ovirt-engine/files/novnc I suspect commit b5522d43e2899f66646bb490d268fa890ce9483f "packaging: introduce generic file serving" introduced this issue. Thanks, Moti

2 1

[Engine-devel] oVirt3.3 - Glance and Neutron Integration
by Udaya Kiran P 01 Oct '13

01 Oct '13

---488649105-2120901827-1380516320=:6878 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Everyone,=0A=0ADoes oVirt3.3 version support Glance and Neutron Integrat= ion.?=0A=0ACan anybody give me few inputs on the current status of these in= tegrations?=0A=0Ahttp://www.ovirt.org/OVirt_3.3_release_announcement=0Ahttp= ://www.ovirt.org/Features/Detailed_OSN_Integration=0A=0AThank You.=0A=0AReg= ards,=0AUdaya Kiran ---488649105-2120901827-1380516320=:6878 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div style=3D"color:#000; background-color:#fff; font-family:ti= mes new roman, new york, times, serif;font-size:10pt"><div>Hi Everyone,</di= v><div><br></div><div style=3D"color: rgb(0, 0, 0); font-size: 13px; font-f= amily: 'times new roman', 'new york', times, serif; background-color: trans= parent; font-style: normal;">Does oVirt3.3 version support Glance and Neutr= on Integration.?</div><div style=3D"color: rgb(0, 0, 0); font-size: 13px; f= ont-family: 'times new roman', 'new york', times, serif; background-color: = transparent; font-style: normal;"><br></div><div style=3D"color: rgb(0, 0, = 0); font-size: 13px; font-family: 'times new roman', 'new york', times, ser= if; background-color: transparent; font-style: normal;">Can anybody give me= few inputs on the current status of these integrations?</div><div style=3D= "color: rgb(0, 0, 0); font-size: 13px; font-family: 'times new roman', 'new= york', times, serif; background-color: transparent; font-style: normal;"><br></div><div class=3D"MsoNormal"><a href=3D"http://www.ovirt.or= g/OVirt_3.3_release_announcement">http://www.ovirt.org/OVirt_3.3_release_an= nouncement</a><o:p></o:p></div><div style=3D"background-color: transparent;= ">=0A=0A</div><div class=3D"MsoNormal"><a href=3D"http://www.ovirt.org/Feat= ures/Detailed_OSN_Integration">http://www.ovirt.org/Features/Detailed_OSN_I= ntegration</a><o:p></o:p></div><div style=3D"color: rgb(0, 0, 0); font-size= : 13px; font-family: 'times new roman', 'new york', times, serif; backgroun= d-color: transparent; font-style: normal;"><br></div><div style=3D"color: r= gb(0, 0, 0); font-size: 13px; font-family: 'times new roman', 'new york', t= imes, serif; background-color: transparent; font-style: normal;">Thank You.= </div><div style=3D"color: rgb(0, 0, 0); font-size: 13px; font-family: 'tim= es new roman', 'new york', times, serif; background-color: transparent; fon= t-style: normal;"><br></div><div style=3D"color: rgb(0, 0, 0); font-size: 1= 3px; font-family: 'times new roman', 'new york', times, serif; background-c= olor: transparent; font-style: normal;">Regards,</div><div style=3D"color: = rgb(0, 0, 0); font-size: 13px; font-family: 'times new roman', 'new york', = times, serif; background-color: transparent; font-style: normal;">Udaya Kiran</div></div= ></body></html> ---488649105-2120901827-1380516320=:6878--

3 16