January 2016 - Devel - oVirt List Archives

[vdsm][virt] what's new in virt (20151215)
by Francesco Romani 23 Mar '16

23 Mar '16

Hi all, I'm happy to start a weekly summary of what's going on on virt's world (VDSM edition). General topics * I've got some mixed feedback about my Vm-on-a-diet effort. I still believe that fat trimming is a worthwhile goal per se, but I'm willing to adapt the strategy responding to the comments, so we will focus on virt-specific topics. * As consequence of the above, I'm focusing on the last bits of device fixing, which involves - fixing all device to update themselves from libvirt XML after domain boot, instead using all the getUnderyling* methods - switch the devices related code to use Etree instead of minidom. This will involve changes to the domain_descriptor. I estimate this task will still trim ~600 lines out of vm.py, so it still somehow gets some size trimming done, albeit not intensive as planned. This is a complex topic, will post plan and ideas on a separate mail * Finally, some series are still worth pushing forward, see below. Patches in need of attention * topic branches - mpolednik started a much needed cleanup and fixing of fake_qemu and fake_kvm code, with the ultimate goal to move all the remaining bits into the faqemu hook, and to make it useful on ppc64. Lots of refactoring is needed to support this change, and that produced https://gerrit.ovirt.org/#/q/topic:cpuinfo - we want to improve the reporting in case of migratio aborted. The ultimate goal is to let Engine (thus the User) know why a migration failed. To export this information, however, we need some cleanup before. Hence: https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:m… - last and less urgent: here's some cleanup about existing getUnderlying* methods of Vm class, preparing the last step of the big vmdevices split. I believe this is useful anyway https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:v… * single patches - https://gerrit.ovirt.org/#/c/46846 this is the first of a series aiming to improve migration support in 4.0. Probably worth merging all together, even though this one seems ready for broader review to me. - https://gerrit.ovirt.org/#/c/49173/ Notified just to raise awareness, still working on ensuring backward compatibility and smooth upgrade - https://gerrit.ovirt.org/#/c/48672 v2v xen support - https://gerrit.ovirt.org/#/c/49951/ OVA support improvements. Worth a look, but note that we are working toward a split of this big patch - https://gerrit.ovirt.org/#/c/49636 V2V refactoring, also almost ready - https://gerrit.ovirt.org/#/c/49570/ still in the context of migration enhancements. We want to throttle incoming migrations, to do so we want to use a sempahore which needs to be held by the creation thread until VM is created. This helper makes this possible, using an uniform interface for both this case and the common, simpler case. That's all for now, as usual, reviews welcome! :) -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani

4 14

Request permissions for otopi maintainership
by Yedidyah Bar David 19 Feb '16

19 Feb '16

Hi, otopi access lists have as unique member Alon Bar-Lev who recently left the project. Since I work a lot on engine-setup which is based on otopi, I have some good experience with it, and also worked on otopi itself in the past, I'm stepping in, proposing myself as maintainer for that project. Thanks, -- Didi

10 12

cpu profile permission error while editing/creating vm
by Tomer Saban 17 Feb '16

17 Feb '16

Hi, If you get an error message like the following while editing/creating VM: """ User doesn't have permissions to assign the cpu profile ASFDS with id 3c990c63-8078-4916-bf18-f38596232a5a to VMs. """ Go to Clusters->choose your cluster-> cpu profiles in the subtab-> choose the any cpu profile-> click add in the right frame and add permission for your user with role "CpuProfileCreator". Thanks, Tomer

3 3

outdated quickstart guide
by Sven Kieske 03 Feb '16

03 Feb '16

--D2pWjDbpFSSm51uhA8xxHJCNvkCFChAEl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, I'm just installing ovirt 3.6.2 in a new dev setup and noticed that the quickstart guide still just mentions 3.4 and 3.5: https://www.ovirt.org/Quick_Start_Guide#Install_oVirt_Engine_.28Fedora_.2= F_Red_Hat_Enterprise_Linux_.2F_CentOS.29 maybe this can get adjusted? PS: Any ETA for ovirt 3.6.3 yet? --=20 Mit freundlichen Gr=C3=BC=C3=9Fen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH & Co. KG K=C3=B6nigsberger Stra=C3=9Fe 6 32339 Espelkamp T: +495772 293100 F: +495772 293333 https://www.mittwald.de Gesch=C3=A4ftsf=C3=BChrer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhause= n Komplement=C3=A4rin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen --D2pWjDbpFSSm51uhA8xxHJCNvkCFChAEl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWq4HsAAoJEMby9TMDAbQRjjwP/2A+R4/ogm04xCeI1jaxLDYF AUevH59BKRr/Z4WWcSOquNWLaDWYvj4xPBsftvPtsxATWqAvhJsoV+mbnNWduH0h 25ja5CsgsblPYSZ2A0yQ+cCz+Vvohh5haCh0niXNblKyDdy/ROpakkMIr1N1Svuj WdTZJe2ODwFxPSBVFqfL9tbwuIa4SXTT5XDVwo4hxBzdcy6q3tEMGzXZ7Pw3x2zt V9YggMbtYjr1iRzlUc7InFxIsqD1fIaD+1J3RY28ogK0GkV4yEPr2ue2c37hsmlX +WtfYyJfH9MoVabhbjCLYqK6DrR7CgPFjVdW7zSl1xZFIcrx//v/2nCDSgAPGCKM YCWATndf7kt2xMoa6CD0jsIhTaOsaGKMsutHn7Xo7dy2nW7tERecZ4NClm2j6YUf 8TR9znPehfRAnqPhHsOri1tuxDSHt/6OT/GqUm0X4cYaYiZkd6OZs6AlIL8MPIqc Nb+rIEujTgHz8a1MuKSva4pcJgC6aKj9RkIdklpFk5qbF4kTL8qPkRGFfh0PWdRT fhe0iCBf+NfoJyFjgUyoVTFkNbKh3+F1Sj37atD1vT18TPEE8GSmZYn310qRZxJN EOSgBp8YkK1y6GvhjcZZAlgTFLAqyMHq8O7ZeIl4oux5b6xrUH8lR1PDMd5lWGsF CBW4ecd9YEw6QKFVR+5H =HGCI -----END PGP SIGNATURE----- --D2pWjDbpFSSm51uhA8xxHJCNvkCFChAEl--

6 7

Changing the name of VDSM in oVirt 4.0.
by Yaniv Dary 02 Feb '16

02 Feb '16

Hi, I wanted to bring this up to get feedback on this proposed change. VDSM doesn't align to other project under the oVirt umbrella like ovirt-engine, ovirt-node, ovirt-guest-agent etc.. I suggest for ease of use and tracking we change the versioning to align to the engine (4.0.0 in oVirt 4.0 GA) to make it easy to know which version was in which release and also change the package naming to something like ovirt-host-manager\ovirt-host-agent. What do you think on this? What do you think the name should be? Yaniv Dary Technical Product Manager Red Hat Israel Ltd. 34 Jerusalem Road Building A, 4th floor Ra'anana, Israel 4350109 Tel : +972 (9) 7692306 8272306 Email: ydary(a)redhat.com IRC : ydary

21 24

Re: [ovirt-devel] Debian porting
by Milan Zamazal 01 Feb '16

01 Feb '16

lucas castro <lucascastroborges(a)gmail.com> writes: > Who is working on ovirt debian porting, I'm working on inclusion of Vdsm into Debian. ovirt-guest-agent is already included in Debian (packaged by another Debian maintainer). I'm not aware about any plans to package Engine for Debian nor I plan to do so. There are also Vdsm Debian packages provided by oVirt at http://resources.ovirt.org/pub/ovirt-3.6/debian/, but I don't recommend using them if you are going to use packages from standard Debian distribution once they are ready. While the packages to be included in Debian started from those provided by oVirt, there are many fixes in them and upgrading from oVirt repository packages to packages from Debian is not supported (may change if there is strong demand for that). So mixing those is likely to cause troubles. As for Vdsm in Debian, I've already uploaded most of the supporting packages (Python libraries, MoM) to Debian unstable. Vdsm itself is in preparation. One blocker is old version of sanlock package in Debian and missing sanlock-python package. I wrote to the Debian package maintainer a few days ago, no response so far. In the meantime, it's possible to use sanlock packages by oVirt from the URL mentioned above. (Please note I can't simply upload Debian package of another maintainer without his consent, so we must be patient.) > And how can I help ? If you'd like to help with Vdsm packaging in Debian, you can do so in any of the following ways: - Providing input on your needs. - Providing feedback on what to do with /rhev/data-center mounts directory in Vdsm. It's FHS incompatible and must be changed for Debian (the current location in the package is /run/vdsm/rhev/data-center). The unpleasant thing is that AFAIK migrations are not possible with current Vdsm across machines with mounts at different locations, so we should be careful. - Testing vdsm* packages once they are ready. They're not yet but once they are, testing them will be very welcome. - Providing feedback on the packaging. The git repository is on Alioth: https://anonscm.debian.org/cgit/collab-maint/vdsm.git/ . BTW, if anybody needs commit access (and doesn't have it) to the repository, tell me. Just please coordinate with me in any case so that we avoid duplicate work or conflicting plans. - The `vdsm*' packages are currently lintian clean, but completely untested, even installation may not work. If you'd like to check the installation and to fix contingent bugs preventing it, it's welcome. You'll also need safelease (https://anonscm.debian.org/cgit/collab-maint/safelease.git/) not yet in Debian but ready to upload, I'll do so soon. - Testing whether all the Vdsm related packages from unstable (python-cpopen, python-threading, ioprocess, safelease, mom, vdsm*) work on Debian 8 (jessie) as well. Ideally, they might work unchanged, but in case they don't we may be considering backporting them. - You can also review patches in debian/patches. Maybe some of the changes should be incorporated upstream, maybe some of them should be improved.

3 3

vdsm_master_storage-tests_wip_testing disabled since May 2015
by Sandro Bonazzola 01 Feb '16

01 Feb '16

Hi: http://jenkins.ovirt.org/user/sbonazzo/my-views/view/Disabled/job/vdsm_mast… is disabled since may 2015 and marked as wip. Looks like it's not really a WIP... Can we delete it? If noone take ownership, we'll delete it on February 1st. -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

2 2

Automation CI for vdsm
by Yaniv Bronheim 31 Jan '16

31 Jan '16

Hi all, We want to run functional tests as part of Vdsm CI for each patch before merge. Therefore we need to declare how to automate this process without overloading our jenkins machines. The functional tests will run using lago (https://github.com/ovirt/lago) - It will initiate multiply vms, install vdsm and manipulate it by nosetests or other procedures such as upgrade, removal and so on. Currently standard CI provides check-patch and check-merged scripts ( http://ovirt-infra-docs.readthedocs.org/en/latest/CI/Build_and_test_standar…) the problem with check-merged is that it will run after merge which doesn't help if something fails. We want to allow developers to trigger the script once reviews and verification are ready (last step before merge). To do so we agreed to add Continues Integration flag for each vdsm patch. Once this flag will be signed with +1 it will trigger Jenkins CI to run the check-merged script (adding new button to gerrit is not an option - you can image that flag as a trigger button), on success Jenkins CI flag will turn to +2. on fail we'll get -1 and once new patchset is ready the developer will remove the +1 and add it back to the Continues Integration flag to re-trigger the job. Please ack the process before we move on with that The patch for those scripts still under review and testing - https://gerrit.ovirt.org/#/c/48268 Thanks -- *Yaniv Bronhaim.*

8 11

oVirt goes to FOSDEM 2016 - the full scoop!
by Mikey Ariel 30 Jan '16

30 Jan '16

FOSDEM 2016 is just a few short weeks away, and I'm happy to share with you the full details about our community presence at the conference. ======= Virt & IaaS Devroom ======= Just a reminder that the full schedule is published on the FOSDEM website[1], and we have some great presentations from our community members for you to learn from. ======= oVirt/Foreman Stand ======= This year we will share a stand with our friends from the Foreman project. Stop by to say hello, grab swag, and enjoy some cool demos! **STAND VOLUNTEERS WANTED** If you're attending FOSDEM and would like to help us out, we'd love to have you there! This is a great opportunity to chat about oVirt with FOSDEM attendees and meet other community members from all over the world. Special surprise swag is reserved for booth volunteers! Please sign up for booth shifts in the etherpad[2] (lines 11-33). One of our core contributors will also be at the booth to support and co-pilot each shift. ======= Social Event on Saturday ======= In previous years, we had informal social gatherings for our community members on Saturday evening. These evenings are yet another excellent opportunity to meet and chat with the oVirt community outside the hectic FOSDEM venue. This year we'd like to hold an event again if there is enough demand, so please write your name/IRCnick/Twitter/G+/email in the etherpad[2] (line 86 and down) **by January 15**. If there is enough interest, we will reserve a nice pub in the center of Brussels and buy the first round :) See you in Brussels! [1] https://fosdem.org/2016/schedule/track/virtualisation_and_iaas/ [2] http://etherpad.ovirt.org/p/ovirt-fosdem-2016 -- Mikey Ariel Community Lead, oVirt www.ovirt.org "To be is to do" (Socrates) "To do is to be" (Jean-Paul Sartre) "Do be do be do" (Frank Sinatra) Mobile: +420-702-131-141 IRC: mariel / thatdocslady Twitter: @ThatDocsLady

4 4

[ANN] oVirt 3.6.3 First Release Candidate is now available for testing
by Sandro Bonazzola 28 Jan '16

28 Jan '16

The oVirt Project is pleased to announce the availability of the First Release Candidate of oVirt 3.6.3 for testing, as of January 28th, 2016 This release is available now for Fedora 22, Red Hat Enterprise Linux 6.7, CentOS Linux 6.7 (or similar) and Red Hat Enterprise Linux >= 7.2, CentOS Linux >= 7.2 (or similar). This release supports Hypervisor Hosts running Red Hat Enterprise Linux >= 7.2, CentOS Linux >= 7.2 (or similar) and Fedora 22. Highly experimental support for Debian 8.3 Jessie has been added too. This release candidate includes updated packages for: - ovirt-engine - ovirt-engine-cli - ovirt-engine-reports - ovirt-log-collector - vdsm - mom This release of oVirt 3.6.3 includes numerous bug fixes. See the release notes [1] for an initial list of the new features and bugs fixed. Please refer to release notes [1] for Installation / Upgrade instructions. A new oVirt Live ISO is also already available [2]. Please note that mirrors[3] may need usually one day before being synchronized. * Read more about the oVirt 3.6.3 release highlights: http://www.ovirt.org/OVirt_3.6.3_Release_Notes * Get more oVirt Project updates on Twitter: https://twitter.com/ovirt * Read more about oVirt Project community events: http://www.ovirt.org/Upcoming_events [1] http://www.ovirt.org/OVirt_3.6.3_Release_Notes [2] http://resources.ovirt.org/pub/ovirt-3.6-pre/iso/ [3] http://www.ovirt.org/Repository_mirrors#Current_mirrors -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

[oVirt jenkins] Weekly report on open tasks for ovirt-engine
by jenkins＠ovirt.org 27 Jan '16

27 Jan '16

------=_Part_65_1366742175.1453916533009 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Files scanned: '**/*.java, **/*.py'. Strings searched: FIXME | TODO | @deprecated Report: http://jenkins.ovirt.org/job/ovirt-engine_3.6_scan-open-tasks_merged//8/tas… ------=_Part_65_1366742175.1453916533009--

1 0

SyNc meeting - Vdsm 26.1
by Yaniv Bronheim 27 Jan '16

27 Jan '16

(ybronhei, piotr, fromani, mzamazal, edwafh, ydary) Hi, Yaniv Dary raised the desire to modify vdsm name to ovirt-host-agent. The motivation is to align with ovirt components (ovirt-agent, ovirt-engine, ovirt-host-deploy, ovirt-node .... and so on). In addition, vdsm versions are not aligned with ovirt versions at all (historical reasons which we keep to avoid upgrade issues). GSS gets many questions about the differences between vdsm and other components in ovirt, and this will make their life easier. Basically, we all agreed that it is a good direction to have consistency with other components in ovirt but ovirt-host-agent sounds less than what vdsm actually does (sounds like ovirt-host-manager fits better). Yaniv will send official mail to devel list and we'll discuss it more deeply there. Francesco backported health patches merged to ovirt-3.5, will be published as part of vdsm v4.16.33 (https://gerrit.ovirt.org/#/c/52699 h ttps://gerrit.ovirt.org/#/c/52700 <https://gerrit.ovirt.org/#/c/52700> https://gerrit.ovirt.org/#/c/52701) it can help for later investigations with 3.5 vdsms. Milan works on debian packing, he arranges the mess we have under our current Debian folder. He currently discovered issues with sanlock package in debian which he still investigates. Greetings, -- *Yaniv Bronhaim.*

2 1

DAO Jenkins job fails on master
by Sandro Bonazzola 27 Jan '16

27 Jan '16

Hi, looks like after https://gerrit.ovirt.org/51535 Jenkins DAO job is failing: http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/ Please fix ASAP. thanks, -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

removing parameterized constructors from queries.
by Martin Mucha 27 Jan '16

27 Jan '16

Hi, I got another bug about missing constructor: public …(P parameters, EngineContext engineContext) { super(parameters, engineContext); } so I looked into: org.ovirt.engine.core.bll.QueriesCommandBase and it seems, that sole 'problem' is with initialization of user in @PostConstruct method. It seems, that we can easily set all those fields via setters, and user initialization can be done later, for example before calling executeQueryCommand in: org.ovirt.engine.core.bll.QueriesCommandBase#executeCommand doing this will move us closer to CDI and avoid errors because of forgotten constructor. Is there a obstacle blocking us from doing this? thanks, Mar. Edit: I had some time left so I tried to implement it, and it seems to be working. It's big patch, but mostly there's just constructors removal. Actual changes are in: QueriesCommandBase CommandsFactory RegisterVdsQuery GetAllTemplateBasedEntityQuery GetAllInstanceTypesQuery GetAllVmTemplatesQuery GetAllImageTypesQuery and test files.

2 3

oVirt 3.6.3 RC1 build starting
by Rafael Martins 27 Jan '16

27 Jan '16

Fyi oVirt products maintainers, An oVirt build for an official release is going to start right now. If you're a maintainer for any of the projects included in oVirt distribution and you have changes in your package ready to be released please: - bump version and release to be GA ready - tag your release within git (implies a GitHub Release to be automatically created) - build your packages within jenkins / koji / copr / whatever - verify all bugs on MODIFIED have target release and target milestone set. -- Rafael Martins

2 1

oVirt 3.6.1 branch has been created
by Rafael Martins 27 Jan '16

27 Jan '16

Hi, just an heads up we branched for 3.6.3 stabilization this morning. If you have patches targeted to 3.6.3 you now need to cherry-pick them to 3.6.3 branch too. -- Rafael Martins

1 1

[ANN] oVirt 3.6.2 Final Release is now available
by Sandro Bonazzola 26 Jan '16

26 Jan '16

The oVirt Project is pleased to announce today the general availability of oVirt 3.6.2. This latest community release includes several new features, such as: - More feedback about the status of the recovery - Rebalance option have been disabled on the menu for non-distributed volumes - Host in maintenance mode now stop glusterd and glusterfsd processes - Host activation now restart glusterd - Improved DNF support - Improved MOM performances - Added the ability to override the Storage Domain name field oVirt is an open-source, openly-governed enterprise virtualization management application, developed by a global community. You can use the oVirt management interface (oVirt Engine) to manage hardware nodes, storage and network resources, and to deploy and monitor virtual machines running in your data center. If you are familiar with VMware products, oVirt is conceptually similar to vSphere. oVirt serves as the bedrock for Red Hat's Enterprise Virtualization product, and it is the "upstream" project where new features are developed prior to their inclusion in Red Hat's supported product offering. Additional Resources: * Read more about the oVirt 3.6.2 release highlights: http://www.ovirt.org/OVirt_3.6.2_Release_Notes * Get more oVirt Project updates on Twitter: https://twitter.com/ovirt * Read more about oVirt Project community events: http://www.ovirt.org/Upcoming_events -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

[UI plugins] replacing RestApiSessionAcquired event
by Vojtech Szocs 26 Jan '16

26 Jan '16

Hi, in oVirt 4.0 the RestApiSessionAcquired event will be replaced with API to create authenticated requests for Engine services. Using REST API persistent session mechanism where UI acquires a single session to be shared by all UI plugins led us to many problems in the past, typically observed by end users as "Auth Required" browser popups. The new API proposed by [1] creates XMLHttpRequest object with following properties: * sets "Authorization: Bearer xxx" header before sending * logs request and response details (enabled via API option) [1] https://gerrit.ovirt.org/#/c/49278/ Example: var xhr = api.createEngineHttpRequest(); xhr.open('GET', 'http://example.com/ovirt-engine/api', true); xhr.setRequestHeader('Accept', 'application/json'); xhr.send(null); Since REST API persistent session mechanism currently relies on cookie (JSESSIONID), individual UI plugins should not try to create a REST session on their own to avoid any clashes. Regards, Vojtech

3 4

[ANN] oVirt 3.6.2 Third Release Candidate is now available for testing
by Sandro Bonazzola 25 Jan '16

25 Jan '16

The oVirt Project is pleased to announce the availability of the Third Release Candidate of oVirt 3.6.2 for testing, as of January 20th, 2016 This release is available now for Fedora 22, Red Hat Enterprise Linux 6.7, CentOS Linux 6.7 (or similar) and Red Hat Enterprise Linux >= 7.2, CentOS Linux >= 7.2 (or similar). This release supports Hypervisor Hosts running Red Hat Enterprise Linux >= 7.2, CentOS Linux >= 7.2 (or similar) and Fedora 22. Highly experimental support for Debian 8.2 Jessie has been added too. This release candidate includes updated packages for: - ovirt-engine - ovirt-engine-reports - ovirt-hosted-engine-setup - vdsm This release of oVirt 3.6.2 includes numerous bug fixes. See the release notes [1] for an initial list of the new features and bugs fixed. Please refer to release notes [1] for Installation / Upgrade instructions. A new oVirt Live ISO is also already available [2]. Please note that mirrors[3] may need usually one day before being synchronized. * Read more about the oVirt 3.6.2 release highlights: http://www.ovirt.org/OVirt_3.6.2_Release_Notes * Get more oVirt Project updates on Twitter: https://twitter.com/ovirt * Read more about oVirt Project community events: http://www.ovirt.org/Upcoming_events [1] http://www.ovirt.org/OVirt_3.6.2_Release_Notes [2] http://resources.ovirt.org/pub/ovirt-3.6-pre/iso/ [3] http://www.ovirt.org/Repository_mirrors#Current_mirrors -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

3 3

Packaging: Rationale for some split packages
by Milan Zamazal 25 Jan '16

25 Jan '16

I work on inclusion of Vdsm into Debian. I don't know what are the reasons for having separate `infra', `xmlrpc', `yajsonrpc', and `jsonrpc' packages. Could you please provide rationale for having each of those packages, separated from `vdsm' and `vdsm-python'? I need to put proper explanations into package descriptions so that the users know whether they should install/remove those packages or not. Thanks, Milan

5 10

Ensure processes death by terminating decorator - https://gerrit.ovirt.org/51407
by Yaniv Bronheim 25 Jan '16

25 Jan '16

Hi guys, Following the work to omit deathSignal attribute from our cpopen implementation we posted https://gerrit.ovirt.org/51407 which is ready for use. Currently locations that should use it are: (I wrote above who I expect to check the area and post a patch for that - we'll discuss it during next vdsm-sync to follow the work) shavivi: vdsm/v2v.py - in _start_virt_v2v you return aysnProc that should call kill() on fail fromani: vdsm_hooks/checkimages/before_vm_start.py - in checkImage - the code looks ok, but check if not better to use the terminating decorator.. I think it will be nicer nsoffer: vdsm/storage/mount.py - good looks ok, I prefer to use terminator there vdsm/storage/iscsiadm.py vdsm/storage/imageSharing.py vdsm/storage/hba.py -good handling, use terminator vdsm/storage/blockSD.py please check your usage with the returned process and see that you're not depending on deathSignal for it to die properly on crush some places define deathSignal for no reason, the call is sync - please remove those places: nsoffer: lib/vdsm/qemuimg.py vdsm/storage/curlImgWrap.py vdsm/storage/storage_mailbox.py vdsm/storage/misc.py fromani: lib/vdsm/virtsparsify.py ybronhei: vdsm/API.py If you can't get to it in a reasonable time, add the task to the list [1] and someone else will be it up. Please try to go over before the sync call. [1] - https://docs.google.com/spreadsheets/d/180F-C1jU54ajUn7TuR-NwrKRZY1IiZI1Z8U… -- *Yaniv Bronhaim.*

3 4

Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"
by Eli Mesika 24 Jan '16

24 Jan '16

Hi all Please note that there is still a problem on engine-setup I have already a fixing draft [1] Meanwhile, until this is verified and merged please do before engine-setup from dbscripts/upgrade dir psql -U engine -f 04_00_0210_add_vds_group_view.sql <db> Thanks and sorry for that, this will be fixed ASAP and reported in this thread. Eli [1] https://gerrit.ovirt.org/#/c/52454/ ----- Original Message ----- > From: "Idan Shaby" <ishaby(a)redhat.com> > To: "Eli Mesika" <emesika(a)redhat.com> > Sent: Tuesday, January 19, 2016 10:10:17 AM > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster" > > Hi Eli, > > I've fetched and rebased master, and got this error while running > engine-setup: > > [ INFO ] Stage: Setup validation > [WARNING] Cannot validate host name settings, reason: resolved host does > not match any of the local addresses > [ ERROR ] Failed to execute stage 'Setup validation': relation "vds_groups" > does not exist LINE 2: SELECT compatibility_version FROM > vds_groups... ^ > [ INFO ] Stage: Clean up > Log file is located at > /home/ishaby/ovirt-engine/var/log/ovirt-engine/setup/ovirt-engine-setup-20160119100829-tebscp.log > [ INFO ] Generating answer file > '/home/ishaby/ovirt-engine/var/lib/ovirt-engine/setup/answers/20160119100830-setup.conf' > [ INFO ] Stage: Pre-termination > [ INFO ] Stage: Termination > [ ERROR ] Execution of setup failed > > Any idea? > > > Regards, > Idan > > On Sun, Jan 17, 2016 at 4:50 PM, Eli Mesika <emesika(a)redhat.com> wrote: > > > > > > > ----- Original Message ----- > > > From: "Eli Mesika" <emesika(a)redhat.com> > > > To: "Jakub Niedermertl" <jniederm(a)redhat.com> > > > Cc: "devel" <devel(a)ovirt.org> > > > Sent: Sunday, January 17, 2016 1:32:27 PM > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead > > please use "cluster" > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Jakub Niedermertl" <jniederm(a)redhat.com> > > > > To: "Eli Mesika" <emesika(a)redhat.com> > > > > Cc: "devel" <devel(a)ovirt.org> > > > > Sent: Thursday, January 14, 2016 7:48:12 PM > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , > > instead > > > > please use "cluster" > > > > > > > > Hi Eli, > > > > > > > > thank you, it helped. Now `engine-setup` works fine. However engine > > itself > > > > reports following in a few seconds after start: > > > > > > > > ERROR: relation "clusters_storage_domain" does not exist > > > > > > > > Relevant part of engine log: http://pastebin.test.redhat.com/340672 > > > > Tested on current master (commit 8561bb69560686d0) and clean db. > > > > > > You are right, sorry for that ... > > > This patch fixes that issue > > > https://gerrit.ovirt.org/#/c/51929 > > > > Patch merged please re-base on master and try again > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Eli Mesika" <emesika(a)redhat.com> > > > > > To: "Jakub Niedermertl" <jniederm(a)redhat.com> > > > > > Cc: "devel" <devel(a)ovirt.org> > > > > > Sent: Thursday, January 14, 2016 1:10:42 AM > > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , > > instead > > > > > please use "cluster" > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Jakub Niedermertl" <jniederm(a)redhat.com> > > > > > > To: "Eli Mesika" <emesika(a)redhat.com> > > > > > > Cc: "devel" <devel(a)ovirt.org> > > > > > > Sent: Wednesday, January 13, 2016 9:18:57 PM > > > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , > > instead > > > > > > please use "cluster" > > > > > > > > > > > > Hi Eli, > > > > > > > > > > > > are db migration scripts supposed to handle this change? My > > > > > > `engine-setup` > > > > > > failed with following message in log: > > > > > > > > > > Hi Jakub > > > > > > > > > > Please re-base on latest master, there was an issue with that and it > > was > > > > > solved in https://gerrit.ovirt.org/#/c/51784/ > > > > > > > > > > > > > > > > > > > > > > """ > > > > > > 2016-01-13 20:02:57 DEBUG > > > > > > otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database > > > > > > database.execute:172 Database: 'None', Statement: ' > > > > > > SELECT compatibility_version FROM cluster;; > > > > > > ', args: {} > > > > > > 2016-01-13 20:02:57 DEBUG > > > > > > otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database > > > > > > database.execute:177 Creating own connection > > > > > > 2016-01-13 20:02:57 DEBUG otopi.context context._executeMethod:156 > > > > > > method > > > > > > exception > > > > > > Traceback (most recent call last): > > > > > > File "/usr/lib/python2.7/site-packages/otopi/context.py", line > > 146, > > > > > > in > > > > > > _executeMethod > > > > > > method['method']() > > > > > > File > > > > > > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py", > > > > > > line 218, in _validation > > > > > > self._checkSupportedVersionsPresent() > > > > > > File > > > > > > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py", > > > > > > line 180, in _checkSupportedVersionsPresent > > > > > > transaction=False, > > > > > > File > > > > > > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/ovirt_**FILTERED**_setup/**FILTERED**_common/database.py", > > > > > > line 196, in execute > > > > > > args, > > > > > > ProgrammingError: relation "cluster" does not exist > > > > > > LINE 2: SELECT compatibility_version FROM cluster;; > > > > > > ^ > > > > > > > > > > > > 2016-01-13 20:02:57 ERROR otopi.context context._executeMethod:165 > > > > > > Failed > > > > > > to > > > > > > execute stage 'Setup validation': relation "cluster" does not exist > > > > > > LINE 2: SELECT compatibility_version FROM cluster;; > > > > > > ^ > > > > > > """ > > > > > > > > > > > > Thank you for answer. > > > > > > > > > > > > Best regards > > > > > > Jakub > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Eli Mesika" <emesika(a)redhat.com> > > > > > > > To: "devel" <devel(a)ovirt.org> > > > > > > > Sent: Wednesday, January 13, 2016 12:00:50 AM > > > > > > > Subject: [ovirt-devel] No more "vds group" in master code , > > instead > > > > > > > please > > > > > > > use "cluster" > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > I have merged today this patch[1] to master. > > > > > > > > > > > > > > The code from historical reasons uses both "vds group" and > > "cluster" > > > > > > > for > > > > > > > a > > > > > > > cluster entity. > > > > > > > This makes the code not-clear, non-readable and hard for > > beginners > > > > > > > (to > > > > > > > find > > > > > > > for example SPs that handle clusters , or all code related to a > > > > > > > cluster > > > > > > > operation) > > > > > > > This also makes our logging and error messages using sometimes > > "vds > > > > > > > group" > > > > > > > and sometimes "cluster" to relate to the same entity. > > > > > > > Worse than that, new code written sometimes introduce a mix of > > both > > > > > > > terms. > > > > > > > > > > > > > > Patch[1] renames "vds group" to cluster all over the code. > > > > > > > This renaming covers all engine code including > > > > > > > Class names > > > > > > > Variables > > > > > > > Comments > > > > > > > Logging > > > > > > > Error messages > > > > > > > Database tables,views, columns and SPs including all kinds of > > keys > > > > > > > and > > > > > > > constrains > > > > > > > > > > > > > > Please do not use from now on the term "vds group" (all its > > variants > > > > > > > (VdsGroup, vdsGroup, vds_group etc.) > > > > > > > Instead , cluster and all its variants should be used > > > > > > > > > > > > > > If you have some written code that is not merged yet, you will > > > > > > > probably > > > > > > > have > > > > > > > a little work on rebase on top this patch, as far as I know those > > > > > > > should > > > > > > > be > > > > > > > trivial patches and if you have any question, please ask. > > > > > > > > > > > > > > Possible affects on other products are minor and were > > communicated to > > > > > > > the > > > > > > > relevant product people. > > > > > > > > > > > > > > [1] https://gerrit.ovirt.org/#/c/51109/ > > > > > > > > > > > > > > Thanks > > > > > > > Eli Mesika > > > > > > > > > > > > > > _______________________________________________ > > > > > > > Devel mailing list > > > > > > > Devel(a)ovirt.org > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel(a)ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > _______________________________________________ > > Devel mailing list > > Devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > >

1 1

Installing vdsm? Watch your weight.
by Fabian Deutsch 23 Jan '16

23 Jan '16

Hey, recently I looked at how many (indirect) dependencies vdsm is pulling in. I did the comparisong using the Node Next squashfs image. What Node Next is doing, it uses the CentOS 7 @core group, and installs vdsm on-top of this. The conclusion is: without-vdsm with-vdsm Ratio Size of squashfs [MB] 292072 450384 1.542 Package count 297 604 2.034 Disk usage [MB] 839596 1382576 1.647 (Without vdsm: @core group + lvm + efi bits) So we see that vdsm doubles the amount of packages, and increases the disk-space requirements by 64%. Two take aways: CentOS @core could be smaller, and we can take another look at vdsm's direct and indirect dependencies. - fabian

2 1

Vdsm leak in multiprocessing / supervdsm interaction
by Milan Zamazal 22 Jan '16

22 Jan '16

FYI, when I performed my simple Vdsm leak test some time ago, I've found a leak in Python multiprocessing module, where multiprocessing.util._afterfork_registry dictionary grows on each supervdsm call. It's not much dramatic from the point of memory usage but maybe the possibly large dictionary can cause other performance problems. It's better to have this fixed and it looks like a Python bug, reported here: https://bugs.python.org/issue26180.

1 0

[RFC] Proposal for dropping FC22 jenkins tests on master branch
by Sandro Bonazzola 22 Jan '16

22 Jan '16

Hi, can we drop FC22 testing in jenkins now that FC23 jobs are up and running? it will reduce jenkins load. If needed we can keep FC22 builds, just dropping the check jobs. Comments? -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

3 7