February 2012 - Devel - oVirt List Archives

[Engine-devel] VM Payload feature
by Oved Ourfalli 10 Apr '12

10 Apr '12

Hey all, Continuing the discussion about Aeolus instance data injection to a VM (http://lists.ovirt.org/pipermail/engine-devel/2012-January/000423.html) we propose a new VM Payload feature. The following wiki page contains a description page of the feature. http://www.ovirt.org/wiki/Features/VMPayload Please read and review. There are several approaches there, and we wish to head your opinions and thoughts about them. Once we agree on an approach, we will start designing. Thank you, Oved

10 18

[Engine-devel] 'Import VM/Template More Than Once' feature
by Gilad Chaplik 30 Mar '12

30 Mar '12

Hello all, The 'Import VM/Template More Than Once' feature description can be found under the following link: http://www.ovirt.org/wiki/Features/ImportMoreThanOnce Please review, and feel free to share your comments and thoughts. Thanks, Gilad.

7 10

[Engine-devel] synthetic-access
by Laszlo Hornyak 01 Mar '12

01 Mar '12

Hi, I am reviewing Allon's patches (e.g. http://gerrit.ovirt.org/#patch,sidebyside,2188,11,backend/manager/modules/d… ) and this is the first time I have met @SuppressWarnings("synthetic-access") annotations in the ovirt code. It is right, eclipse warns about the performance problem synthetic access (if turned on, by default it is turned off). This mostly happens in DAO's because rowmappers are private inner classes. What if, instead of adding an annotation to ignore this - we could make the rowmapper classes package protected? - or since most of these classes are stateless and thread safe, we can add a public final static rowmapper instance and instead of instantiating the rowmapper over and over again, use that single instance. Please share your thoughts. Thank you, Laszlo

4 3

[Engine-devel] My experience using the UI
by Saggi Mizrahi 29 Feb '12

29 Feb '12

I recently had to use the Engine UI (GWT one). The UI in my opinion is very unintuitve and, at some flows, even counter productive. It took me a lot more time to figure out how to do even the simplest tasks. Lets start with the rudimentary things. These are agreed upon UI idioms that are not used currently thus causing needless confusion. These idioms are ingrained into how users grasp a UI when they first it. I did not invent these they are written in various Windows\MacOS\KDE\Gnome and many other UI\HI guidelines. This is not a complete list of all the problems, just the things that annoyed me the most. * Buttons\menu items that spawn dialog windows should end with an ellipsis ("edit..." vs "remove"). * Grayed out means disabled not "not selected" (eg. the domain creation dialog->the lun chooser). * Never write things vertically only horizontally (eg. the domain creation dialog). * The entire object be clickable not only the text (tabs). * Clickable items should be either underlined in another color, or inside a box to differentiated between regular text (menu items). * Buttons should be in the same group should be in the same width and height and the entire area clickable. * Border toggling cannot be used as hover indicator only background and/or text color toggle. * Don't use "/" in the column header."host/ip" should be "Host address" * Everything should be arranged in relative proportions (The search bar looks weird on large screens) * Everything about the error message windows * Try and scale the browser window to 800x600 and see what happens. * Icons that don't have text next to them have to have a tool tip (bookmark search icon) * (This one is my personal preference) Everything that is clickable should have hover toggle that shows what is the entire object you are clicking. * Color scheme!!! alerts(red on gray?) Where does the green on the logo fit into all of this? There are tools to help you create an eye pleasing color scheme (eg. http://colorschemedesigner.com/) Now that the basics are out of the way. These are my opinions and are debatable. - Top panel: * current user name should be next to the sign-out not on opposite ends of list. * About and guide could be merged to "help" Non of them deserve that much prominence in the UI * Configure? What who? Find somewhere contextual to put it. - search: This is a long standing gripe against the UI. * First and foremost it doesn't work properly. Try navigating the Tree and then editing the search bar. * The browser already has a bookmarks feature so reusing the name is confusing, maybe saved views? perspectives? I don't know. * The search bar is change when I navigate, This is confusing. Imagine having the gmail search bar change when you navigate gmail. To fix this I suggest that the search bar remains empty unless the user starts using it and the bookmark button moved to a place where it's obvious it relates to the current view\perspective. - The Tree * Tree? Really? Is that a proper title? * Tree refresh annoyingly does collapse all - Events * What is the difference between the button on the right and the one on the bottom? * I'd rather it'd be called log\messages because these are not really events - All tabs * The difference between "guide me" and "edit" is confusing and arbitrary. * Buttons in the toolbar should be grouped, and spaced according to those groups. * Buttons should utilized the above general UI guidelines * Similar buttons like "run" and "run Once" or "new desktop" and "new server" might be better displayed as drop down button (http://bit.ly/xMAUbK) * Stuff on less importance like "change CD" could be grouped under a drop down button as well so it's less cluttered. * Paging is so 2000, everyone does continues scroll now (http://bit.ly/a8B9UC) - Guide Me: Does not guide and is utterly confusing. * Some buttons are grayed out but you have no idea why until you figure out that there is a hint hidden in the tooltip (An allusion to XKCD?) * Can't use existing entities! Only create new ones. Why? * "Optional actions"? Really? * "There are still unconfigured entities". What? I don't understand what is wrong. Unconfigured isn't even a proper word. Do you mean that I still have entities to set-up? What entities? What is an entity? * "Configure later"? What is wrong with "close". * Again, unify with edit, I kept clicking edit even after I realized that I need to click guide me. Pet peeves: * The green line under the black part of the top bar is just annoying. * CPU Name -> CPU Architecture( name)? * destroy (in storage domain) -> force remove There are a lot more things that could be stream lined. The lun selection screen for example is just plain confusing. But that would require me to start drafting mockups and I have a lot of other work to do. I recommend reading at least the WinXP and Apple HIG guidelines (http://bit.ly/djCHb8) Finally when in doubt copy Google, they have the an excellent web UX team.

1 0

[Engine-devel] Agenda for todays meeting
by Livnat Peer 29 Feb '12

29 Feb '12

Hi All, Today we'll discuss the following: - Summary of mailing list discussions on networking: VM network and optional network. - Floating disks - Snapshot behavior (and live snapshot if time allows) Thanks, Livnat

1 0

[Engine-devel] Problem with log4j
by Juan Hernandez 28 Feb '12

28 Feb '12

Hello, A patch related to log4j that I created was recently merged (commit 8ee5c9bb46bbff7a624a84a07ee6b2f9fa4ec9d4) and apparently is causing a problem during the deployment of the engine for some developers (Moti Asayag pointed that to me). If you find this when deploying the engine: Caused by: java.lang.NoClassDefFoundError: org/apache/log4j/Level Them I am to be blamed and the short term solution is to undo part of my patch in the root pom.xml file: --- a/pom.xml +++ b/pom.xml @@ -244,7 +244,6 @@ <groupId>log4j</groupId> <artifactId>log4j</artifactId> <version>${log4j.version}</version> - <scope>provided</scope> </dependency> </dependencies> </dependencyManagement> I can't reproduce this myself, so please let me know if you find it. If this is common I think that the long term solution would be to add log4j to the list of dependencies of the affected EJB: --- a/backend/manager/modules/beans/scheduler/pom.xml +++ b/backend/manager/modules/beans/scheduler/pom.xml @@ -51,7 +51,7 @@ <addClasspath>false</addClasspath> </manifest> <manifestEntries> - <Dependencies>org.slf4j,deployment.engine.ear.engine-vdsbroker.jar</Dependencies> + <Dependencies>org.slf4j,org.apache.log4j,deployment.engine.ear.engine-vdsbroker.jar</Dependencies> </manifestEntries> </archive> </configuration> Regards, Juan Hernandez -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.

1 0

[Engine-devel] Wiki page for introducing entity search
by Shireesh Anjal 28 Feb '12

28 Feb '12

Hi all, Based on my recent experience with entity search, I have created a Wiki page providing step-by-step instructions on introducing entity search for a new entity in oVirt. It is available at following URL: http://www.ovirt.org/wiki/Development/Introducing_Entity_Search Please feel free to contribute to the same in order to correct any discrepancies or enhance the information provided. -- Thanks, Shireesh

1 0

[Engine-devel] Do we need ImagesToRemoveList in RemoveImageParameters?
by Yair Zaslavsky 28 Feb '12

28 Feb '12

Hi all, I see the getter code for this field is not used by Engine-Core. We perform removal of the image specified by the imageId parameter. Can we remove this parameter? Yair

2 1

[Engine-devel] final fields on entities sent to client
by Tomas Jelinek 28 Feb '12

28 Feb '12

Hi all, as the same entities as the ones used on the server are also sent to the client (e.g. org.ovirt.engine.core.common.businessentities.VM), this entities will than be serialized/deserialized using the GWT serialization. It means, this entities should follow the restrictions given by the GWT serialization: http://code.google.com/webtoolkit/doc/latest/DevGuideServerCommunication.ht… >From it I would like to point out this: "Fields that are declared final are also not exchanged during RPCs, so they should generally be marked transient as well." It means, that no fields which will be sent to client should be marked with the final keyword. Thanks, Tomas

1 0

[Engine-devel] [oVirt Jenkins] Dao test fails due to latest commits
by Eyal Edri 28 Feb '12

28 Feb '12

FYI, there is a new failure in dao tests on jenkins.ovirt.org: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/lastCompletedBuild… Test: org.ovirt.engine.core.dao.DiskImageDAOTest.testSave latest commits (that may have caused this): Changes engine: Add pre defined roles for consume quota (detail / gitweb) engine: Create default unlimited quota for DC (detail / gitweb) engine: Add quota to audit log (detail / gitweb) engine: Add validation for quota name (detail / gitweb) engine: Add/Edit quota commands (detail / gitweb) engine: Remove quota command (detail / gitweb) engine: Add quota id to VM parameters (detail / gitweb) engine: Add quota id to disk image (detail / gitweb) engine: Add quota id to vm static (detail / gitweb) frontend: Add business entities to sharedGWT (detail / gitweb) engine: Add search support for quota. (detail / gitweb) engine: Add audit log messages (detail / gitweb) engine: Add audit log messages to CRUD commands. (detail / gitweb) engine: Adding fix to quota stored procedure (detail / gitweb) engine: Add quota manager class (detail / gitweb) engine: Add quota validation support commandBase (detail / gitweb) engine: Add quota validation for AddVmCommand (detail / gitweb) engine: Add quota validation for Add Disk to VM (detail / gitweb) engine: Add quota validation for Add Vm Tempalte (detail / gitweb) engine:Add quota validation for RunVmCommand (detail / gitweb) Please check, Eyal Edri oVirt Infrastructure Team

1 0

[Engine-devel] Clone VM from snapshot feature
by Yair Zaslavsky 28 Feb '12

28 Feb '12

Hi all, I modified the Wiki pages of this feature: http://www.ovirt.org/wiki/Features/CloneVmFromSnapshot http://www.ovirt.org/wiki/Features/DetailedCloneVmFromSnapshot Comments are more than welcome Kind regards, Yair

6 25

[Engine-devel] Support for stateless nodes
by Mike Burns 27 Feb '12

27 Feb '12

There has been a lot of interest in being able to run stateless Nodes with ovirt-engine. ovirt-node has designed a way [1] to achieve this on the node side, but we need input from the engine and vdsm teams to see if we're missing some requirement or if there needs to be changes on the engine/vdsm side to achieve this. As it currently stands, every time you reboot an ovirt-node that is stateless, it would require manually removing the host in engine, then re-registering/approving it again in engine. Any thoughts, concerns, input on how to solve this? Thanks Mike [1] http://ovirt.org/wiki/Node_Stateless

8 22

[Engine-devel] network - UI Sync meeting
by Roy Golan 27 Feb '12

27 Feb '12

--=_384c57fb-d69c-42b9-b887-1ed31dd6d73e Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit The following meeting has been modified: Subject: network - UI Sync meeting Organizer: "Roy Golan" <rgolan(a)redhat.com> Location: "Asia-tlv" <asia-tlv(a)redhat.com> [MODIFIED] Resources: asia-tlv(a)redhat.com [MODIFIED] Time: Monday, February 27, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem Invitees: mkenneth(a)redhat.com; sgrinber(a)redhat.com; lpeer(a)redhat.com; dfediuck(a)redhat.com; drankevi(a)redhat.com; ecohen(a)redhat.com; iheim(a)redhat.com; ovedo(a)redhat.com; acathrow(a)redhat.com; engine-devel(a)ovirt.org; kroberts(a)redhat.com ... *~*~*~*~*~*~*~*~*~* Follow-up meeting on setup networks UI. issues to follow: 1. can VDSM attach many non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable) 2. if yes is the UI breakdown of vlan/non-vlan is probably not necessary? open issues: 1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? 2.should we implicitly set bridge/bridgeless when attaching a network with setupnetworks? 3.nickless networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it. Bridge ID: 1814335863 https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers… --=_384c57fb-d69c-42b9-b887-1ed31dd6d73e Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit <html><body><h3>The following meeting has been modified:</h3> <p> <table border='0'> <tr><th align=left>Subject:</th><td>network - UI Sync meeting </td></tr> <tr><th align=left>Organizer:</th><td>"Roy Golan" <rgolan(a)redhat.com> </td></tr> </table> <p> <table border='0'> <tr><th align=left>Location:</th><td>"Asia-tlv" <asia-tlv(a)redhat.com> [MODIFIED]</td></tr> <tr><th align=left>Resources:</th><td>asia-tlv(a)redhat.com [MODIFIED]</td></tr> <tr><th align=left>Time:</th><td>Monday, February 27, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem </td></tr></table> <p> <table border='0'> <tr><th align=left>Invitees:</th><td>mkenneth(a)redhat.com; sgrinber(a)redhat.com; lpeer(a)redhat.com; dfediuck(a)redhat.com; drankevi(a)redhat.com; ecohen(a)redhat.com; iheim(a)redhat.com; ovedo(a)redhat.com; acathrow(a)redhat.com; engine-devel(a)ovirt.org; kroberts(a)redhat.com ... </td></tr> </table> <div>*~*~*~*~*~*~*~*~*~*</div><br><br>Follow-up meeting on setup networks UI. <br>issues to follow: <br>1. can VDSM attach many non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable) <br>2. if yes is the UI breakdown of vlan/non-vlan is probably not necessary? <br><br><br>open issues: <br>1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? <br>2.should we implicitly set bridge/bridgeless when attaching a network with setupnetworks? <br>3.nickless networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it. <br><br><br>Bridge ID: 1814335863 <br><br>https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers… </body></html> --=_384c57fb-d69c-42b9-b887-1ed31dd6d73e Content-Type: text/calendar; charset=utf-8; method=REQUEST; name=meeting.ics Content-Transfer-Encoding: 7bit BEGIN:VCALENDAR PRODID:Zimbra-Calendar-Provider VERSION:2.0 METHOD:REQUEST BEGIN:VTIMEZONE TZID:Asia/Jerusalem BEGIN:STANDARD DTSTART:19710101T020000 TZOFFSETTO:+0200 TZOFFSETFROM:+0300 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=9;BYDAY=2SU TZNAME:IST END:STANDARD BEGIN:DAYLIGHT DTSTART:19710101T020000 TZOFFSETTO:+0300 TZOFFSETFROM:+0200 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=-1FR TZNAME:IDT END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT UID:e6d6ce3a-e7f1-492b-9c52-65365ce2e235 SUMMARY:network - UI Sync meeting LOCATION:"Asia-tlv" <asia-tlv(a)redhat.com> ATTENDEE;CN=Miki Kenneth;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:mkenneth@redhat.com ATTENDEE;CN=Simon Grinberg;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=T RUE:mailto:sgrinber@redhat.com ATTENDEE;CN=Livnat Peer;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:lpeer@redhat.com ATTENDEE;CN=Doron Fediuck;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:dfediuck@redhat.com ATTENDEE;CN=Danny Rankevich;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE:mailto:drankevi@redhat.com ATTENDEE;CN=Einav Cohen;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:ecohen@redhat.com ATTENDEE;CN=Itamar Heim;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:iheim@redhat.com ATTENDEE;CN=Oved Ourfalli;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:ovedo@redhat.com ATTENDEE;CN=Andrew Cathrow;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=T RUE:mailto:acathrow@redhat.com ATTENDEE;CN=engine-devel;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:engine-devel@ovirt.org ATTENDEE;CN=Keith Robertson;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE:mailto:kroberts@redhat.com ATTENDEE;CN=William Henry;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:whenry@redhat.com ATTENDEE;CN=Yaniv Kaul;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE: mailto:ykaul@redhat.com ATTENDEE;CN=Ayal Baron;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE: mailto:abaron@redhat.com ATTENDEE;CUTYPE=RESOURCE;ROLE=NON-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:asia-tlv@redhat.com ORGANIZER;CN=Roy Golan:mailto:rgolan@redhat.com DTSTART;TZID="Asia/Jerusalem":20120227T160000 DTEND;TZID="Asia/Jerusalem":20120227T170000 STATUS:CONFIRMED CLASS:PUBLIC X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY TRANSP:OPAQUE LAST-MODIFIED:20120227T134527Z DTSTAMP:20120227T134527Z SEQUENCE:2 DESCRIPTION:The following meeting has been modified:\n\nSubject: network - U I Sync meeting \nOrganizer: "Roy Golan" <rgolan(a)redhat.com> \n\nLocation: "A sia-tlv" <asia-tlv(a)redhat.com> [MODIFIED]\nResources: asia-tlv(a)redhat.com [M ODIFIED]\nTime: Monday\, February 27\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +0 2:00 Jerusalem\n \nInvitees: mkenneth(a)redhat.com\; sgrinber(a)redhat.com\; lpe er(a)redhat.com\; dfediuck(a)redhat.com\; drankevi(a)redhat.com\; ecohen(a)redhat.co m\; iheim(a)redhat.com\; ovedo(a)redhat.com\; acathrow(a)redhat.com\; engine-devel @ovirt.org\; kroberts(a)redhat.com ... \n\n\n*~*~*~*~*~*~*~*~*~*\n\n\nFollow-u p meeting on setup networks UI. \nissues to follow: \n1. can VDSM attach man y non-vlan and many vlan networks to a single nic? (Dan - please reply if it s doable) \n2. if yes is the UI breakdown of vlan/non-vlan is probably not n ecessary? \n\n\nopen issues: \n1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? \n2.should we implicitly set bridge/bridgeless when attaching a network with setupnetwo rks? \n3.nickless networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it. \n\n\nBridge ID: 1 814335863 \n\nhttps://www.intercallonline.com/portlets/scheduling/viewNumber s/listNumbersByCode.do?confCode=1814335863 X-ALT-DESC;FMTTYPE=text/html:<html><body><h3>The following meeting has been modified:</h3>\n\n<p>\n<table border='0'>\n<tr><th align=left>Subject:</th>< td>network - UI Sync meeting </td></tr>\n<tr><th align=left>Organizer:</th>< td>"Roy Golan" &lt\;rgolan(a)redhat.com&gt\; </td></tr>\n</table>\n<p>\n<table border='0'>\n<tr><th align=left>Location:</th><td>"Asia-tlv" <asia-tlv@redh at.com> [MODIFIED]</td></tr>\n<tr><th align=left>Resources:</th><td>asia-tlv @redhat.com [MODIFIED]</td></tr>\n<tr><th align=left>Time:</th><td>Monday\, February 27\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem\n </td></t r></table>\n<p>\n<table border='0'>\n<tr><th align=left>Invitees:</th><td>mk enneth(a)redhat.com\; sgrinber(a)redhat.com\; lpeer(a)redhat.com\; dfediuck@redhat .com\; drankevi(a)redhat.com\; ecohen(a)redhat.com\; iheim(a)redhat.com\; ovedo@re dhat.com\; acathrow(a)redhat.com\; engine-devel(a)ovirt.org\; kroberts(a)redhat.co m ... </td></tr>\n</table>\n<div>*~*~*~*~*~*~*~*~*~*</div><br><br>Follow-up meeting on setup networks UI. <br>issues to follow: <br>1. can VDSM attach m any non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable) <br>2. if yes is the UI breakdown of vlan/non-vlan is probably n ot necessary? <br><br><br>open issues: <br>1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? <br>2.should we implicitly set bridge/bridgeless when attaching a network w ith setupnetworks? <br>3.nickless networks - was that planned for this versi on? VDSM support it already but we are missing the UI and Backend for it. <b r><br><br>Bridge ID: 1814335863 <br><br>https://www.intercallonline.com/port lets/scheduling/viewNumbers/listNumbersByCode.do?confCode=1814335863 </body> </html> BEGIN:VALARM ACTION:DISPLAY TRIGGER;RELATED=START:-PT5M DESCRIPTION:Reminder END:VALARM END:VEVENT END:VCALENDAR --=_384c57fb-d69c-42b9-b887-1ed31dd6d73e--

1 0

[Engine-devel] [backend] a little confusion about the quartz jobs
by Laszlo Hornyak 23 Feb '12

23 Feb '12

hi, I was playing with the quartz jobs in the backend and I thought this is an area where some simplification and/or cleanup would be useful. - SchedulerUtil interface would be nice to hide quartz from the rest of the code, but it very rarely used, the clients are bound to it's single implementation, SchedulerUtilQuartzImpl through it's getInstance() method. - It was designed to be a local EJB, Backend actually expects it to be injected. (this field is not used) - when scheduling a job, you call schedule...Job(Object instance, String methodName, ...) however, it is not the _methodname_ that the executor will look for - instead, it will check the OnTimerMethodAnnotation on all the methods. But this annotation has everywhere the methodName as value - JobWrapper actually iterates over all the methods to find the one with the right annotation So a quick simplification could be: - The annotation is not needed, it could be removed - JobWrapper could just getMethod(methodName, argClasses) instead of looking for the annotation in all of the methods - I am really not for factoryes, but if we want to separate the interface from the implementation, then probably a SchedulerUtilFactory could help here. The dummy implementation would do just the very same thing as the SchedulerUtilQuartzImpl.getInstance() - I would remove the reference to SchedulerUtil from Backend as well, since it is not used. Really _should_ the Backend class do any scheduling? Please share your thoughts. Thank you, Laszlo

4 8

[Engine-devel] bridge-less networks design wiki update
by Roy Golan 23 Feb '12

23 Feb '12

Hi all, Please find bridge-less network design wiki updated with changes following the latest discussions. www.ovirt.org/wiki/Features/Design/Network/Bridgeless_Networks Thanks, Roy

1 0

[Engine-devel] reviewer needed for schedulerutil cleanup
by Laszlo Hornyak 22 Feb '12

22 Feb '12

hi, As we previously agreed, I renamed the SchedulerUtil to SchedulerManager and removed the OnTimerAnnotation, can someone please review? http://gerrit.ovirt.org/#change,2140 Thanks, Laszlo

1 0

[Engine-devel] gwt: new "userportal-gwtp" module, new "gwt-user-gwtp" mvn profile
by Einav Cohen 22 Feb '12

22 Feb '12

Hi, A new oVirt UI module that is called "userportal-gwtp" has been introduced recently; it is written on top of the "gwt-common" infrastructure (on which the "web-admin" is based), and is targeted to eventually replace the existing "userportal" module. This module is still on the works - it is not fully functional yet. In order to build this new project (i.e., compile it to java-script), you need to "mvn build" oVirt with the "gwt-user-gwtp" profile (i.e., with "-Pgwt-user-gwtp"). The "gwt-user-gwtp" mvn profile has been added to the oVirt gwt Jenkins job, so in case of committing a change in the oVirt code that breaks mvn compilation that includes the "gwt-user-gwtp" profile, a relevant notification from Jenkins will be sent to the relevant recipients (just like notifications regarding breaking oVirt compilation with the other two gwt profiles, i.e, "gwt-user" and "gwt-admin", are already being sent). ---- Thanks, Einav

2 1

[Engine-devel] network - UI Sync meeting
by Roy Golan 22 Feb '12

22 Feb '12

--=_7d9c71d1-271b-4875-aea3-66898edcc4c8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit The following meeting has been modified: Subject: network - UI Sync meeting Organizer: "Roy Golan" <rgolan(a)redhat.com> Time: Monday, February 27, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem [MODIFIED] Invitees: mkenneth(a)redhat.com; sgrinber(a)redhat.com; lpeer(a)redhat.com; dfediuck(a)redhat.com; drankevi(a)redhat.com; ecohen(a)redhat.com; iheim(a)redhat.com; ovedo(a)redhat.com; acathrow(a)redhat.com; engine-devel(a)ovirt.org; kroberts(a)redhat.com ... *~*~*~*~*~*~*~*~*~* Follow-up meeting on setup networks UI. issues to follow: 1. can VDSM attach many non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable) 2. if yes is the UI breakdown of vlan/non-vlan is probably not necessary? open issues: 1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? 2.should we implicitly set bridge/bridgeless when attaching a network with setupnetworks? 3.nickless networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it. Bridge ID: 1814335863 https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers… --=_7d9c71d1-271b-4875-aea3-66898edcc4c8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit <html><body><h3>The following meeting has been modified:</h3> <p> <table border='0'> <tr><th align=left>Subject:</th><td>network - UI Sync meeting </td></tr> <tr><th align=left>Organizer:</th><td>"Roy Golan" <rgolan(a)redhat.com> </td></tr> </table> <p> <table border='0'> <tr><th align=left>Time:</th><td>Monday, February 27, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem [MODIFIED] </td></tr></table> <p> <table border='0'> <tr><th align=left>Invitees:</th><td>mkenneth(a)redhat.com; sgrinber(a)redhat.com; lpeer(a)redhat.com; dfediuck(a)redhat.com; drankevi(a)redhat.com; ecohen(a)redhat.com; iheim(a)redhat.com; ovedo(a)redhat.com; acathrow(a)redhat.com; engine-devel(a)ovirt.org; kroberts(a)redhat.com ... </td></tr> </table> <div>*~*~*~*~*~*~*~*~*~*</div><br><br>Follow-up meeting on setup networks UI. <br>issues to follow: <br>1. can VDSM attach many non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable)<br>2. if yes is the UI breakdown of vlan/non-vlan is probably not necessary? <br><br><br>open issues:<br>1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property?<br>2.should we implicitly set bridge/bridgeless when attaching a network with setupnetworks?<br>3.nickless networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it.<br><br><br>Bridge ID: 1814335863 <br><br>https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers… </body></html> --=_7d9c71d1-271b-4875-aea3-66898edcc4c8 Content-Type: text/calendar; charset=utf-8; method=REQUEST; name=meeting.ics Content-Transfer-Encoding: 7bit BEGIN:VCALENDAR PRODID:Zimbra-Calendar-Provider VERSION:2.0 METHOD:REQUEST BEGIN:VTIMEZONE TZID:Asia/Jerusalem BEGIN:STANDARD DTSTART:19710101T020000 TZOFFSETTO:+0200 TZOFFSETFROM:+0300 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=9;BYDAY=2SU TZNAME:IST END:STANDARD BEGIN:DAYLIGHT DTSTART:19710101T020000 TZOFFSETTO:+0300 TZOFFSETFROM:+0200 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=-1FR TZNAME:IDT END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT UID:e6d6ce3a-e7f1-492b-9c52-65365ce2e235 SUMMARY:network - UI Sync meeting ATTENDEE;CN=Miki Kenneth;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:mkenneth@redhat.com ATTENDEE;CN=Simon Grinberg;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=T RUE:mailto:sgrinber@redhat.com ATTENDEE;CN=Livnat Peer;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:lpeer@redhat.com ATTENDEE;CN=Doron Fediuck;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:dfediuck@redhat.com ATTENDEE;CN=Danny Rankevich;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE:mailto:drankevi@redhat.com ATTENDEE;CN=Einav Cohen;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:ecohen@redhat.com ATTENDEE;CN=Itamar Heim;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:iheim@redhat.com ATTENDEE;CN=Oved Ourfalli;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:ovedo@redhat.com ATTENDEE;CN=Andrew Cathrow;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=T RUE:mailto:acathrow@redhat.com ATTENDEE;CN=engine-devel;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:engine-devel@ovirt.org ATTENDEE;CN=Keith Robertson;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE:mailto:kroberts@redhat.com ATTENDEE;CN=William Henry;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:whenry@redhat.com ORGANIZER;CN=Roy Golan:mailto:rgolan@redhat.com DTSTART;TZID="Asia/Jerusalem":20120227T160000 DTEND;TZID="Asia/Jerusalem":20120227T170000 STATUS:CONFIRMED CLASS:PUBLIC X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY TRANSP:OPAQUE LAST-MODIFIED:20120222T001540Z DTSTAMP:20120222T001540Z SEQUENCE:1 DESCRIPTION:The following meeting has been modified:\n\nSubject: network - U I Sync meeting \nOrganizer: "Roy Golan" <rgolan(a)redhat.com> \n\nTime: Monday \, February 27\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem [MODIFI ED]\n \nInvitees: mkenneth(a)redhat.com\; sgrinber(a)redhat.com\; lpeer(a)redhat.c om\; dfediuck(a)redhat.com\; drankevi(a)redhat.com\; ecohen(a)redhat.com\; iheim@r edhat.com\; ovedo(a)redhat.com\; acathrow(a)redhat.com\; engine-devel(a)ovirt.org\ ; kroberts(a)redhat.com ... \n\n\n*~*~*~*~*~*~*~*~*~*\n\n\nFollow-up meeting o n setup networks UI. \nissues to follow: \n1. can VDSM attach many non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable)\n 2. if yes is the UI breakdown of vlan/non-vlan is probably not necessary? \n \n\nopen issues:\n1.should we use "VmNetwork"? (or "allow/able to run VMs" y ou name it) would it be a DC or a Cluster property?\n2.should we implicitly set bridge/bridgeless when attaching a network with setupnetworks?\n3.nickle ss networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it.\n\n\nBridge ID: 1814335863 \n\nht tps://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbersByC ode.do?confCode=1814335863 X-ALT-DESC;FMTTYPE=text/html:<html><body><h3>The following meeting has been modified:</h3>\n\n<p>\n<table border='0'>\n<tr><th align=left>Subject:</th>< td>network - UI Sync meeting </td></tr>\n<tr><th align=left>Organizer:</th>< td>"Roy Golan" &lt\;rgolan(a)redhat.com&gt\; </td></tr>\n</table>\n<p>\n<table border='0'>\n<tr><th align=left>Time:</th><td>Monday\, February 27\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem [MODIFIED]\n </td></tr></table >\n<p>\n<table border='0'>\n<tr><th align=left>Invitees:</th><td>mkenneth@re dhat.com\; sgrinber(a)redhat.com\; lpeer(a)redhat.com\; dfediuck(a)redhat.com\; dr ankevi(a)redhat.com\; ecohen(a)redhat.com\; iheim(a)redhat.com\; ovedo(a)redhat.com\ ; acathrow(a)redhat.com\; engine-devel(a)ovirt.org\; kroberts(a)redhat.com ... </t d></tr>\n</table>\n<div>*~*~*~*~*~*~*~*~*~*</div><br><br>Follow-up meeting o n setup networks UI. <br>issues to follow: <br>1. can VDSM attach many non-v lan and many vlan networks to a single nic? (Dan - please reply if its doabl e)<br>2. if yes is the UI breakdown of vlan/non-vlan is probably not necessa ry? <br><br><br>open issues:<br>1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property?<br>2.shoul d we implicitly set bridge/bridgeless when attaching a network with setupnet works?<br>3.nickless networks - was that planned for this version? VDSM supp ort it already but we are missing the UI and Backend for it.<br><br><br>Brid ge ID: 1814335863 <br><br>https://www.intercallonline.com/portlets/schedulin g/viewNumbers/listNumbersByCode.do?confCode=1814335863 </body></html> BEGIN:VALARM ACTION:DISPLAY TRIGGER;RELATED=START:-PT5M DESCRIPTION:Reminder END:VALARM END:VEVENT END:VCALENDAR --=_7d9c71d1-271b-4875-aea3-66898edcc4c8--

2 1

[Engine-devel] VM disks
by Livnat Peer 21 Feb '12

21 Feb '12

Hi, These days we are working on various features around VM disks, in the different threads it was decided that we'll have the ability to attach a disk to a VM but it will be added as inactive, then the user can activate it for it to be accessible from within the guest. Flow of adding a new disk would be: - creating the disk - attaching the disk to the VM - activating it Flow of adding a shared disk (or any other existing disk): - attach the disk - activate it It seems to me a lot like adding a storage domain and I remember a lot of rejections on the storage domain flow (mostly about it being too cumbersome). After discussing the issue with various people we could not find a good reason for having a VM disk in attached but inactive mode. Of course we can wrap the above steps in one step for specific flows (add+attach within a VM context for example) but can anyone think on a good reason to support attached but inactive disk? I would suggest that when attaching a disk to a VM it becomes part of the VM (active) like in 'real' machines. Thank you, Livnat

8 10

[Engine-devel] Future of IImage and DiskImageBase?
by Yair Zaslavsky 21 Feb '12

21 Feb '12

Hi all, Now with the elimination of DiskImageTemplate entity, Do we really need DiskImageBase and IImage? Yair

2 1

[Engine-devel] bridgless networks
by Roy Golan 19 Feb '12

19 Feb '12

Hi All Lately I've been working on a design of bridge-less network feature in the engine. You can see it in http://www.ovirt.org/wiki/Features/Design/Network/Bridgeless_Networks#Bridg… Please review the design. Note, there are some open issues, you can find in the relevant section. Reviews and comments are very welcome. Thanks, Roy

5 10

[Engine-devel] Empty cdrom drive.
by Igor Lvovsky 19 Feb '12

19 Feb '12

Hi, I want to discuss $subject on the email just to be sure that we all on the same page. So, today in 3.0 vdsm has two ways to create VM with cdrom : 1. If RHEV-M ask to create VM with cdrom, vdsm just create it 2. RHEV-M doesn't ask to create VM with cdrom, vdsm still creates VM with empty cdrom. Vdsm creates this device as 'hdc' (IDE device, index 2), because of libvirt restrictions. In this case RHEV-M will be able to "insert" cdrom on the fly with changeCD request. In the new style API we want to get rid from stupid scenario #2, because we want to be able to create VM without cdrom at all. It means, that now we need to change a little our scenarios: 1. If RHEV-M ask to create VM with cdrom, vdsm just create it 2. RHEV-M doesn't want to create VM with cdrom, but it want to be able to "insert" cdrom on the fly after this. Here we have two options: a. RHEV-M should to pass empty cdrom device on VM creation and use regular changeCD after that b. RHEV-M can create VM without cdrom and add cdrom later through hotplugDisk command. Note: The new libvirt remove previous restriction on cdrom devices. Now cdrom can be created as IDE or VIRTIO device in any index. It means we can easily hotplug it. Regards, Igor Lvovsky

5 5

[Engine-devel] attempting to deploy ovirt-engine built from source
by Ryan Harper 17 Feb '12

17 Feb '12

Hi, I've been attempting to build and deploy ovirt-engine from source; i've been following the guide[1] and I'm still having a bit of trouble; hoping for some help here. I've got a F16 64-bit server. I'm using the jboss that's available via the f16 repos: ovirt-engine-jbossas-1.2-2.fc16.x86_64 which is jboss 7.1 based. I've updated my .m2/settings.xml to match the install path of the above RPM: [build@f16-node ear]$ cat ~/.m2/settings.xml <settings xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/settings-1.0.0.xsd">  <activeProfiles> <activeProfile>oVirtEnvSettings</activeProfile> </activeProfiles> <profiles> <profile> <id>oVirtEnvSettings</id> <properties> <jbossHome>/usr/share/jboss-as-7.1.0.Beta1b</jbossHome> <JAVA_1_6_HOME>/usr/lib/jvm/java-1.6.0-openjdk.x86_64</JAVA_1_6_HOME> <forkTests>always</forkTests> </properties> </profile> </profiles> </settings> engine and the gui build fine with the commands from the wiki. When I attempt to test the connection and webgui they fail. so I looked out in the deployment directory and I see the following: [root@f16-node deployments]# pwd /usr/share/jboss-as-7.1.0.Beta1b/standalone/deployments [root@f16-node deployments]# ls -al total 28 drwxrwxr-x. 3 jboss-as jboss-as 4096 Feb 17 12:28 . drwxrwxr-x. 8 jboss-as jboss-as 4096 Feb 3 11:19 .. -rw-rw-r--. 1 jboss-as jboss-as 8868 Dec 1 16:10 README.txt drwxrwxr-x 15 build build 4096 Feb 17 12:21 engine.ear -rw-rw-r-- 1 jboss-as jboss-as 2353 Feb 17 12:21 engine.ear.failed I'm attaching the engine.ear.failed. 1. http://ovirt.org/wiki/Building_oVirt_engine -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh(a)us.ibm.com

2 3

[Engine-devel] New oVirt GIT Repo Request
by Keith Robertson 17 Feb '12

17 Feb '12

All, I would like to move some of the oVirt tools into their own GIT repos so that they are easier to manage/maintain. In particular, I would like to move the ovirt-log-collector, ovirt-iso-uploader, and ovirt-image-uploader each into their own GIT repos. The Plan: Step 1: Create naked GIT repos on oVirt.org for the 3 tools. Step 2: Link git repos to gerrit. Step 3: Populate naked GIT repos with source and build standalone spec files for each. Step 4: In one patch do both a) and b)... a) Update oVirt manager GIT repo by removing tool source. b) Update oVirt manager GIT repo such that spec has dependencies on 3 new RPMs. Optional: - These three tools share some python classes that are very similar. I would like to create a GIT repo (perhaps ovirt-tools-common) to contain these classes so that a fix in one place will fix the issue everywhere. Perhaps we can also create a naked GIT repo for these common classes while addressing the primary concerns above. Please comment, Keith Robertson

7 12

[Engine-devel] Autorecovery feature plan for review
by Laszlo Hornyak 16 Feb '12

16 Feb '12

Hi, Please review the plan document for autorecovery. http://www.ovirt.org/wiki/Features/Autorecovery Thank you, Laszlo

10 32