July 2016 - Devel - oVirt List Archives

Arrays.asList and GWT
by Roman Mohr 19 Jul '16

19 Jul '16

Hi List, Seems like GWT can't handle Arrays.asList not very well. Sharing this in case others have similar issues: I was working on a very strange deserialization bug in combination with GWT [1]. We had a deserialization problem after loading a VM and trying to send the VM back to the backend. The error looked like this: 2016-06-28 12:17:36,206 ERROR [io.undertow.servlet] (default task-58) Exception while dispatching incoming RPC call: java.lang.NumberFormatException: For input string: "undefined" It turned out that GWT could serialize an ArrayList backed by an Integer[] array but it could not deserialize it afterwards. In my case a list returned by ResultSet#getArray in the DAO layer was sent to GWT: entity.setCpuIds(Arrays.asList((Integer[]) rs.getArray("cpu_core_ids").getArray())); After copying the content over into a regular ArrayList everything worked fine again. entity.setCpuIds(new ArrayList<Integer>(Arrays.asList((Integer[]) rs.getArray("cpu_core_ids").getArray()))) Here is also the gerrit patch set [2]. So if you see strange GWT RPC errors like the one above look out for "Arrays.asList" in you code :). Best Regards, Roman [1] https://bugzilla.redhat.com/show_bug.cgi?id=1350861 [2] https://gerrit.ovirt.org/#/c/61038/2

1 0

oVirt 4.0.2 RC1 merge / branch / tag / bugzilla reminder
by Sandro Bonazzola 19 Jul '16

19 Jul '16

All stable branch maintainers, please make sure to - merge all relevant open bugs until Wednesday morning 11:00 AM TLV time. For each package that need to be built (i.e oVirt product) please make sure every bug in MODIFIED has the right Target Release and Target Milestone. A Target release should state the version of the package you're building and should include the same version you used for the tag you just used for this build. (e.g. for ovirt-engine, tag: ovirt-engine-4.0.2, tr: 4.0.2) A list of bugs that require attention is here: - https://bugzilla.redhat.com/buglist.cgi?quicksearch=target_milestone%3A4.0.… -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

oVirt 4.0.2 RC1 build planned
by Sandro Bonazzola 19 Jul '16

19 Jul '16

Fyi oVirt developers, An oVirt build is planned for this Wednesday 11:00 AM TLV time (10:00 AM CEST). Taking into consideration the time it takes for Jenkins to run a full CI everything need to be backported by Tuesday 11PM. Please make sure to mark as verified and CR +2 so it will be ready for merging Wednesday morning. A new branch ovirt-engine-4.0.2 will be created just before the build, an announce will be sent to remind to backport to that branch after its creation. A list of pending blockers is available here: https://bugzilla.redhat.com/buglist.cgi?quicksearch=target_milestone%3A4.0.… -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

[ANN] oVirt 4.0.1 Final Release is now available
by Sandro Bonazzola 19 Jul '16

19 Jul '16

The oVirt Project is pleased to announce today the general availability of oVirt 4.0.1. This release is available now for: * Fedora 23 (tech preview) * Red Hat Enterprise Linux 7.2 or later * CentOS Linux (or similar) 7.2 or later This release supports Hypervisor Hosts running: * Red Hat Enterprise Linux 7.2 or later * CentOS Linux (or similar) 7.2 or later * Fedora 23 (tech preview) * oVirt Next Generation Node 4.0 Please take a look at our community page[1] to know how to ask questions and interact with developers and users. All issues or bugs should be reported via oVirt Bugzilla[2]. This update is the first in a series of stabilization updates to the 4.0 series. 4.0.1 brings 10 enhancements and more than 200 bugfixes[6], including 70 high or urgent severity fixes, on top of oVirt 4.0 series and is a recommended update for everyone running 4.0.0. See the release notes [3] for installation / upgrade instructions and a list of new features and bugs fixed. Notes: * A new oVirt Live ISO is available. [4] * A new oVirt Next Generation Node will be available soon [4]. * A new oVirt Engine Appliance is already available. * Mirrors[5] might need up to one day to synchronize. Additional Resources: * Read more about the oVirt 4.0.1 release highlights: http://www.ovirt.org/release/4.0.1/ * Get more oVirt Project updates on Twitter: https://twitter.com/ovirt * Check out the latest project news on the oVirt blog: http://www.ovirt.org/blog/ [1] https://www.ovirt.org/community/ [2] https://bugzilla.redhat.com/enter_bug.cgi?classification=oVirt [3] http://www.ovirt.org/release/4.0.1/ [4] http://resources.ovirt.org/pub/ovirt-4.0/iso/ [5] http://www.ovirt.org/Repository_mirrors#Current_mirrors [6] https://bugzilla.redhat.com/buglist.cgi?quicksearch=target_milestone%3Aovir… -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

[VDSM] all check-patch jobs fail on fedora
by Nir Soffer 16 Jul '16

16 Jul '16

Hi infra, Vdsm tests fails now on fedora since they are running now on fedora 24, while vdsm automation was not updated yet to fedora 24. See http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc24-x86_64/ The problem patch seems to be: commit 4a40459191b39bafb6d14c34d6346bb152bc55da Author: Sandro Bonazzola <sbonazzo(a)redhat.com> Date: Thu Jul 14 13:58:44 2016 +0200 vdsm: move from fc22 to fc24 - dropped fc22 gone EOL - moved master to fc24 Change-Id: Ifce815087c649404b44f657911702735c53f75c3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Please revert this patch. We must add support for fedora 24 to vdsm first. When the tests are stable we can switch to fedora 24. Thanks, Nir

2 2

ovirt-engine housekeeping
by Sandro Bonazzola 15 Jul '16

15 Jul '16

Hi, as we did for 3.5, I'm going to do some housekeeping on ovirt-engine git repo. Unless a good reason is given I'm going to drop the following branches on Firday July 15th, being all of them still reachable by tags. ovirt-engine-3.6.0 e55a3b57c7541a60383a8d55f02a6ddeb6ae2ea6 ovirt-engine-3.6.1 81deade7478d1f1b55fd5cbc80a3b3003d9d1a18 ovirt-engine-3.6.2 7db5d96e4ca9a0c4896f627ba4a8835fd395e0b1 ovirt-engine-3.6.3 cb35e8c0070fd666f6a59b2e51993daa94e8ce6a ovirt-engine-3.6.4 e25f112ba2bac541b0e37d3cb60a1eda346b1ed9 ovirt-engine-3.6.5 cd869286db412bbc2d750838eef6f246b229aae2 ovirt-engine-3.6.6 d37fcd09f558d8884b804f8e774f9545b0981fc5 ovirt-engine-3.6.7 f94c8a7131ab2b23219916ee05030b499aec6252 Thanks, -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 1

oVirt metrics
by Yaniv Bronheim 14 Jul '16

14 Jul '16

Hi, In oVirt-4.0 we introduced integration with metrics collectors, In [1] you will find a guide for utilizing your environment to retrieve visualized reports about hosts and vms statistics. I encourage to try that out and send us requests for additional valuable metrics that you think vdsm should publish. This area is still work in progress and we plan to support more technologies and different architectures for metrics collections as describes in the post. This will follow by additional links in the post ([1]) that describe how to do so.. stay tuned. [1] https://bronhaim.wordpress.com/2016/06/26/ovirt-metrics <https://bronhaim.wordpress.com/2016/06/26/ovirt-metrics/>-- *Yaniv Bronhaim.*

4 3

[ACTION REQUIRED] broken dependency with vdsm git6e84643
by Sandro Bonazzola 13 Jul '16

13 Jul '16

DEBUG util.py:417: Error: Package: vdsm-4.18.999-232.git6e84643.el7.centos.x86_64 (ovirt-master-snapshot) DEBUG util.py:417: Requires: safelease >= 1.0-7 DEBUG util.py:417: Available: safelease-1.0-5.el7.x86_64 (centos-epel) DEBUG util.py:417: safelease = 1.0-5.el7 -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

5 7

[ANN] oVirt 4.0.1 Second Release candidate is now available for testing
by Sandro Bonazzola 13 Jul '16

13 Jul '16

The oVirt Project is pleased to announce the availability of the Second Release Candidate of oVirt 4.0.1 for testing, as of July 13th, 2016. This is pre-release software. Please take a look at our community page[1] to know how to ask questions and interact with developers and users. All issues or bugs should be reported via oVirt Bugzilla[2]. This pre-release should not to be used in production. This release is available now for: * Fedora 23 (tech preview) * Red Hat Enterprise Linux 7.2 or later * CentOS Linux (or similar) 7.2 or later This release supports Hypervisor Hosts running: * Red Hat Enterprise Linux 7.2 or later * CentOS Linux (or similar) 7.2 or later * Fedora 23 (tech preview) * oVirt Next Generation Node 4.0 See the release notes draft [3] for installation / upgrade instructions and a list of new features and bugs fixed. Notes: * A new oVirt Live ISO is already available [4]. * A new oVirt Next Generation Node will be available soon [4] * A new oVirt Engine Appliance wil be available soon. * Mirrors[5] might need up to one day to synchronize. Additional Resources: * Read more about the oVirt 4.0.1 release candidate highlights: http://www.ovirt.org/release/4.0.1/ * Get more oVirt Project updates on Twitter: https://twitter.com/ovirt * Check out the latest project news on the oVirt blog: http://www.ovirt.org/blog/ [1] https://www.ovirt.org/community/ [2] https://bugzilla.redhat.com/enter_bug.cgi?classification=oVirt [3] http://www.ovirt.org/release/4.0.1/ [4] http://resources.ovirt.org/pub/ovirt-4.0-pre/iso/ [5] http://www.ovirt.org/Repository_mirrors#Current_mirrors -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

[ACTION REQUIRED] oVirt 4.0.1 RC2 build starting
by Sandro Bonazzola 12 Jul '16

12 Jul '16

Fyi oVirt products maintainers, An oVirt build for an official release is going to start right now. If you're a maintainer for any of the projects included in oVirt distribution and you have changes in your package ready to be released please: - bump version and release to be GA ready - tag your release within git (implies a GitHub Release to be automatically created) - build your packages within jenkins / koji / copr / whatever - verify all bugs on MODIFIED have target release and target milestone set. - add your builds to releng-tools/releases/ovirt-4.0.1_rc2.conf within releng-tools project Thanks, -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

Caching of data from the database done properly
by Roman Mohr 12 Jul '16

12 Jul '16

Hi Everyone, I wanted to discuss a practice which seems to be pretty common in the engine which I find very limiting, dangerous and for some things it can even be a blocker. There are several places in the engine where we are using maps as cache in singletons to avoid reloading data from the database. Two prominent ones are the QuotaManager[1] and the MacPoolPerCluster[2]. While it looks tempting to just use a map as cache, add some locks around it and create an injectable singleton, this has some drawbacks: 1) We have an autoritative source for our data and it offers transactions to take care of inconsistencies or parallel updates. Doing all that in a service again duplicates this. 2) Caching on the service layer is definitely not a good idea. It can introduce unwanted side effects when someone invokes the DAOs directly. 3) The point is more about the question if a cache is really needed: Do I just want that cache because I find it convenient to do a #getMacPoolForCluster(Guid clusterId) in a loop instead of just loading it once before the loop, or do my usage requirements really force me to use a cache? If you really need a cache, consider the following: 1) Do the caching on the DAO layer. This guarantees the best consistency across the data. 2) Yes this means either locking in the DAOs or a transactional cache. But before you complain, think about what in [1] and [2] is done. We do exactly that there, so the complexity is already introduced anyway. 3) Since we are working with transactions, a custom cache should NEVER cache writes (really just talking about our use case here). This makes checks for existing IDs before adding an entity or similar checks unnecessary, don't duplicate constraint checks like in [2]. 4) There should always be a way to disable the cache (even if it is just for testing). 5) If I can't convince you to move the cache to the DAO layer, still add a way to disable the cache. For as long as there is no general caching solution with something like ehcache or infinispan, in my eyes such small things matter a lot to keep a project maintainable. That are some of the best practices I have seen around caching database data. It would be great if we could agree on something like that. Maybe there is already an agreement on something and I am just not aware of it. Looking forward to hear your feedback. Roman [1] https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/b… [2] https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/b…

4 6

oVirt 4.0.1 rc2 merge / branch / tag / bugzilla reminder
by Sandro Bonazzola 11 Jul '16

11 Jul '16

All stable branch maintainers, please make sure to - merge all relevant open bugs until Tuesday morning 11:00 AM TLV time. For each package that need to be built (i.e oVirt product) please make sure every bug in MODIFIED has the right Target Release and Target Milestone. A Target release should state the version of the package you're building and should include the same version you used for the tag you just used for this build. (e.g. for ovirt-engine, tag: ovirt-engine-4.0.1.1, tr: 4.0.1.1) A list of bugs that require attention is here: - https://bugzilla.redhat.com/buglist.cgi?quicksearch=target_milestone%3A4.0.… Thanks, -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

oVirt 4.0.1 RC2 build planned
by Sandro Bonazzola 11 Jul '16

11 Jul '16

Fyi oVirt developers, An oVirt build is planned for this Tuesday 11:00 AM TLV time (10:00 AM CEST). Taking into consideration the time it takes for Jenkins to run a full CI everything need to be backported by Monday 11PM. Please make sure to mark as verified and CR +2 so it will be ready for merging Tuesday morning. A list of pending blockers is available here: https://bugzilla.redhat.com/buglist.cgi?quicksearch=target_milestone%3A4.0.… -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

Weekly bug status for ovirt-system-tests (using Lago) [ 11/07/16 ]
by Eyal Edri 11 Jul '16

11 Jul '16

*Open bugs:* https://goo.gl/eUaPUY *Open issues:* HE 4.0 support - patch under review - https://gerrit.ovirt.org/#/c/59717/ Initial documentation in progress - https://gerrit.ovirt.org/#/c/59870/ *Open patches:* (reviews are welcome) https://gerrit.ovirt.org/#/q/project:ovirt-system-tests+status:open *Jenkins jobs:* http://jenkins.ovirt.org/view/oVirt%20system%20tests/ * Jobs were failing on add host, most failures were due to missing support on new F24 slaves, fixed. * There was an issue with using 3.6 ovirt stable repo in some tests, seems it was leftover from early days, replacing repo with 3.6 nighties as we do in 4.0 and master solved it. * 4 more slaves added to run tests, running F24 * We hit a libvirt bug [1] that forced us to manually enable the service for now. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1290357 *Recently merged patches:* https://gerrit.ovirt.org/#/q/project:ovirt-system-tests+status:merged+since… -- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

1 0

python-paramiko availability
by Paul Dyer 11 Jul '16

11 Jul '16

Hi, I am trying to install the ovirt-4.0 engine to a fresh install of RHEL 7.2. There is a dependency for python-paramiko, but it appears that rpm was removed from RHEL between 6 and 7... The dependency appears when I install ovirt-engine: Error: Package: ovirt-engine-setup-base-4.0.0.6-1.el7.centos.noarch (ovirt-4.0) Requires: python-paramiko This doc notes the package removal: https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/ht… Does anyone know where to source this package? Thanks, Paul -- Paul Dyer, Mercury Consulting Group, RHCE 504-302-8750

3 6

gerrit.ovirt.org migration
by Shlomo Ben David 10 Jul '16

10 Jul '16

Hi All, Today we are planning to migrate gerrit.ovirt.org server to a new bigger instance on Amazon to improve performance. - The migration will start at 18:00 IDT - Estimate migration end time 19:00 IDT. - During the migration the server will not be available (you won't be able to send patches or review code) - The server will be down for about an hour, but if we'll be able to restore it before we'll let you know. - An email will be sent at the end of the migration process. Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL Phone: +972-54-8008858 IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1

6 7

oVirt master moving to F24
by Eyal Edri 10 Jul '16

10 Jul '16

FYI, We encourage all maintainers to switch their projects builds for master to F24, as oVirt project builds usually only latest release (unless there are issues that prevents it). ovirt-engine & mom already moved, this usually requires a single patch to jenkins yaml file for your standard CI project, see [1] for e.g on engine and also you'll need to update the master publisher to take the f24 rpms instead, see [2] for e.g feel free to contact infra list if you need help. [1] https://gerrit.ovirt.org/#/c/60232/ [2] https://gerrit.ovirt.org/#/c/60392/ -- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

1 0

(MASTER) exception on server.log: ERROR: insert or update on table "host_device" violates foreign key constraint "fk_host_device_parent_name"
by Yaniv Kaul 07 Jul '16

07 Jul '16

Caused by: org.postgresql.util.PSQLException: ERROR: insert or update on table "host_device" violates foreign key constraint "fk_host_device_parent_name" Detail: Key (host_id, parent_device_name)=(767142d5-6242-4bb1-bcbd-095595c3b7f1, scsi_host2) is not present in table "host_device". at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2157) at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1886) at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255) at org.postgresql.jdbc2.AbstractJdbc2Connection.executeTransactionCommand(AbstractJdbc2Connection.java:793) at org.postgresql.jdbc2.AbstractJdbc2Connection.commit(AbstractJdbc2Connection.java:817) at org.jboss.jca.adapters.jdbc.local.LocalManagedConnection.commit(LocalManagedConnection.java:96) Seen on ovirt-engine-4.1.0-0.0.master.20160701111322.gitf1c9a5c.el7.centos.noarch Y.

3 3

[FYI] Jenkins maintenance today 18:30 TLV
by Nadav Goldin 06 Jul '16

06 Jul '16

Hi, http://jenkins.ovirt.org will be restarted for plugin updates today at 18:30 TLV time, expected downtime is 30 minutes. Patches sent 30 minutes before might not get checked, patches sent during the downtime will get checked when Jenkins is back. If patches you sent did not trigger CI, you can login after the downtime and re-trigger them manually. Thanks, Nadav.

1 1

oVirt Community Newsletter: June 2016
by Brian Proffitt 06 Jul '16

06 Jul '16

Not only was June the occasion of the Red Hat Summit event in San Francisco, where oVirt was well-represented in the event and within Community Central, but it was also the month where the year's biggest release, oVirt 4.0! The latest release of oVirt features: * A New Administration Portal * Improved Live-Migration Performance * Improved Image Features * Container Support * New and Improved oVirt Node Check out oVirt 4.0 today, and in the meantime, here's what happened in June, 2016: ----------------- Software Releases ----------------- oVirt 4.0.0 Final Release is now available http://lists.ovirt.org/pipermail/announce/2016-June/000268.html New oVirt-Live (4.0.0) is available for download http://lists.ovirt.org/pipermail/users/2016-June/040577.html oVirt 3.6.7 Fifth Release Candidate is now available for testing http://lists.ovirt.org/pipermail/announce/2016-June/000265.html ---------------- In the Community ---------------- oVirt 4.0 is released! http://www.ovirt.org/blog/2016/06/ovirt-40-release/ Go Upstream at Summit Community Central http://red.ht/29ipa6z oVirt Meetup Boston - MA http://www.meetup.com/Boston-oVirt-Community/ A New oVirt Dashboard for Disaster Recovery https://bitbucket.org/chocomango/ovirt-dashboard P.L. Ferrari Deploys Red Hat Enterprise Virtualization for a More Efficient IT Infrastructure http://red.ht/1V12049 Red Hat Summit Community Track Day One http://red.ht/29mAH5m oVirt 4.0 mit neuem Dashboard (Deutsch) http://www.pro-linux.de/news/1/23702/ovirt-40-mit-neuem-dashboard.html ------------------------------------ Deep Dives and Technical Discussions ------------------------------------ Supercharge Your Network Throughput via Single Root I/O Virtualization (SR-IOV) http://red.ht/1RX3Qkx oVirt Release 4.0: New opportunities [Russian] [Video] https://youtu.be/I4hQAH08Dlg How to Install oVirt (Open Virtualisation) on Centos 7 [Indonesian] [Video] https://youtu.be/eO0tzmQ9LCk Fedora 24 Server & oVirt 4.0 [Video Playlist] http://bit.ly/29iqDtk Creating a KVM VM through oVirt 4.0 with Intel Skull Canyon [Video] https://youtu.be/AjmstE30sM0 Unedited Install of Windows 2012 R2 on KVM oVirt with Nuctastic Intel Skull Canyon [Video] https://youtu.be/DnhutZdLYT4 3 Minute Provisioning VM from KVM oVirt Template [Video] https://youtu.be/uH7QraPPFnw Restart of KVM Ovirt Windows 2016 VM in less than 2 seconds [Video] https://youtu.be/Ea_QeOv9mD8 -- Brian Proffitt Principal Community Analyst Open Source and Standards @TheTechScribe 574.383.9BKP

1 0

SPM or SDM for a new verb?
by Shmuel Melamud 05 Jul '16

05 Jul '16

Hi! I'm writing code for a new verb (sparsifyInplace) in VDSM and got two different opinions about whether to use SPM or SDM for it: 1) SDM is the new correct approach, need to use it. 2) SDM is on early stage and may be changed significantly, so it is better to use SPM as mature and reliable approach. What's your opinion? Shmuel

2 1

Ovirt Node Next 4.0.0 host networking setup attempts to bridge an Infiniband interface
by Giorgio Biacchi 05 Jul '16

05 Jul '16

Hello list, currently I have an up and running Ovirt 3.6 installation where every hypervisor access the data domain via NFS over infiniband. All is working as expected, with a couple of hooks I can set connected mode on ib0 and an MTU of 65520. Now I'm testing Ovirt Node Next, but the behavior is different. When I try to set up host networking the procedure attempts to bridge the network "ibstorage", defined in Networks tab, with ib0 interface but a non ethernet interface cannot be bridged that way. There's any way I can obtain the desired result? Or somehow tell to the hypervisor to not bridge that connection and to use ib0 directly? Thanks -- gb PGP Key: http://pgp.mit.edu/ Primary key fingerprint: C510 0765 943E EBED A4F2 69D3 16CC DC90 B9CB 0F34

2 1

update - no infra support for the next 2 days
by Eyal Edri 05 Jul '16

05 Jul '16

FYI, Due to various holidays, PTOs and an on going 3.6.8 build there is not infra support for the next two days. If there are urgent issues, please open a ticket to infra-support(a)ovirt.org and we'll do our best to handle it if possible. -- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

1 0

Integration tests future (and very nice alternative for the DAO fixture file)
by Roman Mohr 04 Jul '16

04 Jul '16

Hi all, In [1] you can find some patches which are meant to improve the test writing experience in ovirt-engine. They provide the following things: A) Domain Object builders which can be used for creating and/or persisting domain objects [2] B) DAO testing without writing fixtures because of the builders C) Integration testing for commands in conjunction with a real database Arquillian, injectable commands and the builders [3] # How to run what? A) In normal unit tests just create a new instance of a builder and use it. This should help us to get rid of all the small createDefaultVm(), createHostWithX() helper methods in our tests. B) In dao tests just inject them and go ahead. The advantage of not using the fixture file is that we can now set up clean scenarios for every test in a setup method. See example 2 below on how easy it is to set up a new cluster. C) Arquillian integration tests need to be marked with "@Category(IntegrationTest.class)" and can inherit from TransactionalTestBase. The @Category annotation makes sure that the integration tests are only run when mvn clean verify -DskipITs=false is invoked. Note that these tests are then executed in the integration test phase of maven. For them we use the maven-failsafe-plugin[5] which will also make sure that the testing database is up to date. See [4] for more details. # Examples 1) Add a running VM to a host, persist everything to the database and load all VMs which are running on the host: VDS host = vdsBuilder.cluster(persistedCluster).persist(); vmBuilder.host(host).up().persist(); List<VM> vms = vmDao.getAllRunningForVds(host.getId()); 2) Add 10 hosts with 1 GB of RAM to a cluster, persist the hosts to the database in a DAO test: public class MyHostDaoTest extends BaseDaoTestCase { @Inject private VdsBuilder vdsBuilder; @Test public void createHosts() { VdsBuilder builder = vdsBuilder.cluster(persistedCluster).physicalMemory(1000); for (int x =0; x < 10; x++){ builder.id(Guid.newGuid()).persist(); } } } 3) Full integration test with arquillian and the database @Category(IntegrationTest.class) public class VmDaoIntegrationTest extends TransactionalTestBase { @Inject VmDao vmDao; private final Guid VM1_GUID = Guid.createGuidFromString("0fe4bc81-5999-4ab6-80f8-7a4a2d4bfacd"); @Deployment public static JavaArchive deploy(){ return createDeployment(); } @Test public void shouldFailOnExistingEntity() { vmBuilder.id(VM1_GUID).cluster(clusterBuilder.reset().persist()).persist(); // This uses assertThat from assertj: assertThat(vmDao.get(VM1_GUID)).isNotNull(); } } 4) Using the builders in a normal unit test without a database: VM vm = new VmBuilder().id(Guid.newGuid()).up().build(); # How to add your own Domain objects? There are just a few simple rules: 1) Your builder should extend org.ovirt.engine.core.builder.AbstractBuilder 2) Make sure that you only access DAOs injected into the builder during #prePersist() and #persist(). This allows to use the #build() method also without injections 3) #prePersist() should set all fields which are necessary to suffice database constraints. The fields should only be set if they are not already set before by the builder. When following this rule we can always persist new objects to the database by simply calling myBuilder.reset().persist(). 4) Mark your builder with @Repository to make them useable for our Spring DAO tests and our Arquillian integration tests. So have a look at the patches at [1] and let me know what you think about them. Best Regards and happy testing, Roman [1] https://gerrit.ovirt.org/#/q/topic:integration [2] https://gerrit.ovirt.org/#/c/47008/17 [3] https://gerrit.ovirt.org/#/c/47007/10 [4] https://gerrit.ovirt.org/#/c/47008/17 [5] https://maven.apache.org/surefire/maven-failsafe-plugin/

5 7

drop-in directories for vdsm configuration
by Irit Goihman 04 Jul '16

04 Jul '16

Hi, A drop-in directories feature has been added to vdsm-4.18.4. This allows the user to put partial configurations into a drop-in file and create new parameters or override default ones. The semantics of the directories is as follows: - /etc/vdsm/vdsm.conf: For default configuration. We install this file if missing, and never touch this file during upgrade. - /etc/vdsm/vdsm.conf.d/ - / run/vdsm/vdsm.conf.d/ - /usr/lib/vdsm/vdsm.conf.d/ Files with a .conf suffix can be placed into any of the vdsm.conf.d drop-in directories. The default configuration file is read before all other files and has the lowest priority. The priority of configuration files under vdsm.conf.d is determined by lexicographic order of file names, so the lexicographic latest file name takes precedence. It is highly recommended to prefix all file names with a two-digit number in order to keep the ordering simple. -- Irit Goihman Software Engineer Red Hat Israel Ltd.

1 0