- Devel - oVirt List Archives

'make distcheck' issues in VDSM project (regarding BZ#1297808)
by Marcin Sobczyk 26 Sep '18

26 Sep '18

Hi, I've been doing some work around making 'make distcheck' and VPATH builds successful for VDSM. Some patches have already been merged, but there is one that I've abandoned because it touches a bigger issue. When doing a VPATH build, some python sources are build-time generated from '.py.in' files (at this moment: 'lib/vdsm/common/constants.py.in', 'lib/vdsm/common/config.py.in', 'lib/vdsm/common/dsaversion.py.in', '/lib/sos/vdsm.py.in'). Suppose we do a VPATH build with: cd ${SRCROOT} && \ ./autogen.sh && \ make distclean && \ mkdir -p /tmp/ovirt-build && \ cd /tmp/ovirt-build && \ ${SRCROOT}/configure && \ make The build-generated '.py' files will land in '/tmp/ovirt-build/lib/...'. As a result, even though the build-generated python modules and the source ones refer to each other, they can't see each other. After some trial and error here are my observations: - we can't generate resulting '.py' files in $(srcdir) - 'make distcheck' purposely sets $(srcdir) to be read-only - we can't just simply add $(builddir) to PYTHONPATH - there are no '__init__.py' files in $(builddir), so i.e. 'import vdsm.common.config' will fail - we can't create dummy '__init__.py' files in $(builddir), because that would break in-tree-builds (we would have to clean regular, git-maintained files) In conclusion, I think we would need to implement a custom python module loader to make VPATH/distcheck successful. It would need to be parametrized with $(builddir)'s path, and would try to resolve unsuccessful imports by finding build-time generated files inside. However, after looking at other oVirt projects (i.e. 'ioprocess', 'ovirt-iso-uploader', 'ovirt-node-ng', 'ovirt-register'), I can see that most of them fail 'make distcheck'. They have even more severe 'makefile'-issues than importing build-time generated python files. So the question is - do we really need 'make distcheck' for VDSM to suceed? Marcin

2 1

Jenkins help
by Germano Veit Michel 25 Sep '18

25 Sep '18

Hi, I'm struggling with a check-patch failing. This is the error (I think): [7;33m************* Module vdsm.tool.update_volume [0m [1;31mE [0m: 87,16: [1;31mInstance of '_Client' has no 'Host' member [0m ( [1;31mno-member [0m) [1;31mE [0m:101,23: [1;31mInstance of '_Client' has no 'StoragePool' member [0m ( [1;31mno-member [0m) The way I understand it, the error above from [1] means that the check patch fails because the cli object does not contain Host or StoragePool. However, from reading the code it seems the Host and StoragePool members are created at runtime by parsing the API schema. So static checking for [2] and [3] fails. I see some other tools doing similar things (i,e. dump_volume_chains), but I can't find anything specific done to prevent it. Or am I missing something? Any idea on how to solve this? [1] https://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/25017/arti… [2] https://gerrit.ovirt.org/gitweb?p=vdsm.git;f=lib/vdsm/tool/update_volume.py… [3] https://gerrit.ovirt.org/gitweb?p=vdsm.git;f=lib/vdsm/tool/update_volume.py… Thanks! Germano

1 1

ovirt-engine has been tagged (ovirt-engine-4.2.7.1)
by Piotr Kliczewski 21 Sep '18

21 Sep '18

1 0

Dealing with TaskID in vdsm api
by Germano Veit Michel 21 Sep '18

21 Sep '18

Hello, I've been struggling with TaskID/FlowID when talking to the VDSM API. I am trying to write a tool that uses the vdsm-api to facilitate the troubleshooting of image issues (snapshots). This tool does a series of API calls, but I cannot find a nice way to track the taskID and clear the completed tasks after completion of the tool commands. Currently I'm clearing all Tasks that match the verb and are finished, which is not ideal. I would like to have the exact TaskID to track and dont want to leave Tasks behind. I don't want also to clear tasks from other entities (like engine!). I understand that if I want to specify the task/flow ids when calling the vdsm API, these two need to be passed as headers (http) so they end up in the context of the call. Is this correct? But using vdsm/client.py I cannot figure out how to do this, but I understand it is possible. I've been looking at vdsm/common/api.py and vdsm/client.py and trying several things but nothing seems to do it. Could anyone please put some light on this? Thanks, Germano

4 10

Re: blog post: quick(er) development / testing of GWT code using SDM
by sangeetha r 21 Sep '18

21 Sep '18

Hi Greg, I followed your post "oVirt Webadmin GWT Debug Quick Refresh" in Centos7. I am able to get the SDM compile works. But changes are not reflecting in UI Chrome/Firefox. I didn't see any error in logs as well. This is the GWT log output when I do compile [INFO] The code server is ready at http://10.149.202.159:9876/[INFO] GET /recompile/webadmin[INFO] Job org.ovirt.engine.ui.webadmin.WebAdmin_1_0[INFO] starting job: org.ovirt.engine.ui.webadmin.WebAdmin_1_0[INFO] binding: locale=en_US[INFO] binding: user.agent=safari[INFO] Compiling module org.ovirt.engine.ui.webadmin.WebAdmin[INFO] Computing all possible rebind results for 'com.gwtplatform.mvp.client.DesktopGinjector'[INFO] Rebinding com.gwtplatform.mvp.client.DesktopGinjector[INFO] Invoking generator com.google.gwt.inject.rebind.GinjectorGenerator[INFO] [WARN] Class org.ovirt.engine.ui.gwtaop.AspectJLogHandler is used in Gin, but not available in GWT client code.[INFO] info AspectJ Weaver Version 1.8.10 built on Monday Dec 12, 2016 at 19:07:48 GMT[INFO] info register classloader com.google.gwt.inject.rebind.GinBridgeClassLoader@cbbe9df[INFO] info using configuration file:/home/admin/.m2/repository/org/ovirt/engine/ui/gwt-aop/4.3.0-SNAPSHOT/gwt-aop-4.3.0-SNAPSHOT.jar!/META-INF/aop.xml[INFO] info register aspect org.ovirt.engine.ui.gwtaop.DontPrune[INFO] warning javax.* types are not being woven because the weaver option '-Xset:weaveJavaxPackages=true' has not been specified[INFO] Unification traversed 23500 fields and methods and 8802 types. 667 are considered part of the current module and 672 had all of their fields and methods traversed.[INFO] Compiling 1 permutation[INFO] Compiling permutation 0...[INFO] Linking per-type JS with 667 new/changed types.[INFO] Source Maps Enabled[INFO] Compile of permutations succeeded[INFO] Compilation succeeded -- 27.667s[INFO] Linking into /home/admin/git/ovirt-engine/frontend/webadmin/modules/webadmin/target/tmp/gwt-codeserver-671189326887964275.tmp/org.ovirt.engine.ui.webadmin.WebAdmin/compile-2/war/webadmin; Writing extras to /home/admin/git/ovirt-engine/frontend/webadmin/modules/webadmin/target/tmp/gwt-codeserver-671189326887964275.tmp/org.ovirt.engine.ui.webadmin.WebAdmin/compile-2/extras/webadmin[INFO] Link succeeded[INFO] Linking succeeded -- 4.482s[INFO] 34.746s total -- Compile completed Can you please help me on this issue. Thanks! Sangeetha S

2 1

Re: [CQ]: 94345,3 (ovirt-provider-ovn) failed "ovirt-4.2" system tests
by Dafna Ron 20 Sep '18

20 Sep '18

I am not sure since I have never opened a ticket for them. I am adding Sandro, Barak and ovirt dev so that perhaps someone with more experience can offer a better advice. On Thu, Sep 20, 2018 at 8:37 AM Miguel Duarte de Mora Barroso < mdbarroso(a)redhat.com> wrote: > On Thu, Sep 20, 2018 at 8:02 AM, Dominik Holler <dholler(a)redhat.com> > wrote: > > On Wed, 19 Sep 2018 17:53:32 +0100 > > Dafna Ron <dron(a)redhat.com> wrote: > > > >> it failed on build-artifacts: > >> http://pastebin.test.redhat.com/649015 > >> > > > > Thanks, I did not find this error message. > > > > > > 13:03:03 [build-artifacts.fc27.x86_64] Failed to synchronize cache for > repo 'mdbarroso-python-ovsdbapp', disabling. > > 13:03:03 [build-artifacts.fc27.x86_64] Last metadata expiration check: > 0:00:00 ago on Wed Sep 19 13:01:34 2018. > > 13:03:03 [build-artifacts.fc27.x86_64] No match for argument: > python2-ovsdbapp > > 13:03:03 [build-artifacts.fc27.x86_64] Error: Unable to find a match > > > > looks like > > https://copr-be.cloud.fedoraproject.org/ > > is unstable. > > Miguel, do you expect that the reference to this repo is removed next > > days, or should we ask someone from copr-be.cloud.fedoraproject.org for > > help? > > Hi Dafna, > > I'm forced to agree that copr has been unstable for the past few days. > > I'll contact the openstack release guys to get an update on the > deliver on the python2-ovsdbapp-0.12.1, but I think we should also > open the copr track. > > Can you elaborate on what needs to be done Dafna? Just drop them an > email saying this repo fails every now and then? > > > > > >> > >> On Wed, Sep 19, 2018 at 5:09 PM Dominik Holler <dholler(a)redhat.com> > >> wrote: > >> > >> > Hi Marcin, > >> > the test looks like succeeded, but the return failed. > >> > Do you have an idea why? > >> > Dominik > >> > > >> > > >> > Begin forwarded message: > >> > > >> > Date: Wed, 19 Sep 2018 16:48:45 +0100 > >> > From: Dafna Ron <dron(a)redhat.com> > >> > To: Dominik Holler <dholler(a)redhat.com> > >> > Subject: Fwd: [CQ]: 94345,3 (ovirt-provider-ovn) failed "ovirt-4.2" > >> > system tests > >> > > >> > > >> > hi, ? > >> > > >> > I am seeing that the check-merge job that failed is still broken. so > >> > guessing you guys are looking into it? > >> > > >> > Thanks, > >> > Dafna > >> > > >> > > >> > ---------- Forwarded message --------- > >> > From: oVirt Jenkins <jenkins(a)ovirt.org> > >> > Date: Wed, Sep 19, 2018 at 4:26 PM > >> > Subject: [CQ]: 94345,3 (ovirt-provider-ovn) failed "ovirt-4.2" > >> > system tests To: <infra(a)ovirt.org> > >> > > >> > > >> > Change 94345,3 (ovirt-provider-ovn) is probably the reason behind > >> > recent system > >> > test failures in the "ovirt-4.2" change queue and needs to be fixed. > >> > > >> > This change had been removed from the testing queue. Artifacts build > >> > from this > >> > change will not be released until it is fixed. > >> > > >> > For further details about the change see: > >> > https://gerrit.ovirt.org/#/c/94345/3 > >> > > >> > For failed test results see: > >> > http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/3150/ > >> > _______________________________________________ > >> > Infra mailing list -- infra(a)ovirt.org > >> > To unsubscribe send an email to infra-leave(a)ovirt.org > >> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/ > >> > oVirt Code of Conduct: > >> > https://www.ovirt.org/community/about/community-guidelines/ > >> > List Archives: > >> > > >> > > https://lists.ovirt.org/archives/list/infra@ovirt.org/message/VGTE6K3DMBCBM… > >> > > > >

2 1

[OST][hc-basic-suite-master] Fails on HE deployment
by Sahina Bose 19 Sep '18

19 Sep '18

xargs -I{} sudo -u vdsm dd if={} | tar -tvf - 772a3dfe-aee8-45d9-9df5-beddcbf92010.ovf\", u'removes': None, u'creates': None, u'chdir': None, u'stdin': None}}, u'stdout_lines': [], u'stderr': u\"vdsm-client: Command Image.prepare with args {'storagepoolID': 'e90984b6-af79-11e8-a2dd-00163e24d363', 'storagedomainID': 'b4c84ead-fb7f-4478-acd2-0309d569b9aa', 'volumeID': 'b18f30b1-5625-4581-b815-94291b226c79', 'imageID': '[u7894c850-665f-47dd-8376-e4da5ae7807f]'} failed:\\n(code=201, message=Volume does not exist: (u'b18f30b1-5625-4581-b815-94291b226c79',))\\ntar: This does not look like a tar archive Is this a known issue? thanks! sahina

2 3

PLEASE READ: Stop merging to ovirt-engine master until further notice
by Dafna Ron 17 Sep '18

17 Sep '18

Hello to all, I asked to stop merging last week but it seemed to have been ignored so writing again. *please stop merging to ovirt-engine master until further notice.* the project has been failing for the last two weeks on various different regressions. You continue to merge changes which means that you are risking further regressions and making it hard to stabilize the master branch for ovirt-engine. to make it clear: 1. all changes that were merged since sept. 4th to the master branch exist only in the ovirt-engine master branch (i.e they are not included in your project package). 2. any code merged to master in the past two weeks was most likely not tested by CQ since we exit on first test failure (if your code effects anything after the reported issues ran, they would not be tested). 3. you are putting other projects at risk for regressions since they are tested with a 2 weeks old ovirt-engine packages. Thanks you. Dafna

1 1

why we only save lv that seg_start_pe=="0" in _reloadlvs
by pengyixiang 17 Sep '18

17 Sep '18

Hello, everyone! if we reload lvs, why we don't update lvs that seg_start_pe != "0" ? there's in [1] with red mark. what seg_start_pe means? If this lv is a vm template, may seg_start_pe is not zero, and we should ignore it? [1] vdsm/storage/lvm.py def _reloadlvs(self, vgName, lvNames=None): lvNames = _normalizeargs(lvNames) cmd = list(LVS_CMD) if lvNames: cmd.extend(["%s/%s" % (vgName, lvName) for lvName in lvNames]) else: cmd.append(vgName) rc, out, err = self.cmd(cmd, self._getVGDevs((vgName,))) with self._lock: if rc != 0: log.warning("lvm lvs failed: %s %s %s", str(rc), str(out), str(err)) lvNames = lvNames if lvNames else self._lvs.keys() for l in lvNames: if isinstance(self._lvs.get(l), Stub): self._lvs[l] = Unreadable(self._lvs[l].name, True) return dict(self._lvs) updatedLVs = {} for line in out: fields = [field.strip() for field in line.split(SEPARATOR)] lv = makeLV(*fields) # For LV we are only interested in its first extent if lv.seg_start_pe == "0": self._lvs[(lv.vg_name, lv.name)] = lv updatedLVs[(lv.vg_name, lv.name)] = lv # Determine if there are stale LVs if lvNames: staleLVs = (lvName for lvName in lvNames if (vgName, lvName) not in updatedLVs.iterkeys()) else: # All the LVs in the VG staleLVs = (lvName for v, lvName in self._lvs.keys() if (v == vgName) and ((vgName, lvName) not in updatedLVs.iterkeys())) for lvName in staleLVs: log.warning("Removing stale lv: %s/%s", vgName, lvName) self._lvs.pop((vgName, lvName), None) log.debug("lvs reloaded") return updatedLVs -- Cheers， Pencc

2 1

[ OST Failure Report ] [ oVirt Master (vdsm) ] [ 14-08-2018 ] [ 006_migrations.migrate_vm ]
by Dafna Ron 17 Sep '18

17 Sep '18

Hi, We have a failure in vm migration on project vdsm master branch. I think the issue is related to this change: https://gerrit.ovirt.org/#/c/94248/ - https://gerrit.ovirt.org/#/c/94248/ Can you please have a look? full logs: https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/10309/artifa… error: 2018-09-14 07:15:43,102-0400 ERROR (migsrc/ade7210f) [virt.vm] (vmId='ade7210f-992e-4256-a33f-1340552892c9') __init__() takes exactly 3 arguments (2 given) (migration:281) 2018-09-14 07:15:43,102-0400 DEBUG (migsrc/ade7210f) [jsonrpc.Notification] Sending event {"params": {"notify_time": 4296575510, "ade7210f-992e-4256-a33f-1340552892c9": {"status": "Up"}}, "jsonrpc": "2.0", "method": "|virt|VM_status|ade72 10f-992e-4256-a33f-1340552892c9"} (__init__:181) 2018-09-14 07:15:43,103-0400 DEBUG (JsonRpc (StompReactor)) [yajsonrpc.protocols.stomp.AsyncClient] Stomp connection established (stompclient:138) 2018-09-14 07:15:43,104-0400 DEBUG (migsrc/ade7210f) [vds] Sending notification |virt|VM_status|ade7210f-992e-4256-a33f-1340552892c9 with params {'notify_time': 4296575510, 'ade7210f-992e-4256-a33f-1340552892c9': {'status': 'Up'}} (clien tIF:225) 2018-09-14 07:15:43,104-0400 ERROR (migsrc/ade7210f) [virt.vm] (vmId='ade7210f-992e-4256-a33f-1340552892c9') Failed to migrate (migration:449) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/virt/migration.py", line 401, in _regular_run self._setupVdsConnection() File "/usr/lib/python2.7/site-packages/vdsm/virt/migration.py", line 241, in _setupVdsConnection self._destServer = jsonrpcvdscli.connect(requestQueue, client) File "/usr/lib/python2.7/site-packages/vdsm/jsonrpcvdscli.py", line 259, in connect return _Server(client, xml_compat) File "/usr/lib/python2.7/site-packages/vdsm/jsonrpcvdscli.py", line 135, in __init__ self._schema = vdsmapi.Schema.vdsm_api(api_strict_mode) File "/usr/lib/python2.7/site-packages/vdsm/api/vdsmapi.py", line 155, in vdsm_api return Schema(schema_types, *args, **kwargs) TypeError: __init__() takes exactly 3 arguments (2 given)

2 3