- Devel - oVirt List Archives

[vdsm] branching out 4.1.2
by Francesco Romani 23 May '17

23 May '17

Hi all, patches against the 4.1 branch are piling up, so I'm thinking about branching out 4.1.2 tomorrow (20170523) The activity on the 4.1.2 front was quite low lately, so we should expect quite few double backports. Thoughts? I'll go forward and branch if noone objects. Bests, -- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh

6 7

VmIconDaoTest compiling error
by shubham dubey 23 May '17

23 May '17

I have done some changes in ovirt-engine now while compiling I am getting following error in file VmIconDaoTest. Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.466 sec <<< FAILURE! testGetVmIconByDataUrlWithValidUrl(org.ovirt.engine.core.dao.VmIconDaoTest) Time elapsed: 18 sec <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:631) at org.ovirt.engine.core.dao.VmIconDaoTest.testGetVmIconByDataUrlWithValidUrl(VmIconDaoTest.java:59) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75) at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86) at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:254) at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:89) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61) at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:193) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) ... ... Failed tests: testGetVmIconByDataUrlWithValidUrl(org.ovirt.engine.core.dao.VmIconDaoTest): expected:<1> but was:<0> I haven't even done any change in VmIconDaoTest file but this error is there. I even try to change the value result.get(0) to result.get(1) in testGetVmIconByDataUrlWithValidUrl but that didn't work. Thanks in advance. Shubham

3 6

Regarding dao tests
by shubham dubey 22 May '17

22 May '17

I have made some changes to engine code and the try to run dao test. $PGPASSWORD=engine \ ./packaging/dbscripts/schema.sh \ -c apply -u engine -d engine_dao_tests This command run sucessfully. but after compiling through make I am getting following error ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on project common: You have 7 Checkstyle violations. -> [Help 1] so can anyone tell me what that means? Thanks, Shubham

3 4

[ OST Manual Job ] Updated default fallback repo
by Daniel Belenky 22 May '17

22 May '17

Hi all, Please note that we've updated the default fallback repo in manual job <http://jenkins.ovirt.org/job/ovirt-system-tests_manual/>. The fallback repo defines the source from which the RPMs that are not part of the patch being tested are being taken. Until today, the default source was 'latest_tested' repo, which is now replaced by 'latest_release'. *Note* that 'latest_tested' repository shouldn't be used on regular basis, as this repository is changing as the experimental flow runs, so in order to avoid failures - please use the stable 'latest_release' repo, which contains all the rpm's that were released in the last official release of oVirt. Thanks, -- DANIEL BELENKY Associate sw engineer RHEV DEVOPS Red Hat Israel <https://www.redhat.com/> dbelenky(a)redhat.com IRC: #rhev-integ, #rhev-dev <https://red.ht/sig>

2 2

[Engine] Runtime log controll script
by Roy Golan 21 May '17

21 May '17

Ever wanted to raise level of the engine logs and wanted to to that fast and runtime? This is a small wrapper around wildfly mgmt interface, called *log-control* to do the trick[1] Example, debug the db interaction layer: ./log-control org.ovirt.engine.core.dal debug It will first try blantly to add the log category and then will set the log level according to what you set. It is simple and stupid. More interesting logger categories: business logic (commands, queries) - org.ovirt.engine.core.bll hosts interaction - org.ovirt.engine.core.vdsbroker various utilities - org.ovirt.engine.core.utils aaa - org.ovirt.engine.exttool.aaa General suggestion - I think is is it time for *ovirt-engine-contrib* so mini-helpers like that can exists and when they are solid can go into mainstream repo, if needed in there. [1] https://gist.github.com/rgolangh/1cb9f9b3b7f7f0a1d16b5a976d90bd55 Thanks, Roy

5 7

ovirt-provider-ovn - appliance inclusion / default enablement
by Sandro Bonazzola 18 May '17

18 May '17

Hi, with https://gerrit.ovirt.org/76855 it's requested to increase the appliance size by adding ovirt-provider-ovn and its dependencies. This raise a few questions. The support for ovirt-provider-ovn is enabled by default in engine-setup and going to be installed by default in the appliance so we're pushing to use it. Why not requiring it at ovirt-engine spec file level? Answer given in the commit message of above patch is: We do not want to have a hard dependency in the form of an rpm require. OVN and openvswitch are relatively heavy and complex, and are still experimental. We would not want to force everybody to pull them onto any Engine host. So why adding it to the appliance, which is the default for hosted engine which is our recommeded way to deploy oVirt, and enable it by default? How this differs from DWH? ovirt-engine requires ovirt-engine-setup which requires ovirt-engine-dwh setup which requires ovirt-engine-dwh. Why can't we just require ovirt-provider-ovn in ovirt-engine instead of tweaking the appliance? If we decide it's not mandatory, why not make the default to not enabling it in engine-setup and avoid to add it to the appliance? Being optional, adding it collides with Bug 1401931 <https://bugzilla.redhat.com/show_bug.cgi?id=1401931> - [RFE] reduce the size of the appliance Thanks, -- SANDRO BONAZZOLA ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>

5 10

[ OST Failure Report ] [ oVirt master ] [ 14/05/2017 ] [ test-repo_ovirt_experimental_master ]
by Shlomo Ben David 18 May '17

18 May '17

Hi, Test failed: [ test-repo_ovirt_experimental_master ] Link to suspected patches: N/A Link to Job: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6665/ Link to all logs: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6665/artif… Error snippet from the log: <error> 2017-05-14 03:56:31,782-0400 ERROR (jsonrpc/3) [storage.TaskManager.Task] (Task='661acb48-075b-494a-8fb4-64c04ed99bcb') Unexpected error (task:871) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 878, in _run return fn(*args, **kargs) File "/usr/lib/python2.7/site-packages/vdsm/logUtils.py", line 52, in wrapper res = f(*args, **kwargs) File "/usr/share/vdsm/storage/hsm.py", line 2172, in getAllTasksInfo allTasksInfo = self._pool.getAllTasksInfo() File "/usr/lib/python2.7/site-packages/vdsm/storage/securable.py", line 77, in wrapper raise SecureError("Secured object is not in safe state") SecureError: Secured object is not in safe state 2017-05-14 03:56:31,785-0400 INFO (jsonrpc/3) [storage.TaskManager.Task] (Task='661acb48-075b-494a-8fb4-64c04ed99bcb') aborting: Task is aborted: u'Secured object is not in safe state' - code 100 (task:1176) 2017-05-14 03:56:31,786-0400 ERROR (jsonrpc/3) [storage.Dispatcher] Secured object is not in safe state (dispatcher:81) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/storage/dispatcher.py", line 73, in wrapper result = ctask.prepare(func, *args, **kwargs) File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 106, in wrapper return m(self, *a, **kw) File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 1184, in prepare raise self.error SecureError: Secured object is not in safe state 2017-05-14 03:56:31,786-0400 INFO (jsonrpc/3) [jsonrpc.JsonRpcServer] RPC call Host.getAllTasksInfo failed (error 654) in 0.00 seconds (__init__:577) 2017-05-14 03:56:31,796-0400 INFO (jsonrpc/5) [dispatcher] Run and protect: getAllTasksStatuses(spUUID=None, options=None) (logUtils:51) 2017-05-14 03:56:31,797-0400 ERROR (jsonrpc/5) [storage.TaskManager.Task] (Task='568f515e-365b-47e4-8b2f-24e15deb6ae9') Unexpected error (task:871) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 878, in _run return fn(*args, **kargs) File "/usr/lib/python2.7/site-packages/vdsm/logUtils.py", line 52, in wrapper res = f(*args, **kwargs) File "/usr/share/vdsm/storage/hsm.py", line 2132, in getAllTasksStatuses allTasksStatus = self._pool.getAllTasksStatuses() File "/usr/lib/python2.7/site-packages/vdsm/storage/securable.py", line 77, in wrapper raise SecureError("Secured object is not in safe state") SecureError: Secured object is not in safe state 2017-05-14 03:56:31,797-0400 INFO (jsonrpc/5) [storage.TaskManager.Task] (Task='568f515e-365b-47e4-8b2f-24e15deb6ae9') aborting: Task is aborted: u'Secured object is not in safe state' - code 100 (task:1176) 2017-05-14 03:56:31,798-0400 ERROR (jsonrpc/5) [storage.Dispatcher] Secured object is not in safe state (dispatcher:81) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/storage/dispatcher.py", line 73, in wrapper result = ctask.prepare(func, *args, **kwargs) File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 106, in wrapper return m(self, *a, **kw) File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 1184, in prepare raise self.error SecureError: Secured object is not in safe state <error> Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL RHCSA | RHCVA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1

5 5

Fwd: UPDATE: Bugzilla 5 beta server is back online
by Sandro Bonazzola 18 May '17

18 May '17

---------- Forwarded message ---------- From: Christine Freitas <cfreitas(a)redhat.com> Date: Mon, May 15, 2017 at 6:03 PM Subject: UPDATE: Bugzilla 5 beta server is back online Hello All, The Bugzilla 5 beta server [1] is back online. We encourage you to test your current scripts and take part in the beta discussions on the Fedora development list [2]. Partners and customers may also use their existing communications channels to share feedback or questions. We've extended the beta window and ask that you provide feedback or questions by Wednesday, June 14th. The official release date for Bugzilla 5 will be determined based on the beta feedback. We will communicate to you as the beta continues to progress. For more information refer to: https://beta-bugzilla.redhat.com/page.cgi?id=whats-new.html https://beta-bugzilla.redhat.com/page.cgi?id=release-notes.html https://beta-bugzilla.redhat.com/page.cgi?id=faq.html https://beta-bugzilla.redhat.com/docs/en/html/using/index.html https://beta-bugzilla.redhat.com/docs/en/html/api/index.html Cheers, the Red Hat Bugzilla team. 1: https://beta-bugzilla.redhat.com/ 2: https://lists.fedoraproject.org/archives/list/devel%40lists. fedoraproject.org/ -- SANDRO BONAZZOLA ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>

1 0

Feature: enhanced OVA support
by Arik Hadas 17 May '17

17 May '17

Hi everyone, We would like to share our plan for extending the currently provided support for OVA files with: 1. Support for uploading OVA. 2. Support for exporting a VM/template as OVA. 3. Support for importing OVA that was generated by oVirt (today, we only support those that are VMware-compatible). 4. Support for downloading OVA. This can be found on the feature page <http://www.ovirt.org/develop/release-management/features/virt/enhance-impor…> . Your feedback and cooperation will be highly appreciated. Thanks, Arik

5 7

[VDSM] Adding Pylint to 'check' target
by Fred Rolland 15 May '17

15 May '17

Hi, We are introducing Pylint to be performed as part of the 'check' target. Once that patch [1] will be merged, every execution of 'make check' will include also a Pylint analysis. Note that execution time will be longer by about 2 minutes. However, you are can use 'jobs' flag to tell 'make' to execute recipes simultaneously. Be aware that the output of the jobs will be interleaved. For example, running 'make' with two parallel jobs: make --jobs=2 check Regards, Freddy [1] https://gerrit.ovirt.org/#/c/76390/

4 3