- Devel - oVirt List Archives

[OST failure report] vdsmfake doesn't produce artifacts
by Pavel Zhukov 30 Mar '17

30 Mar '17

Hello, Vdsmfake doesn't build any installable artifacts and deploy-to* job fails because of this. Example: See <http://jenkins.ovirt.org/job/deploy-to-ovirt_experimental_master/14413> Can someone take a look please? -- Pavel Zhukov Software Engineer

2 1

Writing SQL queries in DAO code
by Yevgeny Zaspitsky 30 Mar '17

30 Mar '17

Hi All, Recently I had a task of performance improvement in one of our network related flows and had some hard time following our DAL code and one of the outcomes of the task was defining a couple of new quite simple, but neat queries. When I came to coding those new queries I remembered how hard was following the existing DAL code, I decided to make my own new methods clearer. So I created [1] and [2] patches. Everything is quite standard there beside the fact that they do not use any stored procedure, but use SQL directly, IMHO by that they save time that I spent in trying to follow what a DAO method does. Looking into the method code you get the understanding of what this method is all about: - no looking for a stored procedure name that is buried in the DAO class hierarchy - no looking for the SP definition So I'd like to propose moving towards this approach in general in all cases when nothing beyond a simple SQL is needed (no stored procedure programming language is needed). >From my experience with the performance improvement task it looks like people avoid adding new queries for a specific need of a flow, instead they use the existing general ones (e.g. dao.getAllForX()) and do the actual join in the bll code. IMHO the proposed approach would simplify adding new specific queries and by that would prevent a decent part of performance issues in the future. I do not propose changing all existing SP's to inline queries in a once, but to allow adding new queries this way. Also we might consider converting relatively simple SP's to inline SQL statements later in a graduate way. [1] - https://gerrit.ovirt.org/#/c/74456 [2] - https://gerrit.ovirt.org/#/c/74458 Regards, Yevgeny

5 12

[ Announcment ] STD CI now supports custom junit reports
by Daniel Belenky 29 Mar '17

29 Mar '17

Hi all, The oVirt infra team is proud to announce that as from today the standard ci supports export of custom junit reports. *How to use?* Simply generate your junit .xml files, and follow the following naming: *<your_custom_name>.junit.xml. *Make sure you move them to exported-artifacts directory. That's all, the std ci will collect your .junit.xml files, and generate the junit report for you. Please feel free to contact the infra team on infra(a)ovirt.org for any more questions you have. Sincerely, -- *Daniel Belenky* *RHV DevOps* *Red Hat Israel*

1 0

Wildfly 11.0.0 Alpha is out
by Sandro Bonazzola 29 Mar '17

29 Mar '17

Hi, just an heads up that Wildfly 11.0.0 Alpha is out so we can start looking at it for master http://wildfly.org/downloads/ Release notes: https://issues.jboss.org/secure/ReleaseNote.jspa?projectId=12313721&version… -- SANDRO BONAZZOLA ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>

1 0

ovirt guest agent and local address
by Marc Young 29 Mar '17

29 Mar '17

Is there a way to manually blacklist a range from being submitted via the ovirt guest agent? The reason I ask, 169.x and 127.0.0.1 never display, but if you're running docker, the agent submits the docker host address (172.17.0.1) RFC1918 defines local address and contains 172.16.0.0/12, which includes 172.17.0.0/16 (it ranges from 172.16.0.0 to 172.31.255.255), so it seems valid, but the UI displays "IP Address" (not plural) Is there anything I can do to prevent this IP from submitting? Screen shot attached. Guest agent info: Operating System: CentOS Linux 7.3.1611 (Core) Kernel Version: 3.10.0-514.el7.x86_64

2 2

oVirt Engine checkstyle upgrade
by Allon Mureinik 28 Mar '17

28 Mar '17

Hi all, As per [1], I've just merged a series of patches that upgrades the oVirt engine to use the latest maven-checkstyle-plugin and checkstyle packages. Please note that the newer checkstyle is a tad stricter than the old one we used to have (read: it contains several fixes for bugs where the old checkstyle was supposed to find issues but missed them). I also took the opportunity and added a couple of new checks that enforce rules we were de-facto adhering to anyway. If any problems come up, please let me know. -Your friendly neighborhood cleanup dude [1] https://bugzilla.redhat.com/show_bug.cgi?id=1433408

5 12

planned Jenkins restart
by Evgheni Dereveanchin 28 Mar '17

28 Mar '17

Hi everyone, I'll be performing a planned Jenkins restart within the next hour. No new builds will be scheduled during this maintenance period. I will inform you once it is over. Regards, Evgheni Dereveanchin

1 1

REST API data aggregation
by Tomas Jelinek 27 Mar '17

27 Mar '17

Hi All, for quite some time I have been more or less involved in development of various UIs for oVirt based entirely on the oVirt's REST API ranging from the quite mature moVirt [1] through some cockpit extensions to a young and experimental user portal replacement [2]. One issue we hit over and over again is the missing data aggregation. In the 3.x era we used to use in moVirt the detail=something api to get the disks and nics of the VM, something like: GET /ovirt-engine/api/vms Accept: application/json; detail=disks This allowed us to store this data in local database leading to great user experience. Since this feature has been removed in 4.x API [3] we needed to retire to a different solution. When the VM detail is selected by the user, start loading the disks and nics and hope the user will not be fast enough to see the delay. The UX is slightly worse bug kinda acceptable. We hit this issue harder in the new user portal [2], because we already have the VM cached and show the whole VM in one screen. So, if you pick it, you will get it's details immediately. But, since you don't have all the details, we need to do an additional call (two actually) to load this data and they start to appear later. So, something which would be very fast and smooth starts to feel sluggish. Recently, we hit this issue again which forced us to sacrifice the UX even more - it is the "console in use" feature of user portal. The use case is this: - if the console is already taken by some user, there are complications if other current user tryes to take it as well (will avoid details about settings and permissins involved, but long story short, the user will probably not be allowed to connect to it. The "probably" is the key here since we can not do any intelligent decision in advance, we can only warn the user that the console is taken). - in the current GWT user portal, if the VM's console is taken, it is shown on the VM's "box" that "console is taken". This was a highly requested feature - to get this information using the current REST API, we need to go to the /vms/<vmid>/sessions subcollection. To get this for all VMs, it would be doing N queries per poll which we can not afford - so the current PR [4] will probably end up to only check it on the attempt to connect to the console warning the user. Maybe it will be also shown in Vm details. But the UX in case the user will look for a VM which has free console will suffer significantly (e.g. try one by one until some opens or look at details one by one to see if the warning appears (with a delay)) I understand that embedding the details of the VM to the response comes with a cost, namely: - performance hit - complexity of the API code - the "cleanness" of REST suffers But I think we should seriously consider to provide some option to data aggregation. I know this has been discussed many times with no result, but I think it is time to bring this topic up again. I'll try to summarize the (failed) attempts tried so far: - the detail=<something> parameter with ad-hoc embedding of data. This has been there and removed in 4.0 [3] - the DoctorREST project - e.g. a proxy above the current api. The idea was to create a service which will be independent of the engine itself, will locally poll the engine's REST, store all data in local (mongo)DB and provide a rich api with aggregations and projections and push notifications. This polling of everything to get the data to DoctorREST proved to be pretty costy, so also a more invasive approach of pushing data from engine to doctor has been discused [5]. None of this two approaches have been accepted (too complicated, too invasive). - writing some custom ad-hoc servlet serving only a purpose of one frontend - this is actually there for the dashboard, but it is not a generic solution for the other frontends and we really should not develop custom "APIs" for every frontend - there were some other proposals discussed (some 3th party solutions etc) but I think none of them made it even to a PoC So, now I would try again and try small to get at least some benefit. I see 2 paths we could try: 1: embed something which burns us immediatly, e.g. the /sessions into VMs. I really liked the ;detail=sessions approach, could we move it back? 2: add some tiny service which would just accept a list of queries, execute them locally (but using real HTTP requests) and return in one bulk. A naive implementation just to give a sense of what I mean of this would be a shell script getting list of strings like " https://localhost/ovirt-engine/api/vms/123/sessions" iterate over them and do a curl request for each, mangle the results into one string and return (credits for this idea to msivak). Easy to implement, possibility to add also projections later to save some bandwidth. But the API would anyway be hammered by bunch of queries, only the network roundtrip would be saved. 3: any other simple approaches? I honestly prefer the first approach. It is not beautiful, it is not REST-ful, but it is easy to implement, very pragmatic and useful. What do you think? Thank you and sorry for the long mail :) Tomas [1]: https://github.com/oVirt/moVirt [2]: https://github.com/oVirt/ovirt-web-ui [3]: https://gerrit.ovirt.org/#/c/61260 [4]: https://github.com/oVirt/ovirt-web-ui/pull/106/ [5]: https://gerrit.ovirt.org/#/c/45233/

7 15

[ OST Failure Report ] [ oVirt 4.1 ] [ 21-03-2017 ] [ test-repo_ovirt_experimental_4.1 ]
by Shlomo Ben David 27 Mar '17

27 Mar '17

Hi, Test failed: [ test-repo_ovirt_experimental_4.1 ] Link to suspected patches: N/A Link to Job: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_4.1/1018 Link to all logs: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_4.1/1018/artifact… Error snippet from the log: <error> ifup/VLAN100_Network::DEBUG::2017-03-21 06:12:03,550::commands::93::root::(execCmd) FAILED: <err> = 'Running scope as unit 979f3d61-c1f9-49c2-b168-799b882f64d5.scope.\n/etc/sysconfig/network-scripts/ifup-eth: line 297: 30633 Terminated /sbin/dhclient ${DHCLIENTARGS} ${DEVICE}\nCannot find device "VLAN100_Network"\nDevice "VLAN100_Network" does not exist.\nDevice "VLAN100_Network" does not exist.\nDevice ... ... ... "VLAN100_Network" does not exist.\n'; <rc> = 1 ifup/VLAN100_Network::ERROR::2017-03-21 06:12:03,551::utils::371::root::(wrapper) Unhandled exception Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 368, in wrapper return f(*a, **kw) File "/usr/lib/python2.7/site-packages/vdsm/concurrent.py", line 180, in run return func(*args, **kwargs) File "/usr/lib/python2.7/site-packages/vdsm/network/configurators/ifcfg.py", line 924, in _exec_ifup _exec_ifup_by_name(iface.name, cgroup) File "/usr/lib/python2.7/site-packages/vdsm/network/configurators/ifcfg.py", line 910, in _exec_ifup_by_name raise ConfigNetworkError(ERR_FAILED_IFUP, out[-1] if out else '') ConfigNetworkError: (29, 'Determining IPv6 information for VLAN100_Network... failed.') </error> Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL RHCSA | RHCVA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1

3 2

vdsm-hook-ovs dependency
by Daniel Belenky 27 Mar '17

27 Mar '17

Hi all, I try to test our master tested repo for repoclosure, and the test fails on the following dependency: 10:44:49 package: vdsm-hook-ovs-4.20.0-162.gitcc43be6.el7.centos.noarch from internal_repo 10:44:49 unresolved deps: 10:44:49 vdsm = 0:4.20.0-162.gitcc43be6.el7.centos When looking at the last builds of VDSM, I could not find this package: *vdsm-hook-ovs* in the 'exported artifacts'. Can someone advise where this package is coming from? Do we need this package? Thanks, -- *Daniel Belenky* *RHV DevOps* *Red Hat Israel*

2 2