- Devel - oVirt List Archives

Type Safety on the Frontend (refactoring of all async queries)
by Martin Betak 26 Jul '16

26 Jul '16

Hi All, today a *major* frontend refactoring was merged [1]. Its purpose was to remove some of the most significant artifacts of legacy C# code. Huge thanks to Vojtech and Alex for heavenly patience during code review! For a complete description please see the commit message, but here are some highlights for programmers that need to touch FE code: 1) AsyncQuery, AsyncCallback and Converter are now generic and typesafe (formerly INewAsyncCallback and IAsyncConverter). 2) It is no longer possible (or desirable) to PASS MODEL to queries. From within Model sublasses `new AsyncQuery<>(...)` will have the correct value set (see patch for impl details) and if you want to run a query on a different model (so the infrastructure would set the progress spinner on that model instead), usually for the purpose of a ListModel showing a popup window - where we want to display the spinner on the dialog window instead, you can use the `myWindowModel.asyncQuery(...)` helper factory to create query with model set to myWindowModel. // note: this also has the nice side-effect of eliminating the harmful pattern of using // the model value from within callbacks by casting it to surrounding model type (while that // value is already available by feature of java inner classes) 3) AsyncDataProvider's API methods now deal with strongly typed queries. This is facilitated through usage of strongly typed Converters (please see some defined converters -> usually you just need a CastingConverter<> or a ListConverter<>). Please use this architectural layer of strongly typed AsyncDataProvider to your advantage. (as plain Fronted.runQuery does not provide any guarantees and leaves you at risk of mis-casting the return value). If you have any more questions please feel free to ask me or look at the patch for details (warning: it's quite big!). This kind of major change necessarily touched all areas of the code (those issuing queries...) and there is of course some probability that something may break. But I believe this risk is well outweight by the benefits. Nevertheless if you find any issue please let me know and we can fix it together. Thanks again to anyone who contributed to this noble effort. Best regards :-) Martin [1] https://gerrit.ovirt.org/#/c/60822/

2 1

[ACTION REQUIRED] VDSM: vdsClientTests.CannonizeHostPortTest failing on master
by Sandro Bonazzola 26 Jul '16

26 Jul '16

*http://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/4639/console <http://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/4639/console>* *00:06:34.315* *00:06:34.315* ======================================================================*00:06:34.315* FAIL: testNoArguments (vdsClientTests.CannonizeHostPortTest)*00:06:34.315* ----------------------------------------------------------------------*00:06:34.316* Traceback (most recent call last):*00:06:34.316* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 494, in testNoArguments*00:06:34.316* self._assertIsIpAddressWithPort(vdscli.cannonizeHostPort())*00:06:34.316* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 548, in _assertIsIpAddressWithPort*00:06:34.316* self._assertValidAddress(addr)*00:06:34.317* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 555, in _assertValidAddress*00:06:34.317* addr)*00:06:34.317* AssertionError: ('invalid IPv4 address: %s', 'ovirt-srv19.phx.ovirt.org')*00:06:34.317* *00:06:34.317* ======================================================================*00:06:34.317* FAIL: testNoneArgument (vdsClientTests.CannonizeHostPortTest)*00:06:34.318* ----------------------------------------------------------------------*00:06:34.318* Traceback (most recent call last):*00:06:34.318* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 497, in testNoneArgument*00:06:34.318* self._assertIsIpAddressWithPort(vdscli.cannonizeHostPort(None))*00:06:34.318* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 548, in _assertIsIpAddressWithPort*00:06:34.319* self._assertValidAddress(addr)*00:06:34.319* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 555, in _assertValidAddress*00:06:34.319* addr)*00:06:34.319* AssertionError: ('invalid IPv4 address: %s', 'ovirt-srv19.phx.ovirt.org')*00:06:34.319* *00:06:34.319* ======================================================================*00:06:34.319* FAIL: testNoneArgumentAndPort (vdsClientTests.CannonizeHostPortTest)*00:06:34.320* ----------------------------------------------------------------------*00:06:34.320* Traceback (most recent call last):*00:06:34.320* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 502, in testNoneArgumentAndPort*00:06:34.320* self._assertIsIpAddressWithPort(res)*00:06:34.320* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 548, in _assertIsIpAddressWithPort*00:06:34.321* self._assertValidAddress(addr)*00:06:34.321* File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/vdsClientTests.py", line 555, in _assertValidAddress*00:06:34.321* addr)*00:06:34.321* AssertionError: ('invalid IPv4 address: %s', 'ovirt-srv19.phx.ovirt.org')*00:06:34.321* *00:06:34.321* Name Stmts Miss Cover Missing*00:06:34.322* --------- -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

2 2

VDSM retired from Fedora distribution
by Sandro Bonazzola 26 Jul '16

26 Jul '16

Hi, just an heads up about VDSM been retired from Fedora distribution due to broken dependency. If you want to get it back there you'll have to start again with the package review process. Thanks, -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

2 1

[ACTION REQUIRED] oVirt 4.0.2 rc2 build starting in 1 hour
by Sandro Bonazzola 26 Jul '16

26 Jul '16

Fyi oVirt products maintainers, An oVirt build for an official release is going to start in one hour If you're a maintainer for any of the projects included in oVirt distribution and you have changes in your package ready to be released please: - bump version and release to be GA ready - tag your release within git (implies a GitHub Release to be automatically created) - build your packages within jenkins / koji / copr / whatever - verify all bugs on MODIFIED have target release and target milestone set. - add your builds to releng-tools/releases/ovirt-4.0.2_rc2.conf withini releng-tools project -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

DRBD Integration with oVirt
by Hayley Swimelar 26 Jul '16

26 Jul '16

Hello all, A DRBD integration into oVirt is currently being planned. DRBD provides replicated, highly available block storage. For those unfamiliar with DRBD more information can be found here: https://www.drbd.org/en/comp/drbd-linux-driver DRBD 9 is the latest version of DRBD and interacts with DRBD Manage which is a daemon exposed via a D-Bus api. More information can be found here: https://www.drbd.org/en/comp/drbdmanage DRBD Manage handles the creation, assignment, etc. of DRBD volumes and is the interface through which Cinder manages DRBD. We are looking for advice on how best to have oVirt communicate with DRBD Manage and we have come to two options: 1) Use Cinder. Although we are integrated into Cinder, there are concerns about the need to set up a complete Cinder instance to provide access to DRBD. 2) The alternative to Cinder would be to have the oVirt Engine communicate directly to DRBD Manage via D-Bus. Any advice on the best way to achieve this would be much appreciated. -- Hayley Swimelar LINBIT | Keeping the Digital World Running DRBD — Corosync — Pacemaker +1-503-573-1262 x212

5 11

When debug vdsm branch 4.0, why there has some code will call function ping(self) in bindingxmlrpc.py cycle? Even the vdsm is not managed by ovirt-engine?
by lifuqiong 26 Jul '16

26 Jul '16

This is a multipart message in MIME format. ------=_NextPart_000_00BE_01D1E741.42F55580 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, I setup a breakpoint in Line 637 in bindingxmlrpc.py , which as follows: (branch:4.0; code url is: https://github.com/oVirt/vdsm/tree/ovirt-4.0) 636 def ping(self): 637 api = API.Global() 638 return api.ping() But even the vdsm is not managed by any ovirt-engine , the line 637 will be called many times, I thought the ping() function will be called only when the ovirt-engine will create connection with vdsm, so why it will be called cycle? Thank you ------=_NextPart_000_00BE_01D1E741.42F55580 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" = xmlns:o=3D"urn:schemas-microsoft-com:office:office" = xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" = xmlns=3D"http://www.w3.org/TR/REC-html40"><head><meta = http-equiv=3DContent-Type content=3D"text/html; = charset=3Dus-ascii"><meta name=3DGenerator content=3D"Microsoft Word 14 = (filtered medium)"><style></style></head><body lang=3DZH-CN link=3Dblue = vlink=3Dpurple style=3D'text-justify-trim:punctuation'><div = class=3DWordSection1>Hi, = <o:p></o:p>         I setup a = breakpoint in Line 637 in bindingxmlrpc.py , which as follows:  = (branch:4.0; code url is: = https://github.com/oVirt/vdsm/tree/ovirt-4.0)<o:p></o:p>636  def = ping(self):<o:p></o:p>637     api =3D = API.Global()<o:p></o:p>638     return = api.ping()<o:p></o:p><o:p> </o:p>         But even = the vdsm is not managed by any ovirt-engine ,  the line 637 will be = called many times, <o:p></o:p><o:p> </o:p>         I thought = the ping() function will be called only when the ovirt-engine will = create connection with vdsm, so why it will be called = cycle?<o:p></o:p><o:p> </o:p>Thank you<o:p></o:p><o:p> </o:p><o:p> </o:p></div></body></html> ------=_NextPart_000_00BE_01D1E741.42F55580--

2 1

How to build and install oVirt on Product Environment
by Dewey Du 25 Jul '16

25 Jul '16

To build and install ovirt-engine execute the folllowing command: $ make clean install-dev PREFIX="${PREFIX}" What about installing it on Product Environment. Is the folllowing command right? $ make clean install PREFIX="${PREFIX}"

2 1

Blog post: Monitoring Improvements in oVirt
by Arik Hadas 25 Jul '16

25 Jul '16

Hi all, I wrote a blog post that summarizes the recent improvements in the code that monitors virtual machines in oVirt. It describes the changes that were done and shows a comparison of different aspects of oVirt with these changes (based on the master branch) vs oVirt 3.6 without these changes: http://ahadas.github.io/monitoring-improvements-in-ovirt/ It is mostly a technical post. However, users might find it interesting as well. Note that the measurements were taken on an environment with 1 host and 6000 running VMs (in a pool). Each VM had a network interface and was diskless. Obviously, this is not a typical setup but it was useful to easily expose some of weak sides of the monitoring. Your feedback is always welcome! Regards, Arik

2 2

anonymous upgrade script instead of tmp function ceremony
by Roy Golan 25 Jul '16

25 Jul '16

We all use the pattern of temporary creating a function for upgrade script, declaring it (copy pasting from last script) and then calling it, then deleting it. This very verbose can be replaced with DO instruction which does essentially the same. # existing declaration ```sql CREATE OR REPLACE FUNCTION __tmp_count() RETURNS VOID AS $procedure$ DECLARE i int; BEGIN i:= (select count(*) from vms) -- useless count just for the demo END; $procedure$ LANGUAGE plpgsql; SELECT __tmp_count(); DROP FUNCTION __tmp_acount(); ``` Can be replaced with ```sql DO $$ DECLARE i int; BEGIN i := (select count(*) from vms) -- useless count for demo END $$; ``` Not tested but tons of less lines to code. Exist in version 9.0.23 and above

1 0

[ANN] oVirt 4.0.2 Release Candidate is now available
by Sandro Bonazzola 21 Jul '16

21 Jul '16

The oVirt Project is pleased to announce the availability of the First Release Candidate of oVirt 4.0.2 for testing, as of July 21st, 2016. This release is available now for: * Fedora 23 (tech preview) * Red Hat Enterprise Linux 7.2 or later * CentOS Linux (or similar) 7.2 or later This release supports Hypervisor Hosts running: * Red Hat Enterprise Linux 7.2 or later * CentOS Linux (or similar) 7.2 or later * Fedora 23 (tech preview) * oVirt Next Generation Node 4.0 This is pre-release software. Please take a look at our community page[1] to know how to ask questions and interact with developers and users. All issues or bugs should be reported via oVirt Bugzilla[2]. This pre-release should not to be used in production. This update is the first release candidate of the second in a series of stabilization updates to the 4.0 series. 4.0.2 brings 5 enhancements and nearly 100 bugfixes, including 38 high or urgent severity fixes, on top of oVirt 4.0 series See the release notes [3] for installation / upgrade instructions and a list of new features and bugs fixed. Notes: * A new oVirt Live ISO is available. [4] * A new oVirt Next Generation Node is available [4]. * A new oVirt Engine Appliance is already available. * Mirrors[5] might need up to one day to synchronize. Additional Resources: * Read more about the oVirt 4.0.2 release highlights: http://www.ovirt.org/release/4.0.2/ * Get more oVirt Project updates on Twitter: https://twitter.com/ovirt * Check out the latest project news on the oVirt blog: http://www.ovirt.org/blog/ [1] https://www.ovirt.org/community/ [2] https://bugzilla.redhat.com/enter_bug.cgi?classification=oVirt [3] http://www.ovirt.org/release/4.0.2/ [4] http://resources.ovirt.org/pub/ovirt-4.0-pre/iso/ [5] http://www.ovirt.org/Repository_mirrors#Current_mirrors -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0