- Devel - oVirt List Archives

[Engine-devel] Proposal for new commit msg design for engine commits
by Eyal Edri 23 Aug '13

23 Aug '13

Hi, You all probably know and familiar with 'ovirt-engine' git hook for commit msg template [1]. this helps understand the general area of the patch in the project but it lacks additional info that might be valuable for scaling automatic tests in Jenkins CI. Let me explain: Infra team is working hard on expanding oVirt CI infrastructure and adding more tests in jenkins (per commit/patch). Adding important meta-data per patch can significatly improve the ability to run specific tests for each patch/commit, and not waste valuable resources on Jenkins jobs that are not relevant to the code in the patch. So the idea is to add/expand current metadata per patch, in the form of: (either) 1. expanding current header template to include more data like 'network' , 'setup', 'tools', 'virt' 2. adding a new label with relevant tags for the patch, called e.g 'METADATA: network, rest, virt' Jenkins jobs will then be able to parse that data and trigger only relevant jobs for it. this can also allow us to add more jobs per patch, an option that is very problematic today considering the amount of patches coming in to engine. Once agreed on a format, we'll be able to add a git hook to verify the validity of the commit msg. (similar to bug-url). if we're not 100% sure that the tags will cover all corner cases and we feel like we need to run the code on all jobs, we can a nightly job to run all the remaining jobs (but at least it won't run on every patch/commit). [1] <core | restapi | tools | history | engine | userportal | webadmin>: thoughts? Eyal Edri.

12 29

[Engine-devel] Gluster Volume asynchronous tasks
by Sahina Bose 22 Aug '13

22 Aug '13

Hi all, We are working on a feature to add support to start and monitor gluster volume asynchronous tasks (like rebalancing a gluster volume, removing brick from volume ) from the oVirt engine. The operations can be started from the Volumes tab or the Bricks sub-tab using the Rebalance, Remove options. These are long running operations which can be monitored using a task id returned from Gluster. We are planning to add the monitoring in the existing Task sub tab The feature description and User flows are at http://www.ovirt.org/Features/Gluster_Volume_Asynchronous_Tasks_Management The detailed design (including REST API design) is at http://www.ovirt.org/Features/Detailed_Gluster_Volume_Asynchronous_Tasks_Ma…. I would really appreciate if you could review and provide your valuable feedback. thanks sahina

4 11

[Engine-devel] Feedback/ input needed on Host power management
by Malini Rao 21 Aug '13

21 Aug '13

Hello all, In taking a look at the current implementation of Hosts> Power management, we have come up with a couple of approaches on improving this from a UX perspective -http://www.ovirt.org/Talk:Community#UXD_Proposals_for_Host_Power_management. We want your thoughts and input on what approach makes more sense from a user's perspective before fine tuning the UI. Thanks Malini User Experience designer

6 7

[Engine-devel] Issues with IBM POWER support in oVirt engine
by Vitor de Lima 20 Aug '13

20 Aug '13

--_000_B2CAFC4D5E2D574A883EF61ACD5ADE330180A712SERV070corpeldo_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi everyone, I wrote some code to run a VM on a IBM POWER host, but I stumbled in some i= ssues that will need a little bit of refactoring in the current code and I = would like some feedback. The first issue is that KVM on POWER requires a special SCSI interface (cal= led SPAPR), which is not available in x86-64. Currently I'm solving this pr= oblem by using (in the VmInfoBuilder class): if (vm.getArchitecture().equals(ArchitectureType.ppc64)) { Map<String, Object> struct =3D new HashMap<String, Object>(); struct.put(VdsProperties.Type, VmDeviceType.CONTROLLER.getName(= )); struct.put(VdsProperties.Device, VdsProperties.Scsi); // Create a controller in the index 1, the VirtIO_SCSI interface= is in index 0 struct.put(VdsProperties.Index, "1"); Map<String, String> spaprAddress =3D new HashMap<String, String= >(); spaprAddress.put("type", "spapr-vio"); struct.put(VdsProperties.Address, spaprAddress); devices.add(struct); } But this is a poor solution, because this class would be polluted by archit= ectural differences. Another thing to notice is that since in IBM POWER the= re are two SCSI controllers, all the SCSI devices must have their SCSI addr= ess explicitly defined (it was not needed before, since there was just one = controller before). It was proposed that a "strategy" class could solve the= problem, but I would like to have some feedback on which package it should= be, since it will also be used in the bll package to validate other stuff. The second issue is that the CD-ROM interface is SCSI on POWER guests (and = must be attached to the SPAPR interface) and IDE on the x86_64, this inform= ation could be retrieved from the osinfo (by creating a property there) or = It could be hard-coded in the strategy class. Which would be the best way to handle this difference? The third and final issue is that when the VNC protocol is used in a VM, by= default a Cirrus Logic VGA device is created. This device is not supported= on POWER guests, but the standard VGA device is. I made a workaround, but = the issue is where to put this association between the device type and the = display protocol. Should it also be a property in the osinfo? Or it should be handled in the = strategy class? --_000_B2CAFC4D5E2D574A883EF61ACD5ADE330180A712SERV070corpeldo_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"PT-BR" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> Hi everyone,<o:p></o:p><= /p> <o:p> </o:p> I wrote some code to run a VM o= n a IBM POWER host, but I stumbled in some issues that will need a little b= it of refactoring in the current code and I would like some feedback.<o:p><= /o:p> <o:p> </o:p> The first issue is that KVM on = POWER requires a special SCSI interface (called SPAPR), which is not availa= ble in x86-64. Currently I’m solving this problem by using (in the Vm= InfoBuilder class):<o:p></o:p> <o:p> </o:p> if (vm.getArchitecture().equals= (ArchitectureType.ppc64)) {<o:p></o:p>      &= nbsp;     Map<String, Object> struct =3D new= HashMap<String, Object>();<o:p></o:p>      &= nbsp;      struct.put(VdsProperties.Type, VmDevice= Type.CONTROLLER.getName());<o:p></o:p>      &= nbsp;      struct.put(VdsProperties.Device, VdsPro= perties.Scsi);<o:p></o:p> <o:p> </o:p>      &= nbsp;     // Create a controller in the index 1, the Vi= rtIO_SCSI interface is in index 0<o:p></o:p>      &= nbsp;      struct.put(VdsProperties.Index, "1= ");<o:p></o:p> <o:p> </o:p>      &= nbsp;      Map<String, String> spaprAddress = =3D new HashMap<String, String>();<o:p></o:p> <o:p> </o:p>      &= nbsp;      spaprAddress.put("type", &quo= t;spapr-vio");<o:p></o:p> <o:p> </o:p>      &= nbsp;      struct.put(VdsProperties.Address, spapr= Address);<o:p></o:p>      &= nbsp;       devices.add(struct);<o:p></o:p></= span> }<o:p></o:p> <o:p> </o:p> But this is a poor solution, be= cause this class would be polluted by architectural differences. Another th= ing to notice is that since in IBM POWER there are two SCSI controllers, al= l the SCSI devices must have their SCSI address explicitly defined (it was not needed before, since there was just= one controller before). It was proposed that a “strategy” clas= s could solve the problem, but I would like to have some feedback on which = package it should be, since it will also be used in the bll package to validate other stuff.<o:p></o:p> <o:p> </o:p> The second issue is that the CD= -ROM interface is SCSI on POWER guests (and must be attached to the SPAPR i= nterface) and IDE on the x86_64, this information could be retrieved from t= he osinfo (by creating a property there) or It could be hard-coded in the strategy class.<o:p></o:p> Which would be the best way to = handle this difference?<o:p></o:p> <o:p> </o:p> The third and final issue is th= at when the VNC protocol is used in a VM, by default a Cirrus Logic VGA dev= ice is created. This device is not supported on POWER guests, but the stand= ard VGA device is. I made a workaround, but the issue is where to put this association between the device type and= the display protocol.<o:p></o:p> Should it also be a property in= the osinfo? Or it should be handled in the strategy class?<o:p></o:p></spa= n> <o:p> </o:p> </div> </body> </html> --_000_B2CAFC4D5E2D574A883EF61ACD5ADE330180A712SERV070corpeldo_--

2 1

[Engine-devel] Rebuild ovirt 3.2.1 success, but lost i18n support
by An Yang 20 Aug '13

20 Aug '13

Hi all, I just rebuild ovirt-engine 3.2.1 according to http://www.ovirt.org/Building_oVirt_engine , it work fine, but I could not choose the language, it always display U.S. English UI. Could you give me a hand, how can I enable GWT's i18n support, or something is wrong in my building ENV? Thanks in advance. -- Bests, An Yang

2 2

Re: [Engine-devel] Jenkins job to run networking functional tests
by Eyal Edri 20 Aug '13

20 Aug '13

[adding devel lists] Usually to get power user privileges you need get +1 community (mostly relevant people in your team/project). saying you're familiar with jenkins and the project and is cabaple of adding jobs to the project. I personally give +1 since i know you're contribution and experience. Eyal. ----- Original Message ----- > From: "Giuseppe Vallarelli" <gvallare(a)redhat.com> > To: "infra" <infra(a)ovirt.org> > Sent: Monday, August 19, 2013 10:19:46 AM > Subject: Jenkins job to run networking functional tests > > Hello everybody, following the previous discussion with Eyal, > I need to get rights in order to create a jenkins job to > achieve what stated in the subject. > > Is it the right place for such request? > > Cheers, Giuseppe > > ----- Forwarded Message ----- > | From: "Eyal Edri" <eedri(a)redhat.com> > | To: "Giuseppe Vallarelli" <gvallare(a)redhat.com> > | Cc: "infra" <infra(a)ovirt.org> > | Sent: Sunday, August 18, 2013 2:06:22 PM > | Subject: Re: running network functional tests > | > | Hi, > | > | Usually in these cases when a new job is requested to a specific > | project/component, > | A 'power user' for the relevant team (in your case network), is given > | privileges on the Jenkins machine > | to add any job required. > | > | I would propose the following: > | 1. request power user access to jenkins.ovirt.org (if you don't already > | have) > | 2. add a new job with your functional test per commit (not per patch for > | starts) > | any infra member can assist you with the labels for slaves / os /etc... > | 3. once that job is running properly, you can contact infra to assist in > | converting it to a per-patch job > | with the topic / field verification logic done. > | 4. not sure if this is relevant to your tests, but all existing jenkins > | slaves are VMs and not bare-metal. > | > | i hope this helps. > | > | Eyal. > | > | ----- Original Message ----- > | > From: "Giuseppe Vallarelli" <gvallare(a)redhat.com> > | > To: "infra" <infra(a)ovirt.org> > | > Sent: Friday, August 16, 2013 12:28:43 PM > | > Subject: Fwd: running network functional tests > | > > | > ----- Forwarded Message ----- > | > | From: "Giuseppe Vallarelli" <gvallare(a)redhat.com> > | > | To: "infra" <infra(a)ovirt.org> > | > | Cc: "David Caro Estevez" <dcaroest(a)redhat.com> > | > | Sent: Monday, August 12, 2013 10:58:04 AM > | > | Subject: running network functional tests > | > | > | > | Hello everbody! > | > | Just recently we added networking functional tests and we would like > | > | to have them running when we submit patches network related, i.e. > | > | going to affect network modules. Displaying success or failure > | > | as it happens with the current unittests. > | > | > | > | Requirements/ideas: > | > | > | > | - OS Fedora 19/RHEL6.4 should not matter. > | > | > | > | - Kernel module used: bonding, dummy. > | > | > | > | - No more than one 'instance' of networkTests should run > | > | on a specific host, simply because we use some global > | > | constants to identify network name vlan id and so on. > | > | > | > | - Ideally we can use a previously proposed idea of commit tag > | > | where for example @networking is provided in the commit msg > | > | title to identify the need of running also the network > | > | functional tests. > | > | > | > | - We should be able to run at the same time functional networking > | > | tests and unit tests - I don't expect any conflicts. > | > | > | > | Would be cool to have a test run before -1s all networking patches > | > | in case of problems :-) > | > | > | > | Let me know if more information are needed. > | > | > | > | > | > | Cheers, Giuseppe > | > > | > Is there any update on the subject? > | > > | > Any estimate to have functional network tests running? > | > I mind that we can run network functional tests upstream > | > that will speed up our workflow and possibly decrease the > | > regressions. > | > > | > Thanks Giuseppe > | > _______________________________________________ > | > Infra mailing list > | > Infra(a)ovirt.org > | > http://lists.ovirt.org/mailman/listinfo/infra > | > > | > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra >

3 3

[Engine-devel] oVirt UI technology stack upgrade complete
by Vojtech Szocs 20 Aug '13

20 Aug '13

Hello everyone, last week, we merged a patch that upgrades oVirt UI technology stack to use the latest version of Google Web Toolkit SDK and related modules [1]. This patch includes all "essential" upgrade changes as described in [2]. After merging the above mentioned patch, we faced some issues related to GWT RPC serialization, involving classes shared between frontend and backend. Please read on to learn more about these issues and ways to fix them. -- (A) NullPointerException at server-side (GWT RPC servlet) when serializing backend business entity into RPC response payload Symptoms * exception in server.log -> Exception while dispatching incoming RPC call: java.lang.NullPointerException * error dialog in web UI with status code 500 (internal server error) Root cause * fields such as "private X field = Y;" of the given entity are not included in GWT RPC serialization policy * this happens when entity constructor isn't referenced in UI code -> GWT compiler marks the constructor and instance initializer as dead code * since instance initializer takes care of adding such fields to given type (entity) in generated JavaScript, such fields won't be added at all Workaround * for each field such as "private X field = Y;" 1, change field declaration to "private X field;" 2, add "field = Y;" statement to constructor Consequence * even though constructor and instance initializer are marked as dead code, fields such as "private X field;" are still added to given type (entity) in generated JavaScript * this is due to how generated JavaScript works, i.e. fields without initialization statement such as "private X field;" are always added, whereas fields with initialization statement such as "private X field = Y;" are added via instance initializer (which might be removed if it's marked as dead code) References * patch [http://gerrit.ovirt.org/#/c/17352/] for RepoImage entity -- (B) Instance field(s) with null values at server-side after deserializing RPC request payload Symptoms * object passed from client contains field(s) with null values, despite client initializing fields before making RPC call Root cause * client uses RPC method signature that works with type A, i.e. VdcActionParametersBase * type A meets GWT RPC serialization rules, as defined in [3] section "Serializable User-defined Classes" * client uses type B (extends A) when calling given RPC method at runtime, i.e. MyCustomParameters * type B does NOT meet GWT RPC serialization rules, i.e. missing no-arg constructor * back at server-side, GWT RPC servlet fails to deserialize type B properly Workaround * ensure all types participating in GWT RPC communication meet GWT RPC serialization rules 1, assignable to IsSerializable or Serializable interface 2, all non-final & non-transient instance fields meet GWT RPC serialization rules 3, contains no-arg constructor (in order to create instance during deserialization) References * patch [http://gerrit.ovirt.org/#/c/17368/] for Gluster Parameter classes -- Regards, Vojtech [1] http://gerrit.ovirt.org/#/c/16739/ [2] http://www.ovirt.org/Features/GWT_Platform_Upgrade [3] http://www.gwtproject.org/doc/latest/DevGuideServerCommunication.html#DevGu…

2 3

[Engine-devel] Rebuild ovirt 3.2.1 success, but lost i18n support
by An Yang 20 Aug '13

20 Aug '13

--=-idC09TPR8Ct/GVyk0dLv Content-Type: multipart/alternative; boundary="=-umgPw/+YnaaGimIE+IJT" --=-umgPw/+YnaaGimIE+IJT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi all, I just rebuild ovirt-engine 3.2.1 aaccording to http://www.ovirt.org/Building_oVirt_engine , it work fine, but I could not choose the language, it always display U.S. English UI. Could you give me a hand, how can I enable GWT's i18n support, or something is wrong in my building ENV?=20 Thanks in advance. An Yang --=-umgPw/+YnaaGimIE+IJT Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; CHARSET=3DUTF-8"> <META NAME=3D"GENERATOR" CONTENT=3D"GtkHTML/4.2.2"> </HEAD> <BODY> Hi all, I just rebuild ovirt-engine 3.2.1 aaccording to <A HREF=3D"http://www.ovirt= .org/Building_oVirt_engine">http://www.ovirt.org/Building_oVirt_engine</A> = , it work fine, but I could not choose the language, it always display U.S.= English UI. Could you give me a hand, how can I enable GWT's i18n support, or something= is wrong in my building ENV? Thanks in advance. An Yang </BODY> </HTML> --=-umgPw/+YnaaGimIE+IJT-- --=-idC09TPR8Ct/GVyk0dLv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAABAgAGBQJSEs0tAAoJEIzlWTTXdxmtmnYIAKlGCEvwHxNNYGeUSH/zPz6C 2CdDyDTzKtTY/L0+Di1Z1z/hwpxNdna18W/OCr9cFlcBwSXM9e9dC3F2FdvIOxFU SL77W81PSJgsbaoYB7vfjA7mwDFxpzpp7n0mMgDPStoJZ5PSxWuRUl0ow5RGDBpk ev7NAhEdpbNLlOrgIIkeYgBEfUZWyZXqodKUELqJ5rrF6Yy5W1M/sBWu4P42XCNc ndwtkXwSnOEaWzoV4FOqtcf2x8oA69DG4Vor64YV030MsFlD2e902FbVwsEQ7BCq pPpHmuGRmQlVt6hksZA4Pjus3J1LX040WmZAynfnx66jVUe5jS96+rj5wl6GB4I= =4yAp -----END PGP SIGNATURE----- --=-idC09TPR8Ct/GVyk0dLv--

1 0

[Engine-devel] Dynamic resource loading in GWT
by Roy Golan 19 Aug '13

19 Aug '13

Painful issue here - we all know the regular drill of maintaining messages in many places, I18N files and so on. Also there's a patch to make all available timezone an java enum and by that share it for free with the UI. its a way better than a backend Query. But this is all hard-coded, not flexible, hard to maintain, we all know. Why won't we make GWT load a javascript dictionary/dictionaries from a servlet or our host page html[1] using GWT Dictionary[3]? that way the configuration is shared with the engine, it relies on the disk, customers and GSS can change it on-site and so on. | index.html | -> | file servlet | -> |read /etc/ovirt-engine/conf/...| ^ | | GWT loads Dictionary | candidates for dynamic resources * I18N resources AppErrors... * config ( just the UI subset ) * osinfo ? [1] host page html - http://www.gwtproject.org/doc/latest/DevGuideOrganizingProjects.html#DevGui… [2] Dynamic string internationalisation - http://www.gwtproject.org/doc/latest/DevGuideI18n.html#DevGuideDynamicStrin… [3] http://www.gwtproject.org/javadoc/latest/com/google/gwt/i18n/client/Diction… Thanks, Roy

6 10

[Engine-devel] New patches for IBM POWER support
by Leonardo Bianconi 19 Aug '13

19 Aug '13

--_000_50EB20226B72D6419356FC320AB62B871917274FSERV070corpeldo_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi everyone! This is the dependency tree of the patches (along with their IDs on gerrit)= that will enable IBM POWER support for the oVirt engine (more patches will= be submitted later): 17853 - core: Add POWER 7 to the CPU list 16700 - core, engine, webadmin: Initial support for alterna= tive architectures 18220 - core: New OS for IBM POWER support 17855 - core: Architecture r= elated queries 18226 - core= , engine, webadmin: Cluster and architecture related changes = 18227 - core, webadmin, engine: Added architecture support for VM and T= emplate 17885 - webadmin: Show only = supported displays 17964 - core, webadmin: Show= only supported disk interfaces 17972 - webadmin: Show only = compatible OSes 18221 - core, webadmin: Show= only supported watchdogs 18227 - core, webadmin, engi= ne: Added architecture support for VM and Template 18150 - engine: Display type validation 18042 - engine: Vnic interface validation We divided the previous patchset into smaller patches with specific feature= s, in order to enhance the review process. We avoided modifying the change = #16700 too much, because the reviewers had already started giving their fee= dback on it. Looking at the tree, the other patches are highly dependent on changes #178= 53/#16700/#1822, and the change #16700 is the largest one. If there is some= thing to do to help the review process, please, let us know. Regards, Leonardo Bianconi/Vitor de Lima/Gustavo Pedrosa --_000_50EB20226B72D6419356FC320AB62B871917274FSERV070corpeldo_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"PT-BR" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> Hi everyone!<o:p></o:p><= /p> <o:p> </o:p> This is the dependency tree of = the patches (along with their IDs on gerrit) that will enable IBM POWER sup= port for the oVirt engine (more patches will be submitted later):<o:p></o:p= > <o:p> </o:p> 17853 - core: Add POWER 7 to th= e CPU list<o:p></o:p>      &= nbsp;          16700 - core, e= ngine, webadmin: Initial support for alternative architectures<o:p></o:p></= span>      &= nbsp;           &nbs= p;             = 18220 - core: New OS for IBM POWER support<o:p></o:p>      &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;    17855 - core: Architecture related queries<o:p></o:p><= /span>      &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;             =        18226 - core, engine, webadmin: C= luster and architecture related changes<o:p></o:p>      &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;           18227 - core= , webadmin, engine: Added architecture support for VM and Template<o:p></o:= p>      &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;    17885 - webadmin: Show only supported displays<o:p></o= :p>      &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;    17964 - core, webadmin: Show only supported disk inter= faces<o:p></o:p>      &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;    17972 - webadmin: Show only compatible OSes<o:p></o:p>=      &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;    18221 - core, webadmin: Show only supported watchdogs<= o:p></o:p>      &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;    18227 - core, webadmin, engine: Added architecture sup= port for VM and Template<o:p></o:p> 18150 - engine: Display type va= lidation<o:p></o:p> 18042 - engine: Vnic interface = validation<o:p></o:p> <o:p> </o:p> We divided the previous patchse= t into smaller patches with specific features, in order to enhance the revi= ew process. We avoided modifying the change #16700 too much, because the re= viewers had already started giving their feedback on it.<o:p></o:p> Looking at the tree, the other = patches are highly dependent on changes #17853/#16700/#1822, and the change= #16700 is the largest one. If there is something to do to help the review = process, please, let us know.<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> Leonardo Bianconi/Vitor de Lima/Gustavo Pedrosa<o:p>= </o:p> <o:p> </o:p> </div> </body> </html> --_000_50EB20226B72D6419356FC320AB62B871917274FSERV070corpeldo_--

1 0