- Devel - oVirt List Archives

[Engine-devel] UI plugins patches merged, moving out of proof-of-concept stage
by Vojtech Szocs 12 Dec '12

12 Dec '12

Hi everyone, I'm happy to announce that oVirt UI plugins feature just moved out of proof-of-concept stage, with relevant patches [1,2] merged into ovirt-engine git repository. I'll be working on related documentation (wiki) in near future, along with contributing some sample plugins into samples-uiplugins [3] git repository. I'd like to thank everyone involved in pushing this feature forward. I hope we'll see some interesting plugins soon! Regards, Vojtech [1] http://gerrit.ovirt.org/#/c/8120/ [2] http://gerrit.ovirt.org/#/c/9250/ [3] git://gerrit.ovirt.org/samples-uiplugins

3 2

[Engine-devel] UI Plugins: PoC patch revision 7 is here
by Vojtech Szocs 12 Dec '12

12 Dec '12

------=_Part_6244399_613158090.1352995860557 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi guys, the latest revisi on of UI Plugins proof-of-c on cept patch is now available for you to experiment with. I've split revision 7 changes apart from revision 6 to make it easier to review new features that were added into revision 7. You can download and apply UI Plugins patches from oVirt Gerrit code review system: 1. revision 6 - http://gerrit.ovirt.org/#/c/8120/ 2. revision 7 - http://gerrit.ovirt.org/#/c/9250/ Please read on to learn what's new in this revisi on . If you have any comments, questi on s or ideas, please let me know! Engine REST API integration UiInit is not the only event handler function anymore! :) UI plugin infrastructure now integrates with Engine REST API by acquiring new REST API session [1] upon successful user authentication. REST API session ID is provided to plugins via RestApiSessionAcquired event handler function. For example: api.register({ RestApiSessionAcquired: function(sessionId) { // Do something with newly acquired session ID } }); Note that UiInit function is still the first function to be invoked on the given plugin. Plugins can therefore expect RestApiSessionAcquired function to be called shortly after UiInit function. For now, UI plugin infrastructure guarantees that acquired Engine REST API session will be valid while the user stays authenticated in WebAdmin. This is done by keeping REST API session alive via periodic heartbeats (HTTP requests) in the background. This also means that it's safe to store and use REST API session ID until RestApiSessionAcquired function is called again with new value. In future, we might consider dropping this kind of guarantee to avoid the keep-alive heartbeat, and use some kind of "is session valid" query to determine if the REST API session is still valid. After the user signs out of WebAdmin, Engine REST API session will be closed, as per [1]. After signing in again, the process of acquiring new REST API session and calling RestApiSessionAcquired function repeats with new session ID value. Engine REST API integration also works seamlessly with auto login - if the user is already logged in on the backend, running WebAdmin in new window (tab) will take him directly to the main (authenticated) section of the application. In this case, UI plugin infrastructure remembers the currently valid REST API session ID using HTML5 local storage (or cookie if the browser doesn't support it). New API function: showDialog It's now possible to open custom dialogs using showDialog function. For example: api.register({ UiInit: function() { api.addMainTabActionButton('Host', 'Show Test Dialog', { onClick: function() { api.showDialog('Test Dialog', 'http://www.ovirt.org/', 600, 400); } }); } }); The signature of showDialog function is following: showDialog (title, contentUrl, width, height) For now, dialogs are shown using window.open API (non-modal browser popups ). This will be changed in future, providing close integration with GWTP / WebAdmin dialog infrastructure. New API function: setMainTabContentUrl It's now possible to update content URL of the given custom main tab using setMainTabContentUrl function. For example: api.register({ UiInit: function() { // Use 'about:blank' URL to display empty content api.addMainTab('Custom Tab', 'custom-tab', 'about:blank'); }, RestApiSessionAcquired: function(sessionId) { var url = 'http://www.ovirt.org/?s=' + encodeURIComponent(sessionId); api.setMainTabContentUrl('custom-tab', url); } }); In the above example, we first add an empty custom main tab. We do this in UiInit event handler function because we know that it's the best place for one-time UI initialization :) As soon as we receive REST API session ID, we update the URL of the custom main tab. This is just an example how REST API session ID can be sent over to your server as part of main tab content URL. The signature of setMainTabContentUrl function is following: setMainTabContentUrl(historyToken, contentUrl) Note that historyToken essentially identifies the custom main tab. That's it for now, let me know what you think! Regards, Vojtech [1] http://wiki.ovirt.org/wiki/Features/RESTSessionManagement ------=_Part_6244399_613158090.1352995860557 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head><style type=3D'text/css'>p { margin: 0; }</style></head><body><= div style=3D'font-family: times new roman,new york,times,serif; font-size: = 12pt; color: #000000'>Hi guys, the latest revision<= /span> of UI Plugins= proof-of-c<spa= n id=3D"DWT4665" class=3D"ZmSearchResult">oncept patch is now= available for you to experiment with. I've split revision 7 changes apart = from revision 6 to make it easier to review new features that were added in= to revision 7. You can download and apply UI Plugins patches from oV= irt Gerrit code review system: <ol><li>revision 6 - http://gerrit.ovirt.= org/#/c/8120/</li><li>revision 7 - http://gerrit.ovirt.org/#/c/9250/ </l= i></ol>Please read on to learn what's new = in this revision. If you have any comments, = questions or ideas, please let me know! <= br><hr style=3D"width: 100%; height: 2px;"> Engine REST API inte= gration UiInit is not= the only event handler function anymore! :) UI plugin infrastructur= e now integrates with Engine REST API by acquiring new REST API session [1]= upon successful user authentication. REST API session ID is provide= d to plugins via RestApiSessionAcquired= event handler function. For example: api.register({</span= >   RestApiSessionAcquired: function(sessionId) { &nbsp= ;   // Do something with newly acquired session ID &nbs= p; } }); Note that UiInit function is still the first function to be invoked on the= given plugin. Plugins can therefore expect RestApiSessionAcquired function to be called shortly after <spa= n style=3D"font-style: italic;">UiInit function. For now, UI = plugin infrastructure guarantees that acquired Engine REST API session will= be valid while the user stays authenticated in WebAdmin. This is done by k= eeping REST API session alive via periodic heartbeats (HTTP requests) in th= e background. This also means that it's safe to store and use REST API sess= ion ID until RestApiSessionAcquired</sp= an> function is called again with new value. In future, we might consider d= ropping this kind of guarantee to avoid the keep-alive heartbeat, and use s= ome kind of "is session valid" query to determine if the REST API session i= s still valid. After the user signs out of WebAdmin, Engine REST API= session will be closed, as per [1]. After signing in again, the process of= acquiring new REST API session and calling RestApiSessionAcquired function repeats with new session ID val= ue. Engine REST API integration also works seamlessly with auto logi= n - if the user is already logged in on the backend, running WebAdmin in ne= w window (tab) will take him directly to the main (authenticated) section o= f the application. In this case, UI plugin infrastructure remembers the cur= rently valid REST API session ID using HTML5 local storage (or cookie if th= e browser doesn't support it). <hr style=3D"width: 100%; height: 2px= ;"> New API function: showDialog</spa= n> It's now possible to open custom dia= logs using showDialog function. = For example: api.register({   UiInit: function() {=     api.addMainTabActionButton('Host', 'Show Test= Dialog', {       onClick: function() {<= /span>         api.showDialog('Test D= ialog', 'http://www.ovirt.org/', 600, 400);     &nbs= p; }     });   } });</spa= n> The signature of showDialog</spa= n> function is following: <div style=3D"margin-left: 40px;">showDialog(title, contentUrl, width, height)</s= pan> </div> For now, dialogs are shown using window.open API (non-modal browser popups). This will be= changed in future, providing close integration with GWTP / WebAdmin dialog= infrastructure. <hr style=3D"width: 100%; height: 2px;"> New API function: setMainTabContentUrl<b= r style=3D"font-weight: bold;"> It's now possible to update content URL = of the given custom main tab using setM= ainTabContentUrl function. For example: api.register({</sp= an>   UiInit: function() {     // Use 'abo= ut:blank' URL to display empty content     api.add= MainTab('Custom Tab', 'custom-tab', 'about:blank');   },</sp= an>   RestApiSessionAcquired: function(sessionId) { &nbsp= ;   var url =3D 'http://www.ovirt.org/?s=3D' + encodeURIComponent= (sessionId);     api.setMainTabContentUrl('custom-= tab', url);   } }); In the above exampl= e, we first add an empty custom main tab. We do this in UiInit event handler function because we know that = it's the best place for one-time UI initialization :) As soon as we receive= REST API session ID, we update the URL of the custom main tab. This is jus= t an example how REST API session ID can be sent over to your server as par= t of main tab content URL. The signature of setMainTabContentUrl function is following: <div = style=3D"margin-left: 40px;">setMainTab= ContentUrl(historyToken, contentUrl) </div> Note that historyToken essentially identifies the = custom main tab. <hr style=3D"width: 100%; height: 2px;"> That's = it for now, let me know what you think! Regards, Vojtech <= span style=3D"font-weight: bold;"> [1] http://wiki.ovirt.org/wiki= /Features/RESTSessionManagement </div></body></html> ------=_Part_6244399_613158090.1352995860557--

3 13

[Engine-devel] Failed to start service jboss.deployment.subunit."engine.ear"
by Michael Pasternak 12 Dec '12

12 Dec '12

any clue what it might be? (latest sources + db) 2012-12-12 12:51:27,658 INFO [org.ovirt.engine.core.bll.Backend] (MSC service thread 1-7) Start time: 12/12/12 12:51 PM 2012-12-12 12:51:27,685 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-7) MSC00001: Failed to start service jboss.deployment.subunit."engine.ear"."engine-bll.jar".component.Backend.START: org.jboss.msc.service.StartException in service jboss.deployment.subunit."engine.ear"."engine-bll.jar".component.Backend.START: Failed to start service at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1767) [jboss-msc-1.0.2.GA.jar:1.0.2.GA] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) [rt.jar:1.6.0_20] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [rt.jar:1.6.0_20] at java.lang.Thread.run(Thread.java:636) [rt.jar:1.6.0_20] Caused by: java.lang.IllegalStateException: JBAS011048: Failed to construct component instance at org.jboss.as.ee.component.BasicComponent.constructComponentInstance(BasicComponent.java:163) at org.jboss.as.ee.component.BasicComponent.createInstance(BasicComponent.java:85) at org.jboss.as.ejb3.component.singleton.SingletonComponent.getComponentInstance(SingletonComponent.java:116) at org.jboss.as.ejb3.component.singleton.SingletonComponent.start(SingletonComponent.java:130) at org.jboss.as.ee.component.ComponentStartService.start(ComponentStartService.java:44) at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.2.GA.jar:1.0.2.GA] at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.2.GA.jar:1.0.2.GA] ... 3 more Caused by: javax.ejb.EJBException: org.springframework.jdbc.BadSqlGrammarException: PreparedStatementCallback; bad SQL grammar [select * from get_all_commands()]; nested exception is org.postgresql.util.PSQLException: ERROR: function get_all_commands() does not exist Hint: No function matches the given name and argument types. You might need to add explicit type casts. Position: 16 ... -- Michael Pasternak RedHat, ENG-Virtualization R&D

2 2

[Engine-devel] upgrade script
by Yair Zaslavsky 12 Dec '12

12 Dec '12

Hi all, Please pay attention - when you send patches with upgrade script the prefix should be 03_02_XXXX_ and not 03_01_XXXX_ For example - this script was originally 03_01_XXXX once, and it's in correct backend/manager/dbscripts/upgrade/03_02_0020_add_libvirt_version_col.sql Yair

1 0

[Engine-devel] another datamodel cleanup
by Laszlo Hornyak 11 Dec '12

11 Dec '12

Hi, Another datamodel cleanup patch is waiting for review: http://gerrit.ovirt.org/9824 Thx, Laszlo

1 0

[Engine-devel] compatibility version
by Laszlo Hornyak 11 Dec '12

11 Dec '12

Hi, When I install an ovirt engine from scratch, the Default DC is set to Compatibility version 3.1, but when I create a new DC, it's Compatibility version is set to 3.2 by default. Is this intentional? Why? Laszlo

2 2

[Engine-devel] Inherited Permissions from System
by Ravi Nori 11 Dec '12

11 Dec '12

I am currently working on a bug to show the inherited permissions on an object. So if the user has permissions assigned on a Cluster, the user should have permissions on the VMs in the cluster. My question is if the user has permissions on the System, should the permissions be inherited to all the entities? Link to the bug https://bugzilla.redhat.com/show_bug.cgi?id=871365 Thanks Ravi

2 1

[Engine-devel] Attaching a console should be controllable
by Frantisek Kobzik 10 Dec '12

10 Dec '12

Hi guys, Just a simple question. I'm writing an engine counterpart for this vdsm feature: https://bugzilla.redhat.com/show_bug.cgi?id=878459 http://gerrit.ovirt.org/#/c/9359 Long story short, it adds the possibility of controlling adding the virtio serial console to a VM. I'm going to add a new column "console_enabled" to vm_static and a new field "bool consoleEnabled" to appropriate entities. I'm just worried about the naming of the column and the field - could I use these names? Isn't it confusing? I just want to avoid unneeded refactoring when the patch is done. Any feedback is welcome! Thanks, Frank

3 2

[Engine-devel] UI Plugins: PoC patch revision 7 update 3 is now available
by Vojtech Szocs 10 Dec '12

10 Dec '12

------=_Part_16659810_2134251194.1355163009146 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi everyone, just a quick update on UI Plugins proof-of-c on cept patch - new patch for revision 7 (update 3) is now available. You can download and apply latest patches from oVirt Gerrit code review system: * rev is ion 6 - http://gerrit.ovirt.org/#/c/8120/ * rev is ion 7 update 3 - http://gerrit.ovirt.org/#/c/9250/ * REST API session patch: http://gerrit.ovirt.org/#/c/9820/ Please read on to learn what's new. Engine REST API integration REST API session patch (see above) now ensures that new session is acquired each time the user logs into WebAdmin, despite the fact that UI plugin infrastructure doesn't close existing REST API session on server after user logout. This means each user login equals new REST API session, based on provided login credentials. This fixes the problem of reusing existing (un-closed) session from previous user login. Many thanks to Michael Pasternak and Oved Ourfalli for the patch! Additionally, known limitation with regard to auto login has been fixed - UI plugin infrastructure now remembers REST API session ID on client (using HTML5 storage / cookie fallback) and uses it for auto login process. UI plugin infrastructure assumes that for auto login, REST API session has already been acquired (via classic login) and is still active at the time of auto login. Updated API function: register To make it clear that api.register function should be called exactly once , the function behavior has been changed in the following way: * previously, you could call api.register multiple times, last call would "win" with regard to passed event handler object * now, you can call api.register only once, subsequent calls will have no effect (the event handler object has already been set ) Regards, Vojtech ------=_Part_16659810_2134251194.1355163009146 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head><style type=3D'text/css'>p { margin: 0; }</style></head><body><= div style=3D'font-family: times new roman,new york,times,serif; font-size: = 12pt; color: #000000'>Hi everyone, just a quick update on UI</sp= an> Plugins<= /span> proof-of-concept patch = - new patch for revision 7 (update 3) is now available. You can down= load and apply latest = patches from oVirt Gerrit code review system: <ul><li>revision 6 - <a target=3D"_blank" href=3D"http://gerrit.ovir= t.org/#/c/8120/">http://gerrit.ovirt.org/#/c/8120/</a></li><l= i>revision 7 update 3 = - <a target=3D"_blank"= href=3D"http://gerrit.ovirt.org/#/c/9250/">http://gerrit.ovirt.org/#/c/925= 0/</a></li><li>REST API session patch: http://gerrit.ovirt.org/#/c/9820/</sp= an></li></ul>Please read on to learn what's new. <hr style= =3D"width: 100%; height: 2px;"> Engine REST API integration</= strong> REST API session patch (see above) now ensures that new session= is acquired each time the user logs into WebAdmin, despite the fact that <= /span>UI plugin infrastructure doesn't close existing REST API ses= sion on server after user logout. This means each user login equals new RES= T API session, based on provided login credentials. This fixes the problem = of reusing existing (un-closed) session from previous user login. Many than= ks to Michael Pasternak and Oved Ourfalli for the patch! = Additionally, known limitation with regard to auto login has been fixed = - UI plugin in= frastructure now remembers REST API session ID on client (using HTML5 stora= ge / cookie fallback) and uses it for auto login process. UI plugin infrastructure assume= s that for auto login, REST API session has already been acquired (via clas= sic login) and is still active at the time of auto login. <hr style=3D"width: 100%; height: = 2px;"> Updated API function: register To make it clear that api.register function sho= uld be called exactly once, the function behavior has been changed i= n the following way: <ul><li>previously, you could call api.register multiple times, last call would "wi= n" with regard to passed event handler object</li><li>now, you can call <sp= an style=3D"font-style: italic;">api.register only once, subsequent = calls will have no effect (the event handler object has already been set)<b= r></li></ul> <hr style=3D"width: 100%; height: 2px;"> R= egards, Vojtech </div></body></html> ------=_Part_16659810_2134251194.1355163009146--

1 0

[Engine-devel] Report vNic Information - Round 2
by Moti Asayag 10 Dec '12

10 Dec '12

Hi, According to the latest discussion of vNic info feature, I've updated its feature page [1]. Note that both feature page and detailed design page are updated. The feature page contains also a suggested mockup for the vm interface sub-tab. [1] http://www.ovirt.org/Feature/ReportingVnicInformation Thanks, Moti

1 0