- Devel - oVirt List Archives

[Engine-devel] Confusing "Attach Disk" checkbox in Add Virtual Disk dialog
by Roy Golan 31 Jul '12

31 Jul '12

Hi all, I find the new "Attach Disk" checkbox very confusing. It doesn't feel like a feature of the dialog but some kind of a disk property laid in the wrong place. I'd expect toggling between two ways of adding disk using tabs or inner menu. even simple inner " add | attach " feels more friendly. Is that an early sketch waiting to be changed? - Roy

3 2

[Engine-devel] oVirt UI Plugins Meeting
by Vojtech Szocs 30 Jul '12

30 Jul '12

------=_Part_18312111_1807961226.1343649759700 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit The following meeting has been modified: Subject: oVirt UI Plugins Meeting Organizer: "Vojtech Szocs" <vszocs(a)redhat.com> Time: Tuesday, July 31, 2012, 4:30:00 PM - 5:30:00 PM GMT +01:00 Belgrade, Bratislava, Budapest, Ljubljana, Prague Invitees: engine-devel(a)ovirt.org; George.Costea(a)netapp.com; Troy.Mangum(a)netapp.com; Dustin.Schoenbrun(a)netapp.com; Ricky.Hopper(a)netapp.com; Chris.Frantz(a)hp.com *~*~*~*~*~*~*~*~*~* Hi guys, let me invite you to a meeting for discussing oVirt UI Plugins feature. Topics covered in this meeting: * UI Plugins proof-of-concept (PoC): how it works and what are its implications * Discuss two ways to build plugins, comparing their pros and cons * Decide on next steps for initial UI Plugins implementation Here are the details required for joining the session. Intercall dial-in numbers can be found at: https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers… Intercall Conference Code ID: 7128867405 # Elluminate session: https://sas.elluminate.com/m.jnlp?sid=819&password=M.9C6593A28029B5159D5DD7… Regards, Vojtech ------=_Part_18312111_1807961226.1343649759700 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body id=3D'htmlmode'><h3>The following meeting has been modified:</h= 3> <p> <table border=3D'0'> <tr><th align=3Dleft>Subject:</th><td>oVirt UI Plugins Meeting </td></tr> <tr><th align=3Dleft>Organizer:</th><td>"Vojtech Szocs" <vszocs(a)redhat.c= om> </td></tr> </table> <p> <table border=3D'0'> <tr><th align=3Dleft>Time:</th><td>Tuesday, July 31, 2012, 4:30:00 PM - 5:3= 0:00 PM GMT +01:00 Belgrade, Bratislava, Budapest, Ljubljana, Prague </td></tr></table> <p> <table border=3D'0'> <tr><th align=3Dleft>Invitees:</th><td>engine-devel(a)ovirt.org; George.Coste= a(a)netapp.com; Troy.Mangum(a)netapp.com; Dustin.Schoenbrun(a)netapp.com; Ricky.H= opper(a)netapp.com; Chris.Frantz(a)hp.com </td></tr> </table> <div>*~*~*~*~*~*~*~*~*~*</div><br><div style=3D'font-family: times new roma= n,new york,times,serif; font-size: 12pt; color: #000000'><div style=3D"font= -family: times new roman,new york,times,serif; font-size: 12pt; color: #000= 000"><div style=3D"font-family: times new roman,new york,times,serif; font-= size: 12pt; color: #000000"><div style=3D"font-family: times new roman,new = york,times,serif; font-size: 12pt; color: #000000"><div style=3D"font-famil= y: times new roman,new york,times,serif; font-size: 12pt; color: #000000">H= i guys,<br><br>let me invite you to a meeting for discussing <span style=3D= "font-weight: bold;">oVirt UI Plugins</span> feature.<br><br>Topics covered= in this meeting:<br><ul><li>UI Plugins proof-of-concept (PoC): how it work= s and what are its implications</li><li>Discuss two ways to build plugins, = comparing their pros and cons</li><li>Decide on next steps for initial UI P= lugins implementation</li></ul><p><br></p><hr style=3D"width: 100%; height:= 2px;"><p><br></p><p>Here are the details required for joining the session.= <br><br>Intercall dial-in numbers can be found at:<br><span class=3D"Object= " id=3D"OBJ_PREFIX_DWT2571_com_zimbra_url"><span class=3D"Object" id=3D"OBJ= _PREFIX_DWT1569_com_zimbra_url"><a target=3D"_blank" href=3D"https://www.in= tercallonline.com/portlets/scheduling/viewNumbers/listNumbersByCode.do?conf= Code=3D7128867405">https://www.intercallonline.com/portlets/scheduling/view= Numbers/listNumbersByCode.do?confCode=3D7128867405</a></span></span><br><br= >Intercall Conference Code ID: <span class=3D"" id=3D"OBJ_PREFIX_DWT2572_co= m_zimbra_phone"><a href=3D"callto:7128867405" target=3D"_blank">7128867405<= /a></span>#</p><p><br></p><p>Elluminate session:</p><p><span class=3D"Objec= t" id=3D"OBJ_PREFIX_DWT5920_com_zimbra_url"><a target=3D"_blank" href=3D"ht= tps://sas.elluminate.com/m.jnlp?sid=3D819&password=3DM.9C6593A28029B515= 9D5DD78B361387">https://sas.elluminate.com/m.jnlp?sid=3D819&password=3D= M.9C6593A28029B5159D5DD78B361387</a></span></p><p><br></p><hr style=3D"widt= h: 100%; height: 2px;"><br>Regards,<br>Vojtech<br><br></div></div></div></d= iv></div></body></html> ------=_Part_18312111_1807961226.1343649759700 Content-Type: text/calendar; charset=utf-8; method=REQUEST; name=meeting.ics Content-Transfer-Encoding: 7bit BEGIN:VCALENDAR PRODID:Zimbra-Calendar-Provider VERSION:2.0 METHOD:REQUEST BEGIN:VTIMEZONE TZID:Europe/Belgrade BEGIN:STANDARD DTSTART:19710101T030000 TZOFFSETTO:+0100 TZOFFSETFROM:+0200 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=10;BYDAY=-1SU TZNAME:CET END:STANDARD BEGIN:DAYLIGHT DTSTART:19710101T020000 TZOFFSETTO:+0200 TZOFFSETFROM:+0100 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=-1SU TZNAME:CEST END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT UID:c3ad3a54-435b-4b59-91c8-9a20931a0c43 SUMMARY:oVirt UI Plugins Meeting ATTENDEE;CN=engine-devel;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=FAL SE:mailto:engine-devel@ovirt.org ATTENDEE;CN=George Costea;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=FA LSE:mailto:George.Costea@netapp.com ATTENDEE;CN=Troy Mangum;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=FALS E:mailto:Troy.Mangum@netapp.com ATTENDEE;CN=Dustin Schoenbrun;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSV P=FALSE:mailto:Dustin.Schoenbrun@netapp.com ATTENDEE;CN=Ricky Hopper;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=FAL SE:mailto:Ricky.Hopper@netapp.com ATTENDEE;CN=Chris Frantz;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=FAL SE:mailto:Chris.Frantz@hp.com ORGANIZER;CN=Vojtech Szocs:mailto:vszocs@redhat.com DTSTART;TZID="Europe/Belgrade":20120731T163000 DTEND;TZID="Europe/Belgrade":20120731T173000 STATUS:CONFIRMED CLASS:PUBLIC X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY TRANSP:OPAQUE LAST-MODIFIED:20120730T120239Z DTSTAMP:20120730T120239Z SEQUENCE:4 DESCRIPTION:The following meeting has been modified:\n\nSubject: oVirt UI Pl ugins Meeting \nOrganizer: "Vojtech Szocs" <vszocs(a)redhat.com> \n\nTime: Tue sday\, July 31\, 2012\, 4:30:00 PM - 5:30:00 PM GMT +01:00 Belgrade\, Bratis lava\, Budapest\, Ljubljana\, Prague\n \nInvitees: engine-devel(a)ovirt.org\; George.Costea(a)netapp.com\; Troy.Mangum(a)netapp.com\; Dustin.Schoenbrun@netapp .com\; Ricky.Hopper(a)netapp.com\; Chris.Frantz(a)hp.com \n\n\n*~*~*~*~*~*~*~*~* ~*\n\n\n\n\n\nHi guys\, \n\nlet me invite you to a meeting for discussing oV irt UI Plugins feature. \n\nTopics covered in this meeting: \n\n * UI Plu gins proof-of-concept (PoC): how it works and what are its implications \n * Discuss two ways to build plugins\, comparing their pros and cons \n * Decide on next steps for initial UI Plugins implementation \n\n\n\n\n\n\nH ere are the details required for joining the session. \n\nIntercall dial-in numbers can be found at: \nhttps://www.intercallonline.com/portlets/scheduli ng/viewNumbers/listNumbersByCode.do?confCode=7128867405 \n\nIntercall Confer ence Code ID: 7128867405 # \n\n\nElluminate session: \nhttps://sas.elluminat e.com/m.jnlp?sid=819&password=M.9C6593A28029B5159D5DD78B361387 \n\n\n\nRegar ds\, \nVojtech \n\n X-ALT-DESC;FMTTYPE=text/html:<html><body id='htmlmode'><h3>The following mee ting has been modified:</h3>\n\n<p>\n<table border='0'>\n<tr><th align=left> Subject:</th><td>oVirt UI Plugins Meeting </td></tr>\n<tr><th align=left>Org anizer:</th><td>"Vojtech Szocs" &lt\;vszocs(a)redhat.com&gt\; </td></tr>\n</ta ble>\n<p>\n<table border='0'>\n<tr><th align=left>Time:</th><td>Tuesday\, Ju ly 31\, 2012\, 4:30:00 PM - 5:30:00 PM GMT +01:00 Belgrade\, Bratislava\, Bu dapest\, Ljubljana\, Prague\n </td></tr></table>\n<p>\n<table border='0'>\n< tr><th align=left>Invitees:</th><td>engine-devel(a)ovirt.org\; George.Costea@n etapp.com\; Troy.Mangum(a)netapp.com\; Dustin.Schoenbrun(a)netapp.com\; Ricky.Ho pper(a)netapp.com\; Chris.Frantz(a)hp.com </td></tr>\n</table>\n<div>*~*~*~*~*~* ~*~*~*~*</div><br><div style='font-family: times new roman\,new york\,times\ ,serif\; font-size: 12pt\; color: #000000'><div style="font-family: times ne w roman\,new york\,times\,serif\; font-size: 12pt\; color: #000000"><div sty le="font-family: times new roman\,new york\,times\,serif\; font-size: 12pt\; color: #000000"><div style="font-family: times new roman\,new york\,times\, serif\; font-size: 12pt\; color: #000000"><div style="font-family: times new roman\,new york\,times\,serif\; font-size: 12pt\; color: #000000">Hi guys\, <br><br>let me invite you to a meeting for discussing <span style="font-weig ht: bold\;">oVirt UI Plugins</span> feature.<br><br>Topics covered in this m eeting:<br><ul><li>UI Plugins proof-of-concept (PoC): how it works and what are its implications</li><li>Discuss two ways to build plugins\, comparing t heir pros and cons</li><li>Decide on next steps for initial UI Plugins imple mentation</li></ul><p><br></p><hr style="width: 100%\; height: 2px\;"><p><br ></p><p>Here are the details required for joining the session.<br><br>Interc all dial-in numbers can be found at:<br><span class="Object" id="OBJ_PREFIX_ DWT2571_com_zimbra_url"><span class="Object" id="OBJ_PREFIX_DWT1569_com_zimb ra_url"><a target="_blank" href="https://www.intercallonline.com/portlets/sc heduling/viewNumbers/listNumbersByCode.do?confCode=7128867405">https://www.i ntercallonline.com/portlets/scheduling/viewNumbers/listNumbersByCode.do?conf Code=7128867405</a></span></span><br><br>Intercall Conference Code ID: <span class="" id="OBJ_PREFIX_DWT2572_com_zimbra_phone"><a href="callto:712886740 5" target="_blank">7128867405</a></span>#</p><p><br></p><p>Elluminate sessio n:</p><p><span class="Object" id="OBJ_PREFIX_DWT5920_com_zimbra_url"><a targ et="_blank" href="https://sas.elluminate.com/m.jnlp?sid=819&amp\;password=M. 9C6593A28029B5159D5DD78B361387">https://sas.elluminate.com/m.jnlp?sid=819&am p\;password=M.9C6593A28029B5159D5DD78B361387</a></span></p><p><br></p><hr st yle="width: 100%\; height: 2px\;"><br>Regards\,<br>Vojtech<br><br></div></di v></div></div></div></body></html> BEGIN:VALARM ACTION:DISPLAY TRIGGER;RELATED=START:-PT5M DESCRIPTION:Reminder END:VALARM END:VEVENT END:VCALENDAR ------=_Part_18312111_1807961226.1343649759700--

1 0

[Engine-devel] oVirt UI Plugins Meeting
by Vojtech Szocs 30 Jul '12

30 Jul '12

------=_Part_18225895_1909350189.1343647908904 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit The following is a new meeting request: Subject: oVirt UI Plugins Meeting Organizer: "Vojtech Szocs" <vszocs(a)redhat.com> Time: Tuesday, July 31, 2012, 4:30:00 PM - 5:30:00 PM GMT +01:00 Belgrade, Bratislava, Budapest, Ljubljana, Prague Invitees: engine-devel(a)ovirt.org *~*~*~*~*~*~*~*~*~* Hi guys, let me invite you to a meeting for discussing oVirt UI Plugins feature. Topics covered in this meeting: * UI Plugins proof-of-concept (PoC): how it works and what are its implications * Discuss two ways to build plugins, comparing their pros and cons * Decide on next steps for initial UI Plugins implementation Here are the details required for joining the session. Intercall dial-in numbers can be found at: https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers… Intercall Conference Code ID: 7128867405 # Regards, Vojtech ------=_Part_18225895_1909350189.1343647908904 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body id=3D'htmlmode'><h3>The following is a new meeting request:</h3= > <p> <table border=3D'0'> <tr><th align=3Dleft>Subject:</th><td>oVirt UI Plugins Meeting </td></tr> <tr><th align=3Dleft>Organizer:</th><td>"Vojtech Szocs" <vszocs(a)redhat.c= om> </td></tr> </table> <p> <table border=3D'0'> <tr><th align=3Dleft>Time:</th><td>Tuesday, July 31, 2012, 4:30:00 PM - 5:3= 0:00 PM GMT +01:00 Belgrade, Bratislava, Budapest, Ljubljana, Prague </td></tr></table> <p> <table border=3D'0'> <tr><th align=3Dleft>Invitees:</th><td>engine-devel(a)ovirt.org </td></tr> </table> <div>*~*~*~*~*~*~*~*~*~*</div><br><div style=3D'font-family: times new roma= n,new york,times,serif; font-size: 12pt; color: #000000'>Hi guys,<br><br>le= t me invite you to a meeting for discussing <span style=3D"font-weight: bol= d;">oVirt UI Plugins</span> feature.<br><br>Topics covered in this meeting:= <br><ul><li>UI Plugins proof-of-concept (PoC): how it works and what are it= s implications</li><li>Discuss two ways to build plugins, comparing their p= ros and cons</li><li>Decide on next steps for initial UI Plugins implementa= tion</li></ul><p><br></p><hr style=3D"width: 100%; height: 2px;"><p><br></p= ><p>Here are the details required for joining the session.<br><br>Intercall= dial-in numbers can be found at:<br><span class=3D"Object" id=3D"OBJ_PREFI= X_DWT2571_com_zimbra_url"><span class=3D"Object" id=3D"OBJ_PREFIX_DWT1569_c= om_zimbra_url"><a target=3D"_blank" href=3D"https://www.intercallonline.com= /portlets/scheduling/viewNumbers/listNumbersByCode.do?confCode=3D7128867405= ">https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbe= rsByCode.do?confCode=3D7128867405</a></span></span><br><br>Intercall Confer= ence Code ID: <span class=3D"" id=3D"OBJ_PREFIX_DWT2572_com_zimbra_phone"><= a href=3D"callto:7128867405" target=3D"_blank">7128867405</a></span>#</p><p= ><br></p><hr style=3D"width: 100%; height: 2px;"><br>Regards,<br>Vojtech<br= ><br></div></body></html> ------=_Part_18225895_1909350189.1343647908904 Content-Type: text/calendar; charset=utf-8; method=REQUEST; name=meeting.ics Content-Transfer-Encoding: 7bit BEGIN:VCALENDAR PRODID:Zimbra-Calendar-Provider VERSION:2.0 METHOD:REQUEST BEGIN:VTIMEZONE TZID:Europe/Belgrade BEGIN:STANDARD DTSTART:19710101T030000 TZOFFSETTO:+0100 TZOFFSETFROM:+0200 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=10;BYDAY=-1SU TZNAME:CET END:STANDARD BEGIN:DAYLIGHT DTSTART:19710101T020000 TZOFFSETTO:+0200 TZOFFSETFROM:+0100 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=-1SU TZNAME:CEST END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT UID:c3ad3a54-435b-4b59-91c8-9a20931a0c43 SUMMARY:oVirt UI Plugins Meeting ATTENDEE;CN=engine-devel;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:engine-devel@ovirt.org ORGANIZER;CN=Vojtech Szocs:mailto:vszocs@redhat.com DTSTART;TZID="Europe/Belgrade":20120731T163000 DTEND;TZID="Europe/Belgrade":20120731T173000 STATUS:CONFIRMED CLASS:PUBLIC X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY TRANSP:OPAQUE LAST-MODIFIED:20120730T113148Z DTSTAMP:20120730T113148Z SEQUENCE:0 DESCRIPTION:The following is a new meeting request:\n\nSubject: oVirt UI Plu gins Meeting \nOrganizer: "Vojtech Szocs" <vszocs(a)redhat.com> \n\nTime: Tues day\, July 31\, 2012\, 4:30:00 PM - 5:30:00 PM GMT +01:00 Belgrade\, Bratisl ava\, Budapest\, Ljubljana\, Prague\n \nInvitees: engine-devel(a)ovirt.org \n\ n\n*~*~*~*~*~*~*~*~*~*\n\nHi guys\, \n\nlet me invite you to a meeting for d iscussing oVirt UI Plugins feature. \n\nTopics covered in this meeting: \n\n * UI Plugins proof-of-concept (PoC): how it works and what are its impli cations \n * Discuss two ways to build plugins\, comparing their pros and cons \n * Decide on next steps for initial UI Plugins implementation \n\ n\n\n\n\n\nHere are the details required for joining the session. \n\nInterc all dial-in numbers can be found at: \nhttps://www.intercallonline.com/portl ets/scheduling/viewNumbers/listNumbersByCode.do?confCode=7128867405 \n\nInte rcall Conference Code ID: 7128867405 # \n\n\n\nRegards\, \nVojtech \n\n X-ALT-DESC;FMTTYPE=text/html:<html><body id='htmlmode'><h3>The following is a new meeting request:</h3>\n\n<p>\n<table border='0'>\n<tr><th align=left>S ubject:</th><td>oVirt UI Plugins Meeting </td></tr>\n<tr><th align=left>Orga nizer:</th><td>"Vojtech Szocs" &lt\;vszocs(a)redhat.com&gt\; </td></tr>\n</tab le>\n<p>\n<table border='0'>\n<tr><th align=left>Time:</th><td>Tuesday\, Jul y 31\, 2012\, 4:30:00 PM - 5:30:00 PM GMT +01:00 Belgrade\, Bratislava\, Bud apest\, Ljubljana\, Prague\n </td></tr></table>\n<p>\n<table border='0'>\n<t r><th align=left>Invitees:</th><td>engine-devel(a)ovirt.org </td></tr>\n</tabl e>\n<div>*~*~*~*~*~*~*~*~*~*</div><br><div style='font-family: times new rom an\,new york\,times\,serif\; font-size: 12pt\; color: #000000'>Hi guys\,<br> <br>let me invite you to a meeting for discussing <span style="font-weight: bold\;">oVirt UI Plugins</span> feature.<br><br>Topics covered in this meeti ng:<br><ul><li>UI Plugins proof-of-concept (PoC): how it works and what are its implications</li><li>Discuss two ways to build plugins\, comparing their pros and cons</li><li>Decide on next steps for initial UI Plugins implement ation</li></ul><p><br></p><hr style="width: 100%\; height: 2px\;"><p><br></p ><p>Here are the details required for joining the session.<br><br>Intercall dial-in numbers can be found at:<br><span class="Object" id="OBJ_PREFIX_DWT2 571_com_zimbra_url"><span class="Object" id="OBJ_PREFIX_DWT1569_com_zimbra_u rl"><a target="_blank" href="https://www.intercallonline.com/portlets/schedu ling/viewNumbers/listNumbersByCode.do?confCode=7128867405">https://www.inter callonline.com/portlets/scheduling/viewNumbers/listNumbersByCode.do?confCode =7128867405</a></span></span><br><br>Intercall Conference Code ID: <span cla ss="" id="OBJ_PREFIX_DWT2572_com_zimbra_phone"><a href="callto:7128867405" t arget="_blank">7128867405</a></span>#</p><p><br></p><hr style="width: 100%\; height: 2px\;"><br>Regards\,<br>Vojtech<br><br></div></body></html> BEGIN:VALARM ACTION:DISPLAY TRIGGER;RELATED=START:-PT5M DESCRIPTION:Reminder END:VALARM END:VEVENT END:VCALENDAR ------=_Part_18225895_1909350189.1343647908904--

1 0

[Engine-devel] Conformining to Java 6 using Animal Sniffer
by Allon Mureinik 29 Jul '12

29 Jul '12

Hi guys, As you may recall, a couple of weeks ago it was decided (in this mailing list), that we want to preserve backwards compatibility to Java 6. Instead of having to install JDK 6 alongside your Java 7, you can now use Animal Sniffer[1] to verify this. Simply run "mvn animal-sniffer:check" before you push, and assuming the build is successful, you're good to go. Note: Animal Sniffer takes about a minute to run, so it was NOT added by default to the "install" target. It is still your responsibility to verify backwards compatibility of you code, this is just a convenient way of doing it. Many thanks to Juan and Doron for their insights and reviews for this patch. -Allon [1] http://mojo.codehaus.org/animal-sniffer-maven-plugin/

1 0

[Engine-devel] FW: Building ovirt engine instructions
by Schoenbrun, Dustin 27 Jul '12

27 Jul '12

Hey All, Ricky sent these out this morning but it never hit the email blaster. I'm forwarding these on his behalf. If you have questions, please let either Ricky or I know. Thanks! -- Dustin Through some experimentation, I found a list of steps that seems to fix everything on my machines: restapi-definition -> project -> properties -> java build path -> source -> add source folder -> target/generated-sources/xjc webadmin -> project -> properties -> java build path -> source -> add source folder -> target/generated-sources/{annotations,gwt} frontend -> project -> properties -> java build path -> source -> add source folder -> target/generated-sources/gwt gwt-common -> project -> properties -> java build path -> source -> add source folder -> target/generated-sources/annotations userportal -> project -> properties -> java build path -> source -> add source folder -> target/generated-sources/{annotations,gwt} These make sure there can't be any cycles introduced, and resolve all errors in the projects. Let me know if any of this doesn't work for you. - Ricky On 7/27/12 7:03 AM, "Costea, George" <George.Costea(a)netapp.com> wrote: >I get to the step that reads, "Change project settings to Resolve >compilation errors." > >After completing the first 3 steps below: > > restapi-definition -> project -> properties -> java build path -> >source -> add source folder -> target/generated-sources/xjc > webadmin -> project -> properties -> java build path -> source -> >add source folder-> >target/generated-sources/{annotations,gwt,test-annotations} > frontend -> project -> properties -> java build path -> source -> >add source folder-> target/generated-sources/gwt > >I am left with 181 Errors. I then try the 4th step: > > frontend -> project -> properties -> Projects -> Add -> webadmin > >This introduces 5 errors stating, "A cycle was detected in the build path >of project 'frontend'/'gwt-common'/'uicommonweb'/'userportal'/'webadmin'. > The cycle consists of projects {frontend, webadmin, uicommonweb, >gwt-common, userportal}" > >I then try the 5th step: > > sharedgwt -> project -> properties -> Projects -> Add -> common > >But there is no sharedgwt project. Does this provide enough detail? > >-----Original Message----- >From: engine-devel-bounces(a)ovirt.org >[mailto:engine-devel-bounces@ovirt.org] On Behalf Of Yair Zaslavsky >Sent: Friday, July 27, 2012 1:13 AM >To: engine-devel(a)ovirt.org >Subject: Re: [Engine-devel] Building ovirt engine instructions > >On 07/27/2012 12:58 AM, Costea, George wrote: >> It works fine from the CLI (I was running out of memory). I'm still >>getting an issue with Eclipse though about a cycle being detected from >>the build path. > >Please elaborate on this cyclic dependency (I guess this is the issue, >right?) > >What matters the most is that you can build from CLI. >Some of the oVirt engine mantainers do not build from Eclipse (I >personally find the maven plugin to be too buggy) , but it's a matter of >personal preference. We will try to help you regardlessly > >Yair > >> >> -----Original Message----- >> From: Oved Ourfalli [mailto:ovedo@redhat.com] >> Sent: Thursday, July 26, 2012 5:34 PM >> To: Costea, George >> Cc: engine-devel(a)ovirt.org >> Subject: Re: [Engine-devel] Building ovirt engine instructions >> >> >> >> ----- Original Message ----- >>> From: "George Costea"<George.Costea(a)netapp.com> >>> To: engine-devel(a)ovirt.org >>> Sent: Thursday, July 26, 2012 11:33:04 PM >>> Subject: [Engine-devel] Building ovirt engine instructions >>> >>> >>> >>> >>> >>> I think the wiki page ( >>> http://wiki.ovirt.org/wiki/Building_Ovirt_Engine ) to build the ovirt >>> engine is outdated. When I reach the deploy section, it always fails. >>> Is there an update to get the ear file deployed? >>> >>> >> Can you elaborate more on the issue? What's the exact failure/error you >>see when deploying? >> >>> >>> The Eclipse instructions ( >>> http://wiki.ovirt.org/wiki/Building_Ovirt_Engine/IDE ) also seem to >>> be out of date. When I follow the steps to change project settings, I >>> get an error stating that ³A cycle was detected in the build path of >>> the project...² Could we get an update on this too? >>> >>> >>> >>> Thanks, >>> >>> George >>> >>> >>> _______________________________________________ >>> Engine-devel mailing list >>> Engine-devel(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>> >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel > >_______________________________________________ >Engine-devel mailing list >Engine-devel(a)ovirt.org >http://lists.ovirt.org/mailman/listinfo/engine-devel >_______________________________________________ >Engine-devel mailing list >Engine-devel(a)ovirt.org >http://lists.ovirt.org/mailman/listinfo/engine-devel

1 0

[Engine-devel] Building ovirt engine instructions
by Costea, George 27 Jul '12

27 Jul '12

--_000_6C8AC8C50E170C4E9B44D47B39B24A480126CBF9SACEXCMBX04PRDh_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think the wiki page (http://wiki.ovirt.org/wiki/Building_Ovirt_Engine) to= build the ovirt engine is outdated. When I reach the deploy section, it a= lways fails. Is there an update to get the ear file deployed? The Eclipse instructions (http://wiki.ovirt.org/wiki/Building_Ovirt_Engine/= IDE) also seem to be out of date. When I follow the steps to change projec= t settings, I get an error stating that "A cycle was detected in the build = path of the project..." Could we get an update on this too? Thanks, George --_000_6C8AC8C50E170C4E9B44D47B39B24A480126CBF9SACEXCMBX04PRDh_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> <p class=3D"MsoNormal">I think the wiki page (<a href=3D"http://wiki.ovirt.= org/wiki/Building_Ovirt_Engine">http://wiki.ovirt.org/wiki/Building_Ovirt_E= ngine</a>) to build the ovirt engine is outdated.  When I reach the de= ploy section, it always fails.  Is there an update to get the ear file deployed?<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">The Eclipse instructions (<a href=3D"http://wiki.ovi= rt.org/wiki/Building_Ovirt_Engine/IDE">http://wiki.ovirt.org/wiki/Building_= Ovirt_Engine/IDE</a>) also seem to be out of date.  When I follow the = steps to change project settings, I get an error stating that “A cycle was detected in the build path of the pr= oject...”  Could we get an update on this too?<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">Thanks,<o:p></o:p></p> <p class=3D"MsoNormal">George <o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> </body> </html> --_000_6C8AC8C50E170C4E9B44D47B39B24A480126CBF9SACEXCMBX04PRDh_--

6 9

[Engine-devel] oVirt UI Plugins: Update on current progress
by Vojtech Szocs 27 Jul '12

27 Jul '12

--=_156c716f-6003-47a3-bcaa-20301ab51501 Content-Type: multipart/alternative; boundary="=_1a8d4419-a4c3-4d94-96e2-c9d519481224" --=_1a8d4419-a4c3-4d94-96e2-c9d519481224 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi guys, I've spent some time working on UI Plugins proof-of-concept (PoC) implement= ation, and thought I'd share my results with you. I've attached a patch tha= t reflects the current progress. The actual PoC implementation takes some inspiration from oVirt UI Plugins = wiki page, and simplifies/streamlines/improves its main concepts. The goal = is to have simple-to-use, yet flexible and robust plugin infrastructure. Ma= jor changes to the original design are outlined below. Each UI plugin runs within the context of an iframe, and therefore requires= a plugin source page that executes the actual plugin code. =E2=80=A2 iframe is essentially the sandbox for each plugin. We can dis= able plugins by detaching their iframe elements from the main document duri= ng WebAdmin runtime. This also allows us to implement features such as plug= in safe mode (no plugins loaded on WebAdmin startup). =E2=80=A2 Plugin source pages and WebAdmin host page share the same ori= gin (protocol, domain, port), with plugin source pages being served through= EngineManager application server (JBoss AS). This is to avoid cross-domain= window/iframe communication issues, when the actual plugin code running in= an iframe tries to register itself into WebAdmin main document's pluginApi= object. =E2=80=A2 There's a servlet designed to render plugin source page for a= ll plugins ( PluginSourcePageServlet ). For the given plugin, it detects it= s dependencies (3rd party JavaScript libraries) and configuration object (J= SON data), reads the actual plugin code, and assembles everything into the = resulting HTML page (to be evaluated by the plugin iframe). =E2=80=A2 iframe isolates plugin dependencies (3rd party JavaScript lib= raries) from other plugins and the main WebAdmin document. In practice, thi= s means that plugin A can use jQuery 1.7 and plugin B can use jQuery 1.6 wi= thout the fear of any clashes. =E2=80=A2 Last but not least, writing plugins in Google Web Toolkit (GW= T) should be as easy as providing your own plugin source page. Just deploy = your GWT plugin application on JBoss AS (next to engine.ear ), and point to= GWT plugin application host page. The current PoC declares a simple plugin that gets loaded using hard-coded = values in PluginSourcePageServlet . Actual plugin code registers the plugin= into global pluginApi.plugins object, with one sample event handler functi= on ( ActionButtonClick ). Just after that, the plugin reports in as ready b= y calling pluginApi.ready function. This essentially puts the plugin into u= se within WebAdmin. To simulate extension point (application event to be consumed by plugins), = when the user clicks "New server" button on "Virtual Machines" main tab, Ac= tionButtonClickEvent gets fired through WebAdmin event bus. PluginEventHand= ler receives this event and invokes ActionButtonClick event handler functio= n on all plugins. (Note: for passing context objects from WebAdmin to plugin event handler fu= nctions, I'm planning to experiment with gwt-exporter project [1]. This wou= ld greatly simplify the way how WebAdmin exposes context-specific plugin AP= I to event handler functions.) As for the next step, I suggest to have some meeting (conference) to discus= s the PoC in detail, and outline tasks for the near future. Also, please le= t me know what you think of the PoC so far. Cheers, Vojtech [1] http://code.google.com/p/gwt-exporter/ --=_1a8d4419-a4c3-4d94-96e2-c9d519481224 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head><style type=3D'text/css'>p { margin: 0; }</style></head><body><= div style=3D'font-family: Times New Roman; font-size: 12pt; color: #000000'= >Hi guys,<br><br>I've spent some time working on UI Plugins proof-of-concep= t (PoC) implementation, and thought I'd share my results with you. I've att= ached a patch that reflects the current progress. <br><br>The actual PoC im= plementation takes some inspiration from oVirt UI Plugins wiki page, and si= mplifies/streamlines/improves its main concepts. The goal is to have simple= -to-use, yet flexible and robust plugin infrastructure. Major changes to th= e original design are outlined below.<br><br><strong>Each UI plugin runs wi= thin the context of an iframe, and therefore requires a </strong><span styl= e=3D"font-style: italic; font-weight: bold;">plugin source page</span><span= style=3D"font-weight: bold;"> that executes the actual plugin code.</span>= <br><ul><li>iframe is essentially the sandbox for each plugin. We can disab= le plugins by detaching their iframe elements from the main document during= WebAdmin runtime. This also allows us to implement features such as <em>pl= ugin safe mode</em> (no plugins loaded on WebAdmin startup).</li><li>Plugin= source pages and WebAdmin host page share the same origin (protocol, domai= n, port), with plugin source pages being served through EngineManager appli= cation server (JBoss AS). This is to avoid cross-domain window/iframe commu= nication issues, when the actual plugin code running in an iframe tries to = register itself into WebAdmin main document's <span style=3D"font-style: it= alic;">pluginApi</span> object.</li><li>There's a servlet designed to rende= r plugin source page for all plugins (<span style=3D"font-style: italic;">P= luginSourcePageServlet</span>). For the given plugin, it detects its depend= encies (3rd party JavaScript libraries) and configuration object (JSON data= ), reads the actual plugin code, and assembles everything into the resultin= g HTML page (to be evaluated by the plugin iframe).</li><li>iframe isolates= plugin dependencies (3rd party JavaScript libraries) from other plugins an= d the main WebAdmin document. In practice, this means that plugin A can use= jQuery 1.7 and plugin B can use jQuery 1.6 without the fear of any clashes= .</li><li>Last but not least, writing plugins in Google Web Toolkit (GWT) s= hould be as easy as providing your own plugin source page. Just deploy your= GWT plugin application on JBoss AS (next to <span style=3D"font-style: ita= lic;">engine.ear</span>), and point to GWT plugin application host page.<br= ></li></ul><p>The current PoC declares a simple plugin that gets loaded usi= ng hard-coded values in <span style=3D"font-style: italic;">PluginSourcePag= eServlet</span>. Actual plugin code registers the plugin into global <span = style=3D"font-style: italic;">pluginApi.plugins</span> object, with one sam= ple event handler function (<span style=3D"font-style: italic;">ActionButto= nClick</span>). Just after that, the plugin reports in as ready by calling = <span style=3D"font-style: italic;">pluginApi.ready</span> function. This e= ssentially puts the plugin into use within WebAdmin.<br></p><p><br></p>To s= imulate extension point (application event to be consumed by plugins), when= the user clicks "New server" button on "Virtual Machines" main tab, <span = style=3D"font-style: italic;">ActionButtonClickEvent</span> gets fired thro= ugh WebAdmin event bus. <span style=3D"font-style: italic;">PluginEventHand= ler</span> receives this event and invokes <span style=3D"font-style: itali= c;">ActionButtonClick</span> event handler function on all plugins.<br><p><= br></p><p>(Note: for passing context objects from WebAdmin to plugin event = handler functions, I'm planning to experiment with gwt-exporter project [1]= . This would greatly simplify the way how WebAdmin exposes context-specific= plugin API to event handler functions.)</p><p><br></p><p>As for the next s= tep, I suggest to have some meeting (conference) to discuss the PoC in deta= il, and outline tasks for the near future. Also, please let me know what yo= u think of the PoC so far.<br></p><br>Cheers,<br>Vojtech<br><br>[1] http://= code.google.com/p/gwt-exporter/<p><br></p><p></p></div></body></html> --=_1a8d4419-a4c3-4d94-96e2-c9d519481224-- --=_156c716f-6003-47a3-bcaa-20301ab51501 Content-Type: text/x-patch; name=WIP-UI-Plugins-PoC.patch Content-Disposition: attachment; filename=WIP-UI-Plugins-PoC.patch Content-Transfer-Encoding: base64 RnJvbSA5NGM0NThkYzk4NThlZTcyMjBhY2Y1MzMyNDU0NGI5ODE0MGM3NTJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWb2p0ZWNoIFN6b2NzIDx2c3pvY3NAcmVkaGF0LmNvbT4KRGF0 ZTogVGh1LCAxOSBKdWwgMjAxMiAxNDo0ODo0MCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFdJUDog VUkgUGx1Z2lucyBQb0MKCkNoYW5nZS1JZDogSWQyODgxMmRkYmU5MDU3NGRlMDE3OGYwYzA3ZGE3 MTNmZTlmZDhjZGEKU2lnbmVkLW9mZi1ieTogVm9qdGVjaCBTem9jcyA8dnN6b2NzQHJlZGhhdC5j b20+Ci0tLQogLi4uL3NlcnZlci9nd3QvUGx1Z2luU291cmNlUGFnZVNlcnZsZXQuamF2YSAgICAg ICAgfCAgIDQxICsrKysrKwogLi4uL3NlcnZlci9nd3QvV2ViYWRtaW5EeW5hbWljSG9zdGluZ1Nl cnZsZXQuamF2YSAgfCAgICA0ICsKIC4uLi9vdmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vZ2luL1N5 c3RlbU1vZHVsZS5qYXZhIHwgICAgNCArCiAuLi4vdWkvd2ViYWRtaW4vcGx1Z2luL1BsdWdpbkFw aU1hbmFnZXIuamF2YSAgICAgICB8ICAxNDMgKysrKysrKysrKysrKysrKysrKysKIC4uLi91aS93 ZWJhZG1pbi9wbHVnaW4vUGx1Z2luRGVmaW5pdGlvbnMuamF2YSAgICAgIHwgICAzMCArKysrCiAu Li4vdWkvd2ViYWRtaW4vcGx1Z2luL1BsdWdpbkV2ZW50SGFuZGxlci5qYXZhICAgICB8ICAgMjQg KysrKwogLi4uL3dlYmFkbWluL3BsdWdpbi9ldmVudC9BY3Rpb25CdXR0b25DbGljay5qYXZhICAg fCAgICA4ICsKIC4uLi9tYWluL3ZpZXcvdGFiL01haW5UYWJWaXJ0dWFsTWFjaGluZVZpZXcuamF2 YSAgIHwgICAgOCArCiAuLi4vd2ViYWRtaW4vc3JjL21haW4vd2ViYXBwL1dFQi1JTkYvd2ViLnht bCAgICAgICB8ICAgMTAgKysKIDkgZmlsZXMgY2hhbmdlZCwgMjcyIGluc2VydGlvbnMoKyksIDAg ZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxl cy9mcm9udGVuZC9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvZnJvbnRlbmQvc2Vy dmVyL2d3dC9QbHVnaW5Tb3VyY2VQYWdlU2VydmxldC5qYXZhCiBjcmVhdGUgbW9kZSAxMDA2NDQg ZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJhZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9vdmly dC9lbmdpbmUvdWkvd2ViYWRtaW4vcGx1Z2luL1BsdWdpbkFwaU1hbmFnZXIuamF2YQogY3JlYXRl IG1vZGUgMTAwNjQ0IGZyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRtaW4vc3JjL21haW4v amF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL3dlYmFkbWluL3BsdWdpbi9QbHVnaW5EZWZpbml0aW9u cy5qYXZhCiBjcmVhdGUgbW9kZSAxMDA2NDQgZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJh ZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vcGx1Z2luL1Bs dWdpbkV2ZW50SGFuZGxlci5qYXZhCiBjcmVhdGUgbW9kZSAxMDA2NDQgZnJvbnRlbmQvd2ViYWRt aW4vbW9kdWxlcy93ZWJhZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvd2Vi YWRtaW4vcGx1Z2luL2V2ZW50L0FjdGlvbkJ1dHRvbkNsaWNrLmphdmEKCmRpZmYgLS1naXQgYS9m cm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL2Zyb250ZW5kL3NyYy9tYWluL2phdmEvb3JnL292aXJ0 L2VuZ2luZS91aS9mcm9udGVuZC9zZXJ2ZXIvZ3d0L1BsdWdpblNvdXJjZVBhZ2VTZXJ2bGV0Lmph dmEgYi9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL2Zyb250ZW5kL3NyYy9tYWluL2phdmEvb3Jn L292aXJ0L2VuZ2luZS91aS9mcm9udGVuZC9zZXJ2ZXIvZ3d0L1BsdWdpblNvdXJjZVBhZ2VTZXJ2 bGV0LmphdmEKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzQwOGQ4ZQotLS0g L2Rldi9udWxsCisrKyBiL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvZnJvbnRlbmQvc3JjL21h aW4vamF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL2Zyb250ZW5kL3NlcnZlci9nd3QvUGx1Z2luU291 cmNlUGFnZVNlcnZsZXQuamF2YQpAQCAtMCwwICsxLDQxIEBACitwYWNrYWdlIG9yZy5vdmlydC5l bmdpbmUudWkuZnJvbnRlbmQuc2VydmVyLmd3dDsKKworaW1wb3J0IGphdmEuaW8uSU9FeGNlcHRp b247CitpbXBvcnQgamF2YS5pby5QcmludFdyaXRlcjsKKworaW1wb3J0IGphdmF4LnNlcnZsZXQu aHR0cC5IdHRwU2VydmxldDsKK2ltcG9ydCBqYXZheC5zZXJ2bGV0Lmh0dHAuSHR0cFNlcnZsZXRS ZXF1ZXN0OworaW1wb3J0IGphdmF4LnNlcnZsZXQuaHR0cC5IdHRwU2VydmxldFJlc3BvbnNlOwor CisvKioKKyAqIFJlbmRlcnMgdGhlIEhUTUwgc291cmNlIHBhZ2UgZm9yIHRoZSBnaXZlbiBVSSBw bHVnaW4uCisgKi8KK3B1YmxpYyBjbGFzcyBQbHVnaW5Tb3VyY2VQYWdlU2VydmxldCBleHRlbmRz IEh0dHBTZXJ2bGV0IHsKKworICAgIHByaXZhdGUgc3RhdGljIGZpbmFsIGxvbmcgc2VyaWFsVmVy c2lvblVJRCA9IDFMOworCisgICAgQE92ZXJyaWRlCisgICAgcHJvdGVjdGVkIHZvaWQgZG9HZXQo SHR0cFNlcnZsZXRSZXF1ZXN0IHJlcXVlc3QsIEh0dHBTZXJ2bGV0UmVzcG9uc2UgcmVzcG9uc2Up IHRocm93cyBJT0V4Y2VwdGlvbiB7CisgICAgICAgIFByaW50V3JpdGVyIHdyaXRlciA9IHJlc3Bv bnNlLmdldFdyaXRlcigpOworICAgICAgICByZXNwb25zZS5zZXRDb250ZW50VHlwZSgidGV4dC9o dG1sOyBjaGFyc2V0PVVURi04Iik7IC8vJE5PTi1OTFMtMSQKKworICAgICAgICB3cml0ZXIuYXBw ZW5kKCI8IURPQ1RZUEUgaHRtbD48aHRtbD48aGVhZD4iKTsgLy8kTk9OLU5MUy0xJAorICAgICAg ICB3cml0ZXIuYXBwZW5kKCI8bWV0YSBodHRwLWVxdWl2PVwiY29udGVudC10eXBlXCIgY29udGVu dD1cInRleHQvaHRtbDsgY2hhcnNldD1VVEYtOFwiPiIpOyAvLyROT04tTkxTLTEkCisgICAgICAg IHdyaXRlci5hcHBlbmQoIjxzY3JpcHQgdHlwZT1cInRleHQvamF2YXNjcmlwdFwiIHNyYz1cImh0 dHBzOi8vYWpheC5nb29nbGVhcGlzLmNvbS9hamF4L2xpYnMvanF1ZXJ5LzEuNy4yL2pxdWVyeS5t aW4uanNcIj48L3NjcmlwdD4iKTsgLy8kTk9OLU5MUy0xJAorICAgICAgICB3cml0ZXIuYXBwZW5k KCI8L2hlYWQ+PGJvZHk+Iik7IC8vJE5PTi1OTFMtMSQKKworICAgICAgICB3cml0ZXIuYXBwZW5k KCI8c2NyaXB0IHR5cGU9XCJ0ZXh0L2phdmFzY3JpcHRcIj4iKTsgLy8kTk9OLU5MUy0xJAorICAg ICAgICB3cml0ZXIuYXBwZW5kKCIoZnVuY3Rpb24oIHBsdWdpbkFwaSwgcGx1Z2luQ29uZmlnICkg eyIpOyAvLyROT04tTkxTLTEkCisgICAgICAgIHdyaXRlci5hcHBlbmQoIiAgd2luZG93LmFsZXJ0 KCdJbnZva2luZyBhY3R1YWwgcGx1Z2luIGNvZGUhJyk7Iik7IC8vJE5PTi1OTFMtMSQKKyAgICAg ICAgd3JpdGVyLmFwcGVuZCgiICB3aW5kb3cuYWxlcnQoJ1JlYWRpbmcgcGx1Z2luIGNvbmZpZ3Vy YXRpb246ICcgKyBwbHVnaW5Db25maWcuZm9vKTsiKTsgLy8kTk9OLU5MUy0xJAorICAgICAgICB3 cml0ZXIuYXBwZW5kKCIgIHBsdWdpbkFwaS5wbHVnaW5zWydteVBsdWdpbiddID0geyIpOyAvLyRO T04tTkxTLTEkCisgICAgICAgIHdyaXRlci5hcHBlbmQoIiAgICBBY3Rpb25CdXR0b25DbGljazog ZnVuY3Rpb24oY29udGV4dE9iamVjdCkgeyB3aW5kb3cuYWxlcnQoJ1dvb2hvbyEnKTsgfSIpOyAv LyROT04tTkxTLTEkCisgICAgICAgIHdyaXRlci5hcHBlbmQoIiAgfTsiKTsgLy8kTk9OLU5MUy0x JAorICAgICAgICB3cml0ZXIuYXBwZW5kKCIgIHBsdWdpbkFwaS5yZWFkeSgnbXlQbHVnaW4nKTsi KTsgLy8kTk9OLU5MUy0xJAorICAgICAgICB3cml0ZXIuYXBwZW5kKCJ9KSAoIHBhcmVudC5wbHVn aW5BcGksIHsgXCJmb29cIjogMTIzIH0gKTsiKTsgLy8kTk9OLU5MUy0xJAorICAgICAgICB3cml0 ZXIuYXBwZW5kKCI8L3NjcmlwdD4iKTsgLy8kTk9OLU5MUy0xJAorCisgICAgICAgIHdyaXRlci5h cHBlbmQoIjwvYm9keT48L2h0bWw+Iik7IC8vJE5PTi1OTFMtMSQKKyAgICB9CisKK30KZGlmZiAt LWdpdCBhL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvZnJvbnRlbmQvc3JjL21haW4vamF2YS9v cmcvb3ZpcnQvZW5naW5lL3VpL2Zyb250ZW5kL3NlcnZlci9nd3QvV2ViYWRtaW5EeW5hbWljSG9z dGluZ1NlcnZsZXQuamF2YSBiL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvZnJvbnRlbmQvc3Jj L21haW4vamF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL2Zyb250ZW5kL3NlcnZlci9nd3QvV2ViYWRt aW5EeW5hbWljSG9zdGluZ1NlcnZsZXQuamF2YQppbmRleCA0MjhkY2M1Li5kY2FmNDlhIDEwMDY0 NAotLS0gYS9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL2Zyb250ZW5kL3NyYy9tYWluL2phdmEv b3JnL292aXJ0L2VuZ2luZS91aS9mcm9udGVuZC9zZXJ2ZXIvZ3d0L1dlYmFkbWluRHluYW1pY0hv c3RpbmdTZXJ2bGV0LmphdmEKKysrIGIvZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy9mcm9udGVu ZC9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvZnJvbnRlbmQvc2VydmVyL2d3dC9X ZWJhZG1pbkR5bmFtaWNIb3N0aW5nU2VydmxldC5qYXZhCkBAIC0zNiw2ICszNiwxMCBAQCBwdWJs aWMgY2xhc3MgV2ViYWRtaW5EeW5hbWljSG9zdGluZ1NlcnZsZXQgZXh0ZW5kcyBHd3REeW5hbWlj SG9zdFBhZ2VTZXJ2bGV0IHsKICAgICAgICAgICAgIGFwcE1vZGVEYXRhLnB1dCgidmFsdWUiLCBT dHJpbmcudmFsdWVPZihhcHBsaWNhdGlvbk1vZGUpKTsgLy8kTk9OLU5MUy0xJAogICAgICAgICAg ICAgd3JpdGVKc09iamVjdCh3cml0ZXIsICJhcHBsaWNhdGlvbk1vZGUiLCBhcHBNb2RlRGF0YSk7 IC8vJE5PTi1OTFMtMSQKICAgICAgICAgfQorCisgICAgICAgIE1hcDxTdHJpbmcsIFN0cmluZz4g cGx1Z2luRGVmaW5pdGlvbnMgPSBuZXcgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4oKTsKKyAgICAg ICAgcGx1Z2luRGVmaW5pdGlvbnMucHV0KCJteVBsdWdpbiIsICIvd2ViYWRtaW4vd2ViYWRtaW4v UGx1Z2luU291cmNlUGFnZT9wbHVnaW49bXlQbHVnaW4iKTsgLy8kTk9OLU5MUy0xJCAvLyROT04t TkxTLTIkCisgICAgICAgIHdyaXRlSnNPYmplY3Qod3JpdGVyLCAicGx1Z2luRGVmaW5pdGlvbnMi LCBwbHVnaW5EZWZpbml0aW9ucyk7IC8vJE5PTi1OTFMtMSQKICAgICB9CiAKICAgICBwcml2YXRl IEludGVnZXIgZ2V0QXBwbGljYXRpb25Nb2RlKEh0dHBTZXJ2bGV0UmVxdWVzdCByZXF1ZXN0KSB7 CmRpZmYgLS1naXQgYS9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL3dlYmFkbWluL3NyYy9tYWlu L2phdmEvb3JnL292aXJ0L2VuZ2luZS91aS93ZWJhZG1pbi9naW4vU3lzdGVtTW9kdWxlLmphdmEg Yi9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL3dlYmFkbWluL3NyYy9tYWluL2phdmEvb3JnL292 aXJ0L2VuZ2luZS91aS93ZWJhZG1pbi9naW4vU3lzdGVtTW9kdWxlLmphdmEKaW5kZXggMzA2OWI5 OS4uNzg5NjNhZCAxMDA2NDQKLS0tIGEvZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJhZG1p bi9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vZ2luL1N5c3RlbU1v ZHVsZS5qYXZhCisrKyBiL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRtaW4vc3JjL21h aW4vamF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL3dlYmFkbWluL2dpbi9TeXN0ZW1Nb2R1bGUuamF2 YQpAQCAtOSw2ICs5LDggQEAgaW1wb3J0IG9yZy5vdmlydC5lbmdpbmUudWkud2ViYWRtaW4uQXBw bGljYXRpb25SZXNvdXJjZXM7CiBpbXBvcnQgb3JnLm92aXJ0LmVuZ2luZS51aS53ZWJhZG1pbi5B cHBsaWNhdGlvblRlbXBsYXRlczsKIGltcG9ydCBvcmcub3ZpcnQuZW5naW5lLnVpLndlYmFkbWlu LnBsYWNlLkFwcGxpY2F0aW9uUGxhY2VzOwogaW1wb3J0IG9yZy5vdmlydC5lbmdpbmUudWkud2Vi YWRtaW4ucGxhY2UuV2ViQWRtaW5QbGFjZU1hbmFnZXI7CitpbXBvcnQgb3JnLm92aXJ0LmVuZ2lu ZS51aS53ZWJhZG1pbi5wbHVnaW4uUGx1Z2luQXBpTWFuYWdlcjsKK2ltcG9ydCBvcmcub3ZpcnQu ZW5naW5lLnVpLndlYmFkbWluLnBsdWdpbi5QbHVnaW5FdmVudEhhbmRsZXI7CiBpbXBvcnQgb3Jn Lm92aXJ0LmVuZ2luZS51aS53ZWJhZG1pbi5zeXN0ZW0uQXBwbGljYXRpb25Jbml0OwogaW1wb3J0 IG9yZy5vdmlydC5lbmdpbmUudWkud2ViYWRtaW4uc3lzdGVtLkludGVybmFsQ29uZmlndXJhdGlv bjsKIApAQCAtMzEsNiArMzMsOCBAQCBwdWJsaWMgY2xhc3MgU3lzdGVtTW9kdWxlIGV4dGVuZHMg QmFzZVN5c3RlbU1vZHVsZSB7CiAgICAgICAgIGJpbmQoUGxhY2VNYW5hZ2VyLmNsYXNzKS50byhX ZWJBZG1pblBsYWNlTWFuYWdlci5jbGFzcykuaW4oU2luZ2xldG9uLmNsYXNzKTsKICAgICAgICAg YmluZChBcHBsaWNhdGlvbkluaXQuY2xhc3MpLmFzRWFnZXJTaW5nbGV0b24oKTsKICAgICAgICAg YmluZChJbnRlcm5hbENvbmZpZ3VyYXRpb24uY2xhc3MpLmFzRWFnZXJTaW5nbGV0b24oKTsKKyAg ICAgICAgYmluZChQbHVnaW5BcGlNYW5hZ2VyLmNsYXNzKS5hc0VhZ2VyU2luZ2xldG9uKCk7Cisg ICAgICAgIGJpbmQoUGx1Z2luRXZlbnRIYW5kbGVyLmNsYXNzKS5hc0VhZ2VyU2luZ2xldG9uKCk7 CiAgICAgfQogCiAgICAgdm9pZCBiaW5kQ29uZmlndXJhdGlvbigpIHsKZGlmZiAtLWdpdCBhL2Zy b250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRtaW4vc3JjL21haW4vamF2YS9vcmcvb3ZpcnQv ZW5naW5lL3VpL3dlYmFkbWluL3BsdWdpbi9QbHVnaW5BcGlNYW5hZ2VyLmphdmEgYi9mcm9udGVu ZC93ZWJhZG1pbi9tb2R1bGVzL3dlYmFkbWluL3NyYy9tYWluL2phdmEvb3JnL292aXJ0L2VuZ2lu ZS91aS93ZWJhZG1pbi9wbHVnaW4vUGx1Z2luQXBpTWFuYWdlci5qYXZhCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLjBiYmRkNjgKLS0tIC9kZXYvbnVsbAorKysgYi9mcm9udGVu ZC93ZWJhZG1pbi9tb2R1bGVzL3dlYmFkbWluL3NyYy9tYWluL2phdmEvb3JnL292aXJ0L2VuZ2lu ZS91aS93ZWJhZG1pbi9wbHVnaW4vUGx1Z2luQXBpTWFuYWdlci5qYXZhCkBAIC0wLDAgKzEsMTQz IEBACitwYWNrYWdlIG9yZy5vdmlydC5lbmdpbmUudWkud2ViYWRtaW4ucGx1Z2luOworCitpbXBv cnQgamF2YS51dGlsLkhhc2hNYXA7CitpbXBvcnQgamF2YS51dGlsLk1hcDsKK2ltcG9ydCBqYXZh LnV0aWwubG9nZ2luZy5Mb2dnZXI7CisKK2ltcG9ydCBjb20uZ29vZ2xlLmd3dC5jb3JlLmNsaWVu dC5KYXZhU2NyaXB0T2JqZWN0OworaW1wb3J0IGNvbS5nb29nbGUuZ3d0LmNvcmUuY2xpZW50Lkpz QXJyYXlTdHJpbmc7CitpbXBvcnQgY29tLmdvb2dsZS5nd3QuZG9tLmNsaWVudC5Eb2N1bWVudDsK K2ltcG9ydCBjb20uZ29vZ2xlLmd3dC5kb20uY2xpZW50LklGcmFtZUVsZW1lbnQ7CitpbXBvcnQg Y29tLmdvb2dsZS5nd3QuZG9tLmNsaWVudC5TdHlsZS5Cb3JkZXJTdHlsZTsKK2ltcG9ydCBjb20u Z29vZ2xlLmd3dC5kb20uY2xpZW50LlN0eWxlLlBvc2l0aW9uOworaW1wb3J0IGNvbS5nb29nbGUu Z3d0LmRvbS5jbGllbnQuU3R5bGUuVW5pdDsKKworLyoqCisgKiBUaGUgbWFpbiBjb21wb25lbnQg b2YgV2ViQWRtaW4gVUkgcGx1Z2luIGluZnJhc3RydWN0dXJlLgorICogPHA+CisgKiBTaG91bGQg YmUgYm91bmQgYXMgR0lOIGVhZ2VyIHNpbmdsZXRvbiwgY3JlYXRlZCBlYXJseSBvbiBkdXJpbmcg YXBwbGljYXRpb24gc3RhcnR1cC4KKyAqLworcHVibGljIGNsYXNzIFBsdWdpbkFwaU1hbmFnZXIg eworCisgICAgcHJpdmF0ZSBzdGF0aWMgZmluYWwgTG9nZ2VyIGxvZ2dlciA9IExvZ2dlci5nZXRM b2dnZXIoUGx1Z2luQXBpTWFuYWdlci5jbGFzcy5nZXROYW1lKCkpOworCisgICAgLy8gTWFwcyBw bHVnaW4gbmFtZXMgdG8gY29ycmVzcG9uZGluZyBpZnJhbWUgZWxlbWVudHMKKyAgICBwcml2YXRl IGZpbmFsIE1hcDxTdHJpbmcsIElGcmFtZUVsZW1lbnQ+IHBsdWdpbklGcmFtZXMgPSBuZXcgSGFz aE1hcDxTdHJpbmcsIElGcmFtZUVsZW1lbnQ+KCk7CisKKyAgICAvLyBNYXBzIHBsdWdpbiBuYW1l cyB0byBjb3JyZXNwb25kaW5nIHBsdWdpbiBvYmplY3RzIChvbmx5IGZvciBwbHVnaW5zIHdoaWNo IGFyZSBjdXJyZW50bHkgcmVhZHkpCisgICAgcHJpdmF0ZSBmaW5hbCBNYXA8U3RyaW5nLCBKYXZh U2NyaXB0T2JqZWN0PiBwbHVnaW5PYmplY3RzID0gbmV3IEhhc2hNYXA8U3RyaW5nLCBKYXZhU2Ny aXB0T2JqZWN0PigpOworCisgICAgcHVibGljIFBsdWdpbkFwaU1hbmFnZXIoKSB7CisgICAgICAg IGV4cG9zZVBsdWdpbkFwaSgpOworICAgICAgICBsb2FkUGx1Z2lucygpOworICAgIH0KKworICAg IC8qKgorICAgICAqIEludm9rZXMgdGhlIGdpdmVuIGV2ZW50IGhhbmRsZXIgZnVuY3Rpb24gb24g YWxsIHBsdWdpbnMgd2hpY2ggYXJlIGN1cnJlbnRseSByZWFkeS4KKyAgICAgKi8KKyAgICBwdWJs aWMgdm9pZCBpbnZva2VQbHVnaW5zKFN0cmluZyBmdW5jdGlvbk5hbWUsIEphdmFTY3JpcHRPYmpl Y3QgY29udGV4dE9iamVjdCkgeworICAgICAgICBmb3IgKEphdmFTY3JpcHRPYmplY3QgcGx1Z2lu T2JqZWN0IDogcGx1Z2luT2JqZWN0cy52YWx1ZXMoKSkgeworICAgICAgICAgICAgaW52b2tlUGx1 Z2luKHBsdWdpbk9iamVjdCwgZnVuY3Rpb25OYW1lLCBjb250ZXh0T2JqZWN0KTsKKyAgICAgICAg fQorICAgIH0KKworICAgIG5hdGl2ZSB2b2lkIGludm9rZVBsdWdpbihKYXZhU2NyaXB0T2JqZWN0 IHBsdWdpbk9iamVjdCwgU3RyaW5nIGZ1bmN0aW9uTmFtZSwgSmF2YVNjcmlwdE9iamVjdCBjb250 ZXh0T2JqZWN0KSAvKi17CisgICAgICAgIGlmIChjb250ZXh0T2JqZWN0ICE9IG51bGwpIHsKKyAg ICAgICAgICAgIHBsdWdpbk9iamVjdFtmdW5jdGlvbk5hbWVdKGNvbnRleHRPYmplY3QpOworICAg ICAgICB9IGVsc2UgeworICAgICAgICAgICAgcGx1Z2luT2JqZWN0W2Z1bmN0aW9uTmFtZV0oKTsK KyAgICAgICAgfQorICAgIH0tKi87CisKKyAgICAvKioKKyAgICAgKiBMb2FkcyBhbGwgcGx1Z2lu cyB0aGF0IHdlcmUgZGV0ZWN0ZWQgd2hlbiBzZXJ2aW5nIFdlYkFkbWluIGhvc3QgcGFnZS4KKyAg ICAgKi8KKyAgICB2b2lkIGxvYWRQbHVnaW5zKCkgeworICAgICAgICBQbHVnaW5EZWZpbml0aW9u cyBkZWZzID0gUGx1Z2luRGVmaW5pdGlvbnMuaW5zdGFuY2UoKTsKKworICAgICAgICBpZiAoZGVm cyAhPSBudWxsKSB7CisgICAgICAgICAgICBKc0FycmF5U3RyaW5nIHBsdWdpbk5hbWVzID0gZGVm cy5nZXRQbHVnaW5OYW1lcygpOworCisgICAgICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IHBs dWdpbk5hbWVzLmxlbmd0aCgpOyBpKyspIHsKKyAgICAgICAgICAgICAgICBTdHJpbmcgbmFtZSA9 IHBsdWdpbk5hbWVzLmdldChpKTsKKyAgICAgICAgICAgICAgICBTdHJpbmcgc291cmNlUGFnZVVy bCA9IGRlZnMuZ2V0UGx1Z2luU291cmNlUGFnZVVybChuYW1lKTsKKworICAgICAgICAgICAgICAg IGxvZ2dlci5pbmZvKCJMb2FkaW5nIHBsdWdpbiBbIiArIG5hbWUgKyAiXSBmcm9tIFVSTCAiICsg c291cmNlUGFnZVVybCk7IC8vJE5PTi1OTFMtMSQgLy8kTk9OLU5MUy0yJAorICAgICAgICAgICAg ICAgIGxvYWRQbHVnaW4obmFtZSwgc291cmNlUGFnZVVybCk7CisgICAgICAgICAgICB9CisgICAg ICAgIH0KKyAgICB9CisKKyAgICAvKioKKyAgICAgKiBMb2FkcyBhIHBsdWdpbiB1c2luZyBpdHMg c291cmNlIHBhZ2UgKEhUTUwgcGFnZSB0aGF0IGV4ZWN1dGVzIHRoZSBhY3R1YWwgcGx1Z2luIGNv ZGUpLgorICAgICAqIDxwPgorICAgICAqIFdlYkFkbWluIHJlcXVpcmVzIGFsbCBwbHVnaW5zIHRv IGhhdmUgYSBzb3VyY2UgcGFnZSBiZWNhdXNlIGVhY2ggcGx1Z2luIHJ1bnMgd2l0aGluIHRoZSBj b250ZXh0IG9mIGFuIGlmcmFtZS4KKyAgICAgKiA8cD4KKyAgICAgKiBOb3RlIHRoYXQgcGx1Z2lu IHNvdXJjZSBwYWdlIFVSTHMgYXJlIGFsd2F5cyByZWxhdGl2ZSB0byBKQm9zcyBzZXJ2ZXIgcm9v dCBwYXRoLiBTb3VyY2UgcGFnZSBVUkxzIG11c3QgdGhlcmVmb3JlCisgICAgICogYWx3YXlzIGJl Z2luIHdpdGggc2xhc2ggKHtAY29kZSAvfSkgY2hhcmFjdGVyLiBUaGlzIGFsbG93cyBXZWJBZG1p biBob3N0IHBhZ2UgYW5kIGluZGl2aWR1YWwgcGx1Z2luIHNvdXJjZSBwYWdlcworICAgICAqIHRv IHNoYXJlIHRoZSBzYW1lIG9yaWdpbiAocHJvdG9jb2wsIGRvbWFpbiwgcG9ydCkgYW5kIGF2b2lk IGNyb3NzLWRvbWFpbiB3aW5kb3cvaWZyYW1lIGNvbW11bmljYXRpb24gaXNzdWVzLgorICAgICAq LworICAgIHZvaWQgbG9hZFBsdWdpbihTdHJpbmcgcGx1Z2luTmFtZSwgU3RyaW5nIHBsdWdpblNv dXJjZVBhZ2VVcmwpIHsKKyAgICAgICAgaWYgKCFwbHVnaW5Tb3VyY2VQYWdlVXJsLnN0YXJ0c1dp dGgoIi8iKSkgeyAvLyROT04tTkxTLTEkCisgICAgICAgICAgICBsb2dnZXIud2FybmluZygiQXR0 ZW1wdGluZyB0byBsb2FkIHBsdWdpbiBbIiArIHBsdWdpbk5hbWUgKyAiXSB1c2luZyBpbnZhbGlk IFVSTCAiICsgcGx1Z2luU291cmNlUGFnZVVybCk7IC8vJE5PTi1OTFMtMSQgLy8kTk9OLU5MUy0y JAorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgaWYgKHBsdWdpbklG cmFtZXMuY29udGFpbnNLZXkocGx1Z2luTmFtZSkpIHsKKyAgICAgICAgICAgIGxvZ2dlci53YXJu aW5nKCJQbHVnaW4gWyIgKyBwbHVnaW5OYW1lICsgIl0gaXMgYWxyZWFkeSBsb2FkZWQiKTsgLy8k Tk9OLU5MUy0xJCAvLyROT04tTkxTLTIkCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0K KworICAgICAgICAvLyBDcmVhdGUgYW4gaWZyYW1lIHVzZWQgdG8gbG9hZCB0aGUgcGx1Z2luIHNv dXJjZSBwYWdlCisgICAgICAgIElGcmFtZUVsZW1lbnQgaWZyYW1lID0gRG9jdW1lbnQuZ2V0KCku Y3JlYXRlSUZyYW1lRWxlbWVudCgpOworICAgICAgICBpZnJhbWUuc2V0U3JjKHBsdWdpblNvdXJj ZVBhZ2VVcmwpOworICAgICAgICBpZnJhbWUuc2V0RnJhbWVCb3JkZXIoMCk7CisgICAgICAgIGlm cmFtZS5nZXRTdHlsZSgpLnNldFBvc2l0aW9uKFBvc2l0aW9uLkFCU09MVVRFKTsKKyAgICAgICAg aWZyYW1lLmdldFN0eWxlKCkuc2V0V2lkdGgoMCwgVW5pdC5QVCk7CisgICAgICAgIGlmcmFtZS5n ZXRTdHlsZSgpLnNldEhlaWdodCgwLCBVbml0LlBUKTsKKyAgICAgICAgaWZyYW1lLmdldFN0eWxl KCkuc2V0Qm9yZGVyU3R5bGUoQm9yZGVyU3R5bGUuTk9ORSk7CisgICAgICAgIHBsdWdpbklGcmFt ZXMucHV0KHBsdWdpbk5hbWUsIGlmcmFtZSk7CisKKyAgICAgICAgLy8gQXR0YWNoIHRoZSBpZnJh bWUgdG8gRE9NIGRvY3VtZW50IGJvZHkKKyAgICAgICAgRG9jdW1lbnQuZ2V0KCkuZ2V0Qm9keSgp LmFwcGVuZENoaWxkKGlmcmFtZSk7CisgICAgfQorCisgICAgLyoqCisgICAgICogSW5kaWNhdGVz IHRoYXQgdGhlIGdpdmVuIHBsdWdpbiBpcyByZWFkeSBmb3IgdXNlLgorICAgICAqIDxwPgorICAg ICAqIE5vdGUgdGhhdCBldmVudCBoYW5kbGVyIGZ1bmN0aW9ucyB3aWxsIGJlIGludm9rZWQgb25s eSBvbiBwbHVnaW5zIHdoaWNoIGFyZSBjdXJyZW50bHkgcmVhZHkuCisgICAgICovCisgICAgdm9p ZCBwbHVnaW5SZWFkeShTdHJpbmcgcGx1Z2luTmFtZSwgSmF2YVNjcmlwdE9iamVjdCBwbHVnaW5P YmplY3QpIHsKKyAgICAgICAgaWYgKHBsdWdpbk5hbWUgPT0gbnVsbCkgeworICAgICAgICAgICAg bG9nZ2VyLndhcm5pbmcoIlBsdWdpbiBuYW1lIGlzIG51bGwgb3IgdW5kZWZpbmVkIik7IC8vJE5P Ti1OTFMtMSQKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAgICAgIGlmICgh cGx1Z2luSUZyYW1lcy5jb250YWluc0tleShwbHVnaW5OYW1lKSkgeworICAgICAgICAgICAgbG9n Z2VyLndhcm5pbmcoIlBsdWdpbiBbIiArIHBsdWdpbk5hbWUgKyAiXSByZXBvcnRzIGluIGFzIHJl YWR5LCBidXQgaGFzIG5vIGlmcmFtZSBhc3NvY2lhdGVkIik7IC8vJE5PTi1OTFMtMSQgLy8kTk9O LU5MUy0yJAorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgcGx1Z2lu T2JqZWN0cy5wdXQocGx1Z2luTmFtZSwgcGx1Z2luT2JqZWN0KTsKKyAgICB9CisKKyAgICBuYXRp dmUgdm9pZCBleHBvc2VQbHVnaW5BcGkoKSAvKi17CisgICAgICAgIHZhciBpbnN0YW5jZSA9IHRo aXM7CisKKyAgICAgICAgLy8gRXhwb3NlIHRoZSBnbG9iYWwgcGx1Z2luQXBpIG9iamVjdAorICAg ICAgICAkd25kLnBsdWdpbkFwaSA9IHsKKworICAgICAgICAgICAgLy8gUGx1Z2lucyB3aWxsIHJl Z2lzdGVyIHRoZW1zZWx2ZXMgaW50byB0aGlzIG9iamVjdCBieSBhZGRpbmcgbmV3IHByb3BlcnR5 OgorICAgICAgICAgICAgLy8gLSBwcm9wZXJ0eSBuYW1lIGlzIHRoZSBuYW1lIG9mIHRoZSBwbHVn aW4KKyAgICAgICAgICAgIC8vIC0gcHJvcGVydHkgdmFsdWUgaXMgdGhlIHBsdWdpbiBvYmplY3Qg Y29udGFpbmluZyBldmVudCBoYW5kbGVyIGZ1bmN0aW9ucworICAgICAgICAgICAgcGx1Z2luczog e30sCisKKyAgICAgICAgICAgIHJlYWR5OiBmdW5jdGlvbihwbHVnaW5OYW1lKSB7CisgICAgICAg ICAgICAgICAgdmFyIHBsdWdpbk9iamVjdCA9IHRoaXMucGx1Z2luc1twbHVnaW5OYW1lXTsKKyAg ICAgICAgICAgICAgICBpbnN0YW5jZS5Ab3JnLm92aXJ0LmVuZ2luZS51aS53ZWJhZG1pbi5wbHVn aW4uUGx1Z2luQXBpTWFuYWdlcjo6cGx1Z2luUmVhZHkoTGphdmEvbGFuZy9TdHJpbmc7TGNvbS9n b29nbGUvZ3d0L2NvcmUvY2xpZW50L0phdmFTY3JpcHRPYmplY3Q7KShwbHVnaW5OYW1lLHBsdWdp bk9iamVjdCk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgfTsKKyAgICB9LSovOworCit9CmRp ZmYgLS1naXQgYS9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL3dlYmFkbWluL3NyYy9tYWluL2ph dmEvb3JnL292aXJ0L2VuZ2luZS91aS93ZWJhZG1pbi9wbHVnaW4vUGx1Z2luRGVmaW5pdGlvbnMu amF2YSBiL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRtaW4vc3JjL21haW4vamF2YS9v cmcvb3ZpcnQvZW5naW5lL3VpL3dlYmFkbWluL3BsdWdpbi9QbHVnaW5EZWZpbml0aW9ucy5qYXZh Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmQxMTE4Y2IKLS0tIC9kZXYvbnVs bAorKysgYi9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL3dlYmFkbWluL3NyYy9tYWluL2phdmEv b3JnL292aXJ0L2VuZ2luZS91aS93ZWJhZG1pbi9wbHVnaW4vUGx1Z2luRGVmaW5pdGlvbnMuamF2 YQpAQCAtMCwwICsxLDMwIEBACitwYWNrYWdlIG9yZy5vdmlydC5lbmdpbmUudWkud2ViYWRtaW4u cGx1Z2luOworCitpbXBvcnQgY29tLmdvb2dsZS5nd3QuY29yZS5jbGllbnQuSmF2YVNjcmlwdE9i amVjdDsKK2ltcG9ydCBjb20uZ29vZ2xlLmd3dC5jb3JlLmNsaWVudC5Kc0FycmF5U3RyaW5nOwor CisvKioKKyAqIE92ZXJsYXkgdHlwZSBmb3Ige0Bjb2RlIHBsdWdpbkRlZmluaXRpb25zfSBnbG9i YWwgSlMgb2JqZWN0LgorICovCitwdWJsaWMgZmluYWwgY2xhc3MgUGx1Z2luRGVmaW5pdGlvbnMg ZXh0ZW5kcyBKYXZhU2NyaXB0T2JqZWN0IHsKKworICAgIHByb3RlY3RlZCBQbHVnaW5EZWZpbml0 aW9ucygpIHsKKyAgICB9CisKKyAgICBwdWJsaWMgc3RhdGljIG5hdGl2ZSBQbHVnaW5EZWZpbml0 aW9ucyBpbnN0YW5jZSgpIC8qLXsKKyAgICAgICAgcmV0dXJuICR3bmQucGx1Z2luRGVmaW5pdGlv bnM7CisgICAgfS0qLzsKKworICAgIHB1YmxpYyBuYXRpdmUgSnNBcnJheVN0cmluZyBnZXRQbHVn aW5OYW1lcygpIC8qLXsKKyAgICAgICAgdmFyIHBsdWdpbk5hbWVzID0gW107CisgICAgICAgIGZv ciAodmFyIGtleSBpbiB0aGlzKSB7CisgICAgICAgICAgICBwbHVnaW5OYW1lcy5wdXNoKGtleSk7 CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIHBsdWdpbk5hbWVzOworICAgIH0tKi87CisKKyAg ICBwdWJsaWMgbmF0aXZlIFN0cmluZyBnZXRQbHVnaW5Tb3VyY2VQYWdlVXJsKFN0cmluZyBwbHVn aW5OYW1lKSAvKi17CisgICAgICAgIHJldHVybiB0aGlzW3BsdWdpbk5hbWVdOworICAgIH0tKi87 CisKK30KZGlmZiAtLWdpdCBhL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRtaW4vc3Jj L21haW4vamF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL3dlYmFkbWluL3BsdWdpbi9QbHVnaW5FdmVu dEhhbmRsZXIuamF2YSBiL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRtaW4vc3JjL21h aW4vamF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL3dlYmFkbWluL3BsdWdpbi9QbHVnaW5FdmVudEhh bmRsZXIuamF2YQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi45ZjUwMWFjCi0t LSAvZGV2L251bGwKKysrIGIvZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJhZG1pbi9zcmMv bWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vcGx1Z2luL1BsdWdpbkV2ZW50 SGFuZGxlci5qYXZhCkBAIC0wLDAgKzEsMjQgQEAKK3BhY2thZ2Ugb3JnLm92aXJ0LmVuZ2luZS51 aS53ZWJhZG1pbi5wbHVnaW47CisKK2ltcG9ydCBvcmcub3ZpcnQuZW5naW5lLnVpLndlYmFkbWlu LnBsdWdpbi5ldmVudC5BY3Rpb25CdXR0b25DbGlja0V2ZW50OworaW1wb3J0IG9yZy5vdmlydC5l bmdpbmUudWkud2ViYWRtaW4ucGx1Z2luLmV2ZW50LkFjdGlvbkJ1dHRvbkNsaWNrRXZlbnQuQWN0 aW9uQnV0dG9uQ2xpY2tIYW5kbGVyOworCitpbXBvcnQgY29tLmdvb2dsZS5nd3QuZXZlbnQuc2hh cmVkLkV2ZW50QnVzOworaW1wb3J0IGNvbS5nb29nbGUuaW5qZWN0LkluamVjdDsKKworLyoqCisg KiBIYW5kbGVzIFdlYkFkbWluIGFwcGxpY2F0aW9uIGV2ZW50cyB0byBiZSBjb25zdW1lZCBieSBV SSBwbHVnaW5zLgorICovCitwdWJsaWMgY2xhc3MgUGx1Z2luRXZlbnRIYW5kbGVyIHsKKworICAg IEBJbmplY3QKKyAgICBwdWJsaWMgUGx1Z2luRXZlbnRIYW5kbGVyKEV2ZW50QnVzIGV2ZW50QnVz LCBmaW5hbCBQbHVnaW5BcGlNYW5hZ2VyIG1hbmFnZXIpIHsKKyAgICAgICAgZXZlbnRCdXMuYWRk SGFuZGxlcihBY3Rpb25CdXR0b25DbGlja0V2ZW50LmdldFR5cGUoKSwgbmV3IEFjdGlvbkJ1dHRv bkNsaWNrSGFuZGxlcigpIHsKKyAgICAgICAgICAgIEBPdmVycmlkZQorICAgICAgICAgICAgcHVi bGljIHZvaWQgb25BY3Rpb25CdXR0b25DbGljayhBY3Rpb25CdXR0b25DbGlja0V2ZW50IGV2ZW50 KSB7CisgICAgICAgICAgICAgICAgbWFuYWdlci5pbnZva2VQbHVnaW5zKCJBY3Rpb25CdXR0b25D bGljayIsIG51bGwpOyAvLyROT04tTkxTLTEkCisgICAgICAgICAgICB9CisgICAgICAgIH0pOwor ICAgIH0KKworfQpkaWZmIC0tZ2l0IGEvZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJhZG1p bi9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vcGx1Z2luL2V2ZW50 L0FjdGlvbkJ1dHRvbkNsaWNrLmphdmEgYi9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL3dlYmFk bWluL3NyYy9tYWluL2phdmEvb3JnL292aXJ0L2VuZ2luZS91aS93ZWJhZG1pbi9wbHVnaW4vZXZl bnQvQWN0aW9uQnV0dG9uQ2xpY2suamF2YQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi42MTQ1YjNkCi0tLSAvZGV2L251bGwKKysrIGIvZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxl cy93ZWJhZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vcGx1 Z2luL2V2ZW50L0FjdGlvbkJ1dHRvbkNsaWNrLmphdmEKQEAgLTAsMCArMSw4IEBACitwYWNrYWdl IG9yZy5vdmlydC5lbmdpbmUudWkud2ViYWRtaW4ucGx1Z2luLmV2ZW50OworCitpbXBvcnQgY29t Lmd3dHBsYXRmb3JtLmRpc3BhdGNoLmFubm90YXRpb24uR2VuRXZlbnQ7CisKK0BHZW5FdmVudAor cHVibGljIGNsYXNzIEFjdGlvbkJ1dHRvbkNsaWNrIHsKKworfQpkaWZmIC0tZ2l0IGEvZnJvbnRl bmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJhZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdp bmUvdWkvd2ViYWRtaW4vc2VjdGlvbi9tYWluL3ZpZXcvdGFiL01haW5UYWJWaXJ0dWFsTWFjaGlu ZVZpZXcuamF2YSBiL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRtaW4vc3JjL21haW4v amF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL3dlYmFkbWluL3NlY3Rpb24vbWFpbi92aWV3L3RhYi9N YWluVGFiVmlydHVhbE1hY2hpbmVWaWV3LmphdmEKaW5kZXggODc4OGNjNy4uMDE4ZDMxYyAxMDA2 NDQKLS0tIGEvZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJhZG1pbi9zcmMvbWFpbi9qYXZh L29yZy9vdmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vc2VjdGlvbi9tYWluL3ZpZXcvdGFiL01haW5U YWJWaXJ0dWFsTWFjaGluZVZpZXcuamF2YQorKysgYi9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVz L3dlYmFkbWluL3NyYy9tYWluL2phdmEvb3JnL292aXJ0L2VuZ2luZS91aS93ZWJhZG1pbi9zZWN0 aW9uL21haW4vdmlldy90YWIvTWFpblRhYlZpcnR1YWxNYWNoaW5lVmlldy5qYXZhCkBAIC0xNyw2 ICsxNyw4IEBAIGltcG9ydCBvcmcub3ZpcnQuZW5naW5lLnVpLnVpY29tbW9ud2ViLm1vZGVscy52 bXMuQ29uc29sZU1vZGVsOwogaW1wb3J0IG9yZy5vdmlydC5lbmdpbmUudWkudWljb21tb253ZWIu bW9kZWxzLnZtcy5WbUxpc3RNb2RlbDsKIGltcG9ydCBvcmcub3ZpcnQuZW5naW5lLnVpLndlYmFk bWluLkFwcGxpY2F0aW9uQ29uc3RhbnRzOwogaW1wb3J0IG9yZy5vdmlydC5lbmdpbmUudWkud2Vi YWRtaW4uQXBwbGljYXRpb25SZXNvdXJjZXM7CitpbXBvcnQgb3JnLm92aXJ0LmVuZ2luZS51aS53 ZWJhZG1pbi5naW4uQ2xpZW50R2luamVjdG9yUHJvdmlkZXI7CitpbXBvcnQgb3JnLm92aXJ0LmVu Z2luZS51aS53ZWJhZG1pbi5wbHVnaW4uZXZlbnQuQWN0aW9uQnV0dG9uQ2xpY2tFdmVudDsKIGlt cG9ydCBvcmcub3ZpcnQuZW5naW5lLnVpLndlYmFkbWluLnNlY3Rpb24ubWFpbi5wcmVzZW50ZXIu dGFiLk1haW5UYWJWaXJ0dWFsTWFjaGluZVByZXNlbnRlcjsKIGltcG9ydCBvcmcub3ZpcnQuZW5n aW5lLnVpLndlYmFkbWluLnNlY3Rpb24ubWFpbi52aWV3LkFic3RyYWN0TWFpblRhYldpdGhEZXRh aWxzVGFibGVWaWV3OwogaW1wb3J0IG9yZy5vdmlydC5lbmdpbmUudWkud2ViYWRtaW4udWljb21t b24uUmVwb3J0QWN0aW9uc0hlbHBlcjsKQEAgLTE2Myw2ICsxNjUsMTIgQEAgcHVibGljIGNsYXNz IE1haW5UYWJWaXJ0dWFsTWFjaGluZVZpZXcgZXh0ZW5kcyBBYnN0cmFjdE1haW5UYWJXaXRoRGV0 YWlsc1RhYmxlVmkKICAgICAgICAgICAgIHByb3RlY3RlZCBVSUNvbW1hbmQgcmVzb2x2ZUNvbW1h bmQoKSB7CiAgICAgICAgICAgICAgICAgcmV0dXJuIGdldE1haW5Nb2RlbCgpLmdldE5ld1NlcnZl ckNvbW1hbmQoKTsKICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgQE92ZXJyaWRlCisgICAg ICAgICAgICBwdWJsaWMgdm9pZCBvbkNsaWNrKExpc3Q8Vk0+IHNlbGVjdGVkSXRlbXMpIHsKKyAg ICAgICAgICAgICAgICBzdXBlci5vbkNsaWNrKHNlbGVjdGVkSXRlbXMpOworICAgICAgICAgICAg ICAgIEFjdGlvbkJ1dHRvbkNsaWNrRXZlbnQuZmlyZShDbGllbnRHaW5qZWN0b3JQcm92aWRlci5p bnN0YW5jZSgpLmdldEV2ZW50QnVzKCkpOworICAgICAgICAgICAgfQogICAgICAgICB9KTsKICAg ICAgICAgZ2V0VGFibGUoKS5hZGRBY3Rpb25CdXR0b24obmV3IFdlYkFkbWluQnV0dG9uRGVmaW5p dGlvbjxWTT4oY29uc3RhbnRzLm5ld0Rlc2t0b3BWbSgpKSB7CiAgICAgICAgICAgICBAT3ZlcnJp ZGUKZGlmZiAtLWdpdCBhL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRtaW4vc3JjL21h aW4vd2ViYXBwL1dFQi1JTkYvd2ViLnhtbCBiL2Zyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2Vi YWRtaW4vc3JjL21haW4vd2ViYXBwL1dFQi1JTkYvd2ViLnhtbAppbmRleCBhNTBmOGFhLi42MmYw MzEyIDEwMDY0NAotLS0gYS9mcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL3dlYmFkbWluL3NyYy9t YWluL3dlYmFwcC9XRUItSU5GL3dlYi54bWwKKysrIGIvZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxl cy93ZWJhZG1pbi9zcmMvbWFpbi93ZWJhcHAvV0VCLUlORi93ZWIueG1sCkBAIC0yMyw2ICsyMywx NiBAQAogCQk8dXJsLXBhdHRlcm4+L3dlYmFkbWluL1dlYkFkbWluLmh0bWw8L3VybC1wYXR0ZXJu PgogCTwvc2VydmxldC1tYXBwaW5nPgogCisJPHNlcnZsZXQ+CisJCTxzZXJ2bGV0LW5hbWU+UGx1 Z2luU291cmNlUGFnZTwvc2VydmxldC1uYW1lPgorCQk8c2VydmxldC1jbGFzcz5vcmcub3ZpcnQu ZW5naW5lLnVpLmZyb250ZW5kLnNlcnZlci5nd3QuUGx1Z2luU291cmNlUGFnZVNlcnZsZXQ8L3Nl cnZsZXQtY2xhc3M+CisJPC9zZXJ2bGV0PgorCisJPHNlcnZsZXQtbWFwcGluZz4KKwkJPHNlcnZs ZXQtbmFtZT5QbHVnaW5Tb3VyY2VQYWdlPC9zZXJ2bGV0LW5hbWU+CisJCTx1cmwtcGF0dGVybj4v d2ViYWRtaW4vUGx1Z2luU291cmNlUGFnZTwvdXJsLXBhdHRlcm4+CisJPC9zZXJ2bGV0LW1hcHBp bmc+CisKIAk8IS0tIERlZmF1bHQgcGFnZSB0byBzZXJ2ZSAtLT4KIAk8d2VsY29tZS1maWxlLWxp c3Q+CiAJCTx3ZWxjb21lLWZpbGU+aW5kZXguaHRtbDwvd2VsY29tZS1maWxlPgotLSAKMS43LjQu NAoK --=_156c716f-6003-47a3-bcaa-20301ab51501--

3 14

[Engine-devel] Additional info on patch reviewers
by Doron Fediuck 25 Jul '12

25 Jul '12

Hi, This may prove to be useful sometime... It is possible to ask gerrit to show a reviewer name, along the verify or code review columns. In order to set it, go to the settings link (up-right corner), and choose Preferences. Check the line "Display Person Name In Review Category". See the attached for sample and what to set. -- /d "This message will self destruct in the future. Or not."

1 0

[Engine-devel] Is ovirt-engine-cli expected for 3.1?
by Steve Gordon 24 Jul '12

24 Jul '12

Hi guys, On the release notes draft [1] one of the items is "New Python CLI, packaged as ??? (CLI).". The CLI page on the wiki says the package is ovirt-engine-cli, but this package doesn't exist in the beta repo. Is the CLI actually being delivered? Thanks, Steve [1] http://wiki.ovirt.org/wiki/Release_Notes_Draft [2] http://wiki.ovirt.org/wiki/CLI

3 2

[Engine-devel] Migration status of a VM
by Itzik Brown 24 Jul '12

24 Jul '12

--_000_4488206DC085244C886DBC9E7038B6892AA3F795MTRDAG01mtlcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Is it possible to know the status of a VM through the API - whether it's in= a migration process and if it is , what are the source and destination? Thanks, Itzik --_000_4488206DC085244C886DBC9E7038B6892AA3F795MTRDAG01mtlcom_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> <p class=3D"MsoNormal">Hi,<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">Is it possible to know the status of a VM through th= e API – whether it's in a migration process and if it is , what are t= he source and destination? <o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">Thanks,<o:p></o:p></p> <p class=3D"MsoNormal">Itzik<o:p></o:p></p> </div> </body> </html> --_000_4488206DC085244C886DBC9E7038B6892AA3F795MTRDAG01mtlcom_--

2 1