- Devel - oVirt List Archives

DAO Jenkins job fails on master
by Sandro Bonazzola 27 Jan '16

27 Jan '16

Hi, looks like after https://gerrit.ovirt.org/51535 Jenkins DAO job is failing: http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/ Please fix ASAP. thanks, -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

removing parameterized constructors from queries.
by Martin Mucha 27 Jan '16

27 Jan '16

Hi, I got another bug about missing constructor: public …(P parameters, EngineContext engineContext) { super(parameters, engineContext); } so I looked into: org.ovirt.engine.core.bll.QueriesCommandBase and it seems, that sole 'problem' is with initialization of user in @PostConstruct method. It seems, that we can easily set all those fields via setters, and user initialization can be done later, for example before calling executeQueryCommand in: org.ovirt.engine.core.bll.QueriesCommandBase#executeCommand doing this will move us closer to CDI and avoid errors because of forgotten constructor. Is there a obstacle blocking us from doing this? thanks, Mar. Edit: I had some time left so I tried to implement it, and it seems to be working. It's big patch, but mostly there's just constructors removal. Actual changes are in: QueriesCommandBase CommandsFactory RegisterVdsQuery GetAllTemplateBasedEntityQuery GetAllInstanceTypesQuery GetAllVmTemplatesQuery GetAllImageTypesQuery and test files.

2 3

oVirt 3.6.3 RC1 build starting
by Rafael Martins 27 Jan '16

27 Jan '16

Fyi oVirt products maintainers, An oVirt build for an official release is going to start right now. If you're a maintainer for any of the projects included in oVirt distribution and you have changes in your package ready to be released please: - bump version and release to be GA ready - tag your release within git (implies a GitHub Release to be automatically created) - build your packages within jenkins / koji / copr / whatever - verify all bugs on MODIFIED have target release and target milestone set. -- Rafael Martins

2 1

oVirt 3.6.1 branch has been created
by Rafael Martins 27 Jan '16

27 Jan '16

Hi, just an heads up we branched for 3.6.3 stabilization this morning. If you have patches targeted to 3.6.3 you now need to cherry-pick them to 3.6.3 branch too. -- Rafael Martins

1 1

[ANN] oVirt 3.6.2 Final Release is now available
by Sandro Bonazzola 26 Jan '16

26 Jan '16

The oVirt Project is pleased to announce today the general availability of oVirt 3.6.2. This latest community release includes several new features, such as: - More feedback about the status of the recovery - Rebalance option have been disabled on the menu for non-distributed volumes - Host in maintenance mode now stop glusterd and glusterfsd processes - Host activation now restart glusterd - Improved DNF support - Improved MOM performances - Added the ability to override the Storage Domain name field oVirt is an open-source, openly-governed enterprise virtualization management application, developed by a global community. You can use the oVirt management interface (oVirt Engine) to manage hardware nodes, storage and network resources, and to deploy and monitor virtual machines running in your data center. If you are familiar with VMware products, oVirt is conceptually similar to vSphere. oVirt serves as the bedrock for Red Hat's Enterprise Virtualization product, and it is the "upstream" project where new features are developed prior to their inclusion in Red Hat's supported product offering. Additional Resources: * Read more about the oVirt 3.6.2 release highlights: http://www.ovirt.org/OVirt_3.6.2_Release_Notes * Get more oVirt Project updates on Twitter: https://twitter.com/ovirt * Read more about oVirt Project community events: http://www.ovirt.org/Upcoming_events -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

[UI plugins] replacing RestApiSessionAcquired event
by Vojtech Szocs 26 Jan '16

26 Jan '16

Hi, in oVirt 4.0 the RestApiSessionAcquired event will be replaced with API to create authenticated requests for Engine services. Using REST API persistent session mechanism where UI acquires a single session to be shared by all UI plugins led us to many problems in the past, typically observed by end users as "Auth Required" browser popups. The new API proposed by [1] creates XMLHttpRequest object with following properties: * sets "Authorization: Bearer xxx" header before sending * logs request and response details (enabled via API option) [1] https://gerrit.ovirt.org/#/c/49278/ Example: var xhr = api.createEngineHttpRequest(); xhr.open('GET', 'http://example.com/ovirt-engine/api', true); xhr.setRequestHeader('Accept', 'application/json'); xhr.send(null); Since REST API persistent session mechanism currently relies on cookie (JSESSIONID), individual UI plugins should not try to create a REST session on their own to avoid any clashes. Regards, Vojtech

3 4

[ANN] oVirt 3.6.2 Third Release Candidate is now available for testing
by Sandro Bonazzola 25 Jan '16

25 Jan '16

The oVirt Project is pleased to announce the availability of the Third Release Candidate of oVirt 3.6.2 for testing, as of January 20th, 2016 This release is available now for Fedora 22, Red Hat Enterprise Linux 6.7, CentOS Linux 6.7 (or similar) and Red Hat Enterprise Linux >= 7.2, CentOS Linux >= 7.2 (or similar). This release supports Hypervisor Hosts running Red Hat Enterprise Linux >= 7.2, CentOS Linux >= 7.2 (or similar) and Fedora 22. Highly experimental support for Debian 8.2 Jessie has been added too. This release candidate includes updated packages for: - ovirt-engine - ovirt-engine-reports - ovirt-hosted-engine-setup - vdsm This release of oVirt 3.6.2 includes numerous bug fixes. See the release notes [1] for an initial list of the new features and bugs fixed. Please refer to release notes [1] for Installation / Upgrade instructions. A new oVirt Live ISO is also already available [2]. Please note that mirrors[3] may need usually one day before being synchronized. * Read more about the oVirt 3.6.2 release highlights: http://www.ovirt.org/OVirt_3.6.2_Release_Notes * Get more oVirt Project updates on Twitter: https://twitter.com/ovirt * Read more about oVirt Project community events: http://www.ovirt.org/Upcoming_events [1] http://www.ovirt.org/OVirt_3.6.2_Release_Notes [2] http://resources.ovirt.org/pub/ovirt-3.6-pre/iso/ [3] http://www.ovirt.org/Repository_mirrors#Current_mirrors -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

3 3

Packaging: Rationale for some split packages
by Milan Zamazal 25 Jan '16

25 Jan '16

I work on inclusion of Vdsm into Debian. I don't know what are the reasons for having separate `infra', `xmlrpc', `yajsonrpc', and `jsonrpc' packages. Could you please provide rationale for having each of those packages, separated from `vdsm' and `vdsm-python'? I need to put proper explanations into package descriptions so that the users know whether they should install/remove those packages or not. Thanks, Milan

5 10

Ensure processes death by terminating decorator - https://gerrit.ovirt.org/51407
by Yaniv Bronheim 25 Jan '16

25 Jan '16

Hi guys, Following the work to omit deathSignal attribute from our cpopen implementation we posted https://gerrit.ovirt.org/51407 which is ready for use. Currently locations that should use it are: (I wrote above who I expect to check the area and post a patch for that - we'll discuss it during next vdsm-sync to follow the work) shavivi: vdsm/v2v.py - in _start_virt_v2v you return aysnProc that should call kill() on fail fromani: vdsm_hooks/checkimages/before_vm_start.py - in checkImage - the code looks ok, but check if not better to use the terminating decorator.. I think it will be nicer nsoffer: vdsm/storage/mount.py - good looks ok, I prefer to use terminator there vdsm/storage/iscsiadm.py vdsm/storage/imageSharing.py vdsm/storage/hba.py -good handling, use terminator vdsm/storage/blockSD.py please check your usage with the returned process and see that you're not depending on deathSignal for it to die properly on crush some places define deathSignal for no reason, the call is sync - please remove those places: nsoffer: lib/vdsm/qemuimg.py vdsm/storage/curlImgWrap.py vdsm/storage/storage_mailbox.py vdsm/storage/misc.py fromani: lib/vdsm/virtsparsify.py ybronhei: vdsm/API.py If you can't get to it in a reasonable time, add the task to the list [1] and someone else will be it up. Please try to go over before the sync call. [1] - https://docs.google.com/spreadsheets/d/180F-C1jU54ajUn7TuR-NwrKRZY1IiZI1Z8U… -- *Yaniv Bronhaim.*

3 4

Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"
by Eli Mesika 24 Jan '16

24 Jan '16

Hi all Please note that there is still a problem on engine-setup I have already a fixing draft [1] Meanwhile, until this is verified and merged please do before engine-setup from dbscripts/upgrade dir psql -U engine -f 04_00_0210_add_vds_group_view.sql <db> Thanks and sorry for that, this will be fixed ASAP and reported in this thread. Eli [1] https://gerrit.ovirt.org/#/c/52454/ ----- Original Message ----- > From: "Idan Shaby" <ishaby(a)redhat.com> > To: "Eli Mesika" <emesika(a)redhat.com> > Sent: Tuesday, January 19, 2016 10:10:17 AM > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster" > > Hi Eli, > > I've fetched and rebased master, and got this error while running > engine-setup: > > [ INFO ] Stage: Setup validation > [WARNING] Cannot validate host name settings, reason: resolved host does > not match any of the local addresses > [ ERROR ] Failed to execute stage 'Setup validation': relation "vds_groups" > does not exist LINE 2: SELECT compatibility_version FROM > vds_groups... ^ > [ INFO ] Stage: Clean up > Log file is located at > /home/ishaby/ovirt-engine/var/log/ovirt-engine/setup/ovirt-engine-setup-20160119100829-tebscp.log > [ INFO ] Generating answer file > '/home/ishaby/ovirt-engine/var/lib/ovirt-engine/setup/answers/20160119100830-setup.conf' > [ INFO ] Stage: Pre-termination > [ INFO ] Stage: Termination > [ ERROR ] Execution of setup failed > > Any idea? > > > Regards, > Idan > > On Sun, Jan 17, 2016 at 4:50 PM, Eli Mesika <emesika(a)redhat.com> wrote: > > > > > > > ----- Original Message ----- > > > From: "Eli Mesika" <emesika(a)redhat.com> > > > To: "Jakub Niedermertl" <jniederm(a)redhat.com> > > > Cc: "devel" <devel(a)ovirt.org> > > > Sent: Sunday, January 17, 2016 1:32:27 PM > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead > > please use "cluster" > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Jakub Niedermertl" <jniederm(a)redhat.com> > > > > To: "Eli Mesika" <emesika(a)redhat.com> > > > > Cc: "devel" <devel(a)ovirt.org> > > > > Sent: Thursday, January 14, 2016 7:48:12 PM > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , > > instead > > > > please use "cluster" > > > > > > > > Hi Eli, > > > > > > > > thank you, it helped. Now `engine-setup` works fine. However engine > > itself > > > > reports following in a few seconds after start: > > > > > > > > ERROR: relation "clusters_storage_domain" does not exist > > > > > > > > Relevant part of engine log: http://pastebin.test.redhat.com/340672 > > > > Tested on current master (commit 8561bb69560686d0) and clean db. > > > > > > You are right, sorry for that ... > > > This patch fixes that issue > > > https://gerrit.ovirt.org/#/c/51929 > > > > Patch merged please re-base on master and try again > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Eli Mesika" <emesika(a)redhat.com> > > > > > To: "Jakub Niedermertl" <jniederm(a)redhat.com> > > > > > Cc: "devel" <devel(a)ovirt.org> > > > > > Sent: Thursday, January 14, 2016 1:10:42 AM > > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , > > instead > > > > > please use "cluster" > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Jakub Niedermertl" <jniederm(a)redhat.com> > > > > > > To: "Eli Mesika" <emesika(a)redhat.com> > > > > > > Cc: "devel" <devel(a)ovirt.org> > > > > > > Sent: Wednesday, January 13, 2016 9:18:57 PM > > > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , > > instead > > > > > > please use "cluster" > > > > > > > > > > > > Hi Eli, > > > > > > > > > > > > are db migration scripts supposed to handle this change? My > > > > > > `engine-setup` > > > > > > failed with following message in log: > > > > > > > > > > Hi Jakub > > > > > > > > > > Please re-base on latest master, there was an issue with that and it > > was > > > > > solved in https://gerrit.ovirt.org/#/c/51784/ > > > > > > > > > > > > > > > > > > > > > > """ > > > > > > 2016-01-13 20:02:57 DEBUG > > > > > > otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database > > > > > > database.execute:172 Database: 'None', Statement: ' > > > > > > SELECT compatibility_version FROM cluster;; > > > > > > ', args: {} > > > > > > 2016-01-13 20:02:57 DEBUG > > > > > > otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database > > > > > > database.execute:177 Creating own connection > > > > > > 2016-01-13 20:02:57 DEBUG otopi.context context._executeMethod:156 > > > > > > method > > > > > > exception > > > > > > Traceback (most recent call last): > > > > > > File "/usr/lib/python2.7/site-packages/otopi/context.py", line > > 146, > > > > > > in > > > > > > _executeMethod > > > > > > method['method']() > > > > > > File > > > > > > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py", > > > > > > line 218, in _validation > > > > > > self._checkSupportedVersionsPresent() > > > > > > File > > > > > > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py", > > > > > > line 180, in _checkSupportedVersionsPresent > > > > > > transaction=False, > > > > > > File > > > > > > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/ovirt_**FILTERED**_setup/**FILTERED**_common/database.py", > > > > > > line 196, in execute > > > > > > args, > > > > > > ProgrammingError: relation "cluster" does not exist > > > > > > LINE 2: SELECT compatibility_version FROM cluster;; > > > > > > ^ > > > > > > > > > > > > 2016-01-13 20:02:57 ERROR otopi.context context._executeMethod:165 > > > > > > Failed > > > > > > to > > > > > > execute stage 'Setup validation': relation "cluster" does not exist > > > > > > LINE 2: SELECT compatibility_version FROM cluster;; > > > > > > ^ > > > > > > """ > > > > > > > > > > > > Thank you for answer. > > > > > > > > > > > > Best regards > > > > > > Jakub > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Eli Mesika" <emesika(a)redhat.com> > > > > > > > To: "devel" <devel(a)ovirt.org> > > > > > > > Sent: Wednesday, January 13, 2016 12:00:50 AM > > > > > > > Subject: [ovirt-devel] No more "vds group" in master code , > > instead > > > > > > > please > > > > > > > use "cluster" > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > I have merged today this patch[1] to master. > > > > > > > > > > > > > > The code from historical reasons uses both "vds group" and > > "cluster" > > > > > > > for > > > > > > > a > > > > > > > cluster entity. > > > > > > > This makes the code not-clear, non-readable and hard for > > beginners > > > > > > > (to > > > > > > > find > > > > > > > for example SPs that handle clusters , or all code related to a > > > > > > > cluster > > > > > > > operation) > > > > > > > This also makes our logging and error messages using sometimes > > "vds > > > > > > > group" > > > > > > > and sometimes "cluster" to relate to the same entity. > > > > > > > Worse than that, new code written sometimes introduce a mix of > > both > > > > > > > terms. > > > > > > > > > > > > > > Patch[1] renames "vds group" to cluster all over the code. > > > > > > > This renaming covers all engine code including > > > > > > > Class names > > > > > > > Variables > > > > > > > Comments > > > > > > > Logging > > > > > > > Error messages > > > > > > > Database tables,views, columns and SPs including all kinds of > > keys > > > > > > > and > > > > > > > constrains > > > > > > > > > > > > > > Please do not use from now on the term "vds group" (all its > > variants > > > > > > > (VdsGroup, vdsGroup, vds_group etc.) > > > > > > > Instead , cluster and all its variants should be used > > > > > > > > > > > > > > If you have some written code that is not merged yet, you will > > > > > > > probably > > > > > > > have > > > > > > > a little work on rebase on top this patch, as far as I know those > > > > > > > should > > > > > > > be > > > > > > > trivial patches and if you have any question, please ask. > > > > > > > > > > > > > > Possible affects on other products are minor and were > > communicated to > > > > > > > the > > > > > > > relevant product people. > > > > > > > > > > > > > > [1] https://gerrit.ovirt.org/#/c/51109/ > > > > > > > > > > > > > > Thanks > > > > > > > Eli Mesika > > > > > > > > > > > > > > _______________________________________________ > > > > > > > Devel mailing list > > > > > > > Devel(a)ovirt.org > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel(a)ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > _______________________________________________ > > Devel mailing list > > Devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > >

1 1