- Devel - oVirt List Archives

Question about https://gerrit.ovirt.org/#/c/49860/
by Vojtech Szocs 09 Dec '15

09 Dec '15

Hi Allon! patch in $subject modifies test method name from: testGetLocaleFromStringString_withDefault to: testGetLocaleFromStringStringWithDefault I've always thought that Java test method names should be as much readable as possible, because in Java tests, the method name is used to describe the particular test case. (Unfortunately, Java test frameworks don't do a good job in this area.. please correct me if I'm wrong.) So with JS/Jasmine we can do this: describe('LocaleUtils', function () { it('should extract locale from given String', function () { // actual test code }); }); but in Java we usually do this: // <methodName>_<extraInfoForSpecificTestCase> void testGetLocaleFromStringString_withDefault which is already far from readable, and this: testGetLocaleFromStringStringWithDefault makes it even worse.. Even though it complies with Java method naming convention, it totally obfuscates what is that particular test case about, which means people who want to maintain such tests need to spend time studying what the test is actually doing.. What's your take on this? Regards, Vojtech

2 1

[Russian oVirt localization] Missing English ApplicationConstants.properties in 3.6
by Juliette Tux 09 Dec '15

09 Dec '15

Hello, There is a missing original English .properties file in tar.gz archives for 3.6.* source. The directory is 'frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin'. There are only translated properties files but no original English ApplicationConstants.properties. Where can I find it, please? Best regards, Julia Dronova -- С уважением, Дронова Юлия

3 7

[vdsm][oVirt 4.0] trimming down vm.py, stage 1
by Francesco Romani 09 Dec '15

09 Dec '15

Hi all, as many already know, we have a problem in the vdsm/virt/* area with the size of vm.py. As in today's master (SHA1: ed7618102e4e3aedf859adb1084eecded8e5158d), vm.py weights like: 1082 11:28:09 fromani@musashi ~/Projects/upstream/vdsm $ ls -lh vdsm/virt/vm.py -rw-rw-r--. 1 fromani fromani 209K Nov 24 11:15 vdsm/virt/vm.py 1083 11:30:22 fromani@musashi ~/Projects/upstream/vdsm $ wc vdsm/virt/vm.py 5202 17125 213026 vdsm/virt/vm.py I'd like to renew my commitment to bring this monster down to a sane size. I don't think we can make it in one go. We should tackle this monster task in stages. We have roughly five weeks left until the end of the year. Sounds like a good timespan for the first stage, and I'm aiming for go down under the 4000 line mark. So we have roughly 1200 lines to eliminate somehow. This is the initial plan I'm thinking off, in expected increasing difficulty level, from easies to hardest: 1. LiveMergeCleanupThread: Chance to break things: minimal - roughly 120 lines (10% of the goal) - can be moved verbatim (cut/paste) elsewhere, like vdsm/virt/livemerge.py, fixing only import paths. 2. the findDrive* family of functions: Chance to break things: minimal/very low - roughly 50 lines (~4% of the goal) - can be moved with minimal changes elsewhere, like vdsm/virt/storage/????.py, 3. the getConf* faimily of functions: Chance to break things: medium-to-high in the 3.x branch, low on 4.x because we drop backward compat. - roughly 110 lines (~9% of the goal) - just drop them for 4.0! - alternatively, need to figure out a proper place, maybe a new module? 4. the Devices/VM setup bits All scatthered through vm.py (e.g. _buildDomainXML, DeviceMapping table) Chance to break things: medium-to-low, depends on individual patches - all summed up, roughly 200 lines (~18% of the goal) - need serious cleanup - no definite plan - mostly is cut/paste or transform Vm methods into functions 5. the getUnderlying* familiy of functions: Chance to break things: low (maybe medium on some cases, to lean on the safe side) - roughly 550 lines (~46% of the goal) - easy to test (just run vms!) - can be moved in the devices/ subpackage with some changes. - require further work in the area to properly integrate this code in the device objects - more work is planned in this area, including move from minidom to ElementTree So far, I've gathered ~1030 lines, so I'm short of 170 lines to reach the goal, but I'm confident I can find something more. The plan now is to start from the easy parts *and* in background with #4, which requires way more work than everything else. Thoughts, objections and suggestions all welcome, especially from storage people, because first items in my list affects them. Thanks and bests, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani

1 2

[VDSM] CI failure - testEnablePromisc (ipwrapperTests.TestDrvinfo)
by Nir Soffer 09 Dec '15

09 Dec '15

Hi all, This is not the first time this test fails, but it is a rare failure. Anyone has a clue why it fails? According the captured log, all the ip runs are successful. Can it be an issue on specific slave? 21:25:25 ====================================================================== 21:25:25 FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo) 21:25:25 ---------------------------------------------------------------------- 21:25:25 Traceback (most recent call last): 21:25:25 File "/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/ipwrapperTests.py", line 130, in testEnablePromisc 21:25:25 "Could not enable promiscuous mode.") 21:25:25 AssertionError: Could not enable promiscuous mode. 21:25:25 -------------------- >> begin captured logging << -------------------- 21:25:25 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /usr/sbin/brctl show (cwd None) 21:25:25 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0 21:25:25 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link add name vdsm-ooqBPb type bridge (cwd None) 21:25:25 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0 21:25:25 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link set dev vdsm-ooqBPb up (cwd None) 21:25:25 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0 21:25:25 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link set dev vdsm-ooqBPb promisc on (cwd None) 21:25:25 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0 21:25:25 --------------------- >> end captured logging << --------------------- See http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1101/conso… Nir

2 1

[oVirt jenkins] Weekly report on open tasks for ovirt-engine
by jenkins＠ovirt.org 08 Dec '15

08 Dec '15

------=_Part_637_49831877.1449574721798 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Files scanned: '**/*.java, **/*.py'. Strings searched: FIXME | TODO | @deprecated Report: http://jenkins.ovirt.org/job/ovirt_engine_scan_open_tasks/42/tasksResult/? ------=_Part_637_49831877.1449574721798--

1 0

Default DC & Cluster are created now with version 4.0
by Eli Mesika 08 Dec '15

08 Dec '15

Hi Please note that https://gerrit.ovirt.org/#/c/48802/ was merged. >From now, Default DC and Cluster are created with version 4.0 A patch adding support for 4.0 from the vdsm side was merged to vdsm today Thanks Eli Mesika

1 0

Reminder: FOSDEM16 Virt & IaaS devroom CFP ends tomorrow, Dec. 8
by Mikey Ariel 07 Dec '15

07 Dec '15

I'd like to remind all that the extended CFP for the Virtualization & Infrastructure-as-a-Service devroom at FOSDEM 2016 ends tomorrow. If you're still on the fence or working on a draft proposal, now is the time to take the leap and join us! Please review the original CFP announcement[1] for submission guidelines, speaker mentoring program information, and important dates. Feel free to email the devroom mailing list iaas-virt-devroom at lists.fosdem.org if you have any questions. See you in Brussels! [1] http://community.redhat.com/blog/2015/10/call-for-proposals-fosdem16-virtua… -- Mikey Ariel Community Lead, oVirt www.ovirt.org "To be is to do" (Socrates) "To do is to be" (Jean-Paul Sartre) "Do be do be do" (Frank Sinatra) Mobile: +420-702-131-141 IRC: mariel / thatdocslady Twitter: @ThatDocsLady

1 0

[oVirt 3.6 Localization Question #39] "prefixMsg,"
by Yuko Katabami 07 Dec '15

07 Dec '15

Hello all, Here is another question: File: UIMessages Resource IDs: numberValidationNumberBetweenInvalidReason numberValidationNumberGreaterInvalidReason numberValidationNumberLessInvalidReason Strings: {0} between {1} and {2}. {0} greater than or equal to {1}. {0} less than or equal to {1}. Question: Could you please provide some example of those messages? Comment section in each of those strings states "0=prefixMsg" but I would like to know what will actually replace {0}, so that I can translate them properly. Kind regards, Yuko

4 8

Re: [ovirt-devel] Jenkins notice
by Sagi Shnaidman 07 Dec '15

07 Dec '15

adding devel mail list: On Mon, Dec 7, 2015 at 3:48 PM, Sagi Shnaidman <sshnaidm(a)redhat.com> wrote: > Hi, > > due to massive push of patches the Jenkins might be affected and perform > slow in the next hours. > > Thanks > > -- > Best regards > Sagi Shnaidman > -- Best regards Sagi Shnaidman

1 0

[VDSM] Coverage - checking coverage with vdsm-coverage
by Nir Soffer 06 Dec '15

06 Dec '15

Hi all, I posted https://gerrit.ovirt.org/49807, adding vdsm-coverage package, making it easy to get coverage report for functional or system tests. This can also be used to understand which code is touched when performing some flow manually. Once this patch is merged, you can create coverage report like this: 1. Install vdsm-coverage 2. Enable coverage in vdsm.conf: [devel] coverage_enable = true 3. Restart vdsm 4. Run tests or interact with engine 5. Stop vdsm The report is created in /var/run/vdsm/vdsm.coverage To create html report: coverage html --rcfile /etc/vdsm/coverage.conf The view the report, start a web server: cd htmlcov python -m SimpleHTTPServer The report is available now in your favorite browser: http://myhost.example.com:8000/ The manual steps described above can probably be automated, having a web server running and generating coverage report on demand. (hint: patches are welcome) Notes: - On RHEL 7.2, python-coverage is old (3.6). Use pip to install more recent one: pip install -U coverage Note that files generated by coverage 3.6 cannot be processed with coverage 4. - Needs debian packaging Please try and suggest improvements. Nir

2 1