- Devel - oVirt List Archives

Re: Jackson-databind related changes
by Martin Perina 15 Sep '23

15 Sep '23

Hi, oVirt Engine is using JBoss Modules feature to load libraries, so when a library version is mentioned in pom.xml it's unrelated to which version is being using during runtime. Here's the detailed description: 1. jackson-databind 2.12.7 mentioned pom.xml is actually being used only when building the project directly with maven (development purposes) https://github.com/oVirt/vdsm-jsonrpc-java/blob/master/pom.xml.in#L61 https://github.com/oVirt/vdsm-jsonrpc-java/blob/master/client/pom.xml.in 2. When building the project as a part of RPM build, then maven (respectively xmvn) is invoked to use only libraries installed locally as a part of RPM dependencies https://github.com/oVirt/vdsm-jsonrpc-java/blob/master/vdsm-jsonrpc-java.sp… So on CS8 we can easily find out the jackson-databind package version being used during RPM build # dnf repoquery --whatprovides 'jackson-databind >= 2.10.0' jackson-databind-0:2.10.0-1.module_el8.4.0+595+e59c9af2.noarch jackson-databind-0:2.10.0-1.module_el8.4.0+782+1d1c31a0.noarch 3. On runtime vdsm-jsonrpc-java is being loaded using JBoss Modules as a part of oVirt Engine: https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/dependenc… which shows that vdsm-jsonrpc-java depends on com.fasterxml.jackson.core.jackson-databind module, which is included in the relevant WildFly release. Currently oVirt Engine is using WildFly 24.0.1, so you can see jackson-databind version using following command: # rpm -ql ovirt-engine-wildfly | grep 'jackson-databind-' /usr/share/ovirt-engine-wildfly/modules/system/layers/base/com/fasterxml/jackson/core/jackson-databind/main/jackson-databind-2.12.3.jar So if you want to bump jackson-databind version for oVirt Engine runtime you have two possibilities: 1. You can deliver updated JBoss module as a part of ovirt-engine-wildfly-overlay RPM: https://github.com/oVirt/ovirt-engine-wildfly/overlay 2. You can try to bump WildFly to latest version in ovirt-engine-wildfly RPM: https://github.com/oVirt/ovirt-engine-wildfly/ Please be awate that at the moment it's not possible to use latest WildFly version, because oVirt Engine is using classic security model, which was removed in favor of Elytron in WildFly 25. So to bump WildFly version, you would need to implement changes in oVirt Engine to use Elytron. Regarding verification the best way is to verify functionality by execution of oVirt System Tests: https://github.com/ovirt/ovirt-system-tests Regards, Martin On Thu, Sep 14, 2023 at 11:44 PM Shubha Kulkarni <shubha.kulkarni(a)oracle.com> wrote: > Hi All > > > > I am yet to get any feedback on my query. So I thought I will reach out > again to see if any one has comment on this - > > > > Background: > > I see the commit for CVE-2020-36518 to vdsm-json-rpc to bump jackson > version to 2.12.7 > > > https://github.com/oVirt/vdsm-jsonrpc-java/commit/d1f423809fd491da7b5324b30… > > This change in only made in pom.xml is made with "default" scope (i.e > compile). > > > > Queries: > > #1. So at runtime, that means this jar should be explicitly packaged > somewhere else. I am wondering how is this newer jackson jar is picked up? > Does it have anything to do with the change outside pom.xml that I don't > see? > > > > #2. Ideally, I would like to verify that vdsm-jsonrpc-java application is > using jackson-core2.12.7 and jackson-databaind 2.12.7-1 when installed on > engine system. What is the best way to do it? > > > > Thanks > > > > *From:* Shubha Kulkarni > *Sent:* Thursday, September 7, 2023 1:47 PM > *To:* devel(a)ovirt.org > *Subject:* Jackson-databind related changes > > > > Hello! > > > > There have been changes added to ovirt-engine and vdsm-jsonrpc-java repos > to address security vulnerabilities in jackson-databind package. I see that > the change is made to bump up version of jackson-databind package to > 2.12.7.1. > > I am wondering what is the rpm version for ovirt-engine and > vdsm-jsonrpc-java that has these fixes? Also, I am curious what is the best > way to validate these changes? > > > > Thanks, > > Shubha > _______________________________________________ > Devel mailing list -- devel(a)ovirt.org > To unsubscribe send an email to devel-leave(a)ovirt.org > Privacy Statement: https://www.ovirt.org/privacy-policy.html > oVirt Code of Conduct: > https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UDIWOPJMWDCRB… > -- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o.

2 1

Re: Jackson-databind related changes
by Sandro Bonazzola 15 Sep '23

15 Sep '23

@Martin Perina <mperina(a)redhat.com> can you help here? Il giorno gio 14 set 2023 alle ore 23:44 Shubha Kulkarni < shubha.kulkarni(a)oracle.com> ha scritto: > Hi All > > > > I am yet to get any feedback on my query. So I thought I will reach out > again to see if any one has comment on this - > > > > Background: > > I see the commit for CVE-2020-36518 to vdsm-json-rpc to bump jackson > version to 2.12.7 > > > https://github.com/oVirt/vdsm-jsonrpc-java/commit/d1f423809fd491da7b5324b30… > > This change in only made in pom.xml is made with "default" scope (i.e > compile). > > > > Queries: > > #1. So at runtime, that means this jar should be explicitly packaged > somewhere else. I am wondering how is this newer jackson jar is picked up? > Does it have anything to do with the change outside pom.xml that I don't > see? > > > > #2. Ideally, I would like to verify that vdsm-jsonrpc-java application is > using jackson-core2.12.7 and jackson-databaind 2.12.7-1 when installed on > engine system. What is the best way to do it? > > > > Thanks > > > > *From:* Shubha Kulkarni > *Sent:* Thursday, September 7, 2023 1:47 PM > *To:* devel(a)ovirt.org > *Subject:* Jackson-databind related changes > > > > Hello! > > > > There have been changes added to ovirt-engine and vdsm-jsonrpc-java repos > to address security vulnerabilities in jackson-databind package. I see that > the change is made to bump up version of jackson-databind package to > 2.12.7.1. > > I am wondering what is the rpm version for ovirt-engine and > vdsm-jsonrpc-java that has these fixes? Also, I am curious what is the best > way to validate these changes? > > > > Thanks, > > Shubha > _______________________________________________ > Devel mailing list -- devel(a)ovirt.org > To unsubscribe send an email to devel-leave(a)ovirt.org > Privacy Statement: https://www.ovirt.org/privacy-policy.html > oVirt Code of Conduct: > https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UDIWOPJMWDCRB… > -- Sandro Bonazzola MANAGER, SOFTWARE ENGINEERING Red Hat In-Vehicle Operating System Red Hat EMEA <https://www.redhat.com/> <https://www.redhat.com/> *Red Hat respects your work life balance. Therefore there is no need to answer this email out of your office hours.*

1 0

Re: Jackson-databind related changes
by Shubha Kulkarni 14 Sep '23

14 Sep '23

Hi All I am yet to get any feedback on my query. So I thought I will reach out again to see if any one has comment on this - Background: I see the commit for CVE-2020-36518 to vdsm-json-rpc to bump jackson version to 2.12.7 https://github.com/oVirt/vdsm-jsonrpc-java/commit/d1f423809fd491da7b5324b30… This change in only made in pom.xml is made with "default" scope (i.e compile). Queries: #1. So at runtime, that means this jar should be explicitly packaged somewhere else. I am wondering how is this newer jackson jar is picked up? Does it have anything to do with the change outside pom.xml that I don't see? #2. Ideally, I would like to verify that vdsm-jsonrpc-java application is using jackson-core2.12.7 and jackson-databaind 2.12.7-1 when installed on engine system. What is the best way to do it? Thanks From: Shubha Kulkarni Sent: Thursday, September 7, 2023 1:47 PM To: devel(a)ovirt.org Subject: Jackson-databind related changes Hello! There have been changes added to ovirt-engine and vdsm-jsonrpc-java repos to address security vulnerabilities in jackson-databind package. I see that the change is made to bump up version of jackson-databind package to 2.12.7.1. I am wondering what is the rpm version for ovirt-engine and vdsm-jsonrpc-java that has these fixes? Also, I am curious what is the best way to validate these changes? Thanks, Shubha

1 0

Jackson-databind related changes
by Shubha Kulkarni 07 Sep '23

07 Sep '23

Hello! There have been changes added to ovirt-engine and vdsm-jsonrpc-java repos to address security vulnerabilities in jackson-databind package. I see that the change is made to bump up version of jackson-databind package to 2.12.7.1. I am wondering what is the rpm version for ovirt-engine and vdsm-jsonrpc-java that has these fixes? Also, I am curious what is the best way to validate these changes? Thanks, Shubha

1 0

Error: Adding new Host to ovirt-engine
by Ahmad Khiet 14 Aug '23

14 Aug '23

Hi, Can't add new host to ovirt engine, because the following error: 2019-06-12 12:23:09,664 p=4134 u=engine | TASK [ovirt-host-deploy-facts : Set facts] ************************************* 2019-06-12 12:23:09,684 p=4134 u=engine | ok: [10.35.1.17] => { "ansible_facts": { "ansible_python_interpreter": "/usr/bin/python2", "host_deploy_vdsm_version": "4.40.0" }, "changed": false } 2019-06-12 12:23:09,697 p=4134 u=engine | TASK [ovirt-provider-ovn-driver : Install ovs] ********************************* 2019-06-12 12:23:09,726 p=4134 u=engine | fatal: [10.35.1.17]: FAILED! => {} MSG: The conditional check 'cluster_switch == "ovs" or (ovn_central is defined and ovn_central | ipaddr and ovn_engine_cluster_version is version_compare('4.2', '>='))' failed. The error was: The ipaddr filter requires python's netaddr be installed on the ansible controller The error appears to be in '/home/engine/apps/engine/share/ovirt-engine/playbooks/roles/ovirt-provider-ovn-driver/tasks/configure.yml': line 3, column 5, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: - block: - name: Install ovs ^ here 2019-06-12 12:23:09,728 p=4134 u=engine | PLAY RECAP ********************************************************************* 2019-06-12 12:23:09,728 p=4134 u=engine | 10.35.1.17 : ok=3 changed=0 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0 whats missing!? Thanks -- Ahmad Khiet Red Hat <https://www.redhat.com/> akhiet(a)redhat.com M: +972-54-6225629 <https://red.ht/sig>

7 10

Please review open PRs
by Sandro Bonazzola 12 Jul '23

12 Jul '23

Hi, there are currently 71 PRs open within oVirt project, waiting for a review: https://github.com/pulls?q=is%3Aopen+is%3Apr+user%3Aovirt+archived%3Afalse If you'd like to get them moving forward, please review them. You don't need to be one of the people with merge rights there in order to review. Your feedback may still help getting the PR in or getting it improved or getting it rejected. Thanks, -- Sandro Bonazzola MANAGER, SOFTWARE ENGINEERING - Red Hat In-Vehicle Operating System Red Hat EMEA <https://www.redhat.com/> sbonazzo(a)redhat.com <https://www.redhat.com/> *Red Hat respects your work life balance. Therefore there is no need to answer this email out of your office hours.*

1 0

Ovirt Admin VM Portal url Not Loading on the Browser After Successful HE Deployment.
by igwevic70＠gmail.com 18 May '23

18 May '23

Hi there, I need some help here, please. I am new to ovirt and I am trying to setup ovirt 4.5.4 a test env. I have successfully deployed HE using "hosted-engine --deploy" after days of encountering a lot of issues, but the current issue now is that I can't access the VM Portal ie WebUI, where I can create VM from the Admin portal. One thing I noticed is that during the deployment process, it supplies a temporary url link like "https://ovirt-node-03.projectplus.com:6900/ovirt-engine" to access the web but when the deployment is done, it kills the this url and it becomes unavailable with no web access again Can someone please please, help me to understand what's going on. I have done this deployment nearly 10x but still getting the same thing, I can just have webui access to the Admin Portal. Thanks in advance for your help. Vik.

1 0

oVirt VM manager not showing any network status
by Dean L 16 May '23

16 May '23

Currently running oVirt VM manager Version 4.5.5-0.master.20230504084909.gitd37b4f7ad9.el8. Noticed that the network status for all the VMs has been showing 0%. ... Dean

1 0

Invalid value '-1' for 'cpu.max': Invalid argument
by lejeczek 15 May '23

15 May '23

Hi guys. with latest stable ovirt node, hosted engine setup fails at, I guess late stage: ... [ INFO ] TASK [ovirt.ovirt.hosted_engine_setup : Notify the user about a failure] [ ERROR ] fatal: [localhost]: FAILED! => {"changed": false, "msg": "Host is not up, please check logs, perhaps also on the engine machine"} as setup sits & waits for a while, before it errors out, I see this in logs: ... 12687 still running (84875) Invalid value '-1' for 'cpu.max': Invalid argument 12687 still running (84870) 12687 still running (84865) 12687 still running (84860) Invalid value '-1' for 'cpu.max': Invalid argument ... and logs continue after engine setup has finished. I've browsed around but resolutions I found did not help, also I suspect it might be a bug thus any comments on how to fix it, are very much appreciated - btw, why BZs reports should go? many thanks, L.

2 1

Console Disconnect Action
by Shubha Kulkarni 12 May '23

12 May '23

Hello, I am experimenting with the feature ‘console disconnect action’ . It provides four actions on disconnect.  Lock screen - This is the default option. For all Linux machines and for Windows desktops this locks the currently active user session. For Windows servers, this locks the desktop and the currently active user.  Logout user - For all Linux machines and Windows desktops, this logs out the currently active user session. For Windows servers, the desktop and the currently active user are logged out.  Shutdown virtual machine - Initiates a graceful virtual machine shutdown.  Reboot virtual machine - Initiates a graceful virtual machine reboot. In my testing, the shutdown and reboot options worked. However, lock screen and logout user option did not work for me. I looked around and found out that qemu-guest agent has no command to log off a user. I see ovirt-guest-agent has some code to logout user as described below - https://github.com/oVirt/ovirt-guest-agent/blob/master/ovirt-guest-agent/Lo… However, it turns out that the ovirt-guest-agent is not supported anymore. So I am wondering how the ‘lock screen’ and ‘logout user’ is implemented and whether it is still supported/supposed to work? Thanks, Shubha

1 0