- Devel - oVirt List Archives

Some ideas on oVirt Java SDK
by Vojtech Szocs 03 Dec '14

03 Dec '14

Hi guys, since the initial (small, working & well-tested) version of oVirtJS JavaScript SDK is finished [*], I've started working on GWT wrapper for oVirtJS. While analyzing/reverse-engineering oVirt Java SDK, some thoughts came to my mind, and I wanted to share them with you. [*] TODO(vszocs) upload new patchset with all recent changes First, the way XJC (JAXB binding compiler that generates Java beans out of REST XSD schema) is invoked looks a bit weird to me, as Java SDK's XsdCodegen does this: Runtime.getRuntime().exec(command) Why not simply use existing Maven plugins to invoke XJC? - either: https://github.com/highsource/maven-jaxb2-plugin - or: http://mojo.codehaus.org/jaxb2-maven-plugin/ Second, and most importantly, what's the point of having "group" entities? I'll give an example - api.xsd contains this: <xs:complexType name="DataCenters"> <xs:complexContent> <xs:extension base="BaseResources"> <xs:sequence> <xs:annotation> <xs:appinfo> <jaxb:property name="DataCenters"/> </xs:appinfo> </xs:annotation> <xs:element ref="data_center" minOccurs="0" maxOccurs="unbounded"/> </xs:sequence> </xs:extension> </xs:complexContent> </xs:complexType> (Same as above for Hosts, Clusters, VMs, etc.) This results in following (IMHO rather meaningless) Java class being generated by XJC: public class DataCenters extends BaseResources { @XmlElement(name = "data_center") protected List<DataCenter> dataCenters; public List<DataCenter> getDataCenters() { if (dataCenters == null) { dataCenters = new ArrayList<DataCenter>(); } return this.dataCenters; } public boolean isSetDataCenters() { return ((this.dataCenters!= null)&&(!this.dataCenters.isEmpty())); } public void unsetDataCenters() { this.dataCenters = null; } } Instead, we could use @XmlElementWrapper as described in [1] to avoid generating "group" entities altogether. [1] https://github.com/dmak/jaxb-xew-plugin The fact that Java SDK provides decorator for each specific resource collection (like DataCenters), instead of having ONE resource collection type, greatly complicates overall design and code-gen aspect. In oVirtJS GWT wrapper, we'll avoid above complication through single resource collection type (having common methods like get(id), list() etc) for all resources. Regards, Vojtech

3 9

REST API CSRF protection header name
by Vojtech Szocs 03 Dec '14

03 Dec '14

Hi, since 3.5 the oVirt REST API features CSRF protection mechanism via CSRFProtectionFilter, see [1] for details. [1] http://gerrit.ovirt.org/#/c/29681/ I'd like to ask what's the motivation behind calling the CSRF token header "JSESSIONID". I think the header name should reflect its logical purpose to avoid confusion. Could we rename this header to something more appropriate like "OVIRT-REST-CSRF-TOKEN" or similar? It would better reflect the purpose of this (CSRF protection) header. In future, we can still have another request header with name "JSESSIONID" for transmitting session ID from client to server, however this potential new header would have different purpose (transfer session ID vs. CSRF token). Each header should have name reflecting its purpose. (This is just a suggestion.) Thanks, Vojtech

2 1

hosted-engine setup/migration features for 3.6
by Yedidyah Bar David 03 Dec '14

03 Dec '14

Hi all, We already have quite a lot of open ovirt-hosted-engine-setup bugs for 3.6 [1]. Yesterday I tried helping someone on irc who planned to migrate to hosted-engine manually, and without knowing (so it seems) that such a feature exists. He had an engine set up on a physical host, prepared a VM for it, and asked about migrating the engine to the VM. In principle this works, but the final result will be a hosted-engine, where the engine manages a VM the runs itself, without knowing it, and without HA. The current recommended migration flow is described in [2]. This page is perhaps a bit outdated, perhaps missing some details etc., but principally works. The main issue with it, AFAICT after discussing this a bit with few people, is that it requires a new clean host. I'd like to hear what people here think about such and similar flows. If you already had an engine and migrated to hosted-engine, what was good, what was bad, what would you like to change? If you plan such a migration, what do you find missing currently? [1] http://red.ht/1vle8Vv [2] http://www.ovirt.org/Migrate_to_Hosted_Engine Best, -- Didi

1 0

[QE][ACTION REQUIRED] oVirt 3.5.1 RC status - postponed
by Sandro Bonazzola 02 Dec '14

02 Dec '14

Hi, We were supposed to start composing oVirt 3.5.1 RC today *2014-12-02 08:00 UTC* from 3.5 branch. We have still blockers for oVirt 3.5.1 RC release so we need to postpone it untill they'll be fixed. The new tentative date for 3.5.1 RC composition is set to *2014-12-09 08:00 UTC The bug tracker [1] shows 2 open blocker: Bug ID Whiteboard Status Summary 1168689 infra ASSIGNED Upgrading from 3.4.4 to 3.5.1 snapshot the vdsm rpm throw an exception 1160846 sla NEW Can't add disk to VM without specifying disk profile when the storage domain has more than one disk profile In order to stabilize the release a new branch ovirt-engine-3.5.1 will be created from the same git hash used for composing the RC. Maintainers: - Please be sure that 3.5 snapshot allow to create VMs before *2014-12-08 15:00 UTC* - Please be sure that no pending patches are going to block the release before *2014-12-08 15:00 UTC* - If any patch must block the RC release please raise the issue as soon as possible. There are still 69 bugs [2] targeted to 3.5.1. Excluding node and documentation bugs we still have 46 bugs [3] targeted to 3.5.1. Maintainers / Assignee: - Please add the bugs to the tracker if you think that 3.5.1 should not be released without them fixed. - Please update the target to 3.5.2 or later for bugs that won't be in 3.5.1: it will ease gathering the blocking bugs for next releases. - Please fill release notes, the page has been created here [4] Community: - If you're testing oVirt 3.5 nightly snapshot, please add yourself to the test page [5] [1] http://bugzilla.redhat.com/1155170 [2] http://goo.gl/7G0PDV [3] http://goo.gl/6gUbVr [4] http://www.ovirt.org/OVirt_3.5.1_Release_Notes [5] http://www.ovirt.org/Testing/oVirt_3.5.1_Testing -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

2 1

oVirt Node Weekly Meeting Minutes - December 2nd 2014
by Fabian Deutsch 02 Dec '14

02 Dec '14

Minutes: http://ovirt.org/meetings/ovirt/2014/ovirt.2014-12-02-14.06.html Minutes (text): http://ovirt.org/meetings/ovirt/2014/ovirt.2014-12-02-14.06.txt Log: http://ovirt.org/meetings/ovirt/2014/ovirt.2014-12-02-14.06.log.html ================================= #ovirt: oVirt Node Weekly Meeting ================================= Meeting started by fabiand at 14:06:16 UTC. The full logs are available at http://ovirt.org/meetings/ovirt/2014/ovirt.2014-12-02-14.06.log.html . Meeting summary --------------- * Agenda (fabiand, 14:06:42) * oVirt 3.5 (fabiand, 14:07:53) * oVirt 3.5 (fabiand, 14:08:23) * Other Items (fabiand, 14:09:56) * oVirt 3.5 (fabiand, 14:11:26) * Latest Node scratch build is the one from two weeks ago (fabiand, 14:13:51) * LINK: https://fedorapeople.org/~fabiand/node/3.5/ovirt-node-iso-3.5.0.ovirt35.201… (fabiand, 14:14:37) * Some stabilizing patches got merged (fabiand, 14:14:53) * Most work focused on the hosted-engine feature (fabiand, 14:15:48) * many HE related patches got reviewed and merged during the last few days (fabiand, 14:18:36) * Basic HE features seems to work fine (fabiand, 14:18:48) * Joining an existing HA HE is not yet supported (fabiand, 14:19:03) * Targetting 3.5.1 to include ovirt-node. ovirt-node-plugins-vdsm and ovirt-node-plugin-he rpms (fabiand, 14:21:06) * ovirt-node-plugin-vdsm is looking good (fabiand, 14:22:42) * vdsm-plugin also needs an update to address an el7 issue (fabiand, 14:24:11) * Other Items (fabiand, 14:24:49) * Jenkins (fabiand, 14:26:03) * tlitovsk working on jenkins automation (fabiand, 14:29:27) * working on local builders, once working, pushing those changes to upstream (fabiand, 14:29:46) * Next-Gen Node (fabiand, 14:31:06) * Start thinking about next-gen node and 3.6 (fabiand, 14:44:15) * generic registration is a potential feature for 3.6 (fabiand, 14:44:26) * Using puppet for configuration changes should get investigated (fabiand, 14:44:37) * Seperating the insatller from the TUI (packaging) is something for 3.6 (fabiand, 14:44:49) * Possibly re-visit other cfg mgmt systems like ansible and chef (fabiand, 14:51:22) * systemd has good sides. (fabiand, 14:52:38) * tlitovsk has the idea of baking a configuration into an ISO (fabiand, 14:58:48) * fabiand would liek to reuse existing tools for next-gen node modifications (fabiand, 14:59:20) * tlitovsk and fabiand to speak about where to do decision making (fabiand, 15:00:29) * fabiand would like to separate rootfs from delivery format (ISO) (fabiand, 15:03:01) Meeting ended at 15:04:21 UTC. Action Items ------------ Action Items, by person ----------------------- * **UNASSIGNED** * (none) People Present (lines said) --------------------------- * fabiand (172) * tlitovsk (16) * rbarry (15) * dougsland (13) * ovirtbot (4) * sbonazzo (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot

1 0

How To Auto Set oVirt RESTApi Session？
by 王成俊 01 Dec '14

01 Dec '14

Dear Sir： I am a new one in studing ovirt engine.Now,I have a Servlet in org.ovirt.engine.ui.frontend.server.gwt package. I want to call *Frontend.getInstance().getLoginHandler().**onLoginSuccess(userName, password, domain)* to set session for restapi in this servlet. But when I visit this servlet,it occur to show me an error which just like "*JBWEB000071: root cause java.lang.ClassNotFoundException: org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback from [Module "deployment.engine.ear.webadmin.war:main" from Service Module Loader]*". I found that this error is occured by calling* Frontend.getInstance()*. Can you tell me how to resolve this problem or a new way to set and resume restapi session in a servlet package of org.ovirt.engine.ui.front.server.gwt like the RestApiSessionManager in org.ovirt.engine.ui.webadmin.plugin.restapi package? thanks! Best Regards!

2 1

Frontend code - introducing GinUiBinder
by Vojtech Szocs 01 Dec '14

01 Dec '14

Hi guys, Martin's GinUiBinder patch [1] just landed into master branch. [1] http://gerrit.ovirt.org/#/c/34954/ This patch allows the use of dependency injection for widgets declared in GWT UiBinder templates. Let's take a look at AbstractVmPopupWidget.ui.xml template: <vm:SerialNumberPolicyWidget ui:field="serialNumberPolicyEditor"/> Inside the "owner" widget, AbstractVmPopupWidget class: @UiField(provided = true) // we need manual instantiation public SerialNumberPolicyWidget serialNumberPolicyEditor; We use "provided = true" in order to manually instantiate SerialNumberPolicyWidget, because this widget accepts some constructor parameters: public SerialNumberPolicyWidget( CommonApplicationTemplates applicationTemplates, ... ) So in AbstractVmPopupWidget, we need to do following: serialNumberPolicyEditor = new SerialNumberPolicyWidget(...) The "provided = true" + "new SerialNumberPolicyWidget(...)" is essentially a boilerplate that adds to overall complexity. Now, let's revisit above example using GinUiBinder. First, in AbstractVmPopupWidget class: @UiField // no need for manual instantiation public SerialNumberPolicyWidget serialNumberPolicyEditor; Then, in SerialNumberPolicyWidget class: @Inject // inject dependencies into this widget public SerialNumberPolicyWidget( CommonApplicationTemplates applicationTemplates, ... ) And finally, we can remove following line: // this is no longer needed, GinUiBinder handles it for us serialNumberPolicyEditor = new SerialNumberPolicyWidget(...) The complete example can be seen here: http://gerrit.ovirt.org/#/c/34954/4/frontend/webadmin/modules/gwt-common/sr… I encourage every UI maintainer to revisit existing code with regard to @UiField(provided = true) and refactor/improve it to take advantage of @Inject in specific widget classes. Let me (or Martin) know if you have any questions. Regards, Vojtech

1 0

Fwd: Got an error after buuilding VDSM on latest upstream commit
by ybronhei 01 Dec '14

01 Dec '14

forwarding to devels anyone familiar with the issue already ? any ready patch? -------- Forwarded Message -------- Subject: Got an error after buuilding VDSM on latest upstream commit Date: Sun, 30 Nov 2014 05:54:45 -0500 (EST) From: Eli Mesika <emesika(a)redhat.com> To: Dan Kenigsberg <danken(a)redhat.com>, Saggi Mizrahi <smizrahi(a)redhat.com>, ybronhei <ybronhei(a)redhat.com>, Dima Kuznetsov <dkuznets(a)redhat.com> CC: Oved Ourfali <oourfali(a)redhat.com>, Barak Azulay <bazulay(a)redhat.com> vdsm: Running restore_nets libvirt: Network Driver error : Network not found: no network with matching name 'vdsm-ovirtmgmt' ^X^CTraceback (most recent call last): File "/usr/share/vdsm/vdsm-restore-net-config", line 139, in <module> restore() File "/usr/share/vdsm/vdsm-restore-net-config", line 125, in restore unified_restoration() File "/usr/share/vdsm/vdsm-restore-net-config", line 70, in unified_restoration setupNetworks(nets, bonds, connectivityCheck=False, _inRollback=True) File "/usr/share/vdsm/network/api.py", line 715, in setupNetworks implicitBonding=True, _netinfo=_netinfo, **d) File "/usr/share/vdsm/network/api.py", line 221, in wrapped ret = func(**attrs) File "/usr/share/vdsm/network/api.py", line 310, in addNetwork netEnt.configure(**options) File "/usr/share/vdsm/network/models.py", line 196, in configure self.configurator.configureBridge(self, **opts) File "/usr/share/vdsm/network/configurators/ifcfg.py", line 92, in configureBridge ifup(bridge.name, bridge.ipConfig.async) File "/usr/share/vdsm/network/configurators/ifcfg.py", line 820, in ifup rc, out, err = _ifup(iface) File "/usr/share/vdsm/network/configurators/ifcfg.py", line 804, in _ifup rc, out, err = utils.execCmd([constants.EXT_IFUP, netIf], raw=False) File "/usr/lib/python2.6/site-packages/vdsm/utils.py", line 622, in execCmd (out, err) = p.communicate(data) File "/usr/lib64/python2.6/subprocess.py", line 732, in communicate stdout, stderr = self._communicate(input, endtime) File "/usr/lib64/python2.6/subprocess.py", line 1316, in _communicate stdout, stderr = self._communicate_with_poll(input, endtime) File "/usr/lib64/python2.6/subprocess.py", line 1388, in _communicate_with_poll ready = poller.poll(self._remaining_time(endtime)) Any ideas ??? Thanks Eli Mesika -- Yaniv Bronhaim.

3 2

[Localization Question] Cluster Policy "power_saving"
by Yuko Katabami 01 Dec '14

01 Dec '14

This is a multi-part message in MIME format. --------------030502000209020304030303 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi oVirt developers, I am currently translating documentation and I would like to ask you one question on power_saving Cluster Policy, in order to understand the mechanism properly so that I can translate accurately. (Please excuse me -- this might be a basic concept, but it is a bit confusing for me) My understanding is that when this is selected, the Manager tries to shut down a host which has the lowest usage within the cluster (so that it can save the power). In order to shut it down, VMs running on that host need to be migrated to other host. Which host will be the destination? Would it be the host with the second lowest usage rate? Many thanks in advance, Yuko Katabami --------------030502000209020304030303 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> </head> <body bgcolor="#FFFFFF" text="#000000"> Hi oVirt developers, I am currently translating documentation and I would like to ask you one question on power_saving Cluster Policy, in order to understand the mechanism properly so that I can translate accurately. (Please excuse me  -- this might be a basic concept, but it is a bit confusing for me) My understanding is that when this is selected, the Manager tries to shut down a host which has the lowest usage within the cluster (so that it can save the power). In order to shut it down, VMs running on that host need to be migrated to other host. Which host will be the destination? Would it be the host with the second lowest usage rate? Many thanks in advance, Yuko Katabami <div class="moz-signature"> </div> </body> </html> --------------030502000209020304030303--

2 2

Re: [ovirt-devel] Fw: Some ideas on oVirt Java SDK
by Michael Pasternak 30 Nov '14

30 Nov '14

Hey Vojtech, How are you?, please see my reply inline. > > On Friday, November 28, 2014 5:26 PM, Vojtech Szocs <vszocs(a)redhat.com> > wrote: > > > Hi guys, > > since the initial (small, working & well-tested) version of oVirtJS > JavaScript SDK is finished [*], I've started working on GWT wrapper > for oVirtJS. > > While analyzing/reverse-engineering oVirt Java SDK, some thoughts > came to my mind, and I wanted to share them with you. > > [*] TODO(vszocs) upload new patchset with all recent changes > > First, the way XJC (JAXB binding compiler that generates Java beans > out of REST XSD schema) is invoked looks a bit weird to me, as Java > SDK's XsdCodegen does this: > > Runtime.getRuntime().exec(command) > > Why not simply use existing Maven plugins to invoke XJC? > - either: https://github.com/highsource/maven-jaxb2-plugin > it was using jaxb to begin with, but Juan has replaced it with XJC, btw Juan, what was the motivation behind this? (REST api uses jaxb as well so we used to have 1x1 mappings) > - or: http://mojo.codehaus.org/jaxb2-maven-plugin/ > same. > > Second, and most importantly, what's the point of having "group" > entities? I'll give an example - api.xsd contains this: > > <xs:complexType name="DataCenters"> > <xs:complexContent> > <xs:extension base="BaseResources"> > <xs:sequence> > <xs:annotation> > <xs:appinfo> > <jaxb:property name="DataCenters"/> > </xs:appinfo> > </xs:annotation> > <xs:element ref="data_center" minOccurs="0" > maxOccurs="unbounded"/> > </xs:sequence> > </xs:extension> > </xs:complexContent> > </xs:complexType> > > (Same as above for Hosts, Clusters, VMs, etc.) > > This results in following (IMHO rather meaningless) Java class > being generated by XJC: > > public class DataCenters extends BaseResources { > > @XmlElement(name = "data_center") > protected List<DataCenter> dataCenters; > > public List<DataCenter> getDataCenters() { > if (dataCenters == null) { > dataCenters = new ArrayList<DataCenter>(); > } > return this.dataCenters; > } > > public boolean isSetDataCenters() { > return ((this.dataCenters!= null)&&(!this.dataCenters.isEmpty())); > } > > public void unsetDataCenters() { > this.dataCenters = null; > } > > } > > Instead, we could use @XmlElementWrapper as described in [1] > to avoid generating "group" entities altogether. > > [1] https://github.com/dmak/jaxb-xew-plugin > > The fact that Java SDK provides decorator for each specific > resource collection (like DataCenters), instead of having ONE > resource collection type, greatly complicates overall design > and code-gen aspect. > well, i guess now is speaking JS constraints ghost, am i right?, at any case, the reasons for having decorator per collection are: 1. compliance with REST API (all SDKs and REST api sharing same well know architecture) 2. "decorator" is a well known and commonly used java design pattern 3. having one resource type serving all collections would create a bottleneck (well it might depend on how you implementing it, but still in my view it's less convenient/readable than dedicated collection with own context, verbs and behaviour) after all the purpose of sdk is being java client serving java application in "Java" way while JS use-case & paradigms are totally different. > > In oVirtJS GWT wrapper, we'll avoid above complication through > single resource collection type (having common methods like > get(id), list() etc) for all resources. > > Regards, > Vojtech > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > -- Michael Pasternak

1 0