- Devel - oVirt List Archives

Testing backported changes
by Kobi Ianko 24 Jun '14

24 Jun '14

Hi, Is there a nice way to check changes I backported to 3.4.1 without messing my 3.5 DB? 10x

5 4

engine got CDI support (finally)
by Roy Golan 23 Jun '14

23 Jun '14

I just recently merged the first CDI [1] patch into master. The patch enables the bll and common projects to have CDI supports but there is now usage still. Further more than the power to create managed beans one can inject dependencies to non-manage beans, e.g all our Command instances. All of the developers are encouraged to read and dig in a bit on the subject to leverage the power of it. I'll will arrange a hands on session. The slides introducing the subject can be found here [2] Also there's a nice mojo group for WELD [3], the reference implementation for CDI spec. join in. [1] http://docs.jboss.org/weld/reference/latest/en-US/html/ [2] https://mojo.redhat.com/docs/DOC-940608 [3] https://mojo.redhat.com/community/old_docspace/bu/middleware/engineering/pr… Thanks, Roy

1 0

Re: [ovirt-devel] [ovirt-users] Host Installation fails - Package openstack-neutron cannot be found
by Sandro Bonazzola 23 Jun '14

23 Jun '14

Il 12/06/2014 12:25, Moti Asayag ha scritto: > > > ----- Original Message ----- >> From: "Udaya Kiran P" <ukiran770(a)yahoo.in> >> To: "users" <users(a)ovirt.org> >> Sent: Wednesday, June 11, 2014 10:25:37 AM >> Subject: [ovirt-users] Host Installation fails - Package openstack-neutron cannot be found >> >> Hi All, >> >> I am trying to add a new Host, with External Network Provider - Neutron. Host >> installation fails in oVirt Engine with below error. >> > > What is the version of the neutron server you're using ? > > you can find repositories here: > http://repos.fedorapeople.org/repos/openstack/openstack-havana/ If the above repository is now required in order to deploy hosts, please send a patch to ovirt-release project and/or open a BZ to be sure we enable that repository by default. Thanks. > >> Please help me resolve this >> >> 2014-06-11 12:54:34 ERROR otopi.plugins.otopi.packagers.yumpackager >> yumpackager.error:97 Yum Cannot queue package openstack-neutron: Package >> openstack-neutron cannot be found >> 2014-06-11 12:54:34 DEBUG otopi.context context._executeMethod:152 method >> exception >> Traceback (most recent call last): >> File "/tmp/ovirt-YnooVggSrR/pythonlib/otopi/context.py", line 142, in >> _executeMethod >> method['method']() >> File >> "/tmp/ovirt-YnooVggSrR/otopi-plugins/ovirt-host-deploy/openstack/neutron.py", >> line 81, in _packages >> self.packager.installUpdate(('openstack-neutron',)) >> File "/tmp/ovirt-YnooVggSrR/pythonlib/otopi/packager.py", line 139, in >> installUpdate >> ignoreErrors=ignoreErrors, >> File "/tmp/ovirt-YnooVggSrR/otopi-plugins/otopi/packagers/yumpackager.py", >> line 295, in install >> ignoreErrors=ignoreErrors >> File "/tmp/ovirt-YnooVggSrR/pythonlib/otopi/miniyum.py", line 865, in install >> **kwargs >> File "/tmp/ovirt-YnooVggSrR/pythonlib/otopi/miniyum.py", line 514, in _queue >> package=package, >> RuntimeError: Package openstack-neutron cannot be found >> 2014-06-11 12:54:34 ERROR otopi.context context._executeMethod:161 Failed to >> execute stage 'Package installation': Package openstack-neutron cannot be >> found >> >> >> Thank you, >> >> Regards, >> Udaya Kiran >> >> _______________________________________________ >> Users mailing list >> Users(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/users >> > _______________________________________________ > Users mailing list > Users(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/users > -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

3 5

Re: [ovirt-devel] F20 python 2.7.5-12 breaks cpopen
by Dan Kenigsberg 23 Jun '14

23 Jun '14

It's a bit confusing, but this is not a task for infra@ovirt, but for the the similarly-named but utterly different team of ovirt developers, who prefer patches to be sent as pull requests to https://github.com/ovirt-infra/cpopen On Mon, Jun 23, 2014 at 05:19:01AM -0400, Francesco Romani wrote: > The attached patch fixes locally. > > > ----- Original Message ----- > > From: "Francesco Romani" <fromani(a)redhat.com> > > To: "infra" <infra(a)ovirt.org> > > Sent: Monday, June 23, 2014 10:48:23 AM > > Subject: F20 python 2.7.5-12 breaks cpopen > > > > Hi Infra, > > > > I just discovered the hard way that the last python package in F20 > > > > # rpm -qi python > > Name : python > > Version : 2.7.5 > > Release : 12.fc20 > > Architecture: x86_64 > > Install Date: Mon 23 Jun 2014 08:28:32 AM CEST > > Group : Development/Languages > > Size : 80819 > > License : Python > > Signature : RSA/SHA256, Thu 19 Jun 2014 04:49:28 PM CEST, Key ID > > 2eb161fa246110c1 > > Source RPM : python-2.7.5-12.fc20.src.rpm > > Build Date : Thu 19 Jun 2014 02:54:35 PM CEST > > Build Host : buildvm-24.phx2.fedoraproject.org > > Relocations : (not relocatable) > > Packager : Fedora Project > > Vendor : Fedora Project > > URL : http://www.python.org/ > > Summary : An interpreted, interactive, object-oriented programming > > language > > > > [...] > > > > Includes this apparently innocuous change: > > * Thu Jun 19 2014 Bohuslav Kabrda <bkabrda(a)redhat.com> - 2.7.5-12 > > - Fix test failures with SQLite 3.8.4 > > - Fix double close of subprocess pipes when child process fails Resolves: > > rhbz#1103450 <<< THIS ONE! > > > > Which is > > http://hg.python.org/cpython/rev/43749cb6bdbd > > > > If we try to run VDSM tests using cpopen 1.3-2[1] > > > > we'll get: http://fpaste.org/112115/ > > > > the fix is simple: just use execute_child_v276 and everything will work > > again. > > How can we detect and react properly to this schenario, however? > > > > Thanks, > > > > +++ > > > > [1] > > # rpm -qi python-cpopen > > Name : python-cpopen > > Version : 1.3 > > Release : 2.fc20 > > Architecture: x86_64 > > Install Date: Sat 15 Feb 2014 09:50:01 PM CET > > > > > > -- > > Francesco Romani > > RedHat Engineering Virtualization R & D > > Phone: 8261328 > > IRC: fromani > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > > > -- > Francesco Romani > RedHat Engineering Virtualization R & D > Phone: 8261328 > IRC: fromani > From a5895505d051dfe387c573474e71b3faf696fcf0 Mon Sep 17 00:00:00 2001 > From: Francesco Romani <fromani(a)redhat.com> > Date: Mon, 23 Jun 2014 11:17:47 +0200 > Subject: [PATCH] compatibility with F20's python 2.7.5-12 I'd prefer the commit message to state the exact exception seen, so that other user could find the fixing patch more easily. > > --- > cpopen/__init__.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/cpopen/__init__.py b/cpopen/__init__.py > index 46ed446..cea001e 100644 > --- a/cpopen/__init__.py > +++ b/cpopen/__init__.py > @@ -26,6 +26,7 @@ This is a simpler method of execing that doesn't go back to python after > forking. This allows for faster safer exec. > """ > > +import inspect > import os > import sys > from subprocess import Popen, PIPE > @@ -101,5 +102,7 @@ class CPopen(Popen): > > if sys.version_info[0:3] >= (2, 7, 6): > _execute_child = _execute_child_v276 > + elif 'to_close' in inspect.getargspec(Popen._execute_child).args: > + _execute_child = _execute_child_v276 > else: > _execute_child = _execute_child_v275 > -- > 1.9.3 > > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra

2 1

[oVirt 3.5 Localization Question #4] "Random Generator"
by Yuko Katabami 23 Jun '14

23 Jun '14

This is a multi-part message in MIME format. --------------010305010700050802020700 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hello again. I would like to ask another question. * File:***CommonApplicationConstants* **Resource ID:*** rngDeviceTab* **Strings:***Random Generator *Question: *Is "Random Generator" same as "Random Number Generator" which appears many times in 3.5 strings? Kind regards, Yuko --------------010305010700050802020700 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> </head> <body text="#000000" bgcolor="#FFFFFF"> Hello again. I would like to ask another question. File: CommonApplicationConstants Resource ID: <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> rngDeviceTab Strings: Random Generator Question: Is "Random Generator" same as "Random Number Generator" which appears many times in 3.5 strings? Kind regards, Yuko <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> <div class="moz-signature"> </div> </body> </html> --------------010305010700050802020700--

3 4

Sampling threads reduction
by Francesco Romani 23 Jun '14

23 Jun '14

Hi everyone, Over the last few days I've been working on an concept to reduce the number of threads in VDSM. Currently, one of the biggest source of them is the VM statistics sampling: We have one thread per VM in charge to do so, and this is obviously poorly scalable. I tried for quite some time to solve this at libvirt level, but according to my findings and feelings, that whould require a huge patch. In the process of studying libvirt, I came up with a simple idea which, according to the initial tests, seems to work quite nicely and I'd like to discuss. The concept is to start with a thread pool (http://en.wikipedia.org/wiki/Thread_pool) and to add the few additions needed by VDSM: 1. to detect and take care of 'stuck' tasks 2. to avoid a 'stuck' task deplenish the worker pool 3. to avoid to start leak threads on a 'stuck' task I failed to find an existing thread pool which had those additions, so I wrote a new one from scratch: https://github.com/mojaves/vdsm/tree/master/lib/threadpool Then I spawned a new subpackage (a-la zombiereaper) and I consolidated the existed thread pool (from the storage subsystem) and added some longer doc. Please note that the storage had no changes except the trivial import fixes. Lastly, I've also added a small compatibility module for concurrent.futures, which is a very nice python module which provides a convenient interface to asynchronously execute callables; this module is included in python 3.2 (https://docs.python.org/3.3/library/concurrent.futures.html#module-concurre…) and there is a backport for python 2.x. This can also allow us (as in the virt group) to consolidate all the long running async operations using the same interface and code. Please note that I reimplemented a thread pool mostly to be able to experiment with the concepts listed above, which I failed to find implemented elsewhere in existing packages. I'm fine to see them reimplemented elsewhere, since I now believe they collectively provide a viable solution for us. The vdsm/virt/sampling.py has been my testbed, and the patch came up nice This is the bulk of the work https://github.com/mojaves/vdsm/commit/2b4c96f9ca3566f0c2f1426beff4400d5311… Here all the changes, most of them are small adjustements https://github.com/mojaves/vdsm/commits/master/vdsm/virt/sampling.py and here is how it will looks like https://github.com/mojaves/vdsm/blob/master/vdsm/virt/sampling.py I'd like the sampling thread mess sorted out in time for 3.6, so please share your thoughts! Thanks and best regards, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani

1 0

Re: [ovirt-devel] [oVirt 3.5 Localization Question #8] "moveDisplayNetworkWarning"
by Yevgeny Zaspitsky 22 Jun '14

22 Jun '14

networkOperationMessage is built dynamically in the run-time (e.g. "Attach <NetworkName> to <InterfaceName>"). The final message depends on operation type and its argument(s) (1 or 2). The possible networkOperationMessage does not include '.' (dot sign) at the end so that was added in order to separate the warning from the operation description. Regards, Yevgeny ----- Original Message ----- > From: "Dan Kenigsberg" <danken(a)redhat.com> > To: yzaspits(a)redhat.com > Cc: lvernia(a)redhat.com > Sent: Friday, June 20, 2014 3:39:47 PM > Subject: Re: [ovirt-devel] [oVirt 3.5 Localization Question #8] "moveDisplayNetworkWarning" > > Hi Yevgeny, I think you are the best to answer this question. > > On Fri, Jun 20, 2014 at 10:08:18PM +1000, Yuko Katabami wrote: > > > > On 06/19/2014 06:28 PM, Yuko Katabami wrote: > > >Hello, > > > > > >This is our last question for today. > > > > > >*File:***ApplicationMessages > > >*Resource IDs:*** moveDisplayNetworkWarning > > >*String:***{0}. Moving the display network will drop VM console > > >connectivity until they are restarted. > > >*Question:* From the source comment "0=networkOperationMessage" I can see > > >that {0} will be replaced with network operation messages. I wonder if > > >each of those messages already contains a fullstop. If so, it will have > > >two full stops. Could you please give me the example of those messages, so > > >that we can check our corresponding translation in Zanata (whether > > >fullstops are included or not). > > Is the variable {0} going to be replaced with messages that start > > with"$detailMessage"? > > I found them newly added to the current project we are translating. > > > > Kind regards, > > > > Yuko > > > > > > > > >Kind regards, > > > > > >Yuko > > > > > > > > >_______________________________________________ > > >Devel mailing list > > >Devel(a)ovirt.org > > >http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > _______________________________________________ > > Devel mailing list > > Devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > >

2 3

[oVirt 3.5 Localization Question #2] "Update display network on cluster with an active VM" (audit log)
by Yuko Katabami 22 Jun '14

22 Jun '14

This is a multi-part message in MIME format. --------------070201030401020800080109 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hello again. I would like to ask another question with the following details: *File:***LocalizedEnums* **Resource ID:*** AuditLogType___NETWORK_UPDATE_DISPLAY_FOR_CLUSTER_WITH_ACTIVE_VM* **Strings:*** Update display network on cluster with an active VM *Question:* Is this string an instruction to the user to update the display network? Since the resource ID suggests it is audit log, there might be a possibility that it is actually meant to be a past event (i.e. "Updated"). Kind regards, Yuko --------------070201030401020800080109 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> </head> <body text="#000000" bgcolor="#FFFFFF"> Hello again. I would like to ask another question with the following details: File: LocalizedEnums Resource ID: <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> AuditLogType___NETWORK_UPDATE_DISPLAY_FOR_CLUSTER_WITH_ACTIVE_VM Strings:  <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> Update display network on cluster with an active VM Question: <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> Is this string an instruction to the user to update the display network? Since the resource ID suggests it is audit log, there might be a possibility that it is actually meant to be a past event (i.e. "Updated"). Kind regards, Yuko <div class="moz-signature"> </div> </body> </html> --------------070201030401020800080109--

4 5

[VDSM] [PATCH] Pthreading pull requests for review
by Nir Soffer 21 Jun '14

21 Jun '14

Hi all, Please review these pull requests for pthreading: - https://github.com/ovirt-infra/pthreading/pull/5 tests: Improve Condition tests - https://github.com/ovirt-infra/pthreading/pull/6 Simpler and more correct handling spurious wakeups v3 Thanks, Nir

1 0

[VDSM] [PATCH] Simpler and more correct handling spurious wakeups
by Nir Soffer 20 Jun '14

20 Jun '14

Hi all, Please review this pull request for pthreading: https://github.com/ovirt-infra/pthreading/pull/4 Thanks, Nir

1 0