- Devel - oVirt List Archives

[Engine-devel] RefObject
by Laszlo Hornyak 17 May '12

17 May '12

hi, Thank you for the reviews on the refobject removal patches! Here are some more :) http://gerrit.ovirt.org/4465 http://gerrit.ovirt.org/4501 http://gerrit.ovirt.org/4502 Thank you, Laszlo

1 0

[Engine-devel] Random seeding in unit tests
by Allon Mureinik 16 May '12

16 May '12

If you ever need a comfortable way to inject a random seed to your test (e.g., for reproducing a specific run), check out the new RandomUtilsSeedingRule: http://ovirt.org/wiki/RandomUtilsSeedingRule

1 0

[Engine-devel] git-review error.
by snmishra＠linux.vnet.ibm.com 15 May '12

15 May '12

Hi, I am trying to push a patch to gerrit for review. $ ./git-review -t nullpointer remote: Resolving deltas: 0% (0/6) To ssh://snmishra@gerrit.ovirt.org:29418/ovirt-engine.git ! [remote rejected] HEAD -> refs/publish/master/nullpointer (prohibited by Gerrit) error: failed to push some refs to 'ssh://snmishra@gerrit.ovirt.org:29418/ovirt-engine.git' I can ssh to gerrit.ovirt.org without password, so that seems to be setup correctly. git-review version is 1.17. I am on 'nullpointer' branch. Thanks in advance for your help. Regards Sharad Mishra

4 4

[Engine-devel] add host failed
by hkran＠linux.vnet.ibm.com 15 May '12

15 May '12

Hi, when I add a host to newly setup ovirt-engine,the system told me that install failed What can I do to figure out what is wrong with it? 2012-May-15, 11:51:37 Host mddd installation failed. Please refer to log files for further details.. 2012-May-15, 11:51:37 Failed to install Host mddd. Step: INSTALLER LIB; Details: deployUtil.py download failed. Pathname could not be resolved (verify computer/domain name).. 2012-May-15, 11:51:31 Installing Host mddd. Step: INSTALLER; Details: Test platform succeeded. 2012-May-15, 11:51:14 Installing Host mddd. Step: RHEV_INSTALL; Details: Connected to Host 9.115.118.194 with SSH key fingerprint: e1:bf:2a:93:f4:1e:4c:fe:22:ca:68:5d:36:06:3b:68. 2012-May-15, 11:51:12 Host mddd parameters were updated by admin@internal. 2012-May-15, 11:46:27 User admin@internal logged in. thanks!

2 1

[Engine-devel] reviewer needed for cleanup patchset
by Laszlo Hornyak 14 May '12

14 May '12

Hi, I need someone who could verify and/or approve my changeset to remove usage of the deprecated RefObject class. http://gerrit.ovirt.org/4235 http://gerrit.ovirt.org/4236 http://gerrit.ovirt.org/4237 http://gerrit.ovirt.org/4238 http://gerrit.ovirt.org/4239 Thank you, Laszlo

1 0

[Engine-devel] The correct way to create test dependencies between
by Allon Mureinik 14 May '12

14 May '12

Hi guys, I've recently come up with (what I believe is) an elegant way to mock the Config object using JUnit @Rules and Mockito (The gritty details can be found at http://gerrit.ovirt.org/4155) This presented me with another issue: On the one hand, the code depends on junit and mockito jars, which are not available in the main scope, only in the test scope. On the other hand, in vanilla Maven there is no dependency between tests of different projects, so placing this class in util's test would make it inaccessible to bll tests. The solution Maven suggests for these kind of issues is creating a test jar (http://maven.apache.org/guides/mini/guide-attached-tests.html) In addition to the regular jar the module produces, you'll get another -test jar, which other modules can depend on using the <type>test-jar</type>, which could of course be put in <scope>test</scope>. Before pushing forward with this approach, I'd like to know if anyone has a principle objection to it. Thanks, Allon

3 3

[Engine-devel] value too long for type character varying(20) in function "insertvds_interface"
by Itzik Brown 14 May '12

14 May '12

Hi, When running VDSM on host with Infiniband HCAs I get the following errors in /usr/share/jboss-as/standalone/log/server.log on the ovirt-engine host. WARN [org.ovirt.engine.core.vdsbroker.VdsManager] (QuartzScheduler_Worker-17) ResourceManager::refreshVdsRunTimeInfo::Failed to refresh VDS , vds = 783eb0ac-9a91-11e1-a8e4-000c29de7759 : xena003, error = DataIntegrityViolationException: CallableStatementCallback; SQL [{call insertvds_interface(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)}]; ERROR: value too long for type character varying(20) Where: SQL statement "INSERT INTO vds_interface(addr, bond_name, bond_type, gateway, id, is_bond, bond_opts, mac_addr, name, network_name, speed, subnet, boot_protocol, type, VDS_ID, vlan_id, mtu, bridged) VALUES(v_addr, v_bond_name, v_bond_type, v_gateway, v_id, v_is_bond, v_bond_opts, v_mac_addr, v_name, v_network_name, v_speed, v_subnet, v_boot_protocol, v_type, v_vds_id, v_vlan_id, v_mtu, v_bridged)" More detailed log: http://pastebin.com/AHD3di5i VDSM: From git repository commit 8a14b63fbbafbdb9ee7f85a9b702bff310f4f668 oVirt-engine: From git repository comit b24dddf094e08afa6a2032a487b37476318a872d Any suggestions? Regards, Itzik

5 5

[Engine-devel] PosixFS: GUI mock-ups have been updated
by Einav Cohen 13 May '12

13 May '12

Please review the mock-ups on the feature page: http://www.ovirt.org/wiki/Features/PosixFSConnection#Changes_in_GUI Comments are welcome. ---- Thanks, Einav

8 37

[Engine-devel] Questions on NIC hotplug (http://www.ovirt.org/wiki/Features/Design/DetailedHotlugNic)
by Yaniv Kaul 13 May '12

13 May '12

1. I wasn't sure from the description, but can one change the Network to which a NIC is connected to when it's up? (looks like a much lighter and reasonable action than unplugging-changing-plugging. Also very easy to do in the physical world). I'm quite sure there's a request for such a feature. 2. The REST API usage of 'activate' and 'deactivate' is certainly not inline with the UI's terminology, which is not only a shame, but is also (to me) confusing with setting the NIC's link up/down (which is possible in QEMU, not sure if we do it in oVirt). the UI concept of arrows also seem to support 'up'/'down' ... 3. Donno if it's just the mock ups, but lets try to use 'Network Card' over 'NIC' where possible. 4. I'm not sure why do we need the 'plug' and 'unplug' buttons, and can't do it in the 'Edit' dialog box. I think it's confusing. 5. How do I create a non-plugged NIC via the API? How do I see if a VM's NIC is plugged or not via the API? 6. SDK example would be great too.

3 2

[Engine-devel] Fwd: Supporting native USB in oVirt
by Oved Ourfalli 11 May '12

11 May '12

Hey, We are now working on adding the support for native USB devices on oVirt, and we have some difficulties. Please see the details/discussion below. Thank you for your help, Oved ----- Forwarded Message ----- From: "Itamar Heim" <iheim(a)redhat.com> To: "Michal Privoznik" <mprivozn(a)redhat.com> Cc: "Oved Ourfalli" <ovedo(a)redhat.com>, "Dave Allan" <dallan(a)redhat.com>, "Jiri Denemark" <jdenemar(a)redhat.com>, "Igor Lvovsky" <ilvovsky(a)redhat.com>, "Eli Mesika" <emesika(a)redhat.com>, "Hans de Goede" <hdegoede(a)redhat.com>, "Dan Kenigsberg" <danken(a)redhat.com>, "Andrew Cathrow" <acathrow(a)redhat.com> Sent: Wednesday, May 9, 2012 1:18:40 PM Subject: Re: Supporting native USB in oVirt On 05/09/2012 01:12 PM, Michal Privoznik wrote: > On 08.05.2012 09:19, Oved Ourfalli wrote: >> Hi, >> >> We are now working on adding the support for native USB devices on oVirt. >> As far as we understand, in order to use it we need to pass the following devices with the following restrictions (according to the EHCI spec): >> 1. EHCI USB controller - with the highest function number, #7. >> >> devices='{type:controller,device:usb,model:ich9-ehci1,address:{type:pci,domain:0x0000,bus:0x00,slot:0x04,function:0x7}}' >> >> 2. 3 UHCI USB controllers, on the same bus and PCI slot as the EHCI controller. Set the multifunction bit to on, on the controller with function #0. >> >> devices='{type:controller,device:usb,model:ich9-uhci1,master:{startport:0},address:{type:pci,domain:0x0000,bus:0x00,slot:0x04,function:0x0,multifunction:on}}' >> devices='{type:controller,device:usb,model:ich9-uhci2,master:{startport:2},address:{type:pci,domain:0x0000,bus:0x00,slot:0x04,function:0x1}}' >> devices='{type:controller,device:usb,model:ich9-uhci3,master:{startport:4},address:{type:pci,domain:0x0000,bus:0x00,slot:0x04,function:0x2}}' >> >> 3. USB redirect devices (according to the needed number of USB slots, maximum 6) on the same bus, each one having a different port. >> >> devices='{type:redir,device:spicevmc,bus:usb,address:{type:usb,bus:0,port:1}}' >> devices='{type:redir,device:spicevmc,bus:usb,address:{type:usb,bus:0,port:2}}' >> devices='{type:redir,device:spicevmc,bus:usb,address:{type:usb,bus:0,port:3}}' >> devices='{type:redir,device:spicevmc,bus:usb,address:{type:usb,bus:0,port:4}}' >> devices='{type:redir,device:spicevmc,bus:usb,address:{type:usb,bus:0,port:5}}' >> devices='{type:redir,device:spicevmc,bus:usb,address:{type:usb,bus:0,port:6}}' >> >> 4. If we want more than 6 USB slots, we need to have 2 EHCI controllers, and 6 UHCI controllers, that are consistent with the restrictions above, on different bus. >> (we need them to be on different bus, since the connection between the redirect devices and the controllers is the bus). >> >> According to Hans (cc-ed), if we let libvirt pick its own addresses, it will put each controller of the composite USB controller device on its own pci slot, which is a violation of the EHCI spec. > >> >> The problem is that the oVirt engine is not aware of addresses. They aren't managed by it. >> They are chosen automatically by libvirt, returned to the engine, and they saved in the engine database in order to provide the ability to retain the same PCI addresses after VM restart. >> >> So, in order to support the EHCI spec, oVirt will have to be aware of addresses, manage them (allocate them, check for collisions, update on every libvirt change regarding that, etc...). Obviously, it doesn't feel right, and in fact it is also not feasible, to manage these addresses in the oVirt domain. >> >> Is all the above correct, or are we missing something? >> If so, can you address the issues above, and provide the ability to manage these devices in libvirt? > > Let's have this conversation upstream (libvirt-list(a)redhat.com) Many > developers are there so if there's anything libvirt can do, we should > agree on concept there.

5 9