- Devel - oVirt List Archives

[Engine-devel] Do we need ImagesToRemoveList in RemoveImageParameters?
by Yair Zaslavsky 28 Feb '12

28 Feb '12

Hi all, I see the getter code for this field is not used by Engine-Core. We perform removal of the image specified by the imageId parameter. Can we remove this parameter? Yair

2 1

[Engine-devel] final fields on entities sent to client
by Tomas Jelinek 28 Feb '12

28 Feb '12

Hi all, as the same entities as the ones used on the server are also sent to the client (e.g. org.ovirt.engine.core.common.businessentities.VM), this entities will than be serialized/deserialized using the GWT serialization. It means, this entities should follow the restrictions given by the GWT serialization: http://code.google.com/webtoolkit/doc/latest/DevGuideServerCommunication.ht… >From it I would like to point out this: "Fields that are declared final are also not exchanged during RPCs, so they should generally be marked transient as well." It means, that no fields which will be sent to client should be marked with the final keyword. Thanks, Tomas

1 0

[Engine-devel] [oVirt Jenkins] Dao test fails due to latest commits
by Eyal Edri 28 Feb '12

28 Feb '12

FYI, there is a new failure in dao tests on jenkins.ovirt.org: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/lastCompletedBuild… Test: org.ovirt.engine.core.dao.DiskImageDAOTest.testSave latest commits (that may have caused this): Changes engine: Add pre defined roles for consume quota (detail / gitweb) engine: Create default unlimited quota for DC (detail / gitweb) engine: Add quota to audit log (detail / gitweb) engine: Add validation for quota name (detail / gitweb) engine: Add/Edit quota commands (detail / gitweb) engine: Remove quota command (detail / gitweb) engine: Add quota id to VM parameters (detail / gitweb) engine: Add quota id to disk image (detail / gitweb) engine: Add quota id to vm static (detail / gitweb) frontend: Add business entities to sharedGWT (detail / gitweb) engine: Add search support for quota. (detail / gitweb) engine: Add audit log messages (detail / gitweb) engine: Add audit log messages to CRUD commands. (detail / gitweb) engine: Adding fix to quota stored procedure (detail / gitweb) engine: Add quota manager class (detail / gitweb) engine: Add quota validation support commandBase (detail / gitweb) engine: Add quota validation for AddVmCommand (detail / gitweb) engine: Add quota validation for Add Disk to VM (detail / gitweb) engine: Add quota validation for Add Vm Tempalte (detail / gitweb) engine:Add quota validation for RunVmCommand (detail / gitweb) Please check, Eyal Edri oVirt Infrastructure Team

1 0

[Engine-devel] Clone VM from snapshot feature
by Yair Zaslavsky 28 Feb '12

28 Feb '12

Hi all, I modified the Wiki pages of this feature: http://www.ovirt.org/wiki/Features/CloneVmFromSnapshot http://www.ovirt.org/wiki/Features/DetailedCloneVmFromSnapshot Comments are more than welcome Kind regards, Yair

6 25

[Engine-devel] Support for stateless nodes
by Mike Burns 27 Feb '12

27 Feb '12

There has been a lot of interest in being able to run stateless Nodes with ovirt-engine. ovirt-node has designed a way [1] to achieve this on the node side, but we need input from the engine and vdsm teams to see if we're missing some requirement or if there needs to be changes on the engine/vdsm side to achieve this. As it currently stands, every time you reboot an ovirt-node that is stateless, it would require manually removing the host in engine, then re-registering/approving it again in engine. Any thoughts, concerns, input on how to solve this? Thanks Mike [1] http://ovirt.org/wiki/Node_Stateless

8 22

[Engine-devel] network - UI Sync meeting
by Roy Golan 27 Feb '12

27 Feb '12

--=_384c57fb-d69c-42b9-b887-1ed31dd6d73e Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit The following meeting has been modified: Subject: network - UI Sync meeting Organizer: "Roy Golan" <rgolan(a)redhat.com> Location: "Asia-tlv" <asia-tlv(a)redhat.com> [MODIFIED] Resources: asia-tlv(a)redhat.com [MODIFIED] Time: Monday, February 27, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem Invitees: mkenneth(a)redhat.com; sgrinber(a)redhat.com; lpeer(a)redhat.com; dfediuck(a)redhat.com; drankevi(a)redhat.com; ecohen(a)redhat.com; iheim(a)redhat.com; ovedo(a)redhat.com; acathrow(a)redhat.com; engine-devel(a)ovirt.org; kroberts(a)redhat.com ... *~*~*~*~*~*~*~*~*~* Follow-up meeting on setup networks UI. issues to follow: 1. can VDSM attach many non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable) 2. if yes is the UI breakdown of vlan/non-vlan is probably not necessary? open issues: 1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? 2.should we implicitly set bridge/bridgeless when attaching a network with setupnetworks? 3.nickless networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it. Bridge ID: 1814335863 https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers… --=_384c57fb-d69c-42b9-b887-1ed31dd6d73e Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit <html><body><h3>The following meeting has been modified:</h3> <p> <table border='0'> <tr><th align=left>Subject:</th><td>network - UI Sync meeting </td></tr> <tr><th align=left>Organizer:</th><td>"Roy Golan" <rgolan(a)redhat.com> </td></tr> </table> <p> <table border='0'> <tr><th align=left>Location:</th><td>"Asia-tlv" <asia-tlv(a)redhat.com> [MODIFIED]</td></tr> <tr><th align=left>Resources:</th><td>asia-tlv(a)redhat.com [MODIFIED]</td></tr> <tr><th align=left>Time:</th><td>Monday, February 27, 2012, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem </td></tr></table> <p> <table border='0'> <tr><th align=left>Invitees:</th><td>mkenneth(a)redhat.com; sgrinber(a)redhat.com; lpeer(a)redhat.com; dfediuck(a)redhat.com; drankevi(a)redhat.com; ecohen(a)redhat.com; iheim(a)redhat.com; ovedo(a)redhat.com; acathrow(a)redhat.com; engine-devel(a)ovirt.org; kroberts(a)redhat.com ... </td></tr> </table> <div>*~*~*~*~*~*~*~*~*~*</div><br><br>Follow-up meeting on setup networks UI. <br>issues to follow: <br>1. can VDSM attach many non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable) <br>2. if yes is the UI breakdown of vlan/non-vlan is probably not necessary? <br><br><br>open issues: <br>1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? <br>2.should we implicitly set bridge/bridgeless when attaching a network with setupnetworks? <br>3.nickless networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it. <br><br><br>Bridge ID: 1814335863 <br><br>https://www.intercallonline.com/portlets/scheduling/viewNumbers/listNumbers… </body></html> --=_384c57fb-d69c-42b9-b887-1ed31dd6d73e Content-Type: text/calendar; charset=utf-8; method=REQUEST; name=meeting.ics Content-Transfer-Encoding: 7bit BEGIN:VCALENDAR PRODID:Zimbra-Calendar-Provider VERSION:2.0 METHOD:REQUEST BEGIN:VTIMEZONE TZID:Asia/Jerusalem BEGIN:STANDARD DTSTART:19710101T020000 TZOFFSETTO:+0200 TZOFFSETFROM:+0300 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=9;BYDAY=2SU TZNAME:IST END:STANDARD BEGIN:DAYLIGHT DTSTART:19710101T020000 TZOFFSETTO:+0300 TZOFFSETFROM:+0200 RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=-1FR TZNAME:IDT END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT UID:e6d6ce3a-e7f1-492b-9c52-65365ce2e235 SUMMARY:network - UI Sync meeting LOCATION:"Asia-tlv" <asia-tlv(a)redhat.com> ATTENDEE;CN=Miki Kenneth;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:mkenneth@redhat.com ATTENDEE;CN=Simon Grinberg;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=T RUE:mailto:sgrinber@redhat.com ATTENDEE;CN=Livnat Peer;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:lpeer@redhat.com ATTENDEE;CN=Doron Fediuck;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:dfediuck@redhat.com ATTENDEE;CN=Danny Rankevich;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE:mailto:drankevi@redhat.com ATTENDEE;CN=Einav Cohen;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:ecohen@redhat.com ATTENDEE;CN=Itamar Heim;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE :mailto:iheim@redhat.com ATTENDEE;CN=Oved Ourfalli;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:ovedo@redhat.com ATTENDEE;CN=Andrew Cathrow;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=T RUE:mailto:acathrow@redhat.com ATTENDEE;CN=engine-devel;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:engine-devel@ovirt.org ATTENDEE;CN=Keith Robertson;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE:mailto:kroberts@redhat.com ATTENDEE;CN=William Henry;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TR UE:mailto:whenry@redhat.com ATTENDEE;CN=Yaniv Kaul;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE: mailto:ykaul@redhat.com ATTENDEE;CN=Ayal Baron;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE: mailto:abaron@redhat.com ATTENDEE;CUTYPE=RESOURCE;ROLE=NON-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRU E:mailto:asia-tlv@redhat.com ORGANIZER;CN=Roy Golan:mailto:rgolan@redhat.com DTSTART;TZID="Asia/Jerusalem":20120227T160000 DTEND;TZID="Asia/Jerusalem":20120227T170000 STATUS:CONFIRMED CLASS:PUBLIC X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY TRANSP:OPAQUE LAST-MODIFIED:20120227T134527Z DTSTAMP:20120227T134527Z SEQUENCE:2 DESCRIPTION:The following meeting has been modified:\n\nSubject: network - U I Sync meeting \nOrganizer: "Roy Golan" <rgolan(a)redhat.com> \n\nLocation: "A sia-tlv" <asia-tlv(a)redhat.com> [MODIFIED]\nResources: asia-tlv(a)redhat.com [M ODIFIED]\nTime: Monday\, February 27\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +0 2:00 Jerusalem\n \nInvitees: mkenneth(a)redhat.com\; sgrinber(a)redhat.com\; lpe er(a)redhat.com\; dfediuck(a)redhat.com\; drankevi(a)redhat.com\; ecohen(a)redhat.co m\; iheim(a)redhat.com\; ovedo(a)redhat.com\; acathrow(a)redhat.com\; engine-devel @ovirt.org\; kroberts(a)redhat.com ... \n\n\n*~*~*~*~*~*~*~*~*~*\n\n\nFollow-u p meeting on setup networks UI. \nissues to follow: \n1. can VDSM attach man y non-vlan and many vlan networks to a single nic? (Dan - please reply if it s doable) \n2. if yes is the UI breakdown of vlan/non-vlan is probably not n ecessary? \n\n\nopen issues: \n1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? \n2.should we implicitly set bridge/bridgeless when attaching a network with setupnetwo rks? \n3.nickless networks - was that planned for this version? VDSM support it already but we are missing the UI and Backend for it. \n\n\nBridge ID: 1 814335863 \n\nhttps://www.intercallonline.com/portlets/scheduling/viewNumber s/listNumbersByCode.do?confCode=1814335863 X-ALT-DESC;FMTTYPE=text/html:<html><body><h3>The following meeting has been modified:</h3>\n\n<p>\n<table border='0'>\n<tr><th align=left>Subject:</th>< td>network - UI Sync meeting </td></tr>\n<tr><th align=left>Organizer:</th>< td>"Roy Golan" &lt\;rgolan(a)redhat.com&gt\; </td></tr>\n</table>\n<p>\n<table border='0'>\n<tr><th align=left>Location:</th><td>"Asia-tlv" <asia-tlv@redh at.com> [MODIFIED]</td></tr>\n<tr><th align=left>Resources:</th><td>asia-tlv @redhat.com [MODIFIED]</td></tr>\n<tr><th align=left>Time:</th><td>Monday\, February 27\, 2012\, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem\n </td></t r></table>\n<p>\n<table border='0'>\n<tr><th align=left>Invitees:</th><td>mk enneth(a)redhat.com\; sgrinber(a)redhat.com\; lpeer(a)redhat.com\; dfediuck@redhat .com\; drankevi(a)redhat.com\; ecohen(a)redhat.com\; iheim(a)redhat.com\; ovedo@re dhat.com\; acathrow(a)redhat.com\; engine-devel(a)ovirt.org\; kroberts(a)redhat.co m ... </td></tr>\n</table>\n<div>*~*~*~*~*~*~*~*~*~*</div><br><br>Follow-up meeting on setup networks UI. <br>issues to follow: <br>1. can VDSM attach m any non-vlan and many vlan networks to a single nic? (Dan - please reply if its doable) <br>2. if yes is the UI breakdown of vlan/non-vlan is probably n ot necessary? <br><br><br>open issues: <br>1.should we use "VmNetwork"? (or "allow/able to run VMs" you name it) would it be a DC or a Cluster property? <br>2.should we implicitly set bridge/bridgeless when attaching a network w ith setupnetworks? <br>3.nickless networks - was that planned for this versi on? VDSM support it already but we are missing the UI and Backend for it. <b r><br><br>Bridge ID: 1814335863 <br><br>https://www.intercallonline.com/port lets/scheduling/viewNumbers/listNumbersByCode.do?confCode=1814335863 </body> </html> BEGIN:VALARM ACTION:DISPLAY TRIGGER;RELATED=START:-PT5M DESCRIPTION:Reminder END:VALARM END:VEVENT END:VCALENDAR --=_384c57fb-d69c-42b9-b887-1ed31dd6d73e--

1 0

[Engine-devel] [backend] a little confusion about the quartz jobs
by Laszlo Hornyak 23 Feb '12

23 Feb '12

hi, I was playing with the quartz jobs in the backend and I thought this is an area where some simplification and/or cleanup would be useful. - SchedulerUtil interface would be nice to hide quartz from the rest of the code, but it very rarely used, the clients are bound to it's single implementation, SchedulerUtilQuartzImpl through it's getInstance() method. - It was designed to be a local EJB, Backend actually expects it to be injected. (this field is not used) - when scheduling a job, you call schedule...Job(Object instance, String methodName, ...) however, it is not the _methodname_ that the executor will look for - instead, it will check the OnTimerMethodAnnotation on all the methods. But this annotation has everywhere the methodName as value - JobWrapper actually iterates over all the methods to find the one with the right annotation So a quick simplification could be: - The annotation is not needed, it could be removed - JobWrapper could just getMethod(methodName, argClasses) instead of looking for the annotation in all of the methods - I am really not for factoryes, but if we want to separate the interface from the implementation, then probably a SchedulerUtilFactory could help here. The dummy implementation would do just the very same thing as the SchedulerUtilQuartzImpl.getInstance() - I would remove the reference to SchedulerUtil from Backend as well, since it is not used. Really _should_ the Backend class do any scheduling? Please share your thoughts. Thank you, Laszlo

4 8

[Engine-devel] bridge-less networks design wiki update
by Roy Golan 23 Feb '12

23 Feb '12

Hi all, Please find bridge-less network design wiki updated with changes following the latest discussions. www.ovirt.org/wiki/Features/Design/Network/Bridgeless_Networks Thanks, Roy

1 0

[Engine-devel] reviewer needed for schedulerutil cleanup
by Laszlo Hornyak 22 Feb '12

22 Feb '12

hi, As we previously agreed, I renamed the SchedulerUtil to SchedulerManager and removed the OnTimerAnnotation, can someone please review? http://gerrit.ovirt.org/#change,2140 Thanks, Laszlo

1 0

[Engine-devel] gwt: new "userportal-gwtp" module, new "gwt-user-gwtp" mvn profile
by Einav Cohen 22 Feb '12

22 Feb '12

Hi, A new oVirt UI module that is called "userportal-gwtp" has been introduced recently; it is written on top of the "gwt-common" infrastructure (on which the "web-admin" is based), and is targeted to eventually replace the existing "userportal" module. This module is still on the works - it is not fully functional yet. In order to build this new project (i.e., compile it to java-script), you need to "mvn build" oVirt with the "gwt-user-gwtp" profile (i.e., with "-Pgwt-user-gwtp"). The "gwt-user-gwtp" mvn profile has been added to the oVirt gwt Jenkins job, so in case of committing a change in the oVirt code that breaks mvn compilation that includes the "gwt-user-gwtp" profile, a relevant notification from Jenkins will be sent to the relevant recipients (just like notifications regarding breaking oVirt compilation with the other two gwt profiles, i.e, "gwt-user" and "gwt-admin", are already being sent). ---- Thanks, Einav

2 1