December 2015 - Devel - oVirt List Archives

[ANN] oVirt 3.6.1 Fourth Release Candidate is now available for testing
by Sandro Bonazzola 11 Dec '15

11 Dec '15

The oVirt Project is pleased to announce the availability of the Fourth Release Candidate of oVirt 3.6.1 for testing, as of December 10th, 2015. This release is available now for Fedora 22, Red Hat Enterprise Linux 6.7, CentOS Linux 6.7 (or similar) and Red Hat Enterprise Linux >= 7.1, CentOS Linux >= 7.1 (or similar). This release supports Hypervisor Hosts running Red Hat Enterprise Linux >= 7.1, CentOS Linux >= 7.1 (or similar) and Fedora 22. Highly experimental support for Debian 8.2 Jessie has been added too. This release candidate includes updated packages for: - ovirt-engine - ovirt-engine-extension-aaa-ldap This release of oVirt 3.6.1 includes numerous bug fixes. See the release notes [1] for an initial list of the new features and bugs fixed. Please refer to release notes [1] for Installation / Upgrade instructions. A new oVirt Live ISO will be available soon[2]. Please note that mirrors[3] may need usually one day before being synchronized. Please refer to the release notes for known issues in this release. [1] http://www.ovirt.org/OVirt_3.6.1_Release_Notes [2] http://resources.ovirt.org/pub/ovirt-3.6-pre/iso/ [3] http://www.ovirt.org/Repository_mirrors#Current_mirrors -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

3 3

oVirt engine 4.0 will require WildFly 10 / EAP 7
by Martin Perina 11 Dec '15

11 Dec '15

Hi, we are going to merge patches which drops EAP 6 support [1] and requires WildFly 10 / EAP 7 [2] for oVirt engine master on Monday December 14th at 10:00 CET. This is a huge step as we will finally be able to use all new features provided by WildFly 10 (J2EE 7, Java 8, RESTEasy 3, ActiveMQ Artemis, Hibernate 5, ...). Upgrade of code base to use those new features will be done incrementally, for example this patch [3] cleans up our CDI related code and upgrades to CDI 1.2. So on Monday please upgrade WildFly packages on your development machines to: ovirt-engine-wildfly-10.0.0 ovirt-engine-wildfly-overlay-10.0.0 and rebase your patches on top of latest master. To ease backporting of patches to oVirt 3.6 we have already merged patches which made oVirt 3.6 compatible with WildFly 10, but please bear in mind that oVirt 3.6 have to be compatible with EAP 6 and there are no plans to upgrade it to WildFly 10! Please contact me or other members of infra team if you have any issue with this upgrade. Thanks Martin Perina [1] https://gerrit.ovirt.org/48208 [2] https://gerrit.ovirt.org/48209 [3] https://gerrit.ovirt.org/48305

2 2

Re: [ovirt-devel] Question about https://gerrit.ovirt.org/#/c/49860/
by Allon Mureinik 10 Dec '15

10 Dec '15

Adding devel list, which was dropped by mistake. On Thu, Dec 10, 2015 at 1:56 PM, Allon Mureinik <amureini(a)redhat.com> wrote: > > > On Wed, Dec 9, 2015 at 6:51 PM, Vojtech Szocs <vszocs(a)redhat.com> wrote: > >> Hi Allon, >> >> not sure if you saw my email (below) but I was wondering >> what's your opinion about test method naming conventions. >> > Generally agree with that, and I tried excluding them where possible - if > I missed any, please say so. > > > >> >> Also, regarding patch https://gerrit.ovirt.org/#/c/49910/ >> why not simply exclude all Java files under src/test/java >> for all projects? (What's the advantage of having per-file >> exclude list of test classes?) >> > I hat overly-broad exclusions. > There are a ton of badly named method in test classes, and I don't want to > encourage any more. > Although if you think this is getting out of hand, we could just do that... > > > >> >> To address other files, like "Other GWT-related classes" >> in [1] -- did you consider adding some source-level Java >> annotation like @DontCheckMethodNames or similar? (Again, >> avoid per-file exclude list of other classes.) >> > Yeah, but I don't want to have to write my own checker - this is a > standard checkstyle check... > > >> >> [1] >> https://gerrit.ovirt.org/#/c/49910/4/build-tools-root/checkstyles/src/main/… >> >> Thanks, >> Vojtech >> >> >> ----- Forwarded Message ----- >> From: "Vojtech Szocs" <vszocs(a)redhat.com> >> To: "devel" <devel(a)ovirt.org> >> Sent: Monday, December 7, 2015 8:00:36 PM >> Subject: [ovirt-devel] Question about https://gerrit.ovirt.org/#/c/49860/ >> >> Hi Allon! >> >> patch in $subject modifies test method name from: >> >> testGetLocaleFromStringString_withDefault >> >> to: >> >> testGetLocaleFromStringStringWithDefault >> >> I've always thought that Java test method names should be >> as much readable as possible, because in Java tests, the >> method name is used to describe the particular test case. >> >> (Unfortunately, Java test frameworks don't do a good job >> in this area.. please correct me if I'm wrong.) >> >> So with JS/Jasmine we can do this: >> >> describe('LocaleUtils', function () { >> it('should extract locale from given String', function () { >> // actual test code >> }); >> }); >> >> but in Java we usually do this: >> >> // <methodName>_<extraInfoForSpecificTestCase> >> void testGetLocaleFromStringString_withDefault >> >> which is already far from readable, and this: >> >> testGetLocaleFromStringStringWithDefault >> >> makes it even worse.. Even though it complies with Java >> method naming convention, it totally obfuscates what is >> that particular test case about, which means people who >> want to maintain such tests need to spend time studying >> what the test is actually doing.. >> >> What's your take on this? >> >> Regards, >> Vojtech >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> > >

1 0

unable to add host ~ InitVdsOnUpCommand parameters specifies storage domain ID when creating host.
by Martin Mucha 10 Dec '15

10 Dec '15

Hi, 'm unable to add host to engine. I have fresh engine build, cleaned host, dropped and recreated DB. I'm adding host using rest¹. Command InitVdsOnUpCommand is called during operation, having getStoragePoolId() equal to 00000001-0001-0001-0001-0000000000c1. However, there's no storage domain in system — it's empty installation, and I'm only creating host yet (so I cannot have any storage domain). Because of that, following code: StorageDomain masterDomain = getStorageDomainDao().getStorageDomains(storagePoolId, StorageDomainType.Master).get(0); in method: org.ovirt.engine.core.bll.InitVdsOnUpCommand#runConnectHostToPoolEvent produces NPE, which is probably cause of host marked as nonoperational. ——— If I'm doing something wrong, plese advice. Martin. [1] curl -v -u "admin@internal:adminadmin" -H "Content-type: application/xml" -d " <host> <name>$NAME</name> <address>10.34.63.167</address> <root_password>qum5net</root_password> <cluster> <name>$CLUSTERNAME</name> </cluster> </host> " -X POST http://localhost:8080/ovirt-engine/api/hosts

1 0

[ANN] oVirt 3.6.1 Third Release Candidate is now available for testing
by Sandro Bonazzola 10 Dec '15

10 Dec '15

The oVirt Project is pleased to announce the availability of the Third Release Candidate of oVirt 3.6.1 for testing, as of December 10th, 2015. This release is available now for Fedora 22, Red Hat Enterprise Linux 6.7, CentOS Linux 6.7 (or similar) and Red Hat Enterprise Linux >= 7.1, CentOS Linux >= 7.1 (or similar). This release supports Hypervisor Hosts running Red Hat Enterprise Linux >= 7.1, CentOS Linux >= 7.1 (or similar) and Fedora 22. Highly experimental support for Debian 8.2 Jessie has been added too. This release candidate includes updated packages for: - ovirt-engine - ovirt-engine-extension-aaa-jdbc - ovirt-hosted-engine-ha - ovirt-hosted-engine-setup - vdsm This release of oVirt 3.6.1 includes numerous bug fixes. See the release notes [1] for an initial list of the new features and bugs fixed. Please refer to release notes [1] for Installation / Upgrade instructions. A new oVirt Live ISO will be available soon[2]. Please note that mirrors[3] may need usually one day before being synchronized. Please refer to the release notes for known issues in this release. [1] http://www.ovirt.org/OVirt_3.6.1_Release_Notes [2] http://resources.ovirt.org/pub/ovirt-3.6-pre/iso/ [3] http://www.ovirt.org/Repository_mirrors#Current_mirrors -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

Question about https://gerrit.ovirt.org/#/c/49860/
by Vojtech Szocs 09 Dec '15

09 Dec '15

Hi Allon! patch in $subject modifies test method name from: testGetLocaleFromStringString_withDefault to: testGetLocaleFromStringStringWithDefault I've always thought that Java test method names should be as much readable as possible, because in Java tests, the method name is used to describe the particular test case. (Unfortunately, Java test frameworks don't do a good job in this area.. please correct me if I'm wrong.) So with JS/Jasmine we can do this: describe('LocaleUtils', function () { it('should extract locale from given String', function () { // actual test code }); }); but in Java we usually do this: // <methodName>_<extraInfoForSpecificTestCase> void testGetLocaleFromStringString_withDefault which is already far from readable, and this: testGetLocaleFromStringStringWithDefault makes it even worse.. Even though it complies with Java method naming convention, it totally obfuscates what is that particular test case about, which means people who want to maintain such tests need to spend time studying what the test is actually doing.. What's your take on this? Regards, Vojtech

2 1

[Russian oVirt localization] Missing English ApplicationConstants.properties in 3.6
by Juliette Tux 09 Dec '15

09 Dec '15

Hello, There is a missing original English .properties file in tar.gz archives for 3.6.* source. The directory is 'frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin'. There are only translated properties files but no original English ApplicationConstants.properties. Where can I find it, please? Best regards, Julia Dronova -- С уважением, Дронова Юлия

3 7

[vdsm][oVirt 4.0] trimming down vm.py, stage 1
by Francesco Romani 09 Dec '15

09 Dec '15

Hi all, as many already know, we have a problem in the vdsm/virt/* area with the size of vm.py. As in today's master (SHA1: ed7618102e4e3aedf859adb1084eecded8e5158d), vm.py weights like: 1082 11:28:09 fromani@musashi ~/Projects/upstream/vdsm $ ls -lh vdsm/virt/vm.py -rw-rw-r--. 1 fromani fromani 209K Nov 24 11:15 vdsm/virt/vm.py 1083 11:30:22 fromani@musashi ~/Projects/upstream/vdsm $ wc vdsm/virt/vm.py 5202 17125 213026 vdsm/virt/vm.py I'd like to renew my commitment to bring this monster down to a sane size. I don't think we can make it in one go. We should tackle this monster task in stages. We have roughly five weeks left until the end of the year. Sounds like a good timespan for the first stage, and I'm aiming for go down under the 4000 line mark. So we have roughly 1200 lines to eliminate somehow. This is the initial plan I'm thinking off, in expected increasing difficulty level, from easies to hardest: 1. LiveMergeCleanupThread: Chance to break things: minimal - roughly 120 lines (10% of the goal) - can be moved verbatim (cut/paste) elsewhere, like vdsm/virt/livemerge.py, fixing only import paths. 2. the findDrive* family of functions: Chance to break things: minimal/very low - roughly 50 lines (~4% of the goal) - can be moved with minimal changes elsewhere, like vdsm/virt/storage/????.py, 3. the getConf* faimily of functions: Chance to break things: medium-to-high in the 3.x branch, low on 4.x because we drop backward compat. - roughly 110 lines (~9% of the goal) - just drop them for 4.0! - alternatively, need to figure out a proper place, maybe a new module? 4. the Devices/VM setup bits All scatthered through vm.py (e.g. _buildDomainXML, DeviceMapping table) Chance to break things: medium-to-low, depends on individual patches - all summed up, roughly 200 lines (~18% of the goal) - need serious cleanup - no definite plan - mostly is cut/paste or transform Vm methods into functions 5. the getUnderlying* familiy of functions: Chance to break things: low (maybe medium on some cases, to lean on the safe side) - roughly 550 lines (~46% of the goal) - easy to test (just run vms!) - can be moved in the devices/ subpackage with some changes. - require further work in the area to properly integrate this code in the device objects - more work is planned in this area, including move from minidom to ElementTree So far, I've gathered ~1030 lines, so I'm short of 170 lines to reach the goal, but I'm confident I can find something more. The plan now is to start from the easy parts *and* in background with #4, which requires way more work than everything else. Thoughts, objections and suggestions all welcome, especially from storage people, because first items in my list affects them. Thanks and bests, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani

1 2

[VDSM] CI failure - testEnablePromisc (ipwrapperTests.TestDrvinfo)
by Nir Soffer 09 Dec '15

09 Dec '15

Hi all, This is not the first time this test fails, but it is a rare failure. Anyone has a clue why it fails? According the captured log, all the ip runs are successful. Can it be an issue on specific slave? 21:25:25 ====================================================================== 21:25:25 FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo) 21:25:25 ---------------------------------------------------------------------- 21:25:25 Traceback (most recent call last): 21:25:25 File "/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/ipwrapperTests.py", line 130, in testEnablePromisc 21:25:25 "Could not enable promiscuous mode.") 21:25:25 AssertionError: Could not enable promiscuous mode. 21:25:25 -------------------- >> begin captured logging << -------------------- 21:25:25 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /usr/sbin/brctl show (cwd None) 21:25:25 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0 21:25:25 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link add name vdsm-ooqBPb type bridge (cwd None) 21:25:25 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0 21:25:25 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link set dev vdsm-ooqBPb up (cwd None) 21:25:25 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0 21:25:25 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link set dev vdsm-ooqBPb promisc on (cwd None) 21:25:25 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0 21:25:25 --------------------- >> end captured logging << --------------------- See http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1101/conso… Nir

2 1

[oVirt jenkins] Weekly report on open tasks for ovirt-engine
by jenkins＠ovirt.org 08 Dec '15

08 Dec '15

------=_Part_637_49831877.1449574721798 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Files scanned: '**/*.java, **/*.py'. Strings searched: FIXME | TODO | @deprecated Report: http://jenkins.ovirt.org/job/ovirt_engine_scan_open_tasks/42/tasksResult/? ------=_Part_637_49831877.1449574721798--

1 0