- Devel - oVirt List Archives

[Engine-devel] java enum syntax trick
by Laszlo Hornyak 18 Apr '12

18 Apr '12

Hi, In java enums, you can leave a coma before the semicolon closing the names in the enum. e.g. enum Foo { bar, baz, // <!-- last, still with a coma ; //and there is no more } I don't know if this fits in the code formating requirements, but maybe it could help us to waste less time on merging because you did not have to change the last line to add some more. Laszlo

2 1

[Engine-devel] Postgres DB Upgrade Procedure wiki
by Eli Mesika 17 Apr '12

17 Apr '12

Hi guys This is an updated version of our Postgres DB Upgrade Procedure. Most of it is not new and main changes are in the new "Configuration changes" section Please review and comment, we need this applied upstream ASAP http://www.ovirt.org/wiki/Postgres-database-upgrade-procedure

1 0

[Engine-devel] Query regarding ValidationUtils#validateInputs
by Shireesh Anjal 17 Apr '12

17 Apr '12

This is a multi-part message in MIME format. --------------060906010904020105000601 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi, This is regarding the following validation method we have in ValidationUtils: /public static <T extends VdcActionParametersBase> ArrayList<String> validateInputs(List<Class<?>> validationGroupList, T parameters);/ I there any particular reason for supporting the validations only on objects of classes derived from VdcActionParametersBase? I guess this was done because this method is primarily intended to validate the action parameters passed to a BLL action, using the validation annotations on the parameter class. However I think this method can be useful for general use as well. e.g. I cannot add a "@Valid" annotation on a "list" or a "map" in a parameter class. So I need to iterate over the list/map, and validate each element inside the loop. The validation inside the loop can also utilize the above method if the restriction "extends VdcActionParametersBase" is removed. This will allow me to do the following in the canDoAction method: protected boolean canDoAction() { ... for(GlusterBrickEntity brick : getParameters().getGlusterVolume().getBricks()) { List<String> errors = ValidationUtils.validateInputs(getValidationGroups(), brick); if(errors != null) { for(String error : errors) { addCanDoActionMessage(error); } } } ... } Regards, Shireesh --------------060906010904020105000601 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> </head> <body bgcolor="#FFFFFF" text="#000000"> Hi, This is regarding the following validation method we have in ValidationUtils: public static <T extends VdcActionParametersBase> ArrayList<String> validateInputs(List<Class<?>> validationGroupList, T parameters); I there any particular reason for supporting the validations only on objects of classes derived from VdcActionParametersBase? I guess this was done because this method is primarily intended to validate the action parameters passed to a BLL action, using the validation annotations on the parameter class. However I think this method can be useful for general use as well. e.g. I cannot add a "@Valid" annotation on a "list" or a "map" in a parameter class. So I need to iterate over the list/map, and validate each element inside the loop. The validation inside the loop can also utilize the above method if the restriction "extends VdcActionParametersBase" is removed. This will allow me to do the following in the canDoAction method: protected boolean canDoAction() { ...     for(GlusterBrickEntity brick : getParameters().getGlusterVolume().getBricks()) {         List<String> errors = ValidationUtils.validateInputs(getValidationGroups(), brick);         if(errors != null) {             for(String error : errors) {                 addCanDoActionMessage(error);             }         }     } ... } Regards, Shireesh </body> </html> --------------060906010904020105000601--

3 3

Re: [Engine-devel] [Users] Hey everyone how do we upgrade engine?
by Livnat Peer 16 Apr '12

16 Apr '12

On 13/04/12 19:59, Itamar Heim wrote: > On 04/13/2012 06:42 PM, Dominic Kaiser wrote: >> I am running 3.0.0_0001-1.6.fc16 ovirt engine and has been great! I >> appreciate Red Hat and all the support from the community on this >> project you all are awesome! >> >> I have not thought about it yet but was looking on the wiki and did not >> see how to upgrade and reninstallengine. What have been your >> experiences doing this and is it worth it? And how to do it? Sorry if >> it was posted somewhere else just let me know if there is info on this >> already. > > by running the engine-upgrade utility, though i suspect it will have to > pass some testing/bug fixes for the second release before can be used > (doing a test upgrade at that phase on your environment would help > finding issues) > We have one issue that we know of and we'll fix soon - https://bugzilla.redhat.com/show_bug.cgi?id=790303 If you are interested you can track engine-devel(a)ovirt.org list for updates on this in the upcoming week (or keep track of the bug status). Livnat >> >> I have had the greatest experience moving from 2 esxiservers to ovirt. >> You guys and gals rock! > thanks - nice to hear. > _______________________________________________ > Users mailing list > Users(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/users

1 0

[Engine-devel] REST session management
by Oved Ourfalli 16 Apr '12

16 Apr '12

Hey, The following wiki page describes a new feature - supporting session management via the REST API: http://www.ovirt.org/wiki/Features/RESTSessionManagement Please review and comment. Thank you, Oved

4 10

[Engine-devel] Getting into memory allocation problems in git?
by Yair Zaslavsky 16 Apr '12

16 Apr '12

Hi all, I got a strange error while trying to fetch a patch from ovrit gerrit. The error looked like this - git fetch http://gerrit.ovirt.org/p/ovirt-engine refs/changes/41/3541/1 && git checkout FETCH_HEAD error: Could not resolve host: gerrit.ovirt.org; Cannot allocate memory while accessing http://gerrit.ovirt.org/p/ovirt-engine/info/refs fatal: HTTP request failed Could not find anything interesting in google, and out of despair started to pass on manual of git. I then encountered git gc. My java instincts told me to give it a shot (after all, garbage collection sounds good), and it worked! (Nothing helped before - not removing local branches, not trying to perform this from various branches, etc...) FYI Yair

1 0

[Engine-devel] Issue with XML namespaces in engine-setup
by Juan Hernandez 14 Apr '12

14 Apr '12

Hello, The code that we use in engine-setup to modify JBoss AS XML configuration files uses the following pattern: datasourceStr = ''' <datasource ...> ... </datasource> ''' xmlObj.addNodes("//datasource:subsystem/datasource:datasources", datasourceStr) This looks correct but is in fact generating a incorrect XML document, as the tags being added are not associated to a namespace. The resulting XML file will be correct, but the temporary representation in memory is not. This causes problems if you later, before writing out the modified file, try to use xpath expressions matching the added nodes: there will be no match. I would suggest that we change the pattern to something like this: datasourceStr = ''' <any_dummy_tag xmlns="urn:jboss:domain:datasources:1.0"> <datasource ...> ... </datasource> </any_dummy_tag> ''' datasourceNodes = libxml2.parseDoc(datasourceStr).getRootElement().children xmlObje.addNodes("//datasource:subsystem/datasource:datasources", datasourceNodes) This way both the representation in memory and the resulting file are correct. Le me know what you think. Regards, Juan Hernandez -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.

4 5

[Engine-devel] Hot-plug of disks and nics
by Ori Liel 11 Apr '12

11 Apr '12

On the subject of activate/deactivate disks and nics ("hot-plug"), I'd like to hear opinions about the correct modelling. I see two possible options (I will use disks as an example, but the chosen modelling should be the same for nics and disks). Option 1 - update: ================= PUT .../api/vms/{vm:id}/disks/{disk:id} <disk> <activated>true</activated> </disk> Pros: ----- * RESTful, no need for new action Cons: ----- * Inconsistent with other flows. We do not normally update status fields to perform actions. For example to run a VM, we do not update it's status to 'activated', we run an action (start). * Enables user to update disk properties AND activate/deactivate in the same operation. Updating certain disk properties is forbidden while the VM is up, but activating/deactivating the disk is allowed always. This requires business-logic in REST-API: if the user activates the disk and changes properties on it - REST-API must first change the properties and then activate the disk (if disk is activated first, update properties will fail). If, on the other hand, the user *deactivates* the disk and changes properties on it - REST-API must first deactivate the disk and then change the properties (changing properties while disk is still active will fail). This bug-prone logic is only necessary because when activate/deactivate is merged with update. Option 2 - action ================= .../api/vms/{vm:id}/disks/{disk:id}/attach Pros: ---- * Less RESTful Cons: ----- * Consistent with other flows * Does not have the drawback of the additional business-logic described above Opinions? Thanks, Ori.

4 5

[Engine-devel] Canceled: oVirt sync meeting (11.04.2012)
by Ofer Schreiber 11 Apr '12

11 Apr '12

Due to low number of attendees, the weekly sync meeting [1] is canceled. Happy holiday, Ofer Schreiber oVirt Release Manager [1] Happens every Wednesday on 14:00 UTC, #ovirt irc channel (oftc)

1 0

[Engine-devel] Floating Disks implementation in REST-API
by Ori Liel 11 Apr '12

11 Apr '12

The "Floating Disks" feature makes disks into stand-alone entities: a given disk may be attached to a VM (as all disks are today), or it may be not attached to any VM, which makes it a floating disk (http://www.ovirt.org/wiki/Features/FloatingDisk) To implement attach/detach of disk to/from VM in REST-API, we intend to introduce two new actions: POST .../api/vms/{vm:id}/disks/{disk:id}/attach POST .../api/vms/{vm:id}/disks/{disk:id}/detach Since we try not to add new actions unless we have to, I want to explain why I believe that these actions are necessary. The other implementation would use existing add/remove flows: POST .../api/vms/{vm:id}/disks - if the disk was passed with an ID, attach it to this VM. If no id - create a new disk. DELETE .../api/vms/{vm:id}/disks/{disk:id} - *ambiguity problem, need to add a flag* We can't break existing API, so regular DELETE must remove the disk, as it does today. To detach a disk using DELETE we'd have to add a flag to the DETELE command. This is quite risky, because if the user forgets to pass this flag, the disk which he wanted to detach will actually be deleted. Theoretically, if we could break the API, the following modelling would resolve the ambiguity and perhaps be ideal: - POST/DELETE disk in root context means create or delete it. - POST/DELETE disk in VM context means attach or detach it. But we don't have the privilege of breaking the API. Considering all of the above - and the fact that attach/detach nics to/from host is also implemented using actions - I believe that the new actions are justifiable. Any comments? Thanks, Ori

6 10