- Devel - oVirt List Archives

Vdsm patches need review and merge
by Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) 16 May '14

16 May '14

--_000_08AA403C8399104A89AF710307FA78AE24404869G5W2743americas_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Martin, Could you help to review these numa vdsm patches: http://gerrit.ovirt.org/#/c/27399/ http://gerrit.ovirt.org/#/c/27090/ http://gerrit.ovirt.org/#/c/27403/ http://gerrit.ovirt.org/#/c/26876/ You had already reviewed some of the patches, but after that I modified the= transferred data format because of the xmlrpc limitations. So could you pl= ease review them again? Hi Dan, I have modified your comments for some of the above patches. Could you plea= se take a look and merge those if no more comments? Thanks & Best Regards Shi, Xiao-Lei (Bruce) Hewlett-Packard Co., Ltd. HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com<mailto:shiguo.li@hp.com> --_000_08AA403C8399104A89AF710307FA78AE24404869G5W2743americas_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div class=3D"WordSection1"> Hi Martin,<o:p></o:p> Could you help to review these numa vdsm patches:<o:= p></o:p> <a href=3D"http://gerrit.ovirt.org/#/c/27399/">http:= //gerrit.ovirt.org/#/c/27399/</a><o:p></o:p> <a href=3D"http://gerrit.ovirt.org/#/c/27090/">http:= //gerrit.ovirt.org/#/c/27090/</a><o:p></o:p> <a href=3D"http://gerrit.ovirt.org/#/c/27403/">http:= //gerrit.ovirt.org/#/c/27403/</a><o:p></o:p> <a href=3D"http://gerrit.ovirt.org/#/c/26876/">http:= //gerrit.ovirt.org/#/c/26876/</a><o:p></o:p> You had already reviewed some of the patches, but af= ter that I modified the transferred data format because of the xmlrpc limit= ations. So could you please review them again?<o:p></o:p> <o:p> </o:p> Hi Dan,<o:p></o:p> I have modified your comments for some of the above = patches. Could you please take a look and merge those if no more comments?<= o:p></o:p> <o:p> </o:p> Thanks & Best Regards<o:p></o:p> Shi, Xiao-Lei (Bruce)<o:p></o:p> <o:p> </o:p> Hewlett-Packard Co., Ltd. HP Servers Core Platform Software China <o:p></o:p> Telephone +86= 23 65683093<o:p></o:p> Mobile +86 18696583447<o:p></o:p><= /span> Email </b= ><a href=3D"mailto:shiguo.li@hp.com"><span= style=3D"color:blue">xiao-lei.shi(a)hp.com</a><o:p></o:p> <o:p> </o:p> </div> </body> </html> --_000_08AA403C8399104A89AF710307FA78AE24404869G5W2743americas_--

4 5

Re: [ovirt-devel] [vdsm] pep8 issue
by Dan Kenigsberg 15 May '14

15 May '14

On Tue, May 13, 2014 at 05:22:15PM -0300, Amador Pahim wrote: > Building vdsm/master in F20, I've got: > > ./vdsm/virt/migration.py:223:19: E225 missing whitespace around operator > > In vdsm/virt/migration.py: > > 218 e.err = (libvirt.VIR_ERR_OPERATION_ABORTED, # error code$ > 219 libvirt.VIR_FROM_QEMU, # error > domain$ > 220 'operation aborted', # error > message$ > 221 libvirt.VIR_ERR_WARNING, # error > level$ > 222 '', '', '', # str1, str2, > str3,$ > 223 -1, -1) # int1, int2$ > 224 raise e$ > > pep8 is not accepting negative integer. Instead, it is handling the > minus sign as an operator. Quick workaround is change -1 to int(-1). > Is this a known? Now it is ;-) > > I'm using python-pep8-1.5.4-1.fc20.noarch It seems like a bug in pep8 tool, and I see that it does not reproduce with v1.5.6 thereof. I'm adding Matthias who may agree to backport the fix to Fedora 20 (or upgrade completely to 1.5.6)

3 6

spacing fix with PatternFly and tables
by Greg Sheremeta 15 May '14

15 May '14

Hi, With the PatternFly look and feel patch applied, GWT's spacing attribute is no longer reliable. When GWT renders a table with this, it puts "cellspacing='10'" into the table. This no longer works, probably because we changed to border-box model. The alternative: .some-table { border-spacing: 10px; border-collapse: separate; } Greg Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme(a)redhat.com

1 1

GFS2 mount via symlink problem
by Enrico Tagliavini 15 May '14

15 May '14

Hi, this issues i described on Red Hat bugzilla entry #888711 [1], but I'll recap here since there is come confusion (mostly my fault, sorry!) in the bug. System setup: CentOS 6.5 fully up to date SGI IS5000 SAS storage with 2 servers connected oVirt is 3.4.0 The Storage configured in oVirt is PosixFS, vfs type is gfs2 gfs2 is on top of CLVM Red Hat Cluster Manager (cman) is used to manage CLVM The issue is summarized by: [root@fionn-virt1 ~]# grep virtstorage /etc/fstab /dev/mapper/vg_is5000-lv_virtstorage /gfs2/virtstorage gfs2 noatime,nodiratime,nobarrier 0 0 [root@fionn-virt1 ~]# grep virtstorage /proc/mounts /dev/dm-13 /gfs2/virtstorage gfs2 rw,seclabel,noatime,nodiratime,hostdata=jid=0,nobarrier 0 0 /dev/dm-13 /rhev/data-center/mnt/_dev_mapper_vg__is5000-lv__virtstorage gfs2 rw,seclabel,noatime,nodiratime,hostdata=jid=0,nobarrier 0 0 [root@fionn-virt1 ~]# grep virtstorage /etc/mtab /dev/mapper/vg_is5000-lv_virtstorage /gfs2/virtstorage gfs2 rw,seclabel,noatime,nodiratime,hostdata=jid=0,nobarrier 0 0 /dev/mapper/vg_is5000-lv_virtstorage /rhev/data-center/mnt/_dev_mapper_vg__is5000-lv__virtstorage gfs2 rw,seclabel,noatime,nodiratime,hostdata=jid=0,nobarrier 0 0 The storage is mounted twice, first by the gfs2 init script and then by ovirt. As you can see even if both ovirt and gfs2 init script used the /dev/mapper/name symlink, in proc mounts there is the real device specified, the one the symlink is pointing to. I have no clue why only GFS2 does that (at least ext* FS are not, didn't checked anything else TBO, I have only ext* FS on other LVM volumes on the same system). In this case oVirt fails to check if the FS is mounted, since there is no entry in /proc/mounts matching the device name specified (the /dev/mapper/name one). I my example above I already applied a fix for that, so it is actually working. I've submitted a fix to ovirt gerrit, see [2], [3] and [4] (the latter is a unit test for checking gfs2). Note that [2] alone is not correct, it needs [3] as well to not break some other setup. Dan Kenigsberg of Red Hat suggested to move the discussion here, since this is a weird issue (why just GFS2 resolves the symlink?). I'm looking for advise, comments to the fix I proposed, but also about if this is actually the better fix? Like fixing GFS2 in the first place. That said I still think this should be handled by ovirt. It doesn't really matter if in /proc/mounts you have the symlink or the real device, it is the same mount Kind regards Enrico [1] https://bugzilla.redhat.com/show_bug.cgi?id=888711 [2] http://gerrit.ovirt.org/27321 [3] http://gerrit.ovirt.org/27425 [4] http://gerrit.ovirt.org/27514

2 2

limiting gwt compiler threads to 1
by Greg Sheremeta 15 May '14

15 May '14

Hi, On Fedora 20, I sometimes get GWT compiler crashes due to OutOfMemory. So I tried limiting to 1 thread like so: make clean install-dev PREFIX=$HOME/ovirt-engine DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=gecko1_8,safari" BUILD_UT=0 DEV_EXTRA_BUILD_FLAGS="-Dgwt.jjs.maxThreads=1 -Dgwt.jjs.permutationWorkerFactory=com.google.gwt.dev.ThreadedPermutationWorkerFactory" When the two compiler threads spawn, they seem to fire at the same time. [INFO] Compiling 2 permutations [INFO] Compiling permutation 0... [INFO] Compiling permutation 1... I would expect there to be a delay while 1 waits for 0: [INFO] Compiling 2 permutations [INFO] Compiling permutation 0... <30 second pause...> <done> [INFO] Compiling permutation 1... <30 second pause...> <done> Do I have the options wrong? Greg Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme(a)redhat.com

3 4

vdsm sync meeting minutes May 13, 2014
by danken＠redhat.com 15 May '14

15 May '14

Vdsm sync call May 13, 2014 =========================== (Join us every other week, 14:30 GMT, on https://bluejeans.com/35386075901 or https://www.intercallonline.com/listNumbersByCode.action?confCode=353860759… ) =========================== - We had a long descussion about multiple graphic devices http://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:gr… - fromani to figure out whether libvirt intends to provide an "alias" for graphics devices. Without it, it would be next-to-impossible to support multiple spice devices. It's already cumbersome to tell spice from vnc devices. - On input, Vdsm must accept both legacy display definitions (in vm.conf) and new-style ones (in vm.conf['devices']). If both exist, legacy ones are to be ignored. - writeable floppies. We believe that they were never used. Currently, vdsm makes floppies writable based on the writability of their filesystem imagea, and checks it in an unsafe manner. So we intend to make all floppies read-only. Actually, it would be nicer to expose a "readonly" flag, so that the client can use in case it really needs to write on the floppy (such as for saving Doom I game state). - live merge Saggi to review Adam's patches, and see if their use of task id is acceptable to him, and would follow the devel(a)ovirt.org thread on the matter. I'm still worried about Engine trusting the vdsm mapping of taskid to (vmid,volumeid), as Vdsm can crash and disappear. - unified network persistence. recently, unified persistence has become the default on the master branch http://gerrit.ovirt.org/25784 this may cause breakage to post-boot network connectivity, in case vdsm fails to start. - To avoid this fragility, we plan to have a leaner standalone service to configure networking on boot. - As a stopgap measure, the management network would be set as ONBOOT=yes, so that most setup would keep their connectivity. please report other problems! - ioprocess integration There's a worry regarding the path of replacing remote-file-handler with ioprocess. Currently, ioprocess is mimicking rfh semantics, while it is more reasonable to align with the future, and make the current rfh implementation mimick ioprocess. When network decided to move away from ifcfg to iproute2, we refactor the code to support both (with configurators), implemented iproute2, and only recently - moved to use it by default. This path ensures that we're not stuck with a convoluted code that matches no implementation. Have I forgotten anything? Dan.

2 1

ovirt-engine on F20
by Sandro Bonazzola 14 May '14

14 May '14

Hi, I'm looking at Bug 1055604 - "Failed to execute stage 'Setup validation': Cannot find Jboss at /usr/share/jboss-as" while running engine-setup on Fedora 20 I haven't seen news about wildfly support on engine side so I'm thinking about workarounds. What about providing jboss-as-7.1.1-11 for F20 as we do for el6? BTW, Juan, can you push spec file used for jboss-as to releng-tools repo? http://resources.ovirt.org/pub/ovirt-3.4-snapshot-static/rpm/el6/x86_64/jbo… If it can conflict somehow with wildfly, what about having it in /opt and configure the engine for using jboss from there? Comments? -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

2 1

Re: [ovirt-devel] oVirt Node ISO rpm-wrapper update
by Sandro Bonazzola 14 May '14

14 May '14

Il 12/05/2014 13:00, Fabian Deutsch ha scritto: > Hey, > > the "wrapper rpm" I am going to talk about is an rpm which contains the > Node ISO image which can be used easily with oVirt Engine. > yum can be used to update this rpm and retrieve the latest oVirt Node > iso for easy consumption. > > For some time we did not deliver Node for Engine in a wrapper rpm > because a lot of things have changed (see below for the full story). > > To get this working again I've been cleaning up the repo and the > contained spec. > > Th repo layout is now: > node-3.0 branch: > Builds the base image from scratch > > ovirt-3.4 branch: > Builds the iso for Engine using edit-node and the base image > > Open issues: A repo file needs to be generated on each build which > contains all the relevant oVirt repositories. > > Sandro, do you have an idea how we can retrieve all list of all relevant > oVirt repositories using some curl oneliner? No, no curl onliner available for that. If you need one, we can provide it. > The repositories are needed by edit-node to pull in the dependencies of > ovirt-node-plugin-vdsm (vdsm, gluster, ...). > > The changes are _slightly_ tested, and once they are in a better shape > we can update Jenkins to use these repos to build the image and rpm for > Engine. > > > Technical background story: > The problem was that the basic way of how the oVirt Node for Engine ISO > was build was dramatically changed. > > Originally the vdsm packages were part of Node's build process. > You build the Node and it was usable with Engine. > > Now - After we introduced plugins, vdsm was migrated into a plugin > (ovirt-node-plugin-vdsm) and the plugin is not part of Node's build > process. ISOs we build these days do not contain vdsm specific bits and > are called "base images". > So if you build Node these days, it is _not_ usable with Engine. > Don't Panic. > > The ovirt-node-plugin-vdsm is added to the "base image" in a second step > using edit-node. This process is now used in ovirt-3.4 branch, where > also the spec file for the wrapper-rpm resides. > > - fabian > -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

2 1

[QE] oVirt 3.4.2 RC status
by Sandro Bonazzola 14 May '14

14 May '14

Hi, We're going to start composing oVirt 3.4.2 RC on 2014-05-27 08:00 UTC from 3.4 branches. The bug tracker [1] shows no blocking bugs for the release There are still 75 bugs [2] targeted to 3.4.2. Excluding node and documentation bugs we still have 47 bugs [3] targeted to 3.4.2. Maintainers / Assignee: - Please add the bugs to the tracker if you think that 3.4.2 should not be released without them fixed. - Please update the target to any next release for bugs that won't be in 3.4.2: it will ease gathering the blocking bugs for next releases. - Please fill release notes, the page has been created here [4] - If you're going to test this release, please add yourself to the test page [5] [1] http://bugzilla.redhat.com/1095370 [2] http://red.ht/1oqLLlr [3] http://red.ht/1nIAZXO [4] http://www.ovirt.org/OVirt_3.4.2_Release_Notes [5] http://www.ovirt.org/Testing/oVirt_3.4.2_Testing Thanks, -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

1 0

vdsm disabling logical volumes
by Jiri Moskovcak 14 May '14

14 May '14

Greetings vdsm developers! While working on adding ISCSI support to the hosted engine tools, I ran into a problem with vdms. It seems that when stopped vdsm deactivates ALL logical volumes in it's volume group and when it starts it reactivates only specific logical volumes. This is a problem for hosted engine tools as they create logical volumes in the same volume group and when vdsm deactivates the LVs the hosted engine tools don't have a way to reactivate it, because the services drop the root permissions and are running as vdsm and apparently only root can activate LVs. So far the only suitable solution seems to be to change vdsm to only deactivate/activate it's own LVs. I would be grateful for any hints. Thank you, Jirka

6 26